Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Matthew Gyurgyik commented on PUP-6125 Re: verbose agent runs result data being sent console and syslog Henrik Lindberg Did you see my closed pull request PR#4837? I think this is similar to what your are suggesting. This PR would cause --verbose and --debug to only log to the console unless --logdest is set. In PR#4982 PR#4982, the idea is that --verbose and --debug
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Henrik Lindberg commented on PUP-6125 Re: verbose agent runs result data being sent console and syslog This seems to be backwards incompatible. Suggest instead changing behaviour so those that want can turn off logging to console when it is not wanted. That way there is no surprise. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Matthew Gyurgyik commented on PUP-6125 Re: verbose agent runs result data being sent console and syslog Submitted a new pull request https://github.com/puppetlabs/puppet/pull/4982 which follows the implementation Michael Smith described. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Michael Smith commented on PUP-6125 Re: verbose agent runs result data being sent console and syslog Ah, paraphrasing some discussion in PR Triage, the suggestion was made that the desired behavior should be: --test implies changing the default logdest to console (which would still be overridden by --logdest). - verbose and debug should not imply writing to console. This is a change in existing behavior that allows people using verbose/debug in daemon runs to continue doing so. If they wish to still write to console, they'll have to add -logdest console. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Michael Smith commented on PUP-6125 Re: verbose agent runs result data being sent console and syslog Posted to #puppet-users, with no feedback: https://groups.google.com/forum/#!topic/puppet-users/7vNUyrTF5Cc. I believe the approach taken in Matthew Gyurgyik's PR looks correct and no one has provided dissent. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Charlie Sharpsteen commented on PUP-6125 Re: verbose agent runs result data being sent console and syslog It seems undesirable to have verbose/debug/show-diff going to syslog as a default, as they're more likely to contain secrets. I think we should be careful not to overload these. Leaving them as simple switches which enable or disable a certain kind of output seems like the most understandable and maintainable behavior. For the case of sensitive data, I think PUP-5832 is the right way to approach this by allowing users to mark resources or parameters as sensitive and letting the system respond appropriately by redacting related log messages and suppressing diffs. For the case of logdest, I agree that we shouldn't be recording output in syslog when users don't expect it. For example, puppet agent -t probably shouldn't send messages to syslog when invoked interactively — that's probably unexpected behavior in most cases. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title
Michael Smith updated an issue
Puppet / PUP-6125
verbose agent runs result data being sent console and syslog
Change By:
Michael Smith
The documentation states{quote}* --logdest: Where to send log messages. Choose between 'syslog' (the POSIX syslog service), 'eventlog' (the Windows Event Log), 'console', or the path to a log file. If debugging or verbosity is enabled, this defaults to 'console'. Otherwise, it defaults to 'syslog' on POSIX systems and 'eventlog' on Windows.{quote}|| Flags || Syslog || Console ||| None | X | || --logdest console | | X || --logdest syslog | X | || --verbose | X | X || --verbose --logdest console | | X || --test | X | X || --test --verbose | X | X |This becomes a problem when the --test option is used. --test expands and sets --verbose which means diff output will get logged to syslog and the console.The expected result - based on logdest's documentation - is to send output only to the console, not syslog.This is a concern, because --test enables show-diff, which can contain secrets (such as passwords) that should not be printed. As a default, this suggests we should not log show-diff and verbose/debug output to more permanent locations such as syslog/eventlog.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegr
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title
Trevor Vaughan commented on PUP-6125
Re: verbose agent runs result data being sent console and syslog
I don't rely on this on purpose, but I've certainly relied on it accidentally since I never paid attention to the documented difference.
I do think that a metaparameter may need to be added to the language that allows for masking specific values.
Something like:
file { '/tmp/secret_sauce':
owner => 'secret',
group => 'squirrel',
content => 'not mah passwords!'
protect => ['content']
}
But, admittedly, that's a lot more work and type `to_s` methods would have to honor it, and all that jazz.
Add Comment
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Michael Smith assigned an issue to Michael Smith Puppet / PUP-6125 verbose agent runs result data being sent console and syslog Change By: Michael Smith Assignee: Michael Smith Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Michael Smith commented on PUP-6125 Re: verbose agent runs result data being sent console and syslog Charlie Sharpsteen have any feedback on this change? I also plan to send out a note to #puppet or #puppet-dev. It seems undesirable to have verbose/debug/show-diff going to syslog as a default, as they're more likely to contain secrets. For anyone currently running with verbose or show-diff enabled, this could be a non-obvious change that will need to be pointed out in release notes. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title
Michael Smith updated an issue
Puppet / PUP-6125
verbose agent runs result data being sent console and syslog
Change By:
Michael Smith
The documentation states{quote}* --logdest: Where to send log messages. Choose between 'syslog' (the POSIX syslog service), 'eventlog' (the Windows Event Log), 'console', or the path to a log file. If debugging or verbosity is enabled, this defaults to 'console'. Otherwise, it defaults to 'syslog' on POSIX systems and 'eventlog' on Windows.{quote}|| Flags || Syslog || Console ||| None | X | || --logdest console | | X || --logdest syslog | X | || --verbose | X | X || --verbose --logdest console | | X || --test | X | X || --test --verbose | X | X |This becomes a problem when the --test option is used. --test expands and sets show_diff=true --verbose which means diff output will get logged to syslog and the console.The expected result is to send output only to the console, not syslog. This is a concern, because --test enables show-diff, which can contain secrets (such as passwords) that should not be printed. As a default, this suggests we should not log show-diff and verbose/debug output to more permanent locations such as syslog/eventlog.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this
Jira (PUP-6125) verbose agent runs result data being sent console and syslog
Title: Message Title Matthew Gyurgyik moved an issue Puppet / PUP-6125 verbose agent runs result data being sent console and syslog Change By: Matthew Gyurgyik Affects Version/s: puppet-agent 1.4.1 Affects Version/s: puppet-agent 1.3.5 Affects Version/s: PUP 4.4.1 Workflow: Release Engineering Scrum Team Workflow Key: PA PUP - 278 6125 Project: Puppet Agent Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
