Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type Ok, this would clearly be a PR that brings down the quality of the Puppet codebase because of the addition of the downgradeable feature for the providers and this param is suspicious. I am going to go ahead and close this and its corresponding PR. We will be moving forward with an alternate solution. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type Yeah I was just discussing with my project manager about how this is something that would be a hard sell for a feature, even if I do finish the Debian and RedHat family providers. I would write a custom function that inherits from package to satisfy our business need, but that whole thing about custom functions requiring server-side cache refreshing is a turnoff. This might be one of those things where Henrik just looks at it for a minute and goes 'well just do this abstract meta-programming trick' and then it works. I would be all for that. If we can satisfy the requirement without my finishing this potentially awkward PR, then I think everyone wins. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Kylo Ginsberg commented on PUP-6136 Re: newparam(:downgrade) for package type Jira hygiene: clearing the fixVersion for now. We can restore that when we know more. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-6136 newparam(:downgrade) for package type Change By: Kylo Ginsberg Fix Version/s: PUP 4.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Kylo Ginsberg commented on PUP-6136 Re: newparam(:downgrade) for package type Hey Matt Schuchard, apologies for not following up more quickly; this sorta slipped off my radar. I did a little searching of jira (and redmine) and there are several variants of this idea, but I didn't find the ticket around the idea of adding a "downgradable" provider feature (but also easily could have missed it). However, more important than the implementation questions I was thinking about above is the question of: do we want this feature? So big thanks for explaining your real-world, pragmatic (brownfield-y) use cases - I wasn't thinking of those cases, but your scenarios make sense. That said, I'd like to get more consensus (or ideas) on how to proceed: do you mind opening a thread on puppet-dev@ wrt this idea? I'm hoping we can get some good discussion of the tradeoffs to various approaches, which will then unblock us on next steps. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type PUP-6099 is basically complete so I can come back to this and decide if and what I want to do for a path forward. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type I could see two use cases for this parameter. The server is in an unknown state prior to the Puppet agent applying the catalog. Multiple modules which are not applied in the same catalog, but are being applied to the same server, are also managing the same package resource. Are either of these typical for well-constructed, managed, and monitored server environments? No. Are they typical at companies which have existed for over five years without a relevant greenfield? Yes. Do I work at one of those companies? Three guesses and the first two don't count. I recall seeing a ticket from back when yum downgrade was first implemented that had suggested the downgradeable feature and that suggestion was promptly shot down, otherwise I would consider that route. Maybe opinions have changed though. So I assume dnf inherits the implementation I did for yum based on the code I saw, rpm is also finished, apt I did the version installed accessing and assignment but not comparison, and dpkg I have not started working on but have poked around some. I too was focusing on the RedHat and Debian families' providers for now since those are something like ninety percent of servers/cloud. I would be all for the path of least resistance on this one, but I am not sure what that is. The custom function is an interesting idea, but I am not fond of the Puppetmaster caching it to make updating it difficult. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Kylo Ginsberg commented on PUP-6136 Re: newparam(:downgrade) for package type Matt Schuchard a few more thoughts/questions on this: ok good, glad my snippet above represents the desired behavior. But: why is this useful? I'm not contending, but I am trying to wrap my brain around the real-world scenarios. This feels unnecessarily non-deterministic, but I know I'm lacking the motivating use cases here. So that would help if we go this route, I'm thinking it would only apply to some providers, so we'd want to have a new feature (downgradeable?) on the package type. (That name isn't great, since it's not quite the opposite of upgradeable but still might be the best choice.) sorting this out for all package providers in core is probably overkill, but it would be worthwhile understanding how it would behave for "major" providers, e.g. maybe yum, dnf, rpm, apt, dpkg? Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type Yes, that would be an example of a typical use-case and the desired goal. As for that discussion, it looks like Henrik rejected an alternate implementation that I myself also rejected for the same reasons he did. The current package behavior on ensure is to pull the version out via regex and then append it onto the provider install command. Reworking that would be even rougher than the route I am traversing, especially because I don't know what providers have that kind of intrinsic functionality (if any). Something I found interesting from viewing the spec tests during my implementation is that Puppet can pull in an array of versions for what is currently installed due to different archs. This really throws a wrench into the situation for should <=> version. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title
Kylo Ginsberg commented on PUP-6136
Re: newparam(:downgrade) for package type
Matt Schuchard I haven't really had a chance to engage with this ticket, but a question and a comment.
First, can you provide some sample snippets / use-cases? I'm guessing you want to be able to disable downgrades so that something like
pakage { 'foo':
ensure => '1.2.3',
downgrade => false
}
And a node on 1.2.1 would end up on 1.2.3, whereas a node on 1.2.5 would remain at 1.2.3. Is that what the goal is?
Second, there's some prior discussion on version matching at https://groups.google.com/forum/#!msg/puppet-dev/f2bPw9liasg/pfWFUja_-XwJ, which itself links to earlier discussions. Just mentioning that in case any of it sheds useful light on the problems you're solving.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type Starting to have second thoughts about this. Implementing this for yum/dnf and rpm is easy, but I started for apt and I can grab the current installed version, but then I cannot simply if should < version because I would have to write a version compare function like in yum. Stepping back and looking at this makes it seem like this would require a huge effort for current installed version parsing and version comparing for each provider. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type PR Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Kylo Ginsberg commented on PUP-6136 Re: newparam(:downgrade) for package type Thanks Matt Schuchard. Yes PRs to master target the next minor not the next patch (except for a narrow window right around release time). Thanks! Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard commented on PUP-6136 Re: newparam(:downgrade) for package type Thanks, I have adjusted the JIRA tags and will start working on the PR in a few hours. Do PR to master target the next minor release and not the next patch release? If so, I need to adjust my JIRA tags in PUP-6099 as well. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard updated an issue Puppet / PUP-6136 newparam(:downgrade) for package type Change By: Matt Schuchard Fix Version/s: PUP 4.4.2 Fix Version/s: PUP 4.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard updated an issue Puppet / PUP-6136 newparam(:downgrade) for package type Change By: Matt Schuchard Issue Type: Improvement New Feature Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Kylo Ginsberg commented on PUP-6136 Re: newparam(:downgrade) for package type Matt Schuchard thanks for proposing this! This would be a new feature so I'd target puppet#master. It would then go out in the next .Y release after it was merged (so puppet 4.5.0 if merged today). Re naming "downgrade" seems reasonable to me (although I am terrible at naming things ) - we can put more eyes on the name with a PR in place. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Elizabeth Plumb updated an issue Puppet / PUP-6136 newparam(:downgrade) for package type Change By: Elizabeth Plumb CS Priority: Needs Priority Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6136 newparam(:downgrade) for package type Change By: Henrik Lindberg Scrum Team: Client Platform Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard updated an issue Puppet / PUP-6136 newparam(:downgrade) for package type Change By: Matt Schuchard Environment: Theoretically all OS , but then again I have no experience with chocolatey. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6136) newparam(:downgrade) for package type
Title: Message Title Matt Schuchard created an issue Puppet / PUP-6136 newparam(:downgrade) for package type Issue Type: Improvement Assignee: Kylo Ginsberg Components: Types and Providers Created: 2016/04/07 6:35 AM Environment: Theoretically all OS Fix Versions: PUP 4.4.2 Labels: puppet-agent Priority: Normal Reporter: Matt Schuchard New parameter :downgrade will downgrade a package if set to true. Defaults to true. Current non-parameter behavior is always true. Initial PR hopefully within a week. Questions: 1. Is this an improvement or new feature? If new feature, is this ok for a Puppet 4.4.x or
