Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2017-05-16 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown commented on  PUP-6362 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 
 
David Schmitt this is a best practices thing we can do upfront to handle potential file path collisions. 
I'm not sure how frequently this happens in the real world, but even if we implement something here, it's a band-aid. The problem needs to be addressed prior to attempting to install a module. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-06-08 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-6362 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 
 
We can't issue a warning on the agent side during pluginsync, because it makes a recursive file_metadatas request, and the server returns the flattened set of file metadata. See https://github.com/puppetlabs/puppet/blob/master/lib/puppet/file_serving/mount/plugins.rb#L3-L5. So the agent never knows there was a collision. We possibly could issue a warning on the master side, but we would have to keep track of which files we've already returned metadata for (for a given request). That might be possible though it may not be good to keep a bunch of paths in memory during the lifetime of the request... 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-05-26 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6362 
 
 
 
  Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Ethan Brown 
 
 
 

Component/s:
 
 PMT 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-05-26 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown commented on  PUP-6362 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 
 
I agree with Rob Reynolds here - this seems intractable on pluginsync. 
However, it is possible to present warnings during a puppet module install conducted on a master, where it should be able to duplicate paths in use across multiple modules. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-05-26 Thread Rob Reynolds (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rob Reynolds updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6362 
 
 
 
  Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Rob Reynolds 
 
 
 

Scrum Team:
 
 Client Platform 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-05-26 Thread Rob Reynolds (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rob Reynolds updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6362 
 
 
 
  Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Rob Reynolds 
 
 
 

Labels:
 
 plugin 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-05-26 Thread Rob Reynolds (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rob Reynolds updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6362 
 
 
 
  Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Rob Reynolds 
 
 
 

Component/s:
 
 Types and Providers 
 
 
 

Component/s:
 
 Modules 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-05-26 Thread Rob Reynolds (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rob Reynolds commented on  PUP-6362 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 
 
I think this has the potential to be difficult to implement, because how do you know when you are overwriting something different and when you are just updating an older version of the same thing? 
Other than graphing all things moving in the current run and then providing warnings when there are collisions... 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6362) Warning should be easily visible when Plugin Sync overwrites files from another Module

2016-05-26 Thread Erick Banks (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Erick Banks created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6362 
 
 
 
  Warning should be easily visible when Plugin Sync overwrites files from another Module  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/05/26 1:41 PM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Erick Banks 
 
 
 
 
 
 
 
 
 
 
The Windows team discovered that using the Powershell module and the DSC module together caused Plugin Sync to overwrite the powershell_manager file causing one of the modules to fail after the sync. 
Since we only test modules in isolation and our users can write modules that can have file collisions, there should be clear warning to the end user when these kinds of overwrites happen. 
Identified possible scenarios: file-name collisions (including fact file-names) and fact name collisions. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment