Jira (PUP-6460) The addition of dig to puppet functions breaks puppetlabs-stdlib
Title: Message Title Nate Potter commented on PUP-6460 Re: The addition of dig to puppet functions breaks puppetlabs-stdlib I submitted a pull request that deprecates the dig function and fixes the tests here https://github.com/puppetlabs/puppetlabs-stdlib/pull/618 , but it looks like the Ruby 1.9.6 job is failing because of an issue like this one https://github.com/travis-ci/travis-ci/issues/5145 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6460) The addition of dig to puppet functions breaks puppetlabs-stdlib
Title: Message Title Nate Potter assigned an issue to Nate Potter Puppet / PUP-6460 The addition of dig to puppet functions breaks puppetlabs-stdlib Change By: Nate Potter Assignee: Nate Potter Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6460) The addition of dig to puppet functions breaks puppetlabs-stdlib
Title: Message Title Henrik Lindberg commented on PUP-6460 Re: The addition of dig to puppet functions breaks puppetlabs-stdlib I can imagine adding default value support to puppet's dig, but it would still be different. Also reluctant to do that since there is a perfectly composable solution with then() and lest() for the simple case of default value and for other more advanced things. Suggest deprecating the 3.x dig function, and not running the stdlib dig tests when puppet is >= 4.5.0. There cannot be many users of that function. We did something similar for the clash in the type function, where the solution was to add a type3x to stdlib for backwards compatibility. The same could be done here for those few that want to continue using the stdlib 3.x dig. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6460) The addition of dig to puppet functions breaks puppetlabs-stdlib
Title: Message Title Thomas Honey commented on PUP-6460 Re: The addition of dig to puppet functions breaks puppetlabs-stdlib I agree this is not easy to fix, we can fudge the tests to pass. But the difference in functionality / output is the real problem. If both functions perform identically it becomes less of an issue. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6460) The addition of dig to puppet functions breaks puppetlabs-stdlib
Title: Message Title Henrik Lindberg commented on PUP-6460 Re: The addition of dig to puppet functions breaks puppetlabs-stdlib The missing documentation for new functions have been addressed. The documentation will be there for puppet 4.6.0. (There are capabilities missing in the internal docs processing pipeline). The work on dig, then, lest was done before the dig was added to stdlib. It is an unfortunate clash and the APIs are unfortunately not compatible. dig($data, 1,2,3) vs. dig($data, [1,2,3], 'default'). Have a hard time coming up with something that would make it possible to support both signatures with one function. Not sure what the best action is. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6460) The addition of dig to puppet functions breaks puppetlabs-stdlib
Title: Message Title Thomas Honey created an issue Puppet / PUP-6460 The addition of dig to puppet functions breaks puppetlabs-stdlib Issue Type: Bug Affects Versions: PUP 4.5.2, PUP 4.5.1, PUP 4.5.0 Assignee: Unassigned Components: Language Created: 2016/06/30 2:44 AM Priority: Major Reporter: Thomas Honey With puppet 4.5.X we have introduced dig as a function. This is not documented @ https://docs.puppet.com/puppet/latest/reference/function.html When running puppetlabs-stdlib dig with puppet 4, it uses puppets dig function not stdlib. This is causing weird behaviour, also breaking the acceptance tests for the module. To replicate: checkout the puppetlabs stdlib module. export PUPPET_GEM_VERSION="= 4.5.0" bundle install --path .bundle/gems/
