Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Austin Boyd updated an issue Puppet / PUP-6743 Classes should propagate schedule metaparameter to its contained resources Change By: Austin Boyd Zendesk Ticket Count: 1 Zendesk Ticket IDs: 47711 Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.153663.1474968853000.5195.1647605340058%40Atlassian.JIRA.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Austin Boyd updated an issue Puppet / PUP-6743 Classes should propagate schedule metaparameter to its contained resources Change By: Austin Boyd Labels: jira_escalated maintenance Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.153663.1474968853000.5196.1647605340117%40Atlassian.JIRA.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Ruben Stein commented on PUP-6743 Re: Classes should propagate schedule metaparameter to its contained resources It is very frustrating that schedules cannot be used for any third party code where you can't dig deep enough to inject the schedule in the leaf resources. I just wanted our puppet agents to be updated only during a maintenance window, but adding a schedule to the puppet_agent resource is completely useless. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.153663.1474968853000.120788.1611220800027%40Atlassian.JIRA.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title
Kevin Reeuwijk commented on PUP-6743
Re: Classes should propagate schedule metaparameter to its contained resources
I just ran into this issue as well, where the following code didn't behave as expected:
windows_updates::kb { $kb :
ensure => 'present',
kb => $kb,
notify => Reboot['patch_window_reboot'],
schedule => 'patch_window'
}
schedule { 'maintenance_window':
range => '22:00 - 04:00',
weekday => 'Saturday',
}
reboot { 'patch_window_reboot':
apply=> 'finished',
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Luca Zecca commented on PUP-6743 Re: Classes should propagate schedule metaparameter to its contained resources Should be really useful and more powerful the propagation of the schedule in classes and define, i am really looking forward for this, hoping that pretty soon will be available! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Jose Alvarez commented on PUP-6743 Re: Classes should propagate schedule metaparameter to its contained resources What is the state of this issue? Adding the schedule parameter for our own code works ok, but it still happens with resources such as concat and concat::fragment that are ignoring the schedule parameter, making the parameter useless for the whole role just by one concat if it can't be allowed to run for the schedule to be of any use. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Lindsey Smith updated an issue Puppet / PUP-6743 Classes should propagate schedule metaparameter to its contained resources Change By: Lindsey Smith Team: Puppet Developer Experience Platform Core Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-6743 Classes should propagate schedule metaparameter to its contained resources Change By: Maggie Dreyer Labels: maintenance triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title cameris commented on PUP-6743 Re: Classes should propagate schedule metaparameter to its contained resources I did dig a little deeper and see the following problems when done while compilation: It seems that the function add_resource_metaparams ( https://github.com/puppetlabs/puppet/blob/5fb5e2deacb6043d2417e2d9acb4ebe78547f971/lib/puppet/parser/compiler.rb#L693-L716 ) is only called on define types and no other container (classes). The problem of the example in my previous comment. Currently the inner schedule takes precedence which is unintuitive. Overwriting the parameter from top down is also not possible, since the inner schedule should be honored when the outer allows it. Therefore we would have to intersect schedules. On the transaction (resource framework) side: The current state is that each resources schedule is checked ( https://github.com/puppetlabs/puppet/blob/5fb5e2deacb6043d2417e2d9acb4ebe78547f971/lib/puppet/transaction/resource_harness.rb#L48-L56 ) during evaluation of the transaction ( https://github.com/puppetlabs/puppet/blob/5fb5e2deacb6043d2417e2d9acb4ebe78547f971/lib/puppet/transaction.rb#L339-L340 ). In order to get all the schedules we would have to recursively ask the resources parent for their schedule parameters (and since the catalog is already in RAL while this is checked, its a bit hard to find the parent). This seems pretty inelegant. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title
cameris commented on PUP-6743
Re: Classes should propagate schedule metaparameter to its contained resources
Apparently defined resources get non relation-metaparameters assigned during the finish step in compilation, but only if the not already have a parameter of the same name: https://github.com/puppetlabs/puppet/blob/6e5bcd85ca1f718978a47b432d82c6dfc8c5b54d/lib/puppet/parser/compiler.rb#L709
So if an embedded resource has a schedule that is not overwritten, it does execute.
define res {
schedule { 'always':
repeat => -1,
range => "00:00:00 - 23:59:59",
}
define res {
notify { 'in def':
message => 'DEFINITION',
schedule => 'always',
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title Henrik Lindberg commented on PUP-6743 Re: Classes should propagate schedule metaparameter to its contained resources It is unclear to me if this is something that should take place during compilation (inheriting meta params from containing class and propagating them to the catalog) or done in the resource framework when applying. Kylo Ginsberg do you know how it is done, or do we need to do some detective work? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title William Hopper updated an issue Puppet / PUP-6743 Classes should propagate schedule metaparameter to its contained resources Change By: William Hopper Labels: maintenance Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title cameris commented on PUP-6743 Re: Classes should propagate schedule metaparameter to its contained resources maybe related to this: https://tickets.puppetlabs.com/browse/PUP-2979 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6743) Classes should propagate schedule metaparameter to its contained resources
Title: Message Title
cameris created an issue
Puppet / PUP-6743
Classes should propagate schedule metaparameter to its contained resources
Issue Type:
New Feature
Assignee:
Kylo Ginsberg
Components:
Language, Types and Providers
Created:
2016/09/27 2:34 AM
Priority:
Normal
Reporter:
cameris
Classes with a schedule metaparameter should propagate it to resources contained in the class. Other metaparameters work as intended (notify/require), but schedule is ignored. small example:
# definitions
define res {
notify { 'in def':
