Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Moses Mendoza created an issue Puppet / PUP-6850 Make commit formatting check robust Issue Type: Bug Assignee: Unassigned Created: 2016/10/28 9:50 AM Labels: maintenance Priority: Normal Reporter: Moses Mendoza PUP-6849 proposes removal of the commit format check, as it is failing consistently on PRs due to commits unrelated to those PRs. Unfortunately, despite a range of attempts to make this work correctly/completely, including: e1efdebf 4d5afd57 1ed7c7ce ...we still haven't gotten it quite right. The most challenging aspect is to accurately get a list of commits that exist only in the pull request and check those. Failure to do so was causing consistent CI failures for many PRs, as commits unrelated to this PR would trigger failure. This then meant lost time investigating and spurious red in hipchat rooms - more effort than the check is worth in IMO. We need to make the check more robust so that it can correctly detect only the commits in a PR.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Shawn Ferry commented on PUP-6850 Re: Make commit formatting check robust Moses Mendoza Allow the commits check to fail without breaking everything? It's not optimal but maybe it's a bit better than removing it entirely. .travis.yaml: matrix: allow_failures: env: "CHECK=commits" Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Moses Mendoza commented on PUP-6850 Re: Make commit formatting check robust Shawn Ferry seems reasonable - i'm not as familiar with that behavior - I'll take a look. Generally speaking I think I'm inclined to avoid having something in there we know doesn't work well rather than keep it and possibly mask the failures, but I'm happy with whatever cuts down on the noise in the short term. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Josh Cooper updated an issue Puppet / PUP-6850 Make commit formatting check robust Change By: Josh Cooper Fix Version/s: PUP 4.7.1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-6850 Make commit formatting check robust Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Ethan Brown commented on PUP-6850 Re: Make commit formatting check robust Merged in https://github.com/puppetlabs/puppet/commit/50c0d51065126f242f984c8060b126c46e2f3af2 Merged up to stable in https://github.com/puppetlabs/puppet/commit/ffabfc3d3019b1a4653c3015182a8996c8a86cde Merged up to master in https://github.com/puppetlabs/puppet/commit/9dda0a424b5067cabdfd70f72b286fa7f29f604a Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Kenn Hussey commented on PUP-6850 Re: Make commit formatting check robust Ethan Brown please provide release notes for this issue, if applicable. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-6850 Make commit formatting check robust Change By: Moses Mendoza Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Moses Mendoza assigned an issue to Unassigned Puppet / PUP-6850 Make commit formatting check robust Change By: Moses Mendoza Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Moses Mendoza commented on PUP-6850 Re: Make commit formatting check robust this issue is internal CI related - no release notes needed Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6850) Make commit formatting check robust
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-6850 Make commit formatting check robust Change By: Maggie Dreyer Fix Version/s: PUP 4.8.2 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
