Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Henrik Lindberg Fix Version/s: PUP 4.9.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Eric Thompson Release Notes Summary: when using certain types of puppet variables data in modules could fail silently to lookup values interpolated from these variables. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Eric Thompson Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Eric Thompson QA Risk Assessment: No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Eric Thompson QA Risk Assessment Reason: improvement of error messaging; covered well by unit tests. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Eric Thompson QA Contact: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Henrik Lindberg commented on PUP-6856 Re: data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Eric Thompson The user facing rule here is that "non existent variables and undef values interpolate as an empty string in a lookup.yaml/hiera.yaml". The rest of the behavior is specified by how digging out a value works (that is, that dot notation means producing an undef result if a partial resolution results in undef). I also suspect that it is unspecified (and not covered with tests) which scope is available to the hiera/lookup configuration files when interpolating. Hiera was very generous in this respect (with wonky side effects), lookup is more strict. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Eric Thompson commented on PUP-6856 Re: data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently i see the unit test for dotted keys in interpolation. do we think we need acceptance tests for the case when missing facts impact hierarchy interpolation, in general? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Craig Gomes updated an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Craig Gomes Sprint: PDS 2016-11-16 , PDS 2016-11-30 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Craig Gomes assigned an issue to qa Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Craig Gomes Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Henrik Lindberg commented on PUP-6856 Re: data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently merged to master at: b0209f5 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Thomas Hallgren Assignee: Thomas Hallgren Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Henrik Lindberg Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title David Schmitt commented on PUP-6856 Re: data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Thomas Hallgren no worries. thanks for fixing! Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Thomas Hallgren commented on PUP-6856 Re: data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently David Schmitt, I'm sorry. I tested using my current branch for PUP-6780. There, the problem no longer exists. I ran your example on master instead and found the root cause to be the mechanism we use to detect missing keys (to throw :no_such_key and then catch it higher up) was missing the catch when dotted keys were used in interpolation. That created a real mess. With the catch in place, the specific problem reported here no longer occurs. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title
David Schmitt updated an issue
Puppet / PUP-6856
data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Thomas Hallgren I've updated the test cases to show that this is not just a case of empty interpolations: the test case with nonsensical values should exhibit the same behaviour as the one with no facts, because both of them should only use the common.yaml that has no interpolation at all in its hierarchy entry. Instead the no-facts case fails without using the values from common.yaml.
Change By:
David Schmitt
Affects Version/s:
PUP 4.8.0
When building the hierarchy for looking up data in modules, {{lib/puppet/data_providers/hiera_config.rb}} the interpolation around https://github.com/puppetlabs/puppet/blob/4.7.0/lib/puppet/data_providers/hiera_config.rb#L101 does weird things causing the whole lookup to fail, instead of* ignoring that hierarchy level* reporting a specific errorThis can easily be reproduced by adding the following code to {{spec/classes/test_spec.rb}} into https://github.com/puppetlabs/puppetlabs-ntp/tree/c4f586c8eabc879837942febbb70d30dc4d614ac and running{code}bundle install --without system_testsbundle exec rake spec_prepbundle exec rspec spec/classes/test_spec.rb{code}{code}require 'spec_helper'describe 'ntp' do before :each doPuppet[:trace]= true end context "false negatives" docontext 'without facts' do # "restrict" is the only reqired parameter with only OS defaults. it { is_expected.to compile .and_raise_error(/expects a value for parameter 'restrict' at line 1/) } end context 'with only the full version missing required fact ' do # hiera.yaml uses os.family to locate data/Debian.yaml, # which contains a ntp::restrict value let :facts do {os: { name family : 'Debian', }} end it { is_expected.to compile }end end context "passing tests" docontext 'with any facts' do # these facts do not match any of the existing data files # only common.yaml is used let :facts do{ os: {name: 'foo', family: ' Debian foo ', release: { major: ' stretch/sid foo ' , full: 'foo' }} , operatingsystem: 'foo' }endit { is_expected.to compile .and_raise_error(/expects a value for parameter 'restrict' at line 1/) } end context 'with full facts' do # all facts provided let :facts do {os: { name: 'Debian', family: 'Debian', release: { major: 'stretch/sid', full:
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Thomas Hallgren commented on PUP-6856 Re: data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently The interpolation does what it's supposed to do and treats a missing key as an empty string. There have been discussions about if this instead should render an error (controlled by the --strict option), see ticket PUP-6767. This ticket requests another type of strictness that should be applied only for interpolations in the to the hiera.conf file. Perhaps the two tickets could be merged? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Change By: Henrik Lindberg Assignee: Thomas Hallgren Story Points: 1 Team: Puppet Developer Support Sprint: PDS 2016-11-16 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://gro
Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently
Title: Message Title David Schmitt created an issue Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Issue Type: Bug Affects Versions: PUP 4.7.0 Assignee: Unassigned Created: 2016/11/01 9:14 AM Priority: Normal Reporter: David Schmitt When building the hierarchy for looking up data in modules, lib/puppet/data_providers/hiera_config.rb the interpolation around https://github.com/puppetlabs/puppet/blob/4.7.0/lib/puppet/data_providers/hiera_config.rb#L101 does weird things causing the whole lookup to fail, instead of ignoring that hierarchy level reporting a specific error This can easily be reproduced by adding the following code to spec/classes/test_spec.rb into https://github.com/puppetlabs/puppetlabs-ntp/tree/c4f586c8eabc879837942febbb70d30dc4d614ac and running bundle install --without s
