Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Jorie Tappa Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Moses Mendoza Release Notes Summary: Prior to Puppet 5.0.0, when printing values to the console that were in a character encoding incompatible with UTF-8 or contained invalid byte sequences, puppet would fail, usually with an `incompatible encodings` error. In Puppet 5.0.0 and later, Puppet will log in UTF-8, and issue a warning upon encountering invalid strings with their content and the backtrace leading up to the log event. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Moses Mendoza Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Moses Mendoza Sprint: Agent N+2 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Moses Mendoza commented on PUP-7063 Re: Handle incompatible encodings in Puppet::Util::Log when rendering to console This is resolved in Puppet 5, via PUP-5756 and PUP-7498 . Logging now handles varying encodings, attempting to convert to UTF-8. Logs entries with invalid encodings are emitted with a warning and their invalid sequences escaped. An example of such a failure is: Debug: Executing: 'diff -u /tmp/utf8.txt /tmp/puppet-file20170613-2377-33tmig' Notice: /Stage[main]/Main/Node[ubuntu16.localdomain]/File[/tmp/utf8.txt]/content: Received a log message with invalid encoding:"\n--- /tmp/utf8.txt\t2017-06-13 11:07:08.997067374 -0700\n+++ /tmp/puppet-file20170613-2377-33tmig\t2017-06-13... Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Moses Mendoza Fix Version/s: PUP 5.y Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Branan Riley updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Branan Riley Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Ethan Brown commented on PUP-7063 Re: Handle incompatible encodings in Puppet::Util::Log when rendering to console Its believed that https://github.com/puppetlabs/puppet/pull/5772/commits/c47be2d3b3d002f02cbed6edee8dfee119152b46 may have fixed this particular problem. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: Agent Ready for Engineering N+2 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Fix Version/s: PUP 5.0.0 Fix Version/s: PUP 5.y Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: Agent Ready for Engineering 1 0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: Agent 2017-04-05 Ready for Engineering Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: Agent 2017- 03 04 - 22 05 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: Agent Ready for Engineering 2017-03-22 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: AP 2017-03-08 Ready for Engineering Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: AP 2017- 02 03 - 22 08 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Sprint: AP Grooming 2017-02-22 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Story Points: 5 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Geoff Nichols Acceptance Criteria: - Puppet::Util::Log can handle a variety of encoded strings without crashing the console and successfully printing the characters.- Should work on Japanese Windows, German Windows, and French Windows, and non-unicode German Linux. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Change By: Moses Mendoza Sprint: AP Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7063) Handle incompatible encodings in Puppet::Util::Log when rendering to console
Title: Message Title Moses Mendoza created an issue Puppet / PUP-7063 Handle incompatible encodings in Puppet::Util::Log when rendering to console Issue Type: Bug Assignee: Unassigned Created: 2017/01/04 11:21 AM Priority: Normal Reporter: Moses Mendoza When showing the results of Puppet::Util::Execution.execute in the console, for example, to log to the console the results of diff -u, (https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/diff.rb#L18), we return a result string in Encoding.default_external, i.e., perhaps ISO-8859-1 (from https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/file/data_sync.rb#L44). This ultimately makes its way to Puppet::Util::Log::Destinations https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/log/destinations.rb#L167 where we try to concatenate it with a UTF-8 string, and fail. I think this is likely the root cause of PUP-1441, and relates to PUP-6432. Beyond the concatenation issue, there is perhaps a deeper issue, which is - what should we do when the console is not capable of rendering the content? Should we use replacement characters? Just print and hope for the best? Add Comment
