Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Eric Thompson updated an issue Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Eric Thompson QA Risk Assessment Reason: covered by unit tests; deprecated behavior; low risk QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Henrik Lindberg Release Notes Summary: part of hiera 5 feature, problem this ticket solves was introduced in unreleased code. Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Henrik Lindberg commented on PUP-7088 Re: deep merge options in hiera v3 config not honored Reluctantly merged to master at: 38b9889 - because we "must" Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren commented on PUP-7088 Re: deep merge options in hiera v3 config not honored No, we don't need to test for parameters. The lookup API does not support :unpack_array. We removed that in PUP-6040. This only applies to the options declared in the hiera.yaml version 3 file. Nothing else. And since version 3 is deprecated already, no further deprecation needs to take place. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Henrik Lindberg commented on PUP-7088 Re: deep merge options in hiera v3 config not honored well, that leads to more work: test that it works for a parameter like :unpack_array we need to deprecate the use of unsupported merge options in the v3 format in puppet 4.9.0 (I suppose) need to remove the special case in puppet 6.0.0 bloat have this dialog open up for potentially other wacky options that will give us/users grief later on This for a parameter that there is no practical use for whatsoever ? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren commented on PUP-7088 Re: deep merge options in hiera v3 config not honored Henrik Lindberg, the time is already spent. A PR is up. It doesn't just cover the :unpack_arrays but also other potential differences caused by use of a more recent deep_merge gem (and of course, if we decide to upgrade the one we have). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Henrik Lindberg commented on PUP-7088 Re: deep merge options in hiera v3 config not honored Please don't worry or spend too much time on :unpack_arrays, it is an option that has no value to anyone using puppet as it is specialized for processing data related to HTML forms. For everyone else it is just super weird. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren commented on PUP-7088 Re: deep merge options in hiera v3 config not honored @erict, do you have any suggestions on how the explain output could be improved? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Thomas Hallgren Story Points: 1 Sprint: PDE 2017-01-25 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Thomas Hallgren Fix Version/s: PUP 4.9.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Thomas Hallgren Assignee: Eric Thompson Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren commented on PUP-7088 Re: deep merge options in hiera v3 config not honored Hiera v3 should not impose limit on supported options for merge options declared in the configuration. So :unpack_arrays (or any other option supported by the vendored deep_merge gem), must be supported in the v3 config to be backward compatible with classic Hiera. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren commented on PUP-7088 Re: deep merge options in hiera v3 config not honored @erict, for :unpack_arrays, please see PUP-6074 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Eric Thompson commented on PUP-7088 Re: deep merge options in hiera v3 config not honored if we think the :unpack_arrays issue will be covered by PUP-7092 then this can be closed. the functionality i need is in the related ticket Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title
Eric Thompson commented on PUP-7088
Re: deep merge options in hiera v3 config not honored
oops. merge_hash_arrays does work. i didn't put the json value in an array, above
---
environment_key4:
- val: 4
[and]
{
"environment_key4" : [{"jsonval": "4"}]
}
[gives:]
Merged result: [
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Eric Thompson commented on PUP-7088 Re: deep merge options in hiera v3 config not honored :merge_hash_arrays => true gets found. haven't confirmed it working yet. but --explain says it's used. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Eric Thompson commented on PUP-7088 Re: deep merge options in hiera v3 config not honored hmmm, that purportedly has :unpack_arrays DEFAULT: nil Set to string value to run "Array::join" then "String::split" against all arrays which i've tried. are the docs out of sync? i'll try it again Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren commented on PUP-7088 Re: deep merge options in hiera v3 config not honored We bundle a deep_merge gem in Puppet. It seems to be the same code-base but an earlier version. It does not have the options that you mention (see https://github.com/puppetlabs/puppet/tree/master/lib/puppet/vendor/deep_merge). Looks like it needs to be updated. I added PUP-7092 to track that. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Eric Thompson commented on PUP-7088 Re: deep merge options in hiera v3 config not honored yeah, it was the warning that tipped me off the current hiera.yaml docs (https://docs.puppet.com/hiera/3.2/configuring.html#mergebehavior) point to this gem: https://github.com/danielsdeleo/deep_merge/blob/master/README.md is that not the correct gem? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Henrik Lindberg assigned an issue to Eric Thompson Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Henrik Lindberg Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren commented on PUP-7088 Re: deep merge options in hiera v3 config not honored The lookup framework has no knowledge of an option named overwrite_arrays and neither has the DeepMerge module that we're using. From the looks of it, not even classic Hiera knows about this option. A warning indicating this is also logged in the output: Warning: /etc/puppetlabs/puppet/hiera.yaml: merge_option 'overwrite_arrays' is not recognized. Option is ignored Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-7088 deep merge options in hiera v3 config not honored Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title Eric Thompson commented on PUP-7088 Re: deep merge options in hiera v3 config not honored a test showing this is here: https://github.com/puppetlabs/puppet/pull/5487 tomorrow i'll fix that so it passes and it can be merged. it'll then fail upon this ticket fix and we can fix the test. assuming i didn't just mess up the config in this example. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7088) deep merge options in hiera v3 config not honored
Title: Message Title
Eric Thompson created an issue
Puppet / PUP-7088
deep merge options in hiera v3 config not honored
Issue Type:
Bug
Assignee:
Thomas Hallgren
Created:
2017/01/10 4:44 PM
Priority:
Normal
Reporter:
Eric Thompson
it appears deep_merge_options are being picked up in the config file, but somehow not understood or honored:
[root@tcqscrr9nhig5nu v3_config_and_data_jmfzk9h3]# pwd
/etc/puppetlabs/code/environments/v3_config_and_data_jmfzk9h3
[root@tcqscrr9nhig5nu v3_config_and_data_jmfzk9h3]# cat hieradata/somesuch.*
{
