Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Jorie Tappa Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Eric Thompson updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Eric Thompson QA Risk Assessment Reason: covered by unit tests; existing acceptance Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Eric Thompson updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Eric Thompson QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg assigned an issue to qa Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Henrik Lindberg Status: Ready for Engineering Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg commented on PUP-7402 Re: handle trailing slashes in references between file resources I believe it was brought back into "ready for engineering" as there were test failures in acceptance. Those are now corrected. (I also think it is wrong to bring a ticket back to "ready for engineering" when the merged logic was not reverted - it should have stayed in test. Changing status. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Eric Sorenson commented on PUP-7402 Re: handle trailing slashes in references between file resources Is this ticket's status correct? Looks like there's already code merged but it's in ready for engineering... Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg commented on PUP-7402 Re: handle trailing slashes in references between file resources I fixed a similar test in the PR. The reason for the change is that the !defined part will now find the resource where it earlier did not. Therefore the test will never add the second conflicting file resource. I.e the test is based on the assumption that it would not find the resource when the endings were different. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title
Josh Cooper commented on PUP-7402
Re: handle trailing slashes in references between file resources
Failed CI in https://jenkins-master-prod-1.delivery.puppetlabs.net/view/puppet-agent/view/master/view/puppet-agent/job/platform_puppet-agent_intn-van-sys_suite-daily-puppet-master/45/
Looks like the test is looking for already declared error message, which I would still expect when running puppet apply. Except that we're using noop, so maybe we don't trigger the message any more. Not sure if the code or test needs updating.
[root@i62nkbk8ue3rc9q puppet]# cat /tmp/dir-resource.5L4vvL
$dir='/tmp/create-dir.EBKZab'
$same_dir='/tmp/create-dir.EBKZab/'
file {$dir:
ensure => directory,
}
if !defined(File["${same_dir}"]) {
file { $same_dir:
ensure => directory,
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Thomas Hallgren commented on PUP-7402 Re: handle trailing slashes in references between file resources Merged to master at ae066f9. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Henrik Lindberg Sprint: PDE 2017-04-05 , PDE 2017-04-19 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Henrik Lindberg Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Kenn Hussey Team: Puppet Developer Experience Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg commented on PUP-7402 Re: handle trailing slashes in references between file resources Side note: the logic that deals with resource references and aliases and the data structures used to index them is a complete mess of expensive operations that over and over again construct values for various aspects of "identity", and even need to construct semi initialized resources in order to trigger the logic of getting a "uniqueness_key". The entire API and implementation needs to be refactored. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources This seemed like an important bug fix, so I brought this in. Without this, validation of references would turn into a nuisance for users that have not been pedantic about references to files (always using the same style wrt trailing slash in titles and references). Change By: Henrik Lindberg Story Points: 3 Release Notes Summary: Certain combination of references to File resources where title and reference were not the same with respect to use of a trailing '/' could cause a reference to not be resolved and resulting in an error. This is now fixed. Sprint: PDE 2017-04-05 Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Henrik Lindberg Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Wyatt Alt updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Wyatt Alt Affects Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Wyatt Alt updated an issue Puppet / PUP-7402 handle trailing slashes in references between file resources Change By: Wyatt Alt Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title Henrik Lindberg commented on PUP-7402 Re: handle trailing slashes in references between file resources I am not sure how to best fix this. Clearly the knowledge of "trailing slash" is specific to the File resource. In general we want to not having to run any code in the resource type's implementation (which is required for this) as that makes us run into the problems of "environment isolation". The File type is however part of Puppet and therefore cannot change between environments. The operation that is required is to create an instance of the resource and then ask for its ref, and then use that to lookup the resource in the catalog. That is however expensive if it is done for every resource. We need to find a better way. Note that, this problem only affects relationships formed via meta parameters. If the operators > < etc. are used then the difference in trailing slash treatment would already have hit the users since it has been that way for quite some time - the relationship operators have both been validating relationships and flagging a diff on trailing slash as a mismatch/not-found. I suggested to Wyatt Alt that this ticket was logged so we could add the relevant tests to Puppet for the behaviour that we actually expect. But also to have the discussion here - what that behavior is supposed to be. For quite some time now, there has been a difference between metaparam refs and operator refs. (Metaparam refs were not validated, but operator ones were, and validation did not consider aliases. In 5.0.0 both metaparam and operator refs are validated, and alias are considered, but the catalog cannot lookup a File[/foo] and find a File[/foo/] (and vice versa). Need to dig into how File does this to see how to best support this. My main concern is other resource types that do the same/similar thing and that we must support generate types to avoid running into environment isolation problems. If we do nothing users may have to change manifests to ensure that naming and referencing files is done consistently with or without slashes. (Would that be terribly bad? They already had to do that in 4.x for relationships formed with the relationship operators). Ping Eric Sorenson and Lindsey Smith Add Comment
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-7402
handle trailing slashes in references between file resources
Change By:
Henrik Lindberg
This change:https://github.com/puppetlabs/puppet/commit/3577fc913373f05b6c58fd7389e097ba7271c147/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb#diff-0changed the legal relationships between file resources with trailing slashes. Specifically, this manifest{code}file {"/home/wyatt/foo": ensure => directory, require => File["/home/wyatt/foo/"],}{code}will compile on Puppet < 5, and store a catalog in PuppetDB, while presenting an error to the user about a circular dependency. On Puppet 5, the same catalog will fail compilation because it is considering the path with the trailing slash to be different than the one in the resource title, meaning the referenced resource is considered missing. Consequently, the catalog is not stored in PuppetDB.This issue was caught by the PuppetDB spec tests around this case here:https://github.com/puppetlabs/puppetdb/blob/master/puppet/spec/unit/indirector/catalog/puppetdb_spec.rb#L623After talking it over with [~henrik.lindberg], we determined that the tests should probably be ported to Puppet and that Puppet compilation needs to handle the behavior change reverted trailing slash in a backwards compatible way .
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send
Jira (PUP-7402) handle trailing slashes in references between file resources
Title: Message Title
Wyatt Alt created an issue
Puppet / PUP-7402
handle trailing slashes in references between file resources
Issue Type:
Bug
Assignee:
Unassigned
Created:
2017/03/28 2:51 PM
Fix Versions:
PUP 5.0.0
Priority:
Normal
Reporter:
Wyatt Alt
This change: https://github.com/puppetlabs/puppet/commit/3577fc913373f05b6c58fd7389e097ba7271c147/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb#diff-0
changed the legal relationships between file resources with trailing slashes. Specifically, this manifest
file {"/home/wyatt/foo":
ensure => directory,
require => File["/home/wyatt/foo/"],
