Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title
Josh Cooper commented on PUP-7497
Re: puppet resource package command fails to list all packages
The problem is the instances method assumes the title is unique across all providers of that type, but the package type supports composite namevars. This patch seems to work, but causes the same package to be reported by both rpm and dnf:
diff --git a/lib/puppet/type.rb b/lib/puppet/type.rb
index 6690a451a7..a55d029c08 100644
--- a/lib/puppet/type.rb
+++ b/lib/puppet/type.rb
@@ -1187,16 +1187,18 @@ class Type
# We always want to use the "first" provider instance we find, unless the resource
# is already managed and has a different provider set
title = instance.respond_to?(:title) ? instance.title : instance.name
-other = provider_instances[title]
+result = new(:name => instance.name, :provider => instance, :title => title)
+key = result.uniqueness_key.compact.join(':')
+other = provider_instances[key]
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Branan Riley updated an issue Puppet / PUP-7497 puppet resource package command fails to list all packages Change By: Branan Riley Labels: cli discovery package triaged type_and_provider Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Branan Riley updated an issue Puppet / PUP-7497 puppet resource package command fails to list all packages Change By: Branan Riley Labels: cli discovery package type_and_provider Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Thomas Kishel commented on PUP-7497 Re: puppet resource package command fails to list all packages Trouble begins right around here: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type.rb#L1168 Puppet.debug "%s %s found in both %s and %s; skipping the %s version" % Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title
Ruth Linehan commented on PUP-7497
Re: puppet resource package command fails to list all packages
Reproduced this - and in the above example with zip from both yum and gem, puppet resource package has the same incorrect output:
package { 'zip':
ensure => '3.0-11.el7',
}
with nothing about it from gem.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Ruth Linehan updated an issue Puppet / PUP-7497 puppet resource package command fails to list all packages Change By: Ruth Linehan Team: Agent Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Thomas Kishel updated an issue Puppet / PUP-7497 puppet resource package command fails to list all packages Change By: Thomas Kishel Labels: discovery Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title
Thomas Kishel updated an issue
Puppet / PUP-7497
puppet resource package command fails to list all packages
Change By:
Thomas Kishel
h4. Issue:h4. The {{puppet resource package}} command used to list packages de-duplicates identically named resources managed by multiple providers.This results in an incomplete list of installed packages , including in the Package Inspector feature released in Puppet Enterprise 2017 . 2. h4. Test:h4. {code}# SYSTEM RUBY[root@pe-20172nightly-master ~]# gem list*** LOCAL GEMS ***geocoder (1.4.3)trollop (2.0)# PUPPET RUBY[root@pe-2017-master ~]# /opt/puppetlabs/puppet/bin/gem list*** LOCAL GEMS ***geocoder (1.3.3)typhoeus (1.0.2){code}Result:{code}[root@pe-2017-master ~]# puppet resource package --param providerpackage { 'geocoder': ensure => ['1.4.3'], provider => 'gem',}package { 'trollop': ensure => ['2.0'], provider => 'gem',}package { 'typhoeus': ensure => ['1.0.2'], provider => 'puppet_gem',}{code}typhoeus gem is only installed in puppet ruby and is listedtrollop gem is only installed in system ruby and is listedgeocoder gem is installed in puppet and system ruby and only system ruby is listed
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Thomas Kishel commented on PUP-7497 Re: puppet resource package command fails to list all packages This issue isn't specific to gem vs puppet_gem providers, it also occurs with gem vs yum providers. [root@pe-201721-master ~]# gem install zip [root@pe-201721-master ~]# gem list | grep zip zip (2.0.2) [root@pe-201721-master ~]# yum install zip [root@pe-201721-master ~]# yum list installed | grep zip zip.x86_64 3.0-11.el7 @base
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title
Thomas Kishel updated an issue
Puppet / PUP-7497
puppet resource package command fails to list all packages
Change By:
Thomas Kishel
h4. Issue:h4. The {{puppet resource package}} command used to list packages discards de-duplicates identically named resources managed by multiple providers.This results in an inaccurate incomplete list of installed packages.h4. Test:h4. {code}# SYSTEM RUBY[root@pe-20172nightly-master ~]# gem list*** LOCAL GEMS ***geocoder (1.4.3)trollop (2.0)# PUPPET RUBY[root@pe-2017-master ~]# /opt/puppetlabs/puppet/bin/gem list*** LOCAL GEMS ***geocoder (1.3.3)typhoeus (1.0.2){code}Result:{code}[root@pe-2017-master ~]# puppet resource package --param providerpackage { 'geocoder': ensure => ['1.4.3'], provider => 'gem',}package { 'trollop': ensure => ['2.0'], provider => 'gem',}package { 'typhoeus': ensure => ['1.0.2'], provider => 'puppet_gem',}{code}typhoeus gem is only installed in puppet ruby and is listedtrollop gem is only installed in system ruby and is listedgeocoder gem is installed in puppet and system ruby and only system ruby is listed
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Thomas Kishel commented on PUP-7497 Re: puppet resource package command fails to list all packages Windows: # SYSTEM RUBY C:\Users\Administrator>gem list *** LOCAL GEMS *** did_you_mean (1.0.0) sinatra (1.4.8) # PUPPET RUBY
Jira (PUP-7497) puppet resource package command fails to list all packages
Title: Message Title Thomas Kishel created an issue Puppet / PUP-7497 puppet resource package command fails to list all packages Issue Type: Bug Affects Versions: PUP 4.9.4 Assignee: Unassigned Created: 2017/05/04 12:04 PM Environment: Linux and Windows Priority: Normal Reporter: Thomas Kishel Issue: The puppet resource package command used to list packages discards identically named resources managed by multiple providers. This results in an inaccurate list of packages. Test: # SYSTEM RUBY
