Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Adam Buxton commented on PUP-7615 Re: puppet command leaks module command issues. Josh Cooper I'm with a client this week, is there a easy way for me to test this ? Do we have an overnight build running I can log into or can pull and vagrant run Happy to test, equally pretty happy you all know more about this fix working than I do Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Josh Cooper commented on PUP-7615 Re: puppet command leaks module command issues. Merged to master at https://github.com/puppetlabs/puppet/commit/281b8905480ff7368237b90e646cc4428d1bb054. Adam Buxton it would be great if you could give this a try. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-7615
puppet command leaks module command issues.
Change By:
Henrik Lindberg
when invoking {code} $ puppet facts (and various utils)Warning: vosp_wls has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at '], "data_provider": null}'Warning: wls_helpers has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at '{"name":"puppetlabs-lvm","version_requirement":">= 0.7.0"} ], "data_provider": null}'Warning: vosp_wls has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at '], "data_provider": null}'Warning: wls_helpers has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at '{"name":"puppetlabs-lvm","version_requirement":">= 0.7.0"} ], "data_provider": null}' {code} These appear to be bleed from what I would expect in puppet module list can or should these be quashed in other utilities.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-7615 puppet command leaks module command issues. Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title
Henrik Lindberg assigned an issue to Henrik Lindberg
Puppet / PUP-7615
puppet command leaks module command issues.
Change By:
Henrik Lindberg
Assignee:
Adam Buxton Henrik Lindberg
Acceptance Criteria:
That it is possible to squelch warnings about faulty metadata.json
Sub-team:
Language
Story Points:
1
Release Notes Summary:
Warnings from faulty metadata.json can now be turned off by setting {{\--strict=off}}.
Team:
Agent
Sprint:
Agent 2017-06-14
Release Notes:
New Feature
Fix Version/s:
PUP 5.0.0
Component/s:
PE
Issue Type:
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Charlie Sharpsteen commented on PUP-7615 Re: puppet command leaks module command issues. Allowing the warning to be silenced by setting strict to off seems reasonable. There may also be an opportunity to improve the message to indicate contexts in which the warning shouldn't be ignored. For example, puppet lookup is probably impacted by this since the metadata file is used to determine which data provider to use for a module. Adding a context-sensitive filter to the message seems like a good idea, but in this case the settings code is already over-complicated and overly sensitive to context. Adding more complexity and sensitivity (more bugs and edge cases) doesn't seem like a good trade-off as this message is: Legitimate, as there is something broken with module metadata that should be fixed and not ignored indefinitely. Just a warning and doesn't prevent tools from executing. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title
Henrik Lindberg commented on PUP-7615
Re: puppet command leaks module command issues.
Adam Buxton Totally understand your frustration.
I looked into what we are currently doing, and the logic is like this (in module.rb):
rescue JSON::JSONError => e
msg = "#{name} has an invalid and unparsable metadata.json file. The parse error: #{e.message}"
case Puppet[:strict]
when :off, :warning
Puppet.warning(msg)
when :error
raise FaultyMetadata, msg
end
{}
As you can see there is a simple opportunity here to change --strict=off to not generate an error. The issue then is that other problems are likely to
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Adam Buxton commented on PUP-7615 Re: puppet command leaks module command issues. You are right they do have that problem with the modules and I am working with them to resolve those issues, but I believe from experience that issue is a separate issue and should be treated as such. The obvious scenario here is they are on a brownfield site trying to learn Puppet and we are sending up false flags every time they run any of the Puppet utilities. Warnings or Errors should not be allowed to make any unrelated utilities look as if they have issues. It is counter intuitive, it is obstructive and if this was support trying to help a remote customer it would be misleading to the customer and be unhelpful to support to have to process the error while troubleshooting. The later is literally what as happened to me with the customer, trying to help them run puppet query and having to spend time sidetracked explaining the issue which I'd already flagged to them to fix in the module context . Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Henrik Lindberg commented on PUP-7615 Re: puppet command leaks module command issues. The logic is simply not structured that way - when puppet needs to load a module it does so, and if that module is broken puppet errors. IMO it is doing the right thing, and it should error. If you were to get past that error (we could add an ignore of errors of metadata.json parsing) - you then have the follow on problem that information in metadata.json (which is used at runtime) is missing and the module may then not function as it should (as an example the 4x function API requires dependencies to be correctly described). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Adam Buxton commented on PUP-7615 Re: puppet command leaks module command issues. Henrik Lindberg Re your suggested course of actions, I'd already reported to the client that their metadata for custom modules as issues and they need to update their test scenarios fro the metadata to be valid during module development. Running the command in different environments get's the same result with different modules etc.. re your questions 1/ My expectation would be that on running utility commands errors of no consequence to that command would not actually show up at all, the errors are out of context when I run `Puppet Fact` , but in context when running the `puppet module` commands. 2/pe 2016.5 3/yes, they are all custom modules for the client 4/nope Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Adam Buxton updated an issue Puppet / PUP-7615 puppet command leaks module command issues. Change By: Adam Buxton Component/s: PE Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Henrik Lindberg assigned an issue to Adam Buxton Puppet / PUP-7615 puppet command leaks module command issues. Change By: Henrik Lindberg Assignee: Adam Buxton Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title Henrik Lindberg commented on PUP-7615 Re: puppet command leaks module command issues. The report is a bit cryptic, but I am taking a guess at what is going on here: When puppet runs, it looks for the application to run (for example "puppet facts"), in order to search it needs an environment to search in (by default "production"), since it is possible to ship applications in modules on the module path puppet loads the modules on the environment's module path. When doing so, it needs to understand things about the modules and it is therefore loading metadata.json. Some of the modules seem to have faulty metadata.json. Cause of action here: fix the broken modules (recommended) do not have those modules in the default environment (production) run commands in a different environment Adam Buxton - a couple of questions: what is it you are expecting someone to fix? which version of Puppet is this for? Have the issues with faulty metadata.json been brought to the attention of the maintainers of the respective module? anything that I misunderstood ? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Jira (PUP-7615) puppet command leaks module command issues.
Title: Message Title
Adam Buxton created an issue
Puppet / PUP-7615
puppet command leaks module command issues.
Issue Type:
Bug
Assignee:
Unassigned
Created:
2017/06/02 2:02 AM
Priority:
Normal
Reporter:
Adam Buxton
when invoking $ puppet facts (and various utils) Warning: vosp_wls has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at '], "data_provider": null } ' Warning: wls_helpers has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at ' {"name":"puppetlabs-lvm","version_requirement":">= 0.7.0"}
], "data_provider": null } ' Warning: vosp_wls has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at '], "data_provider": null } ' Warning: wls_helpers has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at ' {"name":"puppetlabs-lvm","version_requirement":">= 0.7.0"}
], "data_provider": null } '
These appear to be bleed from what I would expect in puppet module list can or should these be quashed in other utilities.
Add Comment
