Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Eric Thompson updated an issue Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Eric Thompson QA Risk Assessment Reason: covered by unit tests Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Eric Thompson updated an issue Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Eric Thompson QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Josh Cooper commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code I agree with Maggie Dreyer about unit test coverage, resolving. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Eric Thompson updated an issue Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Eric Thompson Labels: regression Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Maggie Dreyer commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Personally I feel like the unit tests are enough. I just verified manually that this works. But I do want to qualify that I don't have a good grasp of the subtleties at work here (need to learn more about environments). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Eric Thompson commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Josh Cooper, Ethan Brown, Maggie Dreyer, any opinions on if this should be covered in acceptance? i see the unit tests ensuring modulepath is set in static environment use case. does this go far enough to ensure we can load code the way we expect in places like puppet resource? does this need to be tested against env isolation type cases? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Maggie Dreyer assigned an issue to Maggie Dreyer Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Maggie Dreyer Assignee: qa Maggie Dreyer Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Branan Riley assigned an issue to qa Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Branan Riley Status: Ready for CI Test Assignee: Ethan Brown qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Geoff Nichols commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Merged to puppet#5.0.x at https://github.com/puppetlabs/puppet/commit/60ff95787256e92ca5c98daa08c4c3f188e8be69. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Josh Cooper assigned an issue to Ethan Brown Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Josh Cooper Assignee: Josh Cooper Ethan Brown Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-7766
Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Change By:
Josh Cooper
Release Notes Summary:
Fixes a regression introduced in 5.0.0 that prevented {{puppet resource}} from loading custom types from modules when an explicit {{modulepath}} was specified.
Release Notes:
Bug Fix
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Josh Cooper commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code The second issue is caused because the provider attempts to require helper code but assumes the helper code is in the $LOAD_PATH. That is only true when running puppet agent because we add the agent's pluginsync directory Puppet[:libdir] on the LOAD_PATH. It wouldn't make sense for puppet resource because you'd get different results depending if the agent had run or not. The apache module should be fixed to use require_relative, so that we can always locate the helper code. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Josh Cooper updated an issue Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Josh Cooper Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Geoff Nichols Sprint: Agent N+1 2017-07-26 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Thomas Hallgren commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code New findings: The first commit provided in the PR solves the problem first reported in this ticket. The second problem, found by me, that the a2mod type doesn't find its provider, is the result of using invalid directory names (in this case "puppetlabs-apache" instead of just "apache"). Directories that follow correct naming convention get their lib directories added to the `$LOAD_PATH`. Ethan Brown, Josh Cooper, I suggest that the PR gets accepted in its current form since that solves the reported problem. I removed the second commit (the one that modified the `$LOAD_PATH`. The problem with types not finding their providers is not a regression. It can be solved in one of two ways: Relax the Puppet::Module#is_module_directory? so that it accepts hyphens (must probably be considered a breaking change) Somehow address this in the test framework Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-7766 Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Thomas Hallgren commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code A lot of things seems broken and needs to be fixed in order to support using static environment and --modulepath in combination. First of all, the --modulepath argument must be propagated to the environment that is created in Puppet#base_context. This doesn't happen today. With that fixed, then attempts are done to load a module and such attempts may succeed. An attempt to load the a2mod resource will however fail because the Autoload#load_file implementation is broken. It will call #get_file to find the absolute path of the provider in lib/puppet/provider/a2mod/a2mod.rb. That succeeds. It then calls Kernel#load with this absolute path. The load finds the file but when fails to evaluate it contents because that file contains a require 'puppet/provider/a2mod'. That's not an absolute path and it's not included in the $LOAD_PATH. Consequently, the output now reflects that the type is found but that provider fails to load: Warning: The a2mod provider is deprecated, please use apache::mod instead Error: Could not autoload puppet/provider/a2mod/a2mod: cannot load such file -- puppet/provider/a2mod It seems wrong to me to first use #get_file, which in turn searches, among others, the #module_directories since that list contains directories that the Ruby loader is not aware of. Those directories must be added to the $LOAD_PATH temporarily in order for things to work. I'm concerned that such a change might cause problems down the line. Add Comment
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Josh Cooper commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code David Schmitt, Thomas Honey can you weigh in on this? Has puppet resource --modulepath /path/to/modules regressed in Puppet 5, or did things sometimes work in 4.x when they shouldn't have? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Ethan Brown commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code I'm using a source based workflow - see Fedora 25 gist here - https://gist.github.com/Iristyle/ce390ef8f03785beea0d6acd808e33cd Note that 4.10.4 also fails to completely load the Apache code, so maybe the previous workflow I was using doesn't work for all module structures? I've always had success with that mechanism in the past when building modules FWIW. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title Thomas Hallgren commented on PUP-7766 Re: Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code Is this windows specific? I'm not able to reproduce it on a linux box. I tried the following: bundle exec puppet module install puppetlabs-apache bundle exec puppet resource a2mod works as expected. mv .puppetlabs/etc/code/modules /tmp bundle exec puppet resource a2mod no longer works, a2mod is not found. mv .puppetlabs/etc/code/modules /tmp bundle exec puppet resource a2mod --modulepath /tmp/modules works as expected.
Jira (PUP-7766) Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Title: Message Title
Ethan Brown created an issue
Puppet / PUP-7766
Puppet 5.0 Regression: puppet resource with --modulepath no longer loads expected code
Issue Type:
Bug
Affects Versions:
PUP 5.0.0
Assignee:
Thomas Hallgren
Created:
2017/07/10 4:58 PM
Fix Versions:
PUP 5.0.1
Priority:
Critical
Reporter:
Ethan Brown
Previously, when calling puppet resource, a --modulepath could be specified to load additional type / provider code.
For instance, with Puppet 4.10.4 / Ruby 2.3 running against a Windows node:
bundle exec puppet resource acl c:\windows --modulepath C:\source\puppetlabs-acl-master\spec\fixtures\modules
acl { 'c:\windows':
