Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Alex Dreyer commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans I don't like target node for two reasons: 1. It seems excessively verbose for something you use in most plans. 2. It's 'node centric' and targets should eventually align with things people don't like to call nodes like devices and services. I'm bad at naming things though. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title
Thomas Hallgren commented on PUP-8020
Re: Add data types Nodes and Node to puppet for tasks/plans
Alex Dreyer, yes, you did comment on that PR. And then Henrik Lindberg asked: "IMO - taken out of context it seems a bit too generic. @adreyer are you sure you want just Target? The first time a user may see it is when they read the source of a plan, and they see something like plan foo(Array[Target] $targets) { } - and you then have to think "what is a Target for a plan?"... whereas TargetNode tells you that this is about a node.". I agree with Henrik that the name "Target" is very generic.
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Alex Dreyer commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans I thought I commented on the PR that melinda, michelle and myself looked at how we use "target" in the UI/Docs and we can just change that and call the types "Target" and "Targets" I don't think the regex is that important for now as long as parsing errors generate useful messages Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans I'll divide this ticket into two tickets then. One for the URI data type (the implementation is complete) and then this one. Alex Dreyer, do you see any point in enforcing a regexp pattern on the string? If so, what regexp? Also, there's still an open question on the PR whether or not it's OK to call the new type described in this ticket TargetNode. I think that would be mine and Henrik's preference. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Alex Dreyer commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans There is a default in bolt which can be set with the --transport option. I don't think users should have to specify the scheme in the strings they pass and munging the string itself in bolt seems like it defeats the purpose of parsing this in puppet. URI does seem too strict. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans An string like 'www.example.com' does not represent a valid URI because it has not have a scheme. On the other hand, my assumption would be that the scheme is already determined (ssh or winrm). That in turn makes me wonder if the URI isn't too strict for a node representation. Do we really want to force the user to add the scheme? If not, what's the purpose of using a URI? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Kenn Hussey Fix Version/s: PUP 5.4.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Henrik Lindberg Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Geoff Nichols Sprint: Tasks ELP Kanban Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Thomas Hallgren Assignee: Thomas Hallgren Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Thomas Hallgren Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Thomas Hallgren Assignee: Thomas Hallgren Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title
Thomas Hallgren updated an issue
Puppet / PUP-8020
Add data types Nodes and Node to puppet for tasks/plans
Change By:
Thomas Hallgren
Comment:
I can think of several solutions to the "multiple files" problem that doesn't involve using directories under the tasks folder.1. Use a zip archive. It brings other advantages too in that it is easier and more compact to transport, checksum, etc.2. Put additional files under the "files" directory. This already works with the Puppet {{file_upload}} and {{run_script}} functions. They resolve relative names in the form _/_ from as files residing in _/files/_.3. Let each file use a different extension. If needed, add a number, e.g.{noformat}init.shinit.1.csvinit.2.csv...{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans I can think of several solutions to the "multiple files" problem that doesn't involve using directories under the tasks folder. 1. Use a zip archive. It brings other advantages too in that it is easier and more compact to transport, checksum, etc. 2. Put additional files under the "files" directory. This already works with the Puppet file_upload and run_script functions. They resolve relative names in the form / from as files residing in /files/. 3. Let each file use a different extension. If needed, add a number, e.g. init.sh init.1.csv init.2.csv ... Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans If a target is multiple nodes already, then that's not a good term. The name must signify one URI and the options to pass along with that URI. It's difficult to come up with a descriptive term given that we don't yet know what those options are or how they will be used. One way to resolve this would of course be to prefix the name with a namespace, e.g. Bolt::Node, or alternatively, use a concatenated name for the type such as BoltNode or TargetNode. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title
Alex Dreyer commented on PUP-8020
Re: Add data types Nodes and Node to puppet for tasks/plans
In out terminology elsewhere a target is already multiple nodes. Targets or Target[] may confuse that.
Also targets can be described in forms other than a list of nodes. They could be a pql query or something from an arbitrary inventory plugin.
If we are going to parse a string to create a target we should take this opportunity to split on the same regex we use in puppet-task. {boost::regex("[[:space:],]+")}
{/[\w,]+/}
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans Given the terminology conflict, I'd like to call the new type Target instead of Node. I think that term fits well with the domain. "Upload file to target x and y", "execute the command on the following targets", "The target host is x.y.z", etc. Eric Sorenson, Alex Dreyer, I'd like to hear your opinion on this. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans A complicating factor when implementing the new Node data type type is that node is a keyword in Puppet which parses into a NodeDefinition which is subsequently transformed into a special Puppet::Resource::Type. It is still possible to use Node as a type name (with upper-case 'N') when running with --tasks but do we really want to deliberately create this conflict? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans A string argument to a Node must of course be interpreted as a URI. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Henrik Lindberg commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans While the URI type is of value, the purpose of the entire thing is to make it easy to supply a Node as a string, or a comma separated list of strings. The URI parameters etc. are not asked for - for example it is not ok to force users to initialize a Node as Node(uri => URI(string)). The pattern matching and rules per named part of a URI will come in handy later though. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title
Thomas Hallgren commented on PUP-8020
Re: Add data types Nodes and Node to puppet for tasks/plans
Short recap then, to ensure that we're on the exact same page. The immediate requirements in this ticket are:
1. Implement the URI data type as described. 2. Implement the Node data type as:
Object[
attributes => {
'uri' => URI,
'options' => { type => Hash[String[1], Data], value = {} }
}
]
URI data type enhancement: Inspired by the comment about "tightening", we should make it possible to parameterize the URI data type so that it can constrain what parts of an uri that are allowed (the initial uri proposal suggest matching parts individually but doesn't provide a way to constrain them). Since the parts are well known by name, e.g.:
hierarchical
┌───┴─┐
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Henrik Lindberg commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans Answers / comments: the type Nodes can be an alias for Array[Node] - its main purpose is syntactic sugar (desired by users). If more control over the content is wanted users can use Array[Node, min, max]. The only concern here is that a future UI needs to dig out the parameters where a list of nodes is supposed to be presented. Now that we have the type system available for the JVM it should be a matter of assignability to Array[Node], thus allowing us to handle more advanced cases (tuples, additional restrictions on the Node's etc.) It is good to have a general purpose URI type a Node's "free form hash" is for options so Hash[String[1], Data] is fine - don't see any real need for RichData here. the comma-separated list to Array[Node}} conversion does not really have to be made at the type level - there is always logic feeding the comma separated list of nodes to a plan or task via the functions run_plan and run_task - those functions would take a string to be "potentially comma separated list", and thus if you have URI:s for nodes with commas in them (that would be extremely rare as we are not going to use fragments and queries in the URIs that denote nodes) you would instead give an actual Array of Node or URI to the execution functions. We know that a URI is not enough to fully describe a Node, and we know a hash of options will work - it needs to be open ended because different protocols will require different options. That design could potentially be tightened by having a type associated with a scheme/protocol for the options thus enabling validation of what users give but that would be a future thing. With the additional complexity added to the multiple dispatch in the execution functions comes the price of getting a generic and large error message on type mismatch. We need to also add a custom error message for that, or new users will be baffled when making small mistakes. Add Comment
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans Alternative proposal: Let's add the URI datatype. An instance can be assembled from the individual parts (provided as a hash) or parsed from a string (raw or encoded depending on additional argument) and make the parts available (with choice of encoded or raw form where appropriate) as instance attributes. The URI init_hash can be described as: type UriInitHash = Struct[ Optional[scheme] => String, Optional[user_info] => String, Optional[host] => String, Optional[port] => Integer[0,default], Optional[path] => String, Optional[query] => String, Optional[fragment] => String, ]
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans Given that an URI can contain commas (but a domain name cannot), perhaps we must make it semantically clear what parts of a URI that can be included? Either that, or provide some kind of escape mechanism (double quoting the URI's for instance, since they cannot be used in an URI without escaping them) when parsing the comma-separated string. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Thomas Hallgren commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans I assume that the options "free form hash" is really a Data hash, i.e. Hash[String[1], Data]. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title
Thomas Hallgren commented on PUP-8020
Re: Add data types Nodes and Node to puppet for tasks/plans
I don't understand the motivation for Nodes, Why isn't it enough to declare Array[Node] at all times where multiple nodes are desired? From the looks of it, the only motivation for the a new type with all it's bells and whistles here would be the ability to split a comma separated string. If so, why not use a function?
function parse_nodes(String[1] $nodes) >> Array[Node] {
$nodes.split(',').map |$n| { Node($n) }
}
and if it's too cumbersome to spell out the array form, use an alias:
type Nodes = Array[Node]
If we really need a Nodes data-type for other reasons, should it be parameterized? I.e. is it possible to write Nodes[1] or Nodes[0,3]?
What about assignability? Is Nodes assignable to Array[Node]? Is the opposite true? Are they equal in magnitude? Is Nodes[2,2] assignable to Tuple[Node, Node]?
Add Comment
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Henrik Lindberg Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Change By: Henrik Lindberg Sprint: Tasks ELP Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title
Eric Sorenson updated an issue
Puppet / PUP-8020
Add data types Nodes and Node to puppet for tasks/plans
Change By:
Eric Sorenson
Currently we use a {{String}} data type (that is supposed to have a URI format) as the way to specify a node in the execution API. While this works for now, there are some things are difficult with this design:* When retrospecting introspecting a plan, the data type for a parameter that accepts nodes cannot be identified when it is simply String, or Array[String].* There are additional values (besides what is easily expressed in a URI) that users must be able to specify* There is the desire to be able to describe nodes as a comma separated list of URI - the parsing and handling of that (creating individual node references) is logic that should be available in a single implementationTo solve this, we should add two new data types {{Node}} to describe a single node, and {{Nodes}} a collection of {{Node}} that in most aspects behaves like it was an {{Array\[Node]}}.A {{Node}} has the following attributes:* {{uri}} - contains the protocol, hostname, port, user and password - the individual parts are also available as separate attributes - when constructing an instance, it is specified as either a uri, or as individual parts. (Construction from parts is clearer when author needs to construct the uri from individual values; such as looking up user/password information).* tbd - additional options that vary per protocol - probably a free form hash under an {{options}} attribute - but this may be designed with stronger typing if there is a registry of available protocols (that types valid options).* The constructor should accept a single string and take that to be a URI, or a hash where either uri + options are specified, or the individual parts + options.The {{Nodes}} data type* has an internal list of {{Node}}* it is constructed from a {{String}} such that a split is first made on {{,}} and each split string (s) is fed to {{Node.new(s)}}* it is constructed from an {{Array}} such that each element is an {{Init\[Node]}} - a String or a Hash of attributes for a {{Node}}The functions that take "nodes" should be updated to also accept instance of {{Nodes}}, {{Node}}, or {{Array\[Node]}}. (if they are fed strings, they will create the corresponding Node instances).To complete the functionality, there must be a way to give {{Node}}/{{Nodes}} to bolt (currently this is a URI String only). We do not want to encode all of the attributes of {{Node}} into a URI instead we want a URI in string form to be a unique identifier for one node (connection).
Add Comment
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Eric Sorenson commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans LGTM! Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Henrik Lindberg commented on PUP-8020 Re: Add data types Nodes and Node to puppet for tasks/plans Ping Eric Sorenson - does this description meet your expectations? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8020) Add data types Nodes and Node to puppet for tasks/plans
Title: Message Title Henrik Lindberg created an issue Puppet / PUP-8020 Add data types Nodes and Node to puppet for tasks/plans Issue Type: New Feature Assignee: Unassigned Created: 2017/10/03 12:05 PM Priority: Normal Reporter: Henrik Lindberg Currently we use a String data type (that is supposed to have a URI format) as the way to specify a node in the execution API. While this works for now, there are some things are difficult with this design: When retrospecting a plan, the data type for a parameter that accepts nodes cannot be identified when it is simply String, or Array[String]. There are additional values (besides what is easily expressed in a URI) that users must be able to specify There is the desire to be able to describe nodes as a comma separated list of URI - the parsing and handling of that (creating individual node references) is logic that should be available in a single implementation To solve this, we should add two new data types Node to describe a single node, and Nodes a collection of Node that in most aspects behaves like it was an Array[Node]. A Node has the following attributes: uri - contains the protocol, hostname, port, user and password - the individual parts are also available as separate attr
