Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Josh Cooper Fix Version/s: PUP 5.4.0 Fix Version/s: PUP 5.y Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Josh Cooper commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Rick Sherman based on your comment "We're going to close this PR in favor of moving both apply and resource functionality directly into puppet device" I assume we can close the ticket too? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Davin Hanlon updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Davin Hanlon Team: Modules Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Rick Sherman commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices In speaking with Kenn Hussey we may be able to merge this feature back down to 1.10.x and 5.3.x as it supports some of our broader goals. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Thomas Kishel commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Yay! The 'upside' is, by having target use the url fact, FACTER_url is still available. I tried to identify an alternate mechanism to pass the device object, but was unable navigate the indirection ... # f5.rb def self.transport if Puppet::Util::NetworkDevice.current #we are in `puppet device` Puppet::Util::NetworkDevice.current.transport else puts caller #we are in `puppet resource` Puppet::Util::NetworkDevice::Transport::F5.new(Facter.value(:url)) end
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title David Schmitt commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Thomas Kishel having this will likely fix, or provide a fix for https://github.com/DavidS/puppet-resource_api/blob/60ff8bccbff381b54fd3e67bb2418f1201c0174f/lib/puppet/resource_api/base_context.rb#L10 The only "downside" (if you can even call it that) is that it'll only work for new versions of puppet, and therefore the FACTER_url workaround will likely still be necessary until old versions go out of support. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Thomas Kishel commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices David Schmitt I recently discovered PDK-610. Does this relate/is this compatible with your work? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Josh Cooper commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Ah my bad, I missed the linked PR. Thanks for reopening. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Thomas Kishel commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices My last comment here, regarding Alexander's 'apply_to_device' questions? If so, this should remain open as it has an open PR under review. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Josh Cooper commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Based on Thomas' last comment, I'm going to close this. Please reopen if I'm mistaken. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Rick Sherman updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Rick Sherman Fix Version/s: PUP 5.3.4 Fix Version/s: PUP 4.10.9 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Rick Sherman updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Rick Sherman Fix Version/s: PUP 4.10.9 Fix Version/s: PUP 4.10.10 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Rick Sherman updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Rick Sherman Fix Version/s: PUP 5.4.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Rick Sherman assigned an issue to Rick Sherman Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Rick Sherman Assignee: Rick Sherman Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Adam Bottchen updated an issue Puppet / PUP-8041 Replace FACTER_url with --target for puppet resource with devices Change By: Adam Bottchen Labels: cs_pr_review Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Thomas Kishel commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices No need to apologize: you happened to catch the module during its transition from Developed by Puppet to Developed by F5; and it's great that you're interested in contributing, and your contribution looks interesting. I suggest filing an Issue on GitHub in the F5 repo documenting the problem you are trying to solve; then submit a PR with your solution. Puppet also has a Slack channel: https://puppetcommunity.slack.com #forge-modules that both Puppet and Community members use to discuss module development. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title
Alexander Fisher commented on PUP-8041
Re: Replace FACTER_url with --target for puppet resource with devices
I'm really sorry. In my head, (and I haven't got a logical reason why!!), I thought you were with F5, not Puppet! My bad. Hopefully that might explain some of my previous comments!! I think I've also, (wrongly), assumed you were working at solving the 'limitation to watch out for in the current Puppet release is that 'puppet apply' and 'puppet resource' cannot modify network resources', whereas now I see you're just trying to replace the need to use FACTER_url when querying resources?
With my hack, I'm still using FACTER_url with puppet resource ,(or puppet apply), to specify the target device. I'm just suppressing the call to apply_to_device. Without the modification, setting resources fails with 'Skipping device resources because running on a posix host'. If you don't call apply_to_device, (with the couple of types I've tried), using puppet resource to set resources then 'just works'. eg
FACTER_url='https://puppet:pup...@f5-test.example.com' puppet resource --modulepath=/home/alex/modules f5_ntp '/Common/ntp' timezone=UTC
Notice: /F5_ntp[/Common/ntp]/timezone: timezone changed 'Europe/London' to 'UTC'
f5_ntp { '/Common/ntp':
ensure => 'present',
timezone => 'UTC',
}
Again, sorry for the confusion I've caused! I'll test out my hack with your PR. Since you're only doing Facter.add(:url) when --target is provided to 'puppet resource' (and not also when used with 'puppet device') I guess the changes are compatible.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Thomas Kishel commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Some thoughts ... The device modules I'm familiar with (f5, netapp, netscaler) all implement similar "we are in `puppet resource`" code that uses the url fact pattern, as does TP's simple_hue_device module, and TP authored the implementation of target in puppet device that this ticket/pull request builds upon: https://github.com/puppetlabs/puppet/pull/5768 I added your apply_to_device if Facter.value(:url).nil? to a clean install of puppet (one that does not include my PR) so I don't think that explains it's results on my system. But, more importantly, if you have a PR for the f5 device module, you will need to ask F5 about their preferences: they just recently took over development of the module. It appears that F5 has yet to update the Development section of its documentation regarding contributing. Anyway: my preferences wouldn't matter: I too am also just a code contributor at Puppet. That said, since a proxy puppet agent can specify multiple devices in it's device.conf, if a change such as yours allows puppet resource to connect to a device and get/set resources, but doesn't specify which device, then that change introduces the possibility that puppet resource will connect to an arbitrary, potentially unintended device, yes? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Alexander Fisher commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Oh, I wasn't testing with the changes to puppet you made in https://github.com/puppetlabs/puppet/pull/6275 ! Sorry for the confusion! I understand now. Specifically https://github.com/puppetlabs/puppet/pull/6275/files#diff-ca4a04cda3a8df800f6468a5510247a3R160 explains why my change isn't working for you. I wonder if it'd break any other modules? Probably not. There aren't that many puppet device types around and they don't all use the 'url' fact pattern. (I found https://github.com/tphoney/simple_hue_device that does, but that's just an example module) I've also only just supported the 'development' branch https://github.com/f5devcentral/f5-puppet/commits/development ! Would you prefer PRs targeting that branch or master? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Alexander Fisher commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices I tried the if 'Facter.value(:url).nil?' change in f5_ntp which is a much simpler type with just a single provider. I also only have one device in device.conf. I'm out the office now, but can do some more testing in the morning. Let me know if there's anything else you would like me to try. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Thomas Kishel commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Hmm ... the scope of this ticket was to simply to implement target in puppet resource as it is implemented in puppet device ... [root@pe-201731-master-x ~]# puppet resource --target bigip.example.com f5_virtualserver ... rather than allowing puppet resource and puppet apply to change the configuration of a device (although that would be a valuable improvement.) I added your apply_to_device change to lib/puppet/type/f5_virtualserver.rb, but that didn't allow puppet device to read the configuration of a device without FACTER_url ... [root@pe-201731-master-x ~]# puppet resource f5_virtualserver Warning: Found multiple default providers for f5_virtualserver: stateless, forwarding_ip, performance_l4, reject, forwarding_layer_2, performance_http, standard; using stateless Error: Could not run: undefined method `+' for nil:NilClass (And that error could be cleaned up with the following change in lib/puppet/provider/f5.rb ... ) def self.transport if Puppet::Util::Network
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title Alexander Fisher commented on PUP-8041 Re: Replace FACTER_url with --target for puppet resource with devices Over the last couple of days I've started looking into the F5 module . Getting rid FACTER_url altogether would probably be better, but in the types, instead of apply_to_device, couldn't we just do... apply_to_device if Facter.value(:url).nil? With that change, I've been able to use both puppet resource and puppet apply to change config on the F5. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8041) Replace FACTER_url with --target for puppet resource with devices
Title: Message Title
Thomas Kishel created an issue
Puppet / PUP-8041
Replace FACTER_url with --target for puppet resource with devices
Issue Type:
New Feature
Assignee:
Unassigned
Created:
2017/10/10 12:22 PM
Priority:
Minor
Reporter:
Thomas Kishel
Since 2012, we've used FACTER_url as a workaround for puppet resource:
A limitation to watch out for in the current Puppet release is that 'puppet apply' and 'puppet resource' cannot modify network resources. However, we implemented a feature to allow puppet resource to query a F5 device. (For authors of types/providers, making changes to resources aren’t supported until apply_to_device in resources type are handled differently by puppet apply/resource commands). For now we use url facts to establish connectivity to specific F5 devices.
https://puppet.com/blog/managing-f5-big-ip-network-devices-puppet
Using FACTER_url is insecure, as it places authentication credentials either in history or in the environment. It's also ugly.
If we implement --target in puppet resource as we've done in puppet device we can lookup the target device's url and internally set {{Facter(:url). This would not require changes to existing device modules.
If we implement this as a device(name) method in Puppet::Util::NetworkDevice::Config, it would allow device tasks to use device(name) to target devices.
