Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney created an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Issue Type:
Task
Assignee:
Unassigned
Created:
2017/11/08 8:49 AM
Priority:
Normal
Reporter:
Eric Delaney
The Puppet::Util.benchmark method adds to the message (msg) passed into the method. We should instead find all usages of the method and append the 'in % {seconds}
to the string passed in so that it can be included in the original translation message rather than appended separately. (like it as below)
object.send(level, msg + (_(" in %0.2f seconds") % seconds))
Making this change will cause the test tests/i18n/check_puppet_run_messages.rb to fail until translation is completed and the translation string in the test is updated (as needed).
Add Comment
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Sprint:
Platform Core Hopper Grooming
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Sprint:
Platform Core Hopper Grooming
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Sprint:
Platform Core Grooming Hopper
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Acceptance Criteria:
- Refactor calls to Puppet::Util.benchmark to pass in a complete message string- include "in %{seconds} seconds" in the string- have benchmark() format the string and and set the number of seconds take msg % " { seconds: seconds } - ensure tests and CI continue to pass
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Acceptance Criteria:
- Refactor calls to Puppet::Util.benchmark to pass in a complete message string- include "in %{seconds} seconds" in the string- have benchmark() format the string and and set the number of seconds take msg % " { seconds: seconds }
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney commented on PUP-8131
Re: Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
I looked at the code and most of the cases are easy enough to just add the missing string to the message in the benchmark() call.
In one case we'll need to escape % format so that we can process the string once in the method and then again inside of benchmark "ie string % {format_now}
more string in %% {seconds} seconds" so that the "%{seconds}
will be passed in the string to benchmark to complete the formatting of it
The puppet-test string uses benchmark, but none of the strings in it appear to be marked for translation.
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Sprint:
Platform Core Grooming Hopper
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Sub-team:
Coremunity
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Sprint:
Platform Core Hopper KANBAN
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney assigned an issue to Eric Delaney
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Assignee:
Eric Delaney
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Release Notes:
Not Needed
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Release Notes:
Not Needed New Feature
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Eric Delaney updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Eric Delaney
Release Notes:
New Feature Not Needed
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Josh Cooper assigned an issue to Melissa Stone
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Josh Cooper
Assignee:
Eric Delaney Melissa Stone
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Melissa Stone updated an issue
Puppet / PUP-8131
Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Change By:
Melissa Stone
Fix Version/s:
PUP 5.3.4
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8131) Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Title: Message Title
Melissa Stone commented on PUP-8131
Re: Calls to Puppet::Util.benchmark should include a 'in %{seconds} seconds' in there message
Merged into 5.3.x at https://github.com/puppetlabs/puppet/commit/fa13f1a10b718105e98ad2fe523d5bf0fc688e73
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
