Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title David Kramer updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: David Kramer Sub-team: Bolt Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title David Kramer updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: David Kramer Sprint: Bolt Kanban Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title David Kramer updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: David Kramer Team: Direct Change Platform Core Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title David Kramer assigned an issue to Unassigned Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: David Kramer Assignee: Alex Dreyer Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Jonathan Newman updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Jonathan Newman Sub-team: Bolt Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Alex Dreyer updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Alex Dreyer Release Notes Summary: Previously bolt rejected tasks that used non-Data types in parameters metadata. Now non-Data types are allowed. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Alex Dreyer updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Alex Dreyer Fix Version/s: BOLT 0.13.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Alex Dreyer updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Alex Dreyer Sprint: Bolt Kanban Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Geoff Nichols Team: Direct Change Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Michael Smith updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Michael Smith Fix Version/s: PUP 5.4.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Michael Smith updated an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Michael Smith Affects Version/s: PUP 5.4.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Thomas Hallgren commented on PUP-8283 Re: Puppet rejects tasks with valid non-Data types like 'Hash' I created BOLT-283 for the check if given user arguments is Data (item #3 in Alex's long term list). Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Thomas Hallgren assigned an issue to Alex Dreyer Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Thomas Hallgren Assignee: Thomas Hallgren Alex Dreyer Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Henrik Lindberg commented on PUP-8283 Re: Puppet rejects tasks with valid non-Data types like 'Hash' I suggest that we remove the enforcement that a user entered parameter data type T must be compliant with Data and instead just check at runtime that a given value is compliant with both T and Data. If user given type allows a value but it is not Data, it is really the schema/transport that limits the data type to Data, so this feels most natural. When there is an error it can be explained when it was allowed by data type but not by protocol. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Alex Dreyer commented on PUP-8283 Re: Puppet rejects tasks with valid non-Data types like 'Hash' There were a bunch of pretty long discussion on this last summer. We shouldn't change what Hash means we just need to update how we handle tasks Currently we have two layers: 1. Is the type specified for a parameter in metadata valid for a task.(Is it assignable to Data) 2. Is the specified parameter value assignable to the type in metadata. Long term we should have three layers: 1. Is the type specified for a parameter in metadata valid for a task(Is there a chance it's assignable to Data) 2. Does the specified parameter value match the specified type 3. Is the specified parameter value assignable to Data If adding layer 1 is difficult we should just skip it for the time being. It's more important that we allow valid metadata that uses the Hash type than fail fast for invalid metadata like using the Regex type. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Henrik Lindberg commented on PUP-8283 Re: Puppet rejects tasks with valid non-Data types like 'Hash' This is correct since Hash is actually a wider data type than Data since it can contain both keys and values that are not compliant. Don't think we can change this without lots of consequences. The compliant definition is Hash[String,Data] - for which we could make an alias like DataHash. Background - in the early versions of the type system, a Hash was supposed to be limited such that it was JSON Data compliant but it was not. Since it was already in use with a wider definition we decided to make Hash be the "any hash" (no constraints on keys/values). It has been that way since quite some time back. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-8283
Puppet rejects tasks with valid non-Data types like 'Hash'
Change By:
Henrik Lindberg
*Puppet Version:* BoltPuppet Tasks can only accept parameters as JSON. However it should be valid in task metadata to use puppet types that *may* be assignable to JSON like bare {{Hash}}. Puppet seems to be rejecting these{ { code} } Error: Failed to load metadata for task example_tasks::hash_get: Task initializer has wrong type, entry 'parameters' entry 'data' entry 'type' expects a Type[Data] value, got Type[Hash] in /Users/adreyer/src/puppetlabs/puppetconf_modules/example_tasks/tasks/hash_get.json{ { code} } *Desired Behavior:*Task metadata that gives parameters types that may be assignable to {{Data}} should be considered valid.*Actual Behavior:*Puppet refuses to load tasks that use types which are not assignable to {{Data}} like {{Hash}}
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Alex Dreyer created an issue Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Issue Type: Bug Assignee: Unassigned Created: 2017/12/21 9:28 AM Priority: Normal Reporter: Alex Dreyer Puppet Version: Bolt Puppet Tasks can only accept parameters as JSON. However it should be valid in task metadata to use puppet types that may be assignable to JSON like bare Hash. Puppet seems to be rejecting these code Error: Failed to load metadata for task example_tasks::hash_get: Task initializer has wrong type, entry 'parameters' entry 'data' entry 'type' expects a Type[Data] value, got Type[Hash] in /Users/adreyer/src/puppetlabs/puppetconf_modules/example_tasks/tasks/hash_get.json code Desired Behavior: Task metadata that gives parameters types that may be assignable to Data should be considered valid. Actual Behavior: Puppet refuses to load tasks that use types which are not assignable to Data like Hash Add Comment
Jira (PUP-8283) Puppet rejects tasks with valid non-Data types like 'Hash'
Title: Message Title Alex Dreyer assigned an issue to Thomas Hallgren Puppet / PUP-8283 Puppet rejects tasks with valid non-Data types like 'Hash' Change By: Alex Dreyer Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
