Jira (PUP-8284) i18n need to change "on node #{node}" code to be translation friendly
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-8284
i18n need to change "on node #{node}" code to be translation friendly
Change By:
Josh Cooper
We need to change how we report the node that a message occurs on to be more translation friendly. Currently the common way is to say "on node # \ {node \ }". We should be more translation friendly about this.{ { noformat} 09:42 $ grep -r 'on node' liblib/puppet/defaults.rb:should be used on nodes running `puppet agent` or `puppet apply`.lib/puppet/error.rb: msg = "#{msg} on node #{node}" if nodelib/puppet/external/dot.rb:'fixedsize', # default: false; label text has no affect on node sizelib/puppet/parser/compiler.rb:message = "#{detail} on node #{node.name}"lib/puppet/util/log.rb: msg = _("%{msg} on node %{node}") % { msg: msg, node: node } unless node.nil? {noformat } }
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8284) i18n need to change "on node #{node}" code to be translation friendly
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-8284
i18n need to change "on node #{node}" code to be translation friendly
Change By:
Josh Cooper
We need to change how we report the node that a message occurs on to be more translation friendly. Currently the common way is to say "on node #{node}". We should be more translation friendly about this. {noformat} 09:42 $ grep -r 'on node' liblib/puppet/defaults.rb:should be used on nodes running `puppet agent` or `puppet apply`.lib/puppet/error.rb: msg = "#{msg} on node #{node}" if nodelib/puppet/external/dot.rb:'fixedsize', # default: false; label text has no affect on node sizelib/puppet/parser/compiler.rb:message = "#{detail} on node #{node.name}"lib/puppet/util/log.rb: msg = _("%{msg} on node %{node}") % { msg: msg, node: node } unless node.nil? {noformat}
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8284) i18n need to change "on node #{node}" code to be translation friendly
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-8284
i18n need to change "on node #{node}" code to be translation friendly
Change By:
Josh Cooper
We need to change how we report the node that a message occurs on to be more translation friendly. Currently the common way is to say "on node #{node}". We should be more translation friendly about this.{ noformat} { 09:42 $ grep -r 'on node' liblib/puppet/defaults.rb:should be used on nodes running `puppet agent` or `puppet apply`.lib/puppet/error.rb: msg = "#{msg} on node #{node}" if nodelib/puppet/external/dot.rb:'fixedsize', # default: false; label text has no affect on node sizelib/puppet/parser/compiler.rb:message = "#{detail} on node #{node.name}"lib/puppet/util/log.rb: msg = _("%{msg} on node %{node}") % { msg: msg, node: node } unless node.nil? {noformat } }
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8284) i18n need to change "on node #{node}" code to be translation friendly
Title: Message Title
Thomas Hallgren commented on PUP-8284
Re: i18n need to change "on node #{node}" code to be translation friendly
Another thing to take into account here is that the wording "on node ..." can be gravely misleading. It should say something like "during compile for node ..." instead. PUP-8370 can serve as a good example of this.
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8284) i18n need to change "on node #{node}" code to be translation friendly
Title: Message Title
Eric Delaney created an issue
Puppet / PUP-8284
i18n need to change "on node #{node}" code to be translation friendly
Issue Type:
Task
Affects Versions:
PUP 5.3.3
Assignee:
Unassigned
Created:
2017/12/21 9:56 AM
Priority:
Normal
Reporter:
Eric Delaney
We need to change how we report the node that a message occurs on to be more translation friendly. Currently the common way is to say "on node # {node}". We should be more translation friendly about this. 09:42 $ grep -r 'on node' lib lib/puppet/defaults.rb: should be used on nodes running `puppet agent` or `puppet apply`. lib/puppet/error.rb: msg = "#{msg} on node #{node}
" if node lib/puppet/external/dot.rb: 'fixedsize', # default: false; label text has no affect on node size lib/puppet/parser/compiler.rb: message = "# {detail}
on node # {node.name}
" lib/puppet/util/log.rb: msg = _("% {msg}
on node % {node}
") % { msg: msg, node: node }
unless node.nil?
