Jira (PUP-8488) Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Title: Message Title John Duarte updated an issue Puppet / PUP-8488 Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate Change By: John Duarte QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.238005.1519415123000.9167.1571669701644%40Atlassian.JIRA.
Jira (PUP-8488) Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Title: Message Title
Eric Delaney commented on PUP-8488
Re: Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Looking through the modules, it appears that the only place that we stub out microsoft_windows? we're also stubbing windows?
./puppetlabs-inifile/spec/unit/puppet/type/ini_setting_spec.rb:Puppet.features.stub(:microsoft_windows?) { false }
./puppetlabs-inifile/spec/unit/puppet/type/ini_setting_spec.rb:Puppet::Util::Platform.stub(:windows?) { false }
./puppetlabs-inifile/spec/unit/puppet/type/ini_setting_spec.rb:Puppet.features.stub(:microsoft_windows?) { true }
./puppetlabs-inifile/spec/unit/puppet/type/ini_setting_spec.rb:Puppet::Util::Platform.stub(:windows?) { true }
Add Comment
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Jira (PUP-8488) Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Title: Message Title Eric Putnam updated an issue Puppet / PUP-8488 Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate Change By: Eric Putnam Convert usage of [Puppet.features.microsoft_windows?|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/feature/base.rb#L17] to [Puppet::Util::Platform.windows?|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/ windows platform .rb #L7 ] where appropriate.We need to be careful when reviewing the usages, its ok to mock the usage of Puppet.features.microsoft_windows? however we should NOT be mocking out the Puppet::Util::Platform.windows?, so care must be taken to ensure the things we convert make sense and that we continue to have the proper testing coverage. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from
Jira (PUP-8488) Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Title: Message Title Eric Putnam updated an issue Puppet / PUP-8488 Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate Change By: Eric Putnam Convert usage of [ Puppet.features.microsoft_windows? |https://github.com/puppetlabs/puppet/blob/master/lib/puppet/feature/base.rb#L17] to [ Puppet::Util::Platform.windows? |https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows.rb] where appropriate.We need to be careful when reviewing the usages, its ok to mock the usage of Puppet.features.microsoft_windows? however we should NOT be mocking out the Puppet::Util::Platform.windows?, so care must be taken to ensure the things we convert make sense and that we continue to have the proper testing coverage. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it,
Jira (PUP-8488) Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Title: Message Title Eric Putnam commented on PUP-8488 Re: Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate e.g. https://github.com/puppetlabs/puppetlabs-inifile/blob/master/spec/unit/puppet/type/ini_setting_spec.rb https://github.com/puppetlabs/puppetlabs-hocon/blob/master/lib/puppet/type/hocon_setting.rb#L15 https://github.com/puppetlabs/puppetlabs-registry/blob/master/spec/unit/puppet/provider/registry_value_spec.rb#L6 Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8488) Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Title: Message Title Eric Delaney updated an issue Puppet / PUP-8488 Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate Change By: Eric Delaney Sprint: Platform Core Grooming KANBAN Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8488) Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate
Title: Message Title Eric Delaney created an issue Puppet / PUP-8488 Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate Issue Type: Task Assignee: Eric Delaney Created: 2018/02/23 11:45 AM Priority: Normal Reporter: Eric Delaney Convert usage of Puppet.features.microsoft_windows? to Puppet::Util::Platform.windows? where appropriate. We need to be careful when reviewing the usages, its ok to mock the usage of Puppet.features.microsoft_windows? however we should NOT be mocking out the Puppet::Util::Platform.windows?, so care must be taken to ensure the things we convert make sense and that we continue to have the proper testing coverage. Add Comment
