Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title John Duarte updated an issue Puppet / PUP-8492 Move the empty() function from stdlib to puppet Change By: John Duarte QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.238369.1519679936000.9164.1571669701578%40Atlassian.JIRA.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg moved an issue Puppet / PUP-8492 Move the empty() function from stdlib to puppet Change By: Henrik Lindberg Fix Version/s: PUP 5.5.0 Fix Version/s: PUP 5.5.0 Key: BOLT PUP - 353 8492 Project: Puppet Task Runner Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this g
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-8492
Move the empty() function from stdlib to puppet
Change By:
Henrik Lindberg
Release Notes Summary:
The {{empty()}} function has moved from stdlib to puppet , and now also supports answering if a {{Binary}} value is empty (has zero bytes) .
Add Comment
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-8492 Move the empty() function from stdlib to puppet Change By: Henrik Lindberg Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Thomas Hallgren commented on PUP-8492 Re: Move the empty() function from stdlib to puppet Merged to master at 8bbea52. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-8492 Move the empty() function from stdlib to puppet Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8492 Move the empty() function from stdlib to puppet Change By: Henrik Lindberg Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg commented on PUP-8492 Re: Move the empty() function from stdlib to puppet A follow up fix was merged to master at b468cd4 fixing the issue that empty() must return true for undef. That also adds deprecation warnings for the undef case. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Kenn Hussey commented on PUP-8492 Re: Move the empty() function from stdlib to puppet Henrik Lindberg please add release notes for this issue, if needed. Thanks! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-8492
Move the empty() function from stdlib to puppet
Change By:
Henrik Lindberg
Release Notes Summary:
The {{empty()}} function has moved from stdlib to puppet, and now also supports answering if a {{Binary}} value is empty (has zero bytes). Calling empty with an undef value, or with a numeric value is now also deprecated and will issue a warning.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Kenn Hussey commented on PUP-8492 Re: Move the empty() function from stdlib to puppet Henrik Lindberg please add release notes for this issue if needed, thanks! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8492 Move the empty() function from stdlib to puppet Change By: Henrik Lindberg Release Notes: New Feature Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg commented on PUP-8492 Re: Move the empty() function from stdlib to puppet Kenn Hussey It already had a release note - just that it was not flipped from "None" Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Eric Sorenson commented on PUP-8492 Re: Move the empty() function from stdlib to puppet Henrik Lindberg Why deprecate the behaviour that empty on an undef variable is true? Is it going to change in the future? What is the workaround for people who currently use empty() to determine whether a variable is undef? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title
Henrik Lindberg commented on PUP-8492
Re: Move the empty() function from stdlib to puppet
Earlier, since the function was a 3.x function it was important to handle undef the same way as an empty string because empty strings were considered to be equivalent to undef - it was just a mess. Now with data types and automatic type checking there should be a lot less confusion over what something is - and treating undef as "an empty container" is far more likely to mask a bug than being useful. So, what to use instead of using empty() or !empty() to check if something is/not-is undef depends on why that check is made. Also, if the check is made to raise an error, the entire construct can be replaced by using either automatic type checking, or calling assert_type. Examples for checking if something is:
undef: $x =~ Undef, or $x == undef
not undef: $x =~ NotUndef, $x !~ Undef, or $x != undef
undef or an empty string: $x =~ Optional[String[0,0]]
non-empty string: $x =~ String[1]
non-empty array: $x =~ Array[1]
non-empty hash: $x =~ Hash[1]
non-empty array or hash: $x =~ Collection[1]
the same as stdlib 3.x version of empty: $x =~ Variant[String[0,0], Collection[0,0], Undef]
If using empty() to mean "unspecified" and having it in multiple places in a module, it could be of value to define a data type - say MyModule::Unspecified like this:
type MyModule::Unspecified = Variant\[String\[0,0], Collection\[0,0], Undef]
and then replace empty($x) with $x =~ MyModule::Unspecified Or, if so preferred, define a function like this:
function mymodule::unspecified(Any $x) {
$x =~ Variant\[String\[0,0], Collection\[0,0], Undef]
}
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Eric Sorenson commented on PUP-8492 Re: Move the empty() function from stdlib to puppet Sure, people could opt in to that if they were having problems. But (a) that syntax is all much more advanced than the if empty($foo) pattern, and (b) we can't find and fix all the instances of this, which are used in everything from other stdlib functions to the PE internal modules, so I don't think it's appropriate to mark it for a deprecation/removal. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg commented on PUP-8492 Re: Move the empty() function from stdlib to puppet ok, will add a ticket and remove the deprecation Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8492) Move the empty() function from stdlib to puppet
Title: Message Title Henrik Lindberg commented on PUP-8492 Re: Move the empty() function from stdlib to puppet PUP-8623 for the removal of the deprecation of undef Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
