Jira (PUP-8553) PAL should be able to run with 'empty' puppet settings

2018-03-26 Thread Alex Dreyer (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Dreyer commented on  PUP-8553  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PAL should be able to run with 'empty' puppet settings   
 

  
 
 
 
 

 
 I think giving PAL more control of setting would be useful but the PAL users shouldn't have to worry about what the settings are and how to use PAL without accidentally creating a bunch of settings configured directories on disk that don't make much sense outside of an agent run. The most important feature for PAL imo is simply making it easy to run with 'empty' settings. Hopefully the API for that can be fixed without untangling the entire settings mess.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8553) PAL should be able to run with 'empty' puppet settings

2018-03-15 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8553  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PAL should be able to run with 'empty' puppet settings   
 

  
 
 
 
 

 
 I would like to change how all the logic that is reached via PAL gets access to Settings. (As we all know it goes via methods [] and []= in Puppet, and those use @@settings as the place where the settings are. I can imagine keeping the settings in the Puppet context instead and that a user of PAL can provide an alternative implementation or initialize puppet's current implementation. The later is probably needed if PAL is used in the mode where it is configured from a given environment name (things like modulepath is configured from environment.conf + all the other settings). The current settings system is expensive to initialize even after not generating, compiling and applying the settings catalog, and a different approach would have a positive effect on startup performance of bolt's use of PAL.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8553) PAL should be able to run with 'empty' puppet settings

2018-03-15 Thread Alex Dreyer (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Dreyer commented on  PUP-8553  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PAL should be able to run with 'empty' puppet settings   
 

  
 
 
 
 

 
 We then have to manage the tmpdir that we're using to empty settings and even that seemed like an unsafe hack. What if puppet adds a required setting that doesn't accept a tmpdir as it's argument?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8553) PAL should be able to run with 'empty' puppet settings

2018-03-15 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-8553  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PAL should be able to run with 'empty' puppet settings   
 

  
 
 
 
 

 
 You should be able to call Puppet.initialize_settings(opts) once for the duration of bolt's ruby process (where opts are the root settings, e.g. confdir, that point to the temp dir). The one downside of reusing the same {[vardir}} across plan compiles is that you could in theory have state leaking across compilation. Not sure if that would happen in practice with bolt plans?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8553) PAL should be able to run with 'empty' puppet settings

2018-03-15 Thread Alex Dreyer (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Dreyer commented on  PUP-8553  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PAL should be able to run with 'empty' puppet settings   
 

  
 
 
 
 

 
 Josh Cooper Henrik Lindberg thoughts on how to clean this up?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8553) PAL should be able to run with 'empty' puppet settings

2018-03-15 Thread Alex Dreyer (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Dreyer created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8553  
 
 
  PAL should be able to run with 'empty' puppet settings   
 

  
 
 
 
 

 
Issue Type: 
  New Feature  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/03/15 3:03 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Alex Dreyer  
 

  
 
 
 
 

 
 Problem: When using PAL puppet settings may be unexpectedly be picked up from puppet's configuration directories. Bolt has hacked around this problem by wrapping PAL calls with:  
 
 
 
 
 def with_puppet_settings  
 
 
   Dir.mktmpdir('bolt') do |dir|  
 
 
 cli = []  
 
 
 Puppet::Settings::REQUIRED_APP_SETTINGS.each do |setting|  
 
 
   cli << "--#{setting}" << dir  
 
 
 end