Jira (PUP-9043) Downloaded files are sometimes truncated
Title: Message Title Josh Cooper commented on PUP-9043 Re: Downloaded files are sometimes truncated I confirmed the ruby behavior is definitely incorrect, from https://tools.ietf.org/html/rfc7230#section-3.4 A message that uses a valid Content-Length is incomplete if the size of the message body received (in octets) is less than the value given by Content-Length. I'm going to patch our vendored ruby and push on getting the ruby PR merged upstream. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.268200.1533583523000.52597.1565649180724%40Atlassian.JIRA.
Jira (PUP-9043) Downloaded files are sometimes truncated
Title: Message Title
Josh Cooper commented on PUP-9043
Re: Downloaded files are sometimes truncated
We could protect against the ruby bug for file sources (either puppet or http*):
diff --git a/lib/puppet/type/file/source.rb b/lib/puppet/type/file/source.rb
index df8fa95751..8f48f9865b 100644
--- a/lib/puppet/type/file/source.rb
+++ b/lib/puppet/type/file/source.rb
@@ -323,7 +323,25 @@ module Puppet
def chunk_file_from_source
get_from_source do |response|
case response.code
-when /^2/; uncompress(response) { |uncompressor| response.read_body { |chunk| yield uncompressor.uncompress(chunk) } }
+when /^2/
+ truncated = false
+ uncompress(response) do |uncompressor|
+response.read_body do |data|
Jira (PUP-9043) Downloaded files are sometimes truncated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9043 Downloaded files are sometimes truncated Change By: Josh Cooper Summary: file resource - mtime checksum does not seem to work Downloaded files are sometimes truncated Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.268200.1533583523000.48974.1565298540223%40Atlassian.JIRA.
