Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-11-19 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 Ciprian Badescu, Heston Hoffman This was fixed in 6.10.1, it doesn't need to be "fixed" again in 6.11.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.38530.1574183820947%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-11-19 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.11.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.38541.1574183821043%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-11-18 Thread Heston Hoffman (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Heston Hoffman updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Heston Hoffman  
 
 
Labels: 
 resolved-issue-added  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.36402.1574099880900%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-11-14 Thread Ciprian Badescu (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ciprian Badescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Ciprian Badescu  
 
 
Fix Version/s: 
 PUP 6.11.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.32419.1573744080842%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-10 Thread Jean Bond (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jean Bond updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Jean Bond  
 
 
Release Notes Summary: 
 Redact sensitive values when interpolated in a notify resource's message. note added for 6.10.1-jb  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.137917.1570722360695%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-09 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 Passed CI in 36c35404b8474b5949c87c49e0b360d426b64cbb  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.135961.1570634702023%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-09 Thread George Mrejea (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 George Mrejea commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 I believe this can be closed since the commit was promoted and tested in master.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.135778.1570622340434%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-07 Thread Kris Bosland (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kris Bosland commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 Merged to 5.5.x in 7781997.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.133340.1570501080427%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-07 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.4.4  
 
 
Fix Version/s: 
 PUP 6.4.5  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.133095.1570490400717%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-04 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.4.z  
 
 
Fix Version/s: 
 PUP 5.5.z  
 
 
Fix Version/s: 
 PUP 6.4.4  
 
 
Fix Version/s: 
 PUP 5.5.18  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit 

Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-04 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.10.1  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.130824.1570232221203%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-04 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 This did not make 5.5.17, but should make 6.4.4 and 6.10.1  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.130814.1570232221163%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-04 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/679d55489b1d1c13467272d647feb05e1065fbf6  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.130585.1570227721221%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-04 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 There are two issues going on. This ticket is about the notify resource printing messages 1 and 2 to the console, which ends up logs. The second issue is that the compiler evaluates these differently, which is surprising UX:  
 
 
 
 
 $secret = Sensitive('secret')  
 
 
 notify { 'a': message => $secret }  
 
 
 notify { 'b': message => "${secret}" }
  
 
 
 
  The resulting catalog contains:  
 
 
 
 
 {  
 
 
   "type": "Notify",  
 
 
   "title": "a",  
 
 
   "tags": [  
 
 
 "notify",  
 
 
 "a",  
 
 
 "class"  
 
 
   ],  
 
 
   

Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-03 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Release Notes Summary: 
 Redact sensitive values when interpolated in a notify resource's message.  
 
 
Release Notes: 
 Bug Fix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.127896.1570122240488%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-01 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Josh Cooper  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 Josh Cooper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.124546.1569991861687%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-10-01 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sprint: 
 Coremunity Hopper Platform Core KANBAN  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.124556.1569991861732%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-09-17 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sprint: 
 Coremunity  Grooming  Hopper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.103064.1568777220562%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-09-17 Thread Rob Braden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Braden assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Rob Braden  
 
 
Assignee: 
 Jorie Tappa  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.101891.1568744820907%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-09-16 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.0.z  
 
 
Fix Version/s: 
 PUP 6.4.z  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.99973.1568659501200%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-07-22 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa assigned an issue to Jorie Tappa  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Assignee: 
 Jorie Tappa  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.24909.1563814381164%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-07-22 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 Regardless of original intentions, we do not want to reveal any sensitive data in the notify resource. Josh Cooper's comment above should resolve this for the notify resource specifically, but there might be other issues we haven't come across yet.    As Henrik mentioned above, we could've implemented another flag to force a reveal but we haven't, so redacting the data should always be the expected behavior, and the safest/least surprise for the user.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.24778.1563814140407%40Atlassian.JIRA.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-07-15 Thread Kris Bosland (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kris Bosland commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 The team is coming to the view that the least surprise for users is if only code specifically designed to handle Sensitive values can get the unredacted version.  It should not show up in even Debug logs by default, because that requires our users to manage their debug logs and reports as Sensitive data.  This is a larger scale engineering effort, and we will work towards tickets and epics to outline this work.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.16863.1563229920271%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-06-12 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 If it's an intended behavior, we should be explicit about it in the docs. If it's not, we can prioritize this for future Sensitive improvements. If it's an intended behavior that we now want to change, we need approval/priority from Products or a PM.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.44927.1560371400976%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-06-12 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Component/s: 
 Docs  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283215.1540998541000.44915.1560371340806%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-03-01 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 Because when the sensitive value is interpolated that takes place when the catalog is compiled and a Sensitive value turns it into a string by generating "redacted". When doing this the agent gets the string "redacted" not a sensitive value - and this is probably not what the user intended, so there really is no "other case" for a provider to deal with. The support for sensitive on the agent side is partly in the harness - reporting values etc. checks if param is marked as sensitive. All types providers that do something else with values must be aware that a value may be sensitive and handle it appropriately. This is naturally not great. The alternative is not great either: we could instead of setting the sensitive flag in the resource have the values actually be of type Sensitive. Then, any type provider getting this value would need to know how to unwrap it - and thus also be aware that it is handling a sensitive value. That has other issues naturally - and this was why the design with a separate sensitive flag was introduced. (If we had done this, it would be more secure, but would be a lot more painful).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at 

Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-03-01 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 But Henrik Lindberg why does interpolating the secret value correctly redact:  
 
 
 
 
 $ bx puppet apply -e "\$secret = Sensitive.new('foo'); notify { 'n': message => \"\${secret}\"}"  
 
 
 Notice: Compiled catalog for localhost in environment production in 0.03 seconds  
 
 
 Notice: Sensitive [value redacted]
  
 
 
 
  But not when handled the secret value directly:  
 
 
 
 
 $ bx puppet apply -e "\$secret = Sensitive.new('foo'); notify { 'n': message => \$secret}"  
 
 
 Notice: Compiled catalog for localhost in environment production in 0.03 seconds  
 
 
 Notice: foo
  
 
 
 
  Surely providers shouldn't be expected to handle those two cases differently?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

 

Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-01-31 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 I don't see how we can get around this for types/providers that do their own logging/output where values should be appear as redacted without actually making them recognize if they should redact. This because they are written to operate on a single clear text value.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-01-14 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9295  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
 The Puppet::Pops::Types::PSensitiveType#to_s method is only called in the third case, I assume as a result of interpolating the sensitive message in a string. One fix is to do the following, but it feels like a game of "whack a mole" as every type/provider needs to check if it's been given a sensitive property/parameter:  
 
 
 
 
 diff --git a/lib/puppet/type/notify.rb b/lib/puppet/type/notify.rb  
 
 
 index 96830aa91b..aa7cb5603b 100644  
 
 
 --- a/lib/puppet/type/notify.rb  
 
 
 +++ b/lib/puppet/type/notify.rb  
 
 
 @@ -11,11 +11,12 @@ module Puppet  
 
 
  newproperty(:message, :idempotent => false) do  
 
 
desc "The message to be sent to the log."  
 
 
def sync  
 
 
 +message = @sensitive ? 'Sensitive [value redacted]' : self.should  
 
 
  case @resource["withpath"]  
 
 
  when :true  
 
 
 -  send(@resource[:loglevel], self.should)  
   

Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2019-01-07 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 5.5.9  
 
 
Fix Version/s: 
 PUP 6.0.z  
 
 
Fix Version/s: 
 PUP 5.5.z  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2018-11-01 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sprint: 
 Coremunity Grooming  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2018-10-31 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Fix Version/s: 
 PUP 5.5.9  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9295) Notify resource exposes Sensitive data when message is a Sensitive data

2018-10-31 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9295  
 
 
  Notify resource exposes Sensitive data when message is a Sensitive data   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Summary: 
 Notify resource  exposing  exposes  Sensitive data when message is  raw  a  Sensitive data  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.