Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Heston Hoffman updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Heston Hoffman Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper commented on PUP-9357 Re: Noop exec debug logging should include the command Merged to master in b98e6938a2, and passed CI in ee27e9ed1b Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Josh Cooper Fix Version/s: PUP 6.4.0 Fix Version/s: PUP 6.0.6 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper commented on PUP-9357 Re: Noop exec debug logging should include the command Follow up PR merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/65bbfe02358629b8a60cfbcc8bf049e4d022d600 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Kris Bosland updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Kris Bosland Release Notes Summary: The exec resource will now print a debug message with the command, if checks prevent it from being executed. Also, if any of the :command, :onlyif, or :unless parameters are marked sensitive, all commands will be redacted from the log output. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Kris Bosland commented on PUP-9357 Re: Noop exec debug logging should include the command We decided to mark all commands here as sensitive if one is marked sensitive. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Kris Bosland commented on PUP-9357 Re: Noop exec debug logging should include the command Hey Eric Sorenson we were talking about the second PR on this ticket, if we should change the exec(provider) run method, or just revert the change of supporting sensitive on :onlyif and :unless at all, and just going back to the user needing to set sensitive on command or getting no redaction. Can you help us decide? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper commented on PUP-9357 Re: Noop exec debug logging should include the command Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/911e9264b7b3c96969e1fac84f15865eb2013337. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Josh Cooper Fix Version/s: PUP 5.5.z Fix Version/s: PUP 5.5.11 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Kris Bosland updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Kris Bosland Release Notes Summary: The exec resource will now print a debug message with the command, if checks prevent it from being executed. Release Notes: Enhancement Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title
Eric Sorenson commented on PUP-9357
Re: Noop exec debug logging should include the command
Hm, so the code snippet would be
exec { 'example':
command => Sensitive.new('/bin/true'),
unless => Sensitive.new('/bin/false'),
}
Like Chris Roddy I don't have any evidence that people need this today but if it's easy to add, then sure, go for it.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Chris Roddy commented on PUP-9357 Re: Noop exec debug logging should include the command I don't have specific customer stories to support it, but it seems intuitively obvious to me that those attributes should support Sensitive. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Kris Bosland commented on PUP-9357 Re: Noop exec debug logging should include the command Eric Sorenson, I am concerned that 'unless', 'onlyif', and other checks may need to support sensitive for the same reason that the command of an exec should, as I am working on this ticket. Do you agree? Have you heard of any customer requests? Thanks. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Melissa Stone commented on PUP-9357 Re: Noop exec debug logging should include the command pr: https://github.com/puppetlabs/puppet/pull/7368 there's a typo in the commit message, which is why the PR isn't being linked to the ticket Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Kris Bosland updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Kris Bosland Sprint: Coremunity Hopper Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Kris Bosland assigned an issue to Kris Bosland Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Kris Bosland Assignee: Kris Bosland Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Josh Cooper Fix Version/s: PUP 5.5.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-9357
Noop exec debug logging should include the command
Change By:
Josh Cooper
When running in noop mode, debug logging for exec resources includes e.g. the unless and onlyif commands, but it does not log the command that would be run, instead merely logging that it has not yet been run and should have been. Because an exec's command is frequently assembled using variable interpolation (and therefore can't be just read from the manifest conclusively), and because the resource will often have a custom title, users running with --noop --debug would likely benefit from seeing the command itself in debug output.There are other ways of getting this information, so it's not a big problem, but it would be a nice thing to have. {noformat} % /opt/puppetlabs/puppet/bin/puppet apply --noop --debug -e "exec { 'example': command => '/bin/true', unless => '/bin/false', }"--- 8< ---Info: Applying configuration version '1544556833'Debug: Exec[example](provider=posix): Executing check '/bin/false'Debug: Executing: '/bin/false'Notice: /Stage[main]/Main/Exec[example]/returns: current_value 'notrun', should be ['0'] (noop)Debug: /Stage[main]/Main/Exec[example]: The container Class[Main] will propagate my refresh eventNotice: Class[Main]: Would have triggered 'refresh' from 1 eventDebug: Class[Main]: The container Stage[main] will propagate my refresh eventNotice: Stage[main]: Would have triggered 'refresh' from 1 eventDebug: Finishing transaction 47213377716240Debug: Storing stateDebug: Pruned old state cache entries in 0.00 secondsDebug: Stored state in 0.01 secondsNotice: Applied catalog in 0.10 seconds--- 8< --- {noformat}
Add Comment
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Josh Cooper Sprint: Coremunity Hopper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9357 Noop exec debug logging should include the command Change By: Josh Cooper Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title
Chris Roddy updated an issue
Puppet / PUP-9357
Noop exec debug logging should include the command
Change By:
Chris Roddy
When running in noop mode, debug logging for exec resources includes e.g. the unless and onlyif commands, but it does not log the command that would be run, instead merely logging that it has not yet been run and should have been. Because an exec's command is frequently assembled using variable interpolation (and therefore can't be just read from the manifest conclusively), and because the resource will often have a custom title, users running with --noop --debug would likely benefit from seeing the command itself in debug output.There are other ways of getting this information, so it's not a big problem, but it would be a nice thing to have. {{ % /opt/puppetlabs/puppet/bin/puppet apply --noop --debug -e "exec { 'example': command => '/bin/true', unless => '/bin/false', }"--- 8< ---Info: Applying configuration version '1544556833'Debug: Exec[example](provider=posix): Executing check '/bin/false'Debug: Executing: '/bin/false'Notice: /Stage[main]/Main/Exec[example]/returns: current_value 'notrun', should be ['0'] (noop)Debug: /Stage[main]/Main/Exec[example]: The container Class[Main] will propagate my refresh eventNotice: Class[Main]: Would have triggered 'refresh' from 1 eventDebug: Class[Main]: The container Stage[main] will propagate my refresh eventNotice: Stage[main]: Would have triggered 'refresh' from 1 eventDebug: Finishing transaction 47213377716240Debug: Storing stateDebug: Pruned old state cache entries in 0.00 secondsDebug: Stored state in 0.01 secondsNotice: Applied catalog in 0.10 seconds--- 8< --- }}
Add Comment
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title
Chris Roddy created an issue
Puppet / PUP-9357
Noop exec debug logging should include the command
Issue Type:
Improvement
Assignee:
Unassigned
Created:
2018/12/11 11:37 AM
Priority:
Normal
Reporter:
Chris Roddy
When running in noop mode, debug logging for exec resources includes e.g. the unless and onlyif commands, but it does not log the command that would be run, instead merely logging that it has not yet been run and should have been. Because an exec's command is frequently assembled using variable interpolation (and therefore can't be just read from the manifest conclusively), and because the resource will often have a custom title, users running with --noop --debug would likely benefit from seeing the command itself in debug output. There are other ways of getting this information, so it's not a big problem, but it would be a nice thing to have. ```% /opt/puppetlabs/puppet/bin/puppet apply --noop --debug -e "exec { 'example': command => '/bin/true', unless => '/bin/false', } " — 8< — Info: Applying configuration version '1544556833' Debug: Exec[example](provider=posix): Executing check '/bin/false' Debug: Executing: '/bin/false' Notice: /Stage[main]/Main/Exec[example]/returns: current_value 'notrun', should be ['0'] (noop) Debug: /Stage[main]/Main/Exec[example]: The container Class[Main] will propagate my refresh event Notice: Class[Main]: Would have triggered 'refresh' from 1 event Debug: Class[Main]: The container Stage[main] will propagate my refresh event Notice: Stage[main]: Would have triggered 'refresh' from 1 event Debug: Finishing transaction 47213377716240 Debug: Storing state Debug: Pruned old state cache entries in 0.00 seconds Debug: Stored state in 0.01 seconds Notice: Applied catalog in 0.10 seconds — 8< —
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title
Chris Roddy updated an issue
Puppet / PUP-9357
Noop exec debug logging should include the command
Change By:
Chris Roddy
When running in noop mode, debug logging for exec resources includes e.g. the unless and onlyif commands, but it does not log the command that would be run, instead merely logging that it has not yet been run and should have been. Because an exec's command is frequently assembled using variable interpolation (and therefore can't be just read from the manifest conclusively), and because the resource will often have a custom title, users running with --noop --debug would likely benefit from seeing the command itself in debug output.There are other ways of getting this information, so it's not a big problem, but it would be a nice thing to have. ``` {{ % /opt/puppetlabs/puppet/bin/puppet apply --noop --debug -e "exec { 'example': command => '/bin/true', unless => '/bin/false', }"--- 8< ---Info: Applying configuration version '1544556833'Debug: Exec[example](provider=posix): Executing check '/bin/false'Debug: Executing: '/bin/false'Notice: /Stage[main]/Main/Exec[example]/returns: current_value 'notrun', should be ['0'] (noop)Debug: /Stage[main]/Main/Exec[example]: The container Class[Main] will propagate my refresh eventNotice: Class[Main]: Would have triggered 'refresh' from 1 eventDebug: Class[Main]: The container Stage[main] will propagate my refresh eventNotice: Stage[main]: Would have triggered 'refresh' from 1 eventDebug: Finishing transaction 47213377716240Debug: Storing stateDebug: Pruned old state cache entries in 0.00 secondsDebug: Stored state in 0.01 secondsNotice: Applied catalog in 0.10 seconds--- 8< --- ``` }}
Add Comment
Jira (PUP-9357) Noop exec debug logging should include the command
Title: Message Title
Chris Roddy updated an issue
Puppet / PUP-9357
Noop exec debug logging should include the command
Change By:
Chris Roddy
When running in noop mode, debug logging for exec resources includes e.g. the unless and onlyif commands, but it does not log the command that would be run, instead merely logging that it has not yet been run and should have been. Because an exec's command is frequently assembled using variable interpolation (and therefore can't be just read from the manifest conclusively), and because the resource will often have a custom title, users running with --noop --debug would likely benefit from seeing the command itself in debug output.There are other ways of getting this information, so it's not a big problem, but it would be a nice thing to have.```% /opt/puppetlabs/puppet/bin/puppet apply --noop --debug -e "exec { 'example': command => '/bin/true', unless => '/bin/false', }"--- 8< ---Info: Applying configuration version '1544556833'Debug: Exec[example](provider=posix): Executing check '/bin/false'Debug: Executing: '/bin/false'Notice: /Stage[main]/Main/Exec[example]/returns: current_value 'notrun', should be ['0'] (noop)Debug: /Stage[main]/Main/Exec[example]: The container Class[Main] will propagate my refresh eventNotice: Class[Main]: Would have triggered 'refresh' from 1 eventDebug: Class[Main]: The container Stage[main] will propagate my refresh eventNotice: Stage[main]: Would have triggered 'refresh' from 1 eventDebug: Finishing transaction 47213377716240Debug: Storing stateDebug: Pruned old state cache entries in 0.00 secondsDebug: Stored state in 0.01 secondsNotice: Applied catalog in 0.10 seconds--- 8< --- ```
Add Comment
