Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2021-06-14 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9365  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
 This hasn't been updated in a few years and we don't have plans on fixing this anytime soon. If anyone wants to work on this, please reopen and ping us in slack if you have questions.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.289068.154505099.56367.1623712500087%40Atlassian.JIRA.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2019-09-30 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9365  
 
 
  Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.289068.154505099.121646.1569906300280%40Atlassian.JIRA.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2019-06-19 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9365  
 
 
  Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 beginner help_wanted  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.289068.154505099.54005.1560979021162%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2019-06-19 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9365  
 
 
  Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 help_wanted  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.289068.154505099.53459.1560967800453%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2019-01-03 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-9365  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
 For anyone that want to work on this - I think the logic is here: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/graph/simple_graph.rb#L439 For some values it calls a stringify method, and it only deals with embedded double quotes. Not certain if something similar is needed for values that are used in DOT output without stringifying them.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2018-12-23 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-9365  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
 The only real constraint is that a title must be unique for all instances of the resource type and that it should not contain square brackets - what happens if there is a newline in that string is indeed unspecified and I suspect that there are quite a few use cases where that could lead to surprising results.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2018-12-17 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson assigned an issue to Mihkel Ader  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9365  
 
 
  Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
Change By: 
 Eric Sorenson  
 
 
Assignee: 
 Mihkel Ader  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2018-12-17 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson commented on  PUP-9365  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
 Titles with newlines are kind of unspecified behaviour - what is the problem you are trying to solve here? cc Henrik Lindberg - not sure if a title with embedded newline is even an acceptable syntax  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9365) Newlines in resource titles result in invalid .dot files

2018-12-17 Thread Mihkel Ader (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihkel Ader created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9365  
 
 
  Newlines in resource titles result in invalid .dot files   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/12/17 4:49 AM  
 
 
Priority: 
  Trivial  
 
 
Reporter: 
 Mihkel Ader  
 

  
 
 
 
 

 
 Puppet Version: 6.0.4 Puppet Server Version: OS Name/Version: Linux Puppet does not escape newlines in resource titles when generating graph files:    
 
 
 
 
 # puppet apply --graph -e 'notify {"line1\nline2":}'  
 
 
 ...  
 
 
 # dotty .puppetlabs/opt/puppet/cache/state/graphs/resources.dot  
 
 
 graph parser: string ran past end of line near line 18  
 
 
 context: >>> Notif <<< y[line1  
 
 
 line1