Jira (PUP-9450) jvm-ssl-utils schema bug for schema 'Readerable'

2019-01-18 Thread Simon (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Simon updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9450  
 
 
  jvm-ssl-utils schema bug for schema 'Readerable'   
 

  
 
 
 
 

 
Change By: 
 Simon  
 

  
 
 
 
 

 
 When using the jvm-ssl-utils library with activated schema validations in tests we stumbled upon a strange behavior. Although passing a byte array as a Readerable we get schema violations. Further investigations led us to the schema definition [1]. `byte[]` may be valid clojure, but certainly not what was intended:{{user=> byte[]#object[clojure.core$byte 0x78ed3c5f "clojure.core$byte@78ed3c5f"][]  }}This gets parsed in two objects first `byte` and an empty vector. Same for `char[]`. The proper schema to use here would be `schema.core/bytes` and `schema.core/chars`.  [1] [https://github.com/puppetlabs/jvm-ssl-utils/blob/master/src/clojure/puppetlabs/ssl_utils/core.clj#L131] Off-Topic:  You should certainly think about activating issues in gitlab. We really appreciate that you create open source software and ourselves are keen to contribute whenever possible. However, I'm a little annoyed  of  by  the overhead of this issue report. Not only, that I had to create an account, storing my mail in this platform (which I didn't find a way to delete after this issue being closed), I feel very inconvenient posting here: After 20 minutes of exploring your Jira (which I'm luckily used to, others aren't), I'm not very sure that I created that ticket in the right project. Thus, please enable the issue tracker on gitlab if you don't want to miss valuable feedback on your projects in the future.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
 

Jira (PUP-9450) jvm-ssl-utils schema bug for schema 'Readerable'

2019-01-18 Thread Simon (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Simon created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9450  
 
 
  jvm-ssl-utils schema bug for schema 'Readerable'   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2019/01/18 12:02 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Simon  
 

  
 
 
 
 

 
 When using the jvm-ssl-utils library with activated schema validations in tests we stumbled upon a strange behavior. Although passing a byte array as a Readerable we get schema violations. Further investigations led us to the schema definition [1]. `byte[]` may be valid clojure, but certainly not what was intended: {{ user=> byte[] #object[clojure.core$byte 0x78ed3c5f "clojure.core$byte@78ed3c5f"] [] }} This gets parsed in two objects first `byte` and an empty vector. Same for `char[]`. The proper schema to use here would be `schema.core/bytes` and `schema.core/chars`.   [1] https://github.com/puppetlabs/jvm-ssl-utils/blob/master/src/clojure/puppetlabs/ssl_utils/core.clj#L131   
 Off-Topic:  You should certainly think about activating issues in gitlab. We really appreciate that you create open source software and ourselves are keen to contribute whenever possible. However, I'm a little annoyed of the overhead of this issue report. Not only, that I had to create an account, storing my mail in this platform (which I didn't find a way to delete after this issue being closed), I feel very inconvenient posting here: After 20 minutes of exploring your Jira (which I'm luckily used to, others aren't), I'm not very sure that I created that ticket in the right project. Thus, please enable the issue tracker on gitlab if you don't want to miss valuable feedback on your projects in the future.