Jira (PUP-9789) Constants assigned twice emit warning during Litmus use on Windows.
Title: Message Title
William Hurt updated an issue
Puppet / PUP-9789
Constants assigned twice emit warning during Litmus use on Windows.
Change By:
William Hurt
When running acceptance tests via Litmus, the Puppet::Util::Windows::APITypes::FFI module from lib/puppet/util/windows/api_types.rb is loaded via the puppet gem.Unfortunately this module always gets loaded twice and a warning is returned to the commandline:{noformat}C:/src/puppetlabs-java_ks/.bundle/gems/ruby/2.5.0/gems/puppet-6.4.2-x64-mingw32/lib/puppet/util/windows/api_types.rb:6: warning: already initialized constant FFI::WIN32_FALSE C:/src/puppetlabs-java_ks/.bundle/gems/ruby/2.5.0/gems/pdk-1.10.0/lib/pdk/util/windows/api_types.rb:6: warning: previous definition of WIN32_FALSE was here C:/src/puppetlabs-java_ks/.bundle/gems/ruby/2.5.0/gems/puppet-6.4.2-x64-mingw32/lib/puppet/util/windows/api_types.rb:9: warning: already initialized constant FFI::ERROR_SUCCESS C:/src/puppetlabs-java_ks/.bundle/gems/ruby/2.5.0/gems/pdk-1.10.0/lib/pdk/util/windows/api_types.rb:9: warning: previous definition of ERROR_SUCCESS was here{noformat}
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9789) Constants assigned twice emit warning during Litmus use on Windows.
Title: Message Title
William Hurt updated an issue
Puppet / PUP-9789
Constants assigned twice emit warning during Litmus use on Windows.
Change By:
William Hurt
Summary:
{brief summary of issue} Constants assigned twice emit warning during Litmus use on Windows.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.313352.1561054057000.3.1561054140611%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9789) Constants assigned twice emit warning during Litmus use on Windows.
Title: Message Title Josh Cooper commented on PUP-9789 Re: Constants assigned twice emit warning during Litmus use on Windows. Conditionally defining a constant is asking for trouble, since some other gem could define them to different values before puppet is required, and this PR would make puppet silently ignore that problem. We should fix litmus so it doesn't reload puppet or require multiple copies of puppet. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.313352.1561054057000.58736.1561413840321%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9789) Constants assigned twice emit warning during Litmus use on Windows.
Title: Message Title Jesse Scott commented on PUP-9789 Re: Constants assigned twice emit warning during Litmus use on Windows. We have already removed the monkey patching of those constants in pdk/master and that will be going out in the next PDK release: https://github.com/puppetlabs/pdk/commit/4b02f0c500275b2ef9ae07c36db553de4a5ed5a3 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.313352.1561054057000.58764.1561414560478%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9789) Constants assigned twice emit warning during Litmus use on Windows.
Title: Message Title Josh Cooper commented on PUP-9789 Re: Constants assigned twice emit warning during Litmus use on Windows. Thanks Jesse Scott. Along the same lines, it'd be great to no longer define methods in the FFI namespace like https://github.com/puppetlabs/pdk/blob/4b02f0c500275b2ef9ae07c36db553de4a5ed5a3/lib/pdk/util/windows/api_types.rb#L6-L32, especially if we start fixing bugs in the puppet version. Longer term, I'd like to extract the win32 specific code from puppet and into a gem that other ruby projects can use. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.313352.1561054057000.58772.1561414800235%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9789) Constants assigned twice emit warning during Litmus use on Windows.
Title: Message Title Thomas Honey commented on PUP-9789 Re: Constants assigned twice emit warning during Litmus use on Windows. here is the ticket for context https://tickets.puppetlabs.com/browse/PDK-1348 basically we are using FFI raw, when there are commity gems designed for this https://rubygems.org/gems/win32-api/ Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.313352.1561054057000.59191.1561463760381%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9789) Constants assigned twice emit warning during Litmus use on Windows.
Title: Message Title Josh Cooper commented on PUP-9789 Re: Constants assigned twice emit warning during Litmus use on Windows. The win32 gems from djberger have lots of issues, especially around Unicode, see PUP-5560, PUP-5735. Please don't use them in PDK or any new ruby code. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.313352.1561054057000.59455.1561474920819%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
