Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9826 Puppet exec timeout does not match documentation Change By: Josh Cooper Labels: tbd Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.316540.1563215346000.21585.1638833160347%40Atlassian.JIRA.
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title Josh Cooper commented on PUP-9826 Re: Puppet exec timeout does not match documentation The timeout applies to each try, but the problem is if a timeout occurs for any one try, then the entire resource is marked as failed, instead of continuing to retry. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.316540.1563215346000.17292.1563252660103%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9826 Puppet exec timeout does not match documentation Change By: Josh Cooper Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.316540.1563215346000.17267.1563248700187%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title
Nate McCurdy commented on PUP-9826
Re: Puppet exec timeout does not match documentation
exec { 'test':
command => '/bin/sleep 5; /bin/false',
tries => 10,
try_sleep => 1,
timeout => 4,
}
That triggers the timeout error, but this does not:
exec { 'test':
command => '/bin/sleep 4; /bin/false',
tries => 10,
try_sleep => 1,
timeout => 5,
}
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title
Nate McCurdy updated an issue
Puppet / PUP-9826
Puppet exec timeout does not match documentation
Change By:
Nate McCurdy
*Puppet Version: 5.5.14-1xenial *Puppet Server Version: 5.3.8-1xenial *OS Name/Version: Ubuntu 16.04 XenialDescribe your issue in as much detail as possible…When using tries in an exec resource the documentation states that the timeout parameter of the exec block applies to each try, but the code currently does not implement the functionality in that way. The timeout should apply to each try.Slack community chat snippet{quote}natemccurdy [11 minutes ago] The timeout is for *the entire exec*, not for each try. (edited)Jason Grammenos [10 minutes ago] `Note that the timeout parameter applies to each try rather than to the complete set of tries.`natemccurdy [10 minutes ago] err.. sorry, You’re right.natemccurdy [10 minutes ago] Read that wrong.josh [9 minutes ago] The docs are wrong unfortunatelyJason Grammenos [9 minutes ago] oh?natemccurdy [9 minutes ago] Oh, hah :slightly_smiling_face:josh [8 minutes ago] maybe it used to apply to each try at some point?natemccurdy [8 minutes ago] Either way, try removing the `timeout` or set it to `0` and see what happens.josh [6 minutes ago] Looks like it's been broken since [https://github.com/puppetlabs/puppet/commit/e0e6b642c4e]josh [5 minutes ago] The begin/rescue needs to be inside `tries.times do |try|` Describe steps to reproduce… {quote} *Desired Behavior:* {code} exec { 'test': command => '/bin/false', tries => 10, try_sleep => 5, timeout => 10,}{code} This should have a per try timeout of 10 seconds as per the documentation.*Actual Behavior:*The exec time's out because the current implementation applies the timeout to the whole set of tries.current documentation:[https://puppet.com/docs/puppet/6.6/types/exec.html#exec-attribute-tries]Please take a moment and attach any relevant log output and/or manifests. This will help us immensely when troubleshooting the issue.{code} Exec try 1/10 /etc/puppetlabs/code/modules/mm/manifests/graylog/graylog.pp:83 Jul 15 2019 - 14:10:34 Exec[configure-ldap](provider=posix) Executing 'curl -s -v -i --netrc-file /etc/graylog/server/configure_ldap.netrc -o /etc/graylog/server/configure_ldap.log -H "Content-Type: application/json" -H "X-Requested-By: puppet" -X PUT [http://localhost:9000/api/system/ldap/settings] --data @/etc/graylog/server/configure_ldap_data.json 2>&1 | grep 'HTTP/1.1 204''Jul 15 2019 - 14:10:34 Puppet debug Executing: 'curl -s -v -i --netrc-file /etc/graylog/server/configure_ldap.netrc -o /etc/graylog/server/configure_ldap.log -H "Content-Type: application/json" -H "X-Requested-By: puppet" -X PUT [http://localhost:9000/api/system/ldap/settings] --data @/etc/graylog/server/configure_ldap_data.json 2>&1 | grep 'HTTP/1.1 204'' Jul 15 2019 - 14:10:44 Puppet err Command exceeded timeout {code}
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title
Nate McCurdy updated an issue
Puppet / PUP-9826
Puppet exec timeout does not match documentation
Change By:
Nate McCurdy
*Puppet Version: 5.5.14-1xenial *Puppet Server Version: 5.3.8-1xenial *OS Name/Version: Ubuntu 16.04 XenialDescribe your issue in as much detail as possible…When using tries in an exec resource the documentation states that the timeout parameter of the exec block applies to each try, but the code currently does not implement the functionality in that way. The timeout should apply to each try.Slack community chat snippet{quote}natemccurdy [11 minutes ago] The timeout is for *the entire exec*, not for each try. (edited)Jason Grammenos [10 minutes ago] `Note that the timeout parameter applies to each try rather than to the complete set of tries.`natemccurdy [10 minutes ago] err.. sorry, You’re right.natemccurdy [10 minutes ago] Read that wrong.josh [9 minutes ago] The docs are wrong unfortunatelyJason Grammenos [9 minutes ago] oh?natemccurdy [9 minutes ago] Oh, hah :slightly_smiling_face:josh [8 minutes ago] maybe it used to apply to each try at some point?natemccurdy [8 minutes ago] Either way, try removing the `timeout` or set it to `0` and see what happens.josh [6 minutes ago] Looks like it's been broken since [https://github.com/puppetlabs/puppet/commit/e0e6b642c4e]josh [5 minutes ago] The begin/rescue needs to be inside `tries.times do |try|` Describe steps to reproduce…{quote}*Desired Behavior:* {code} exec { 'test': command => '/bin/false', tries => 10, try_sleep => 5, timeout => 10,}{code} This should have a per try timeout of 10 seconds as per the documentation.*Actual Behavior:*The exec time's out because the current implementation applies the timeout to the whole set of tries.current documentation: [https://puppet.com/docs/puppet/ 5 6 . 3 6 /types/exec.html#exec-attribute-tries]Please take a moment and attach any relevant log output and/or manifests. This will help us immensely when troubleshooting the issue. {code} Exec try 1/10 /etc/puppetlabs/code/modules/mm/manifests/graylog/graylog.pp:83 Jul 15 2019 - 14:10:34 Exec[configure-ldap](provider=posix) Executing 'curl -s -v -i --netrc-file /etc/graylog/server/configure_ldap.netrc -o /etc/graylog/server/configure_ldap.log -H "Content-Type: application/json" -H "X-Requested-By: puppet" -X PUT [http://localhost:9000/api/system/ldap/settings] --data @/etc/graylog/server/configure_ldap_data.json 2>&1 | grep 'HTTP/1.1 204''Jul 15 2019 - 14:10:34 Puppet debug Executing: 'curl -s -v -i --netrc-file /etc/graylog/server/configure_ldap.netrc -o /etc/graylog/server/configure_ldap.log -H "Content-Type: application/json" -H "X-Requested-By: puppet" -X PUT [http://localhost:9000/api/system/ldap/settings] --data @/etc/graylog/server/configure_ldap_data.json 2>&1 | grep 'HTTP/1.1 204'' Jul 15 2019 - 14:10:44 Puppet err Command exceeded timeout {code}
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title Nate McCurdy commented on PUP-9826 Re: Puppet exec timeout does not match documentation Here's the faulty block of code: https://github.com/puppetlabs/puppet/blob/6.6.0/lib/puppet/type/exec.rb#L129-L142 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.316540.1563215346000.16321.1563216180448%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title
Nate McCurdy updated an issue
Puppet / PUP-9826
Puppet exec timeout does not match documentation
Change By:
Nate McCurdy
Affects Version/s:
PUP 5.5.14
Affects Version/s:
PUP 6.6.0
*Puppet Version: 5.5.14-1xenial*Puppet Server Version: 5.3.8-1xenial*OS Name/Version: Ubuntu 16.04 XenialDescribe your issue in as much detail as possible…When using tries in an exec resource the documentation states that the timeout parameter of the exec block applies to each try, but the code currently does not implement the functionality in that way. The timeout should apply to each try.Slack community chat snippet ``` {quote} natemccurdy [11 minutes ago]The timeout is for *the entire exec*, not for each try. (edited) Jason Grammenos [10 minutes ago]`Note that the timeout parameter applies to each try rather than to the complete set of tries.`natemccurdy [10 minutes ago]err.. sorry, You’re right.natemccurdy [10 minutes ago]Read that wrong.josh [9 minutes ago]The docs are wrong unfortunatelyJason Grammenos [9 minutes ago]oh?natemccurdy [9 minutes ago]Oh, hah :slightly_smiling_face:josh [8 minutes ago]maybe it used to apply to each try at some point?natemccurdy [8 minutes ago]Either way, try removing the `timeout` or set it to `0` and see what happens.josh [6 minutes ago]Looks like it's been broken since [ https://github.com/puppetlabs/puppet/commit/e0e6b642c4e ] josh [5 minutes ago]The begin/rescue needs to be inside `tries.times do |try|` ``` Describe steps to reproduce… {quote} *Desired Behavior:* ``` {code} exec { ' configure test ':command => " ' /bin/false ",path => [ ' /usr/bin' , '/bin'], tries => 10,try_sleep => 5,timeout = > 10, } ``` {code} This should have a per try timeout of 10 seconds as per the documentation.*Actual Behavior:*The exec time's out because the current implementation applies the timeout to the whole set of tries.current documentation: [ https://puppet.com/docs/puppet/5.3/types/exec.html#exec-attribute-tries ] Please take a moment and attach any relevant log output and/or manifests. This will help us immensely when troubleshooting the issue. ``` {code} Exec try 1/10 /etc/puppetlabs/code/modules/mm/manifests/graylog/graylog.pp:83Jul 15 2019 - 14:10:34 Exec[configure-ldap](provider=posix) Executing 'curl -s -v -i --netrc-file /etc/graylog/server/configure_ldap.netrc -o /etc/graylog/server/configure_ldap.log -H "Content-Type: application/json" -H "X-Requested-By: puppet" -X PUT [ http://localhost:9000/api/system/ldap/settings ] --data @/etc/graylog/server/configure_ldap_data.json 2>&1 | grep 'HTTP/1.1 204''
Jira (PUP-9826) Puppet exec timeout does not match documentation
Title: Message Title
Jason Grammenos created an issue
Puppet / PUP-9826
Puppet exec timeout does not match documentation
Issue Type:
Bug
Assignee:
Unassigned
Created:
2019/07/15 11:29 AM
Priority:
Normal
Reporter:
Jason Grammenos
*Puppet Version: 5.5.14-1xenial *Puppet Server Version: 5.3.8-1xenial *OS Name/Version: Ubuntu 16.04 Xenial Describe your issue in as much detail as possible… When using tries in an exec resource the documentation states that the timeout parameter of the exec block applies to each try, but the code currently does not implement the functionality in that way. The timeout should apply to each try. Slack community chat snippet ``` natemccurdy [11 minutes ago] The timeout is for the entire exec, not for each try. (edited) Jason Grammenos [10 minutes ago] `Note that the timeout parameter applies to each try rather than to the complete set of tries.` natemccurdy [10 minutes ago] err.. sorry, You’re right. natemccurdy [10 minutes ago] Read that wrong. josh [9 minutes ago] The docs are wrong unfortunately Jason Grammenos [9 minutes ago] oh? natemccurdy [9 minutes ago] Oh, hah :slightly_smiling_face: josh [8 minutes ago] maybe it used to apply to each try at some point? natemccurdy [8 minutes ago] Either way, try removing the `timeout` or set it to `0` and see what happens. josh [6 minutes ago] Looks like it's been broken since https://github.com/puppetlabs/puppet/commit/e0e6b642c4e josh [5 minutes ago] The begin/rescue needs to be inside `tries.times do |try|` ``` Describe steps to reproduce… Desired Behavior: ``` exec { 'configure': command => "/bin/false", path => ['/usr/bin','/bin'], tries => 10, try_sleep => 5, timeout = 10, } ``` This should have a per try timeout of 10 seconds as per the documentation. Actual Behavior: The exec time's out because the current implementation applies the timeout to the whole set of tries. current documentation: https://puppet.com/docs/puppet/5.3/types/exec.html#exec-attribute-tries Please take a moment and attach any relevant log output and/or manifests. This will help us immensely when troubleshooting the issue. ``` Exec try 1/10 /etc/puppetlabs/code/modules/mm/manifests/graylog/graylog.pp:83 Jul 15 2019 - 14:10:34 Exec
