Re: [Puppet Users] Breaking changes in Puppetlabs_spec_helper v0.5.0

2014-06-10 Thread Gavin Williams 
Hunter

Thanks for the updated gem. Will give it a go when I have a few mins :) 

Cheers
Gav

On Tuesday, 10 June 2014 00:05:40 UTC+1, Hunter Haugen wrote:
>
> Sorry about that; I was thinking of mocha as more of an extraneous 
> dependency rather than a feature. Turns out that the mock_with :mocha line 
> was a "feature" of puppetlabs_spec_helper and removing it changed the 
> behavior of projects which depend on PSH. That's what I get for releasing 
> on friday...
>
> I have released 0.5.1 which adds back the mocha dependency and mock_with 
> :mocha.
>
> Eventually I would like to see puppetlabs_spec_helper's helpful features 
> (like the puppet indirection initialization adapter pattern code and 
> fixtures) move into rspec-puppet, and its muddled/questionable aspects 
> resolved as to whether they should be removed or migrated into another more 
> appropriate place. At least the module team now owns this code and it can 
> start moving again.
>
>
>
> -Hunter
>
>
> On Mon, Jun 9, 2014 at 10:06 AM, Garrett Honeycutt <
> g...@garretthoneycutt.com > wrote:
> On 6/9/14, 12:49 PM, Clayton O'Neill wrote:
> > On Mon, Jun 9, 2014 at 11:23 AM, fatmcgav  
> > > wrote:
> >
> > Afternoon all,
> >
> > Just thought I'd make the lists aware of an issue I hit with
> > puppetlabs_spec_helper v0.5.0 today.
> >
> > It would appear that changes committed in [1] results in the
> > dropping of mocha as a dependency, and therefore any tests depending
> > on mocha failing.
> > The error I was seeing was:
> >
> > 
> Failure/Error:Puppet::Type.type(:application).stubs(:defaultprovider).returns
> > described_class
> >
> > NoMethodError:
> >
> > undefined method `stubs' for Puppet::Type::Application:Class
> >
> > # ./spec/unit/puppet/provider/application/asadmin_spec.rb:6
> >
> > A work-around for me was to pin puppetlabs_spec_helper to v0.4.x. [2]
> >
> >
> > I just ran into the same problem.  Is this a bug, or a change in API?  I
> > also worked around it via '~> 0.4.1'.
>
>
> Hi,
>
> Created a ticket[1] asking Puppet Labs to release this as 1.0.0, so that
> each release cannot break the API as so many of us depend on this.
>
> [1] - https://tickets.puppetlabs.com/browse/PUP-2743
>
> Br,
> -g
>
> --
> Garrett Honeycutt
> @learnpuppet
> Puppet Training with LearnPuppet.com
> Mobile: +1.206.414.8658
>
> --
> You received this message because you are subscribed to the Google Groups 
> "Puppet Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to puppet-users...@googlegroups.com .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/puppet-users/5395E97A.9050005%40garretthoneycutt.com
> .
> For more options, visit https://groups.google.com/d/optout.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/bde8ae76-df80-4ed1-8fb5-00de3c94b51b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Puppet Users] Breaking changes in Puppetlabs_spec_helper v0.5.0

2014-06-09 Thread Garrett Honeycutt 
On 6/9/14, 7:04 PM, Hunter Haugen wrote:
> Sorry about that; I was thinking of mocha as more of an extraneous
> dependency rather than a feature. Turns out that the mock_with :mocha
> line was a "feature" of puppetlabs_spec_helper and removing it changed
> the behavior of projects which depend on PSH. That's what I get for
> releasing on friday...
> 
> I have released 0.5.1 which adds back the mocha dependency and mock_with
> :mocha.
> 
> Eventually I would like to see puppetlabs_spec_helper's helpful features
> (like the puppet indirection initialization adapter pattern code and
> fixtures) move into rspec-puppet, and its muddled/questionable aspects
> resolved as to whether they should be removed or migrated into another
> more appropriate place. At least the module team now owns this code and
> it can start moving again.
> 
> 
> 
> -Hunter

Thanks Hunter!

-g


-- 
Garrett Honeycutt
@learnpuppet
Puppet Training with LearnPuppet.com
Mobile: +1.206.414.8658

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/5396527A.7090206%40garretthoneycutt.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Puppet Users] Breaking changes in Puppetlabs_spec_helper v0.5.0

2014-06-09 Thread Hunter Haugen 
Sorry about that; I was thinking of mocha as more of an extraneous
dependency rather than a feature. Turns out that the mock_with :mocha line
was a "feature" of puppetlabs_spec_helper and removing it changed the
behavior of projects which depend on PSH. That's what I get for releasing
on friday...

I have released 0.5.1 which adds back the mocha dependency and mock_with
:mocha.

Eventually I would like to see puppetlabs_spec_helper's helpful features
(like the puppet indirection initialization adapter pattern code and
fixtures) move into rspec-puppet, and its muddled/questionable aspects
resolved as to whether they should be removed or migrated into another more
appropriate place. At least the module team now owns this code and it can
start moving again.



-Hunter


On Mon, Jun 9, 2014 at 10:06 AM, Garrett Honeycutt 
wrote:
On 6/9/14, 12:49 PM, Clayton O'Neill wrote:
> On Mon, Jun 9, 2014 at 11:23 AM, fatmcgav  > wrote:
>
> Afternoon all,
>
> Just thought I'd make the lists aware of an issue I hit with
> puppetlabs_spec_helper v0.5.0 today.
>
> It would appear that changes committed in [1] results in the
> dropping of mocha as a dependency, and therefore any tests depending
> on mocha failing.
> The error I was seeing was:
>
>
Failure/Error:Puppet::Type.type(:application).stubs(:defaultprovider).returns
> described_class
>
> NoMethodError:
>
> undefined method `stubs' for Puppet::Type::Application:Class
>
> # ./spec/unit/puppet/provider/application/asadmin_spec.rb:6
>
> A work-around for me was to pin puppetlabs_spec_helper to v0.4.x. [2]
>
>
> I just ran into the same problem.  Is this a bug, or a change in API?  I
> also worked around it via '~> 0.4.1'.


Hi,

Created a ticket[1] asking Puppet Labs to release this as 1.0.0, so that
each release cannot break the API as so many of us depend on this.

[1] - https://tickets.puppetlabs.com/browse/PUP-2743

Br,
-g

--
Garrett Honeycutt
@learnpuppet
Puppet Training with LearnPuppet.com
Mobile: +1.206.414.8658

--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/puppet-users/5395E97A.9050005%40garretthoneycutt.com
.
For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/CAJaQvGASwqWN1_daKjteeHx2kK4skXARKzT9Qxrhmu%3DGtTtW3w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Puppet Users] Breaking changes in Puppetlabs_spec_helper v0.5.0

2014-06-09 Thread Garrett Honeycutt 
On 6/9/14, 12:49 PM, Clayton O'Neill wrote:
> On Mon, Jun 9, 2014 at 11:23 AM, fatmcgav  > wrote:
> 
> Afternoon all,
> 
> Just thought I'd make the lists aware of an issue I hit with
> puppetlabs_spec_helper v0.5.0 today.
> 
> It would appear that changes committed in [1] results in the
> dropping of mocha as a dependency, and therefore any tests depending
> on mocha failing.
> The error I was seeing was:
> 
> 
> Failure/Error:Puppet::Type.type(:application).stubs(:defaultprovider).returns
> described_class
> 
> NoMethodError:
> 
> undefined method `stubs' for Puppet::Type::Application:Class
> 
> # ./spec/unit/puppet/provider/application/asadmin_spec.rb:6
> 
> A work-around for me was to pin puppetlabs_spec_helper to v0.4.x. [2]
> 
> 
> I just ran into the same problem.  Is this a bug, or a change in API?  I
> also worked around it via '~> 0.4.1'. 


Hi,

Created a ticket[1] asking Puppet Labs to release this as 1.0.0, so that
each release cannot break the API as so many of us depend on this.

[1] - https://tickets.puppetlabs.com/browse/PUP-2743

Br,
-g

-- 
Garrett Honeycutt
@learnpuppet
Puppet Training with LearnPuppet.com
Mobile: +1.206.414.8658

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/5395E97A.9050005%40garretthoneycutt.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Puppet Users] Breaking changes in Puppetlabs_spec_helper v0.5.0

2014-06-09 Thread Clayton O'Neill 
On Mon, Jun 9, 2014 at 11:23 AM, fatmcgav  wrote:

> Afternoon all,
>
> Just thought I'd make the lists aware of an issue I hit with
> puppetlabs_spec_helper v0.5.0 today.
>
> It would appear that changes committed in [1] results in the dropping of
> mocha as a dependency, and therefore any tests depending on mocha failing.
> The error I was seeing was:
>
> Failure/Error: Puppet::Type.type(:application).stubs(:defaultprovider).returns
> described_class
>
> NoMethodError:
>
> undefined method `stubs' for Puppet::Type::Application:Class
>
> # ./spec/unit/puppet/provider/application/asadmin_spec.rb:6
> A work-around for me was to pin puppetlabs_spec_helper to v0.4.x. [2]
>

I just ran into the same problem.  Is this a bug, or a change in API?  I
also worked around it via '~> 0.4.1'.

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/CADg-rOXdrM7qxY_67rRMHyhNVBA6T10nQNR7cnDqBzqA7kiSHg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Puppet Users] Breaking changes in Puppetlabs_spec_helper v0.5.0

2014-06-09 Thread fatmcgav 
Afternoon all,

Just thought I'd make the lists aware of an issue I hit with
puppetlabs_spec_helper v0.5.0 today.

It would appear that changes committed in [1] results in the dropping of
mocha as a dependency, and therefore any tests depending on mocha failing.
The error I was seeing was:

Failure/Error: Puppet::Type.type(:application).stubs(:defaultprovider).returns
described_class

NoMethodError:

undefined method `stubs' for Puppet::Type::Application:Class

# ./spec/unit/puppet/provider/application/asadmin_spec.rb:6
A work-around for me was to pin puppetlabs_spec_helper to v0.4.x. [2]

Hopefully this will prevent un-necessary time-wastage for anyone else :)

Also, as a general comment to PL - Is it possible to get some advance
notice of breaking changes such as this?
As this could potentially have been prevented by a release email stating
the breaking nature of the changes, and prompting users to ensure they are
pinning versions as appropriate.

Thanks for the assistance of igalic and _rc on #puppet-dev.

Cheers
Gavin

[1]
https://github.com/puppetlabs/puppetlabs_spec_helper/commit/1c23917f60f64e4fbf7b9effdb212f907656826f
[2]
https://github.com/fatmcgav/fatmcgav-glassfish/commit/ae4bbc94d611acb6c037cb9e3cc852d28a162f9b

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/CAGJCw3jp7tEekxWu6DyDG2p%3DVQGKrm%2BtwQSbH1Gy9v%3Dvtf_n0Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.