Re: [Puppet Users] Re: augeas-0.10.0_1 in FreeBSD can't see /etc/rc.conf

[Dominic Cleal]

On 01/05/12 21:12, Darryl Wisneski wrote:
> On Tue, May 01, 2012 at 02:15:25PM -0400, Steve Wills wrote:
>> Hi,
>>
>> Thanks for the info. Something is definitely not right, but it doesn't
>> seem to work for me even with the older version:
>>
>> It looks like the problem is that the fix in ticket 255:
>>
>> https://fedorahosted.org/augeas/ticket/255
>> https://fedorahosted.org/augeas/changeset/95515f45adf192ab10e6c6ffbd69b5977a9f78b2/
> 
> The patch worked but the rc.conf potentially needs double quotes
> on the RHS, or value.  No?  It seems this functionality conflicts
> with the resolution of ticket 255.

Yes, there is some conflict here.  Unfortunately the path /etc/rc.conf
has now been picked up by Arch Linux for all configuration (sigh):

https://wiki.archlinux.org/index.php/Rc.conf

In their case it's meant to be fully bash-compatible according to
rc.conf(5).  When /etc/rc.conf was originally added to Shellvars
upstream, the same was probably assumed for FreeBSD.  I assume the
quotes are just for style, or are they required for parsing?

I'd be hesitant to suggest changing back to the rcconf.aug lens, even
though it was here first, due to Arch and that we've started to use
Shellvars now.  This means you'd need to update resources to add the
quotes explicitly, or that Steve patched the FreeBSD port to keep the
rcconf.aug lens instead of upstream's Shellvars (which could get confusing).

What do you think?

>> is not included in the current release. That's OK, I can patch it in. See
>> attached patch. With this, I get:
>>
>> % augtool --version
>> augtool 0.10.0 
>> Copyright (C) 2007-2011 David Lutterkort
>> License LGPLv2+: GNU LGPL version 2.1 or later
>>  
>> This is free software: you are free to change and redistribute it.
>> There is NO WARRANTY, to the extent permitted by law.
>>
>> Written by David Lutterkort
>> % augtool print /files/etc/rc.conf
>> /files/etc/rc.conf
>> /files/etc/rc.conf/keymap = "\"us.pc-ctrl\""
>> /files/etc/rc.conf/sshd_enable = "\"YES\""
>> [snip]

This matches what should be back in the next Augeas release, and how
0.8.1/0.9.0 both behaved.

-- 
Dominic Cleal
Red Hat Consulting
m: +44 (0)7817 878113

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to 
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/puppet-users?hl=en.

[Puppet Users] Re: augeas-0.10.0_1 in FreeBSD can't see /etc/rc.conf

[Darryl Wisneski]

Hi Steve:

On Tue, May 01, 2012 at 02:15:25PM -0400, Steve Wills wrote:
> Hi,
> 
> Thanks for the info. Something is definitely not right, but it doesn't
> seem to work for me even with the older version:
> 
> It looks like the problem is that the fix in ticket 255:
> 
> https://fedorahosted.org/augeas/ticket/255
> https://fedorahosted.org/augeas/changeset/95515f45adf192ab10e6c6ffbd69b5977a9f78b2/
> 

The patch worked but the rc.conf potentially needs double quotes
on the RHS, or value.  No?  It seems this functionality conflicts
with the resolution of ticket 255.

-dkw


> is not included in the current release. That's OK, I can patch it in. See
> attached patch. With this, I get:
> 
> % augtool --version
> augtool 0.10.0 
> Copyright (C) 2007-2011 David Lutterkort
> License LGPLv2+: GNU LGPL version 2.1 or later
>  
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> 
> Written by David Lutterkort
> % augtool print /files/etc/rc.conf
> /files/etc/rc.conf
> /files/etc/rc.conf/keymap = "\"us.pc-ctrl\""
> /files/etc/rc.conf/sshd_enable = "\"YES\""
> [snip]
> %
> 
> If this works for you, I'll go ahead and commit this.
> 
> Thanks,
> Steve
> 
> > Howdy:
> >
> > Since I upgraded some of my FreeBSD boxen to augeas-0.10.0* I can't
> > get augeas to address /etc/rc.conf.  I was able to modify key/values
> > in /etc/rc.conf in augeas-0.7.1_2 in my puppet classes and augtool.
> > I think I recall Dominic saying that the /etc/rc.conf lens was added
> > by the FreeBSD ports maintainer.  Can you help please?  I just
> > refreshed my ports tree (portsnap fetch extract) and remade augeas.
> > The checksums on the lens files has not changes between versions.
> > I am seeing this behavior in FreeBSD 8.2 and 9.0 RELEASE.
> >
> > # pwd
> > /usr/ports/textproc/augeas
> > # make deinstall reinstall clean
> >
> > Here is the output of augtool:
> >
> > broken:
> >
> > # pkg_info |grep augeas
> > augeas-0.10.0_1 A configuration editing tool
> >
> > # find  /usr/local/share/augeas/lenses/ -name "*rcconf*" -exec sum {} \;
> > 29678 1 /usr/local/share/augeas/lenses/tests/rcconf.aug
> > 13563 1 /usr/local/share/augeas/lenses/rcconf.aug
> >
> > # augtool
> > augtool> print /files/etc/rc.conf
> > augtool>
> >
> >
> > works:
> >
> > # pkg_info |grep augeas
> > augeas-0.7.1_2  A configuration editing tool
> >
> > $  find  /usr/local/share/augeas/lenses/ -name "*rcconf*" -exec sum {} \;
> > 13563 1 /usr/local/share/augeas/lenses/rcconf.aug
> > 29678 1 /usr/local/share/augeas/lenses/tests/rcconf.aug
> >
> > # augtool
> > augtool> print /files/etc/rc.conf
> > /files/etc/rc.conf
> > /files/etc/rc.conf/cloned_interfaces = "lagg0 vlan502 vlan503 tap0"
> > [snip]
> > /files/etc/rc.conf/ifconfig_em0 = "up"
> > /files/etc/rc.conf/ifconfig_em1 = "up"
> > /files/etc/rc.conf/ifconfig_lagg0 = "up laggproto failover laggport em0
> > laggport em1"
> > /files/etc/rc.conf/openssh_enable = "YES"
> > /files/etc/rc.conf/ntpd_enable = "YES"
> > /files/etc/rc.conf/ntpd_sync_on_start = "YES"
> > /files/etc/rc.conf/nrpe2_enable = "YES"
> > /files/etc/rc.conf/sendmail_enable = "NONE"
> > /files/etc/rc.conf/tmpmfs = "YES"
> > /files/etc/rc.conf/postgresql_enable = "YES"
> > /files/etc/rc.conf/puppet_enable = "YES"
> > /files/etc/rc.conf/snmpd_enable = "YES"
> > /files/etc/rc.conf/pf_enable = "YES"
> > /files/etc/rc.conf/jail_enable = "YES"
> > [snip]
> >
> > Thanks,
> > -dkw
> >

> Index: Makefile
> ===
> RCS file: /home/pcvs/ports/textproc/augeas/Makefile,v
> retrieving revision 1.10
> diff -u -r1.10 Makefile
> --- Makefile  25 Apr 2012 01:11:34 -  1.10
> +++ Makefile  1 May 2012 18:09:53 -
> @@ -8,7 +8,7 @@
>  
>  PORTNAME=augeas
>  PORTVERSION= 0.10.0
> -PORTREVISION=1
> +PORTREVISION=2
>  CATEGORIES=  textproc
>  MASTER_SITES=http://augeas.net/download/
>  
> @@ -38,7 +38,6 @@
>  
>  post-install:
>   ${MKDIR} ${LENSESDIR}/tests
> - ${INSTALL_DATA} ${FILESDIR}/rcconf.aug ${LENSESDIR}/rcconf.aug
>   ${INSTALL_DATA} ${FILESDIR}/test_rcconf.aug 
> ${LENSESDIR}/tests/rcconf.aug
>  
>  .include 
> Index: pkg-plist
> ===
> RCS file: /home/pcvs/ports/textproc/augeas/pkg-plist,v
> retrieving revision 1.2
> diff -u -r1.2 pkg-plist
> --- pkg-plist 12 Feb 2012 13:17:44 -  1.2
> +++ pkg-plist 1 May 2012 18:09:53 -
> @@ -231,7 +231,6 @@
>  %%DATADIR%%/lenses/dist/xml.aug
>  %%DATADIR%%/lenses/dist/xorg.aug
>  %%DATADIR%%/lenses/dist/yum.aug
> -%%DATADIR%%/lenses/rcconf.aug
>  %%DATADIR%%/lenses/tests/rcconf.aug
>  share/vim/vimfiles/ftdetect/augeas.vim
>  share/vim/vimfiles/syntax/augeas.vim
> Index: files/patch-lenses__shellvars.aug
> ===
> RCS file: files/pa