[pve-devel] applied: [PATCH qemu-server v3] rollback: Only create start task with --start if VM is not running

2022-12-30 Thread Thomas Lamprecht
Am 21/12/2022 um 17:51 schrieb Stefan Hanreich:
> When rolling back to the snapshot of a VM that includes RAM, the VM
> gets started by the rollback task anyway, so no additional start task
> is needed. Previously, when rolling back with the start parameter and
> the VM snapshot included RAM, a start task was created. That task
> failed because the VM had already been started by the rollback task.
> 
> Additionally documented this behaviour in the description of the start
> parameter
> 
> Signed-off-by: Stefan Hanreich 
> ---
> Changes v2 -> v3:
> Use vm_running_locally() instead of check_running()
> Improved description
> 
> Changes v1 -> v2:
> Do not parse config for checking type of snapshot but rather directly check
> whether VM is running or not via check_running()
> 
>  PVE/API2/Qemu.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>

applied, thanks!


___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



[pve-devel] applied: [PATCH pve-network] controllers: evpn : correctly limit the number of controllers to max 1

2022-12-30 Thread Thomas Lamprecht
Am 27/12/2022 um 08:17 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier 
> ---
>  PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-30 Thread Thomas Lamprecht
Am 28/12/2022 um 15:18 schrieb Stefan Sterz:
> maybe somewhat off-topic for the patch at hand, but it might be nice to
> modularize the pve report. so that `pvereport` gives you a default set
> of information, but you could also use `pvereport ha` to give you more
> information specifically about the state of the ha manager or `pvereport
> ceph` for information about ceph etc.
> 
> maybe paired with a verbose flag so that you could request more detailed
> info. e.g. `pvereport zfs` gives the zfs information currently in the
> report, but `pvereport zfs -v` could also include `arc_summary` and `cat
> /sys/module/zfs/parameters/zfs_arc_max` and other less often needed but
> sometimes useful information.
> 
> this might be handy especially in cases where you need information that
> spans several files/commands that aren't always needed. it might make
> the `pvereport` more useful in the forum too, where we currently can't
> use it at all because it discloses too much information.
> 
I'd rather keep it simple and not blow it up too much with a massive amount of
switches, lots of topics are very intertwined, e.g., ha issues often need most
information to have a full picture, i.e., it never hurts to have more
information. Also note that the forum is the community one and so IMO the wrong
place for any generic enterprise support report request, publicly readable for
all compared to the subscription contract and private enterprise support portal.

If, a generic (public) IP hashing might be sensible, and if that's done such
that it's still relatively easy to trace the different used one (i.e., a more
human readable/comparable hash than md5/SHA/...) it can be just always turned
on too.


___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel