Re: [pve-devel] [PATCH installer 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset

2023-11-16 Thread Stoiko Ivanov 
this is wrong!
the dataset is only needed for pve
I'll resend a v2

sorry for the noise!


On Thu, 16 Nov 2023 16:00:40 +0100
Stoiko Ivanov  wrote:

> this enables the users to set reservations on / separate from
> /var/lib/vz - where backups, ISOs, and other data might fill the
> complete pool.
> 
> Signed-off-by: Stoiko Ivanov 
> ---
>  Proxmox/Install.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c868992..a96249e 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -189,6 +189,9 @@ sub zfs_create_rpool {
>  syscmd("zfs create $pool_name/ROOT/$root_volume_name")  == 0 ||
>   die "unable to create zfs $pool_name/ROOT/$root_volume_name volume\n";
>  
> +syscmd("zfs create -p $pool_name/ROOT/$root_volume_name/var/lib/vz")  == 
> 0 ||
> + die "unable to create zfs $pool_name/ROOT/$root_volume_name/var/lib/vz 
> volume\n";
> +
>  # default to `relatime` on, fast enough for the installer and production
>  syscmd("zfs set atime=on relatime=on $pool_name") == 0 || die "unable to 
> set zfs properties\n";
>  



___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH installer 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset

2023-11-16 Thread Stoiko Ivanov 
this enables the users to set reservations on / separate from
/var/lib/vz - where backups, ISOs, and other data might fill the
complete pool.

Signed-off-by: Stoiko Ivanov 
---
 Proxmox/Install.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c868992..a96249e 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -189,6 +189,9 @@ sub zfs_create_rpool {
 syscmd("zfs create $pool_name/ROOT/$root_volume_name")  == 0 ||
die "unable to create zfs $pool_name/ROOT/$root_volume_name volume\n";
 
+syscmd("zfs create -p $pool_name/ROOT/$root_volume_name/var/lib/vz")  == 0 
||
+   die "unable to create zfs $pool_name/ROOT/$root_volume_name/var/lib/vz 
volume\n";
+
 # default to `relatime` on, fast enough for the installer and production
 syscmd("zfs set atime=on relatime=on $pool_name") == 0 || die "unable to 
set zfs properties\n";
 
-- 
2.39.2



___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel