Re: [pve-devel] [PATCH] rbd : free_image : retry if rbd has watchers

2014-12-08 Thread Andrew Thrift 
Hi Alexandre,

 yes this was tested with 3.3-3

# aptitude -F '%p %v#' search qemu-server
qemu-server   3.3-3



On Mon, Dec 8, 2014 at 5:07 PM, Alexandre DERUMIER aderum...@odiso.com
wrote:

 We are still experiencing corruption when performing live disk moves,
 even with this patch in place.

 Do you talk about patch  rbd : free_image : retry if rbd has watchers ?

 because we don't have applied this patch, because it was not the problem
 but the consequence.

 Do you have tested last qemu-server package from pvetest repository ?(=
 3.3-3)

 It should be fixed here.



 - Mail original -
 De: Andrew Thrift and...@networklabs.co.nz
 À: aderumier aderum...@odiso.com
 Cc: pve-devel pve-devel@pve.proxmox.com
 Envoyé: Lundi 8 Décembre 2014 04:42:23
 Objet: Re: [pve-devel] [PATCH] rbd : free_image : retry if rbd has watchers

 Hi Alexandre,
 We are still experiencing corruption when performing live disk moves, even
 with this patch in place.

 Is there anything we can do to help pinpoint the cause of this ?



 On Wed, Nov 12, 2014 at 7:39 PM, Alexandre DERUMIER  aderum...@odiso.com
  wrote:


 Ok, Great!

 Thanks for testing.

 (@cc pve-devel)

 - Mail transféré -

 De: Andrew Thrift  and...@networklabs.co.nz 
 À: Alexandre DERUMIER  aderum...@odiso.com 
 Envoyé: Mercredi 12 Novembre 2014 05:10:40
 Objet: Re: [pve-devel] [PATCH] rbd : free_image : retry if rbd has watchers


 Hi Alexandre,


 Initial testing looks promising.


 I have tested migrating disks that have active writes on them and it
 worked well. All files had matching md5 sums.


 I will test with 4K writes tomorrow.


 On Fri, Nov 7, 2014 at 10:42 PM, Andrew Thrift  and...@networklabs.co.nz
  wrote:



 Thanks Alexandre,


 I will try these first thing Monday.


 Have a good weekend !








 On Fri, Nov 7, 2014 at 10:29 PM, Alexandre DERUMIER  aderum...@odiso.com
  wrote:

 blockquote
 Do you know why online Disk Move's could be causing this corruption ? We
 have had to stop using it as if we corrupt a customers DB server it would
 not be a good thing :(

 Can you try to 2 patchs I have sent ? I think it should fix the problem.


 - Mail original -

 De: Andrew Thrift  and...@networklabs.co.nz 
 À: Alexandre DERUMIER  aderum...@odiso.com 
 Envoyé: Jeudi 6 Novembre 2014 21:18:19
 Objet: Re: [pve-devel] [PATCH] rbd : free_image : retry if rbd has watchers




 HI Alexandre,


 Not related specifically to this patch. But using DIsk Move while the VM
 is online results in corruption for us almost every time we use it.


 We are using PVE3.3 with RBD storage. Typically we are moving from one RBD
 pool to another. We seem to get coorruption if the block copy completes or
 fails.


 We are primarily running Windows guest OS's with virtio or virtio-scsi
 disks.


 Our Ceph cluster has 84 spinning disks and 7x Intel S3700 Journal's.
 Networking to all devices is 2x10gigabit bonded and performance generally
 is very good.




 Do you know why online Disk Move's could be causing this corruption ? We
 have had to stop using it as if we corrupt a customers DB server it would
 not be a good thing :(




 On Fri, Nov 7, 2014 at 5:00 AM, Alexandre DERUMIER  aderum...@odiso.com
  wrote:


 I'll resend a V2 tommorow
 - Mail original -

 De: Dietmar Maurer  diet...@proxmox.com 
 À: Alexandre DERUMIER  aderum...@odiso.com 
 Cc: pve-devel@pve.proxmox.com
 Envoyé: Jeudi 6 Novembre 2014 16:08:38
 Objet: RE: [pve-devel] [PATCH] rbd : free_image : retry if rbd has watchers



  And what happens if we get other errors?
 
  Currently It's retrying until $i  ~0
 
  but we could add a die directly if $err !~ image still has watchers

 Yes, I think that would be better.
 ___
 pve-devel mailing list
 pve-devel@pve.proxmox.com
 http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




 /blockquote




___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Remove Disk

2014-12-08 Thread Martin Maurer 
Yes, see https://bugzilla.proxmox.com/show_bug.cgi?id=584

Martin

From: pve-devel [mailto:pve-devel-boun...@pve.proxmox.com] On Behalf Of Andrew 
Thrift
Sent: Montag, 08. Dezember 2014 00:13
To: pve-devel@pve.proxmox.com
Subject: [pve-devel] Remove Disk

Hi,

I have noticed from at least PVE 2.3 through 3.3 that when removing a disk from 
a VM that there is no Task created, and that no progress is shown.

This means that on storage such as Ceph where disk removal can take some time, 
you are in the dark as to progress.  You also cannot see from a VM's Task 
History when a disk was deleted.

Can this missing functionality please be added to the roadmap ?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] Add qga freeze in vzdump in snapshot mode

2014-12-08 Thread Wolfgang Link 
it will freeze the filesystem to provide consistents.

Signed-off-by: Wolfgang Link wolfg...@linksystems.org
---
 PVE/VZDump/QemuServer.pm |   19 +--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index fd36c69..2c62de3 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -286,8 +286,8 @@ sub archive {
 my $resume_on_backup;
 
 my $skiplock = 1;
-
-if (!PVE::QemuServer::check_running($vmid)) {
+my $vm_is_running = PVE::QemuServer::check_running($vmid);
+if (!$vm_is_running) {
eval {
$self-loginfo(starting kvm to execute backup task);
PVE::QemuServer::vm_start($self-{storecfg}, $vmid, undef, 
@@ -380,8 +380,23 @@ sub archive {
 
$qmpclient-queue_cmd($vmid, $add_fd_cb, 'getfd', 
  fd = $outfileno, fdname = backup);
+ 
+   my $freeze_fs = 0; 
+
+   if ( $self-{vmlist}-{$vmid}-{agent} == 1  $vm_is_running ){
+   $freeze_fs = 
PVE::QemuServer::vm_mon_cmd($vmid,guest-fsfreeze-freeze);  
+   $self-loginfo(Can't freeze fs!)if ( defined($freeze_fs)   
$freeze_fs == 0 );
+   }
+   
$qmpclient-queue_execute();
 
+   my $thaw_fs = 0; 
+   $thaw_fs= PVE::QemuServer::vm_mon_cmd($vmid,guest-fsfreeze-thaw) 
+   if ( $freeze_fs  0 );
+
+   $self-loginfo(Error by trying thaw fs, you must unlock manually)
+   if ( $freeze_fs  0  0 != $freeze_fs - $thaw_fs );
+
die $qmpclient-{errors}-{$vmid} if $qmpclient-{errors}-{$vmid};
 
if ($cpid) {
-- 
1.7.10.4

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel