Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

[Marco Gabriel - inett GmbH]

I totally agree, but wanted to point out that while this solution is not the 
prettiest, but the information is exactly where it needs to be.

The main reason for this is to identify backups residing on an old backup store 
like an archive.

But I am open. Would you prefer having a manifest included in the archive or as 
a separate file on the same storage?

Marco

Holen Sie sich Outlook für Android<https://aka.ms/ghei36>


[cid:inett5-126x70_81c2a0fa-28f3-411c-8d4f-6b70748d931f.png]

Ihr IT Systemhaus
in Saarbrücken

[cid:Facebook_f91e3de6-689a-4957-b6ca-dbf3ca3c7f7b.png]<https://www.facebook.com/inettgmbh><https://plus.google.com/+InettDe>[cid:Twitter_ab6c04c5-c40f-43ea-a66b-5114ca78bf2d.png]<https://twitter.com/inettgmbh>[cid:RSS_170102a2-2aa4-4995-8b7c-d88dd57e8397.png]<https://www.inett.de/feed.rss>
Marco Gabriel
Geschäftsführer

t: 0681-410993-0
e: mgabr...@inett.de


www.inett.de<http://www.inett.de>

Technische Fragen:
Support E-Mail: supp...@inett.de<mailto:supp...@inett.de>
Support Hotline: 0681-410993-42


inett GmbH | Mainzer Str. 183 | 66121 Saarbrücken
Geschäftsführung: Marco Gabriel | Amtsgericht Saarbrücken HRB 16588


From: Dietmar Maurer 
Sent: Wednesday, November 13, 2019 4:42:28 PM
To: PVE development discussion ; Marco Gabriel - 
inett GmbH 
Subject: Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added 
"includename" option

> IMHO this is the wrong way to store additional information about
> the backup.

I am thinking about adding a manifest.json file which may contain
such information 

___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-guest-common 0/1] vzdump: added "includename" option which adds the name or hostname of a vm or container to a backup filename

[Marco Gabriel - inett GmbH]

Thanks for clarification.

I'd update the wiki page accordingly.

Best regards,
Marco


inett GmbH
>> Ihr IT Systemhaus in  Saarbrücken

Marco Gabriel
Geschäftsführer

t: 0681-410993-0
e: mgabr...@inett.de
www.inett.de

Technische Fragen:
Support E-Mail: supp...@inett.de
Support Hotline: 0681-410993-42


inett GmbH | Geschäftsführung: Marco Gabriel | Amtsgericht Saarbrücken HRB 16588
-Ursprüngliche Nachricht-
Von: Thomas Lamprecht  
Gesendet: Mittwoch, 13. November 2019 15:12
An: PVE development discussion ; Marco Gabriel - 
inett GmbH 
Betreff: Re: [pve-devel] [PATCH pve-guest-common 0/1] vzdump: added 
"includename" option which adds the name or hostname of a vm or container to a 
backup filename

On 11/13/19 3:02 PM, Marco Gabriel wrote:
> *** BLURB HERE ***
> 
> Marco Gabriel (1):
>   vzdump: added "includename" option
> 
>  PVE/VZDump/Common.pm | 6 ++
>  1 file changed, 6 insertions(+)
> 

FYI, some pointers for sending patches with git/mail

It's nice if related patches are send together, even if they are from different 
repositories. This can be done with first using `git format-patch` and then do 
a single git send-email over all generated patches. For example, lets go to a 
few repos and format the most recent commit as patch to /tmp/patchq, then send 
it:

# cd pve-manager; git format-patch -s -o /tmp/patchq -1 # cd 
../pve-guest-common; git format-patch -s -o /tmp/patchq -1 # cd ../pve-docs; 
git format-patch -s -o /tmp/patchq -1 # git send-email --compose 
--to=pve-devel@pve.proxmox.com /tmp/patchq/*

Using "start-number" and the like can improve this further, but it's a good 
start.

Another thing would is: if you do not fill out the cover letter, (see your 
BLURP HERE) anyway, it's better to omit it completely, which can be totally 
fine for small series or a single specific feature where the commit message(s) 
are enough, and no common overview or rationale is required to understand the 
goal and method used in a series.

Just a few pointer valid for anybody sending patches to developer mailing lists.

cheers,
Thomas

___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] Feature: add vm name or ct hostname to backup file name as requested in #438

[Marco Gabriel - inett GmbH]

Hi,

long time ago, I requested adding the container hostname or vm name in bugzilla 
request #438. As I wanted to practice developing features for pve and how to 
use the git repos, I implemented the feature. I should have asked before, but I 
haven't. So I am not upset if the feature won't make it into upstream. I'm 
going to try sending them by mail in additional patch mails.

I am not sure if I signed a CLA already. If not, where should I send it to?

Best regards,
Marco


[cid:inett5-126x70_81c2a0fa-28f3-411c-8d4f-6b70748d931f.png]

Ihr IT Systemhaus
in Saarbr?cken

[cid:Facebook_f91e3de6-689a-4957-b6ca-dbf3ca3c7f7b.png][cid:Twitter_ab6c04c5-c40f-43ea-a66b-5114ca78bf2d.png][cid:RSS_170102a2-2aa4-4995-8b7c-d88dd57e8397.png]
Marco Gabriel
Gesch?ftsf?hrer

t: 0681-410993-0
e: mgabr...@inett.de


www.inett.de

Technische Fragen:
Support E-Mail: supp...@inett.de
Support Hotline: 0681-410993-42


inett GmbH | Mainzer Str. 183 | 66121 Saarbr?cken
Gesch?ftsf?hrung: Marco Gabriel | Amtsgericht Saarbr?cken HRB 16588
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel