Re: [pve-devel] [PAST pve-manager] use correct checked value for ha resource edit dialog

2015-09-09 Thread Thomas Lamprecht 

s/PAST/PATCH/
Sorry but shouldn't have an effect.

On 09/09/2015 03:21 PM, Thomas Lamprecht wrote:

Signed-off-by: Thomas Lamprecht 
---
  www/manager/ha/ResourceEdit.js | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager/ha/ResourceEdit.js b/www/manager/ha/ResourceEdit.js
index 962cdda..bc48c70 100644
--- a/www/manager/ha/ResourceEdit.js
+++ b/www/manager/ha/ResourceEdit.js
@@ -54,7 +54,7 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
{
xtype: 'pvecheckbox',
name: 'enable',
-   checked: true,
+   checked: me.enable,
uncheckedValue: 0,
fieldLabel: gettext('enable')
}



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PAST pve-manager] use correct checked value for ha resource edit dialog

2015-09-09 Thread Thomas Lamprecht 
Signed-off-by: Thomas Lamprecht 
---
 www/manager/ha/ResourceEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager/ha/ResourceEdit.js b/www/manager/ha/ResourceEdit.js
index 962cdda..bc48c70 100644
--- a/www/manager/ha/ResourceEdit.js
+++ b/www/manager/ha/ResourceEdit.js
@@ -54,7 +54,7 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
{
xtype: 'pvecheckbox',
name: 'enable',
-   checked: true,
+   checked: me.enable,
uncheckedValue: 0,
fieldLabel: gettext('enable')
}
-- 
2.1.4

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PAST pve-manager] use correct checked value for ha resource edit dialog

2015-09-09 Thread Dietmar Maurer 
that looks strange to me - is that really required?
The current GUI works for me, so how can I reproduce the bug?

> On September 9, 2015 at 3:21 PM Thomas Lamprecht 
> wrote:
> 
> 
> Signed-off-by: Thomas Lamprecht 
> ---
>  www/manager/ha/ResourceEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager/ha/ResourceEdit.js b/www/manager/ha/ResourceEdit.js
> index 962cdda..bc48c70 100644
> --- a/www/manager/ha/ResourceEdit.js
> +++ b/www/manager/ha/ResourceEdit.js
> @@ -54,7 +54,7 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
>   {
>   xtype: 'pvecheckbox',
>   name: 'enable',
> - checked: true,
> + checked: me.enable,
>   uncheckedValue: 0,
>   fieldLabel: gettext('enable')
>   }
> -- 
> 2.1.4
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PAST pve-manager] use correct checked value for ha resource edit dialog

2015-09-09 Thread Thomas Lamprecht 


Didn't replied to the list, sorry.

 Weitergeleitete Nachricht 
Betreff: 	Re: [pve-devel] [PAST pve-manager] use correct checked value 
for ha resource edit dialog

Datum:  Wed, 9 Sep 2015 18:10:50 +0200
Von:Thomas Lamprecht <t.lampre...@proxmox.com>
An: Dietmar Maurer <diet...@proxmox.com>



Reproduction:
Disable an service and then try to edit it. You cannot enable it
directly as the checkbox is already checked.
So you need to save it as disabled (although it is already disabled)
reopen the edit box and only then you can enable it.

Am 09.09.2015 um 17:31 schrieb Dietmar Maurer:

that looks strange to me - is that really required?
The current GUI works for me, so how can I reproduce the bug?


On September 9, 2015 at 3:21 PM Thomas Lamprecht <t.lampre...@proxmox.com>
wrote:


Signed-off-by: Thomas Lamprecht <t.lampre...@proxmox.com>
---
  www/manager/ha/ResourceEdit.js | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager/ha/ResourceEdit.js b/www/manager/ha/ResourceEdit.js
index 962cdda..bc48c70 100644
--- a/www/manager/ha/ResourceEdit.js
+++ b/www/manager/ha/ResourceEdit.js
@@ -54,7 +54,7 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
{
xtype: 'pvecheckbox',
name: 'enable',
-   checked: true,
+   checked: me.enable,
uncheckedValue: 0,
fieldLabel: gettext('enable')
}
--
2.1.4

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel





___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PAST pve-manager] use correct checked value for ha resource edit dialog

2015-09-09 Thread Dietmar Maurer 
> Reproduction:
> Disable an service and then try to edit it. You cannot enable it 
> directly as the checkbox is already checked.
> So you need to save it as disabled (although it is already disabled) 
> reopen the edit box and only then you can enable it.

I cannot reproduce that.

> 
> Am 09.09.2015 um 17:31 schrieb Dietmar Maurer:
> > that looks strange to me - is that really required?
> > The current GUI works for me, so how can I reproduce the bug?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PAST pve-manager] use correct checked value for ha resource edit dialog

2015-09-09 Thread Thomas Lamprecht 



Am 09.09.2015 um 19:42 schrieb Dietmar Maurer:

Reproduction:
Disable an service and then try to edit it. You cannot enable it
directly as the checkbox is already checked.
So you need to save it as disabled (although it is already disabled)
reopen the edit box and only then you can enable it.

I cannot reproduce that.
Ok, better reproduction: disable an HA service resource via web 
interface and then try to disable another one, then the check-box state 
doesn't represent the current state.





Am 09.09.2015 um 17:31 schrieb Dietmar Maurer:

that looks strange to me - is that really required?
The current GUI works for me, so how can I reproduce the bug?



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel