Re: [pve-devel] [PATCH] Fix: root can now be disabled in GUI.

2015-01-20 Thread Dietmar Maurer 

So it is no longer possible to login on a fresh installed system?!

On 01/07/2015 08:49 AM, Wolfgang Link wrote:

Signed-off-by: Wolfgang Link 
---
  PVE/AccessControl.pm |7 ---
  1 file changed, 7 deletions(-)

diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm
index db85d08..29dba39 100644
--- a/PVE/AccessControl.pm
+++ b/PVE/AccessControl.pm
@@ -356,8 +356,6 @@ sub check_user_enabled {
  
  return 1 if $data->{enable};
  
-return 1 if $username eq 'root@pam'; # root is always enabled

-
  die "user '$username' is disabled\n" if !$noerr;
   
  return undef;

@@ -694,11 +692,6 @@ sub userconfig_force_defaults {
  foreach my $r (keys %$special_roles) {
$cfg->{roles}->{$r} = $special_roles->{$r};
  }
-
-# fixme: remove 'root' group (not required)?
-
-# add root user
-$cfg->{users}->{'root@pam'}->{enable} = 1;
  }
  
  sub parse_user_config {



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] Fix: root can now be disabled in GUI.

2015-01-06 Thread Wolfgang Link 

Signed-off-by: Wolfgang Link 
---
 PVE/AccessControl.pm |7 ---
 1 file changed, 7 deletions(-)

diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm
index db85d08..29dba39 100644
--- a/PVE/AccessControl.pm
+++ b/PVE/AccessControl.pm
@@ -356,8 +356,6 @@ sub check_user_enabled {
 
 return 1 if $data->{enable};
 
-return 1 if $username eq 'root@pam'; # root is always enabled
-
 die "user '$username' is disabled\n" if !$noerr;
  
 return undef;
@@ -694,11 +692,6 @@ sub userconfig_force_defaults {
 foreach my $r (keys %$special_roles) {
$cfg->{roles}->{$r} = $special_roles->{$r};
 }
-
-# fixme: remove 'root' group (not required)?
-
-# add root user 
-$cfg->{users}->{'root@pam'}->{enable} = 1;
 }
 
 sub parse_user_config {
-- 
1.7.10.4


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel