Re: [pve-devel] [PATCH qemu-server] vzdump: fix template backup to stdout

2020-05-06 Thread Thomas Lamprecht
On 5/6/20 11:56 AM, Fabian Grünbichler wrote:
> redirecting to the saved STDOUT in case of a template backup or a VM
> without any disks failed because of the erroneous '=':
> 
> Backup of VM 123123 failed - command '/usr/bin/vma create -v -c [...]' failed:
> Bad filehandle: =5 at /usr/share/perl/5.28/IPC/Open3.pm line 58.
> 
> https://forum.proxmox.com/threads/vzdump-to-stdout.69364
> 
> Signed-off-by: Fabian Grünbichler 
> ---
>  PVE/VZDump/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied, thanks!


___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


[pve-devel] [PATCH qemu-server] vzdump: fix template backup to stdout

2020-05-06 Thread Fabian Grünbichler
redirecting to the saved STDOUT in case of a template backup or a VM
without any disks failed because of the erroneous '=':

Backup of VM 123123 failed - command '/usr/bin/vma create -v -c [...]' failed:
Bad filehandle: =5 at /usr/share/perl/5.28/IPC/Open3.pm line 58.

https://forum.proxmox.com/threads/vzdump-to-stdout.69364

Signed-off-by: Fabian Grünbichler 
---
 PVE/VZDump/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index f122539..3a990cf 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -518,7 +518,7 @@ sub archive_vma {
$self->loginfo(join(' ', @$cmd));
 
if ($opts->{stdout}) {
-   $self->cmd($cmd, output => ">&=" . fileno($opts->{stdout}));
+   $self->cmd($cmd, output => ">&" . fileno($opts->{stdout}));
} else {
$self->cmd($cmd);
}
-- 
2.20.1


___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel