Re: [pve-devel] [PATCH v4 manager 3/3] Allow CPUModelSelector to be searched by vendor as well

2019-10-02 Thread Thomas Lamprecht
On 9/10/19 7:11 PM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter 
> ---
>  www/manager6/form/CPUModelSelector.js | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/www/manager6/form/CPUModelSelector.js 
> b/www/manager6/form/CPUModelSelector.js
> index dea6c44c..55532a0d 100644
> --- a/www/manager6/form/CPUModelSelector.js
> +++ b/www/manager6/form/CPUModelSelector.js
> @@ -4,6 +4,7 @@ Ext.define('PVE.form.CPUModelSelector', {
>  
>  valueField: 'value',
>  displayField: 'value',
> +searchFields: [ 'value', 'vendor' ],
>  
>  emptyText: Proxmox.Utils.defaultText + ' (kvm64)',
>  allowBlank: true,
> 

instead of this and 2/3 we also could just a virtual combined field
in the model and use that as displayField, like I did for the USB
Selector [0].

But, just as idea, multi column search could be nice enough on
it's own do justify the relative big overwrite in ComboGrid..

[0]: 
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=19fa4ee333aaa193638858241651b0f9e1a40e2e

___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


[pve-devel] [PATCH v4 manager 3/3] Allow CPUModelSelector to be searched by vendor as well

2019-09-10 Thread Stefan Reiter
Signed-off-by: Stefan Reiter 
---
 www/manager6/form/CPUModelSelector.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/form/CPUModelSelector.js 
b/www/manager6/form/CPUModelSelector.js
index dea6c44c..55532a0d 100644
--- a/www/manager6/form/CPUModelSelector.js
+++ b/www/manager6/form/CPUModelSelector.js
@@ -4,6 +4,7 @@ Ext.define('PVE.form.CPUModelSelector', {
 
 valueField: 'value',
 displayField: 'value',
+searchFields: [ 'value', 'vendor' ],
 
 emptyText: Proxmox.Utils.defaultText + ' (kvm64)',
 allowBlank: true,
-- 
2.20.1


___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel