Re: [pygame] Capturing Multiple Keyboard Inputs

[Silver]

On 1/15/2012 8:16 PM, Ian Mallett wrote:
 On Sun, Jan 15, 2012 at 7:46 PM, Ryan Strunk ryan.str...@gmail.com wrote:
 
 Hello everyone,
 I am testing my understanding of the pygame.key module by creating a
 program
 that pans the sound of a car engine and raises/lowers its frequency. While
 the individual keys do exactly what they're supposed to, I run into a big
 problem when I try to do two things at once. For example, if I hold the up
 arrow, the frequency of the sound rises with no problem. If I then hold
 down
 the left arrow while still holding up, however, the frequency stops rising
 and the pan begins to adjust itself. How can I make both keys carry out
 their assigned task at the same time?
 As a side note, aside from exporting the redundant code below into its own
 methods, are there any other ways to check for multiple keys without giving
 each its own if check?
 Ugly code is below:

 import pygame
 from sound_lib.stream import FileStream
 from sound_lib.output import Output

 def main():
clock = pygame.time.Clock()
o = Output()
sound = FileStream(file=sounds/car.wav)
screen = pygame.display.set_mode((640, 400))
sound.looping = True
sound.play()
pygame.key.set_repeat(50, 50)
while(True):
for event in pygame.event.get():
if event.type == pygame.KEYDOWN:
if event.key == pygame.K_UP:
sound.frequency += 200
if event.key == pygame.K_DOWN:
sound.frequency -= 200
if event.key == pygame.K_LEFT:
if sound.pan = -0.9:
sound.pan = -0.9
else:
sound.pan -= 0.1
if event.key == pygame.K_RIGHT:
if sound.pan = 0.9:
sound.pan = 0.9
else:
sound.pan += 0.1
if event.key == pygame.K_ESCAPE:
exit()
clock.tick(10)

 if __name__ == '__main__':
main()

 Thanks,
 Ryan

 You should use pygame.key.get_pressed() to check whether the left/up keys
 are pressed.  Something like:
 
 while pygame.event.get(): pass
 key = pygame.key.get_pressed()
 if key[K_LEFT]: #whatever
 if key[K_UP]: #whatever
 
 Ian

OK, I am seriously confuzzled here. I thought that pygame.event.get()
gave you all the events, and that his code SHOULD capture multiple
keypresses.

What is the difference between get_pressed and event.get()?

Oh, and would the key repeat be worth doing manually to see if that is
the issue?

soemthing like:

waspressed = []
thisframepressed = []

every frame:
thisframepressed = []
if event.key in waspressed:
## trigger again
thisframepressed.append(event.key)
else:
waspressed.append(event.key)
for i in waspressed:
if not i in thisframepressed:
waspressed.remove(i)

Re: [pygame] Capturing Multiple Keyboard Inputs

[Radomir Dopieralski]

On Mon, Jan 16, 2012 at 20:22, Silver rockac...@gmail.com wrote:
 On 1/15/2012 8:16 PM, Ian Mallett wrote:
 On Sun, Jan 15, 2012 at 7:46 PM, Ryan Strunk ryan.str...@gmail.com wrote:

 Hello everyone,
 I am testing my understanding of the pygame.key module by creating a
 program
 that pans the sound of a car engine and raises/lowers its frequency. While
 the individual keys do exactly what they're supposed to, I run into a big
 problem when I try to do two things at once. For example, if I hold the up
 arrow, the frequency of the sound rises with no problem. If I then hold
 down
 the left arrow while still holding up, however, the frequency stops rising
 and the pan begins to adjust itself. How can I make both keys carry out
 their assigned task at the same time?
 As a side note, aside from exporting the redundant code below into its own
 methods, are there any other ways to check for multiple keys without giving
 each its own if check?
 Ugly code is below:

 import pygame
 from sound_lib.stream import FileStream
 from sound_lib.output import Output

 def main():
        clock = pygame.time.Clock()
        o = Output()
        sound = FileStream(file=sounds/car.wav)
        screen = pygame.display.set_mode((640, 400))
        sound.looping = True
        sound.play()
        pygame.key.set_repeat(50, 50)
        while(True):
                for event in pygame.event.get():
                        if event.type == pygame.KEYDOWN:
                                if event.key == pygame.K_UP:
                                        sound.frequency += 200
                                if event.key == pygame.K_DOWN:
                                        sound.frequency -= 200
                                if event.key == pygame.K_LEFT:
                                        if sound.pan = -0.9:
                                                sound.pan = -0.9
                                        else:
                                                sound.pan -= 0.1
                                if event.key == pygame.K_RIGHT:
                                        if sound.pan = 0.9:
                                                sound.pan = 0.9
                                        else:
                                                sound.pan += 0.1
                                if event.key == pygame.K_ESCAPE:
                                        exit()
                clock.tick(10)

 if __name__ == '__main__':
        main()

 Thanks,
 Ryan

 You should use pygame.key.get_pressed() to check whether the left/up keys
 are pressed.  Something like:

 while pygame.event.get(): pass
 key = pygame.key.get_pressed()
 if key[K_LEFT]: #whatever
 if key[K_UP]: #whatever

 Ian

 OK, I am seriously confuzzled here. I thought that pygame.event.get()
 gave you all the events, and that his code SHOULD capture multiple
 keypresses.

It gives you all events. You get the even for pressing the first key,
and you get the event for pressing the second key.
You also get the events for releasing those keys later on. You can
keep track of which keys are pressed that way, but pygame does that
for you internally, so you can just get the state of all the keys with
get_pressed, which is more convenient.

 What is the difference between get_pressed and event.get()?

The former gives you the states of all the keys (including keys like
shift and ctrl), the latter gives you an event from the event queue.

 Oh, and would the key repeat be worth doing manually to see if that is
 the issue?

If your game depends on the timing of those repeats, you will most
certainly want to use pygame.Clock and do your own timing, instead of
relying on event.get and the operating system's key repeat.

 soemthing like:

 waspressed = []
 thisframepressed = []

 every frame:
        thisframepressed = []
        if event.key in waspressed:
                ## trigger again
                thisframepressed.append(event.key)
        else:
                waspressed.append(event.key)
        for i in waspressed:
                if not i in thisframepressed:
                        waspressed.remove(i)

No, don't use events for that. Just run your main loop at a constant
FPS with pygame.Clock and check for the key states with get_pressed
regularly. Don't forget to pump the events though, or the window will
become unresponsive.

Re: [pygame] Capturing Multiple Keyboard Inputs

[Silver]

On 1/16/2012 11:35 AM, Radomir Dopieralski wrote:
 On Mon, Jan 16, 2012 at 20:22, Silver rockac...@gmail.com wrote:
 On 1/15/2012 8:16 PM, Ian Mallett wrote:
 On Sun, Jan 15, 2012 at 7:46 PM, Ryan Strunk ryan.str...@gmail.com wrote:

 Hello everyone,
 I am testing my understanding of the pygame.key module by creating a
 program
 that pans the sound of a car engine and raises/lowers its frequency. While
 the individual keys do exactly what they're supposed to, I run into a big
 problem when I try to do two things at once. For example, if I hold the up
 arrow, the frequency of the sound rises with no problem. If I then hold
 down
 the left arrow while still holding up, however, the frequency stops rising
 and the pan begins to adjust itself. How can I make both keys carry out
 their assigned task at the same time?
 As a side note, aside from exporting the redundant code below into its own
 methods, are there any other ways to check for multiple keys without giving
 each its own if check?
 Ugly code is below:

 import pygame
 from sound_lib.stream import FileStream
 from sound_lib.output import Output

 def main():
clock = pygame.time.Clock()
o = Output()
sound = FileStream(file=sounds/car.wav)
screen = pygame.display.set_mode((640, 400))
sound.looping = True
sound.play()
pygame.key.set_repeat(50, 50)
while(True):
for event in pygame.event.get():
if event.type == pygame.KEYDOWN:
if event.key == pygame.K_UP:
sound.frequency += 200
if event.key == pygame.K_DOWN:
sound.frequency -= 200
if event.key == pygame.K_LEFT:
if sound.pan = -0.9:
sound.pan = -0.9
else:
sound.pan -= 0.1
if event.key == pygame.K_RIGHT:
if sound.pan = 0.9:
sound.pan = 0.9
else:
sound.pan += 0.1
if event.key == pygame.K_ESCAPE:
exit()
clock.tick(10)

 if __name__ == '__main__':
main()

 Thanks,
 Ryan

 You should use pygame.key.get_pressed() to check whether the left/up keys
 are pressed.  Something like:

 while pygame.event.get(): pass
 key = pygame.key.get_pressed()
 if key[K_LEFT]: #whatever
 if key[K_UP]: #whatever

 Ian

 OK, I am seriously confuzzled here. I thought that pygame.event.get()
 gave you all the events, and that his code SHOULD capture multiple
 keypresses.
 
 It gives you all events. You get the even for pressing the first key,
 and you get the event for pressing the second key.
 You also get the events for releasing those keys later on. You can
 keep track of which keys are pressed that way, but pygame does that
 for you internally, so you can just get the state of all the keys with
 get_pressed, which is more convenient.
 
 What is the difference between get_pressed and event.get()?
 
 The former gives you the states of all the keys (including keys like
 shift and ctrl), the latter gives you an event from the event queue.
 
 Oh, and would the key repeat be worth doing manually to see if that is
 the issue?
 
 If your game depends on the timing of those repeats, you will most
 certainly want to use pygame.Clock and do your own timing, instead of
 relying on event.get and the operating system's key repeat.
 
 soemthing like:

 waspressed = []
 thisframepressed = []

 every frame:
thisframepressed = []
if event.key in waspressed:
## trigger again
thisframepressed.append(event.key)
else:
waspressed.append(event.key)
for i in waspressed:
if not i in thisframepressed:
waspressed.remove(i)
 
 No, don't use events for that. Just run your main loop at a constant
 FPS with pygame.Clock and check for the key states with get_pressed
 regularly. Don't forget to pump the events though, or the window will
 become unresponsive.
Thanks a lot.

RE: [pygame] Capturing Multiple Keyboard Inputs

[Ryan Strunk]

 On 1/15/2012 8:16 PM, Ian Mallett wrote:

 You should use pygame.key.get_pressed() to check whether the left/up 
 keys are pressed.  Something like:

 while pygame.event.get(): pass
 key = pygame.key.get_pressed()
 if key[K_LEFT]: #whatever
 if key[K_UP]: #whatever

I understand the reasoning behind get_pressed. What's the significance of
while pygame.event.get(): pass
Is that what you use instead of the for loop to step through the events in the 
queue, or is that the main event loop? Should I be putting that in instead of 
for key in pygame.event.get():
in order to look through all of the generated events?
Thanks,
Ryan

Re: [pygame] Capturing Multiple Keyboard Inputs

[Ian Mallett]

On Mon, Jan 16, 2012 at 4:27 PM, Ryan Strunk ryan.str...@gmail.com wrote:

 I understand the reasoning behind get_pressed. What's the significance of
 while pygame.event.get(): pass

Oops.  I meant: for event in pygame.event.get(): pass

Is that what you use instead of the for loop to step through the events in
 the queue, or is that the main event loop? Should I be putting that in
 instead of
 for key in pygame.event.get():
 in order to look through all of the generated events?
 Thanks,
 Ryan

Briefly:

Every input gets sent to the event queue.  This queue is what
pygame.event.get() returns.  You MUST call this function (or similar)
often, or else the queue will fill up, and you'll get problems.

This can be tedious to use.  In your case, you want something to happen
continuously if both keys are pressed.  Because you're only processing one
event at a time, you can't know if you're pressing two keys.  Moreover, you
can't know that you're holding down a key (you worked around this by adding
the repeat).

The commands like pygame.key.get_pressed() return *instantaneous* values.
 In this case, you can ask it whether any combination of keys are pressed.
 Internally, this works by keeping track of what's happened (e.g., if a
pygame.KEYDOWN event was put into the queue, then PyGame will store a
variable saying so for later use).

Ian

[pygame] Capturing Multiple Keyboard Inputs

[Ryan Strunk]

Hello everyone,
I am testing my understanding of the pygame.key module by creating a program
that pans the sound of a car engine and raises/lowers its frequency. While
the individual keys do exactly what they're supposed to, I run into a big
problem when I try to do two things at once. For example, if I hold the up
arrow, the frequency of the sound rises with no problem. If I then hold down
the left arrow while still holding up, however, the frequency stops rising
and the pan begins to adjust itself. How can I make both keys carry out
their assigned task at the same time?
As a side note, aside from exporting the redundant code below into its own
methods, are there any other ways to check for multiple keys without giving
each its own if check?
Ugly code is below:

import pygame
from sound_lib.stream import FileStream
from sound_lib.output import Output

def main():
clock = pygame.time.Clock()
o = Output()
sound = FileStream(file=sounds/car.wav)
screen = pygame.display.set_mode((640, 400))
sound.looping = True
sound.play()
pygame.key.set_repeat(50, 50)
while(True):
for event in pygame.event.get():
if event.type == pygame.KEYDOWN:
if event.key == pygame.K_UP:
sound.frequency += 200
if event.key == pygame.K_DOWN:
sound.frequency -= 200
if event.key == pygame.K_LEFT:
if sound.pan = -0.9:
sound.pan = -0.9
else:
sound.pan -= 0.1
if event.key == pygame.K_RIGHT:
if sound.pan = 0.9:
sound.pan = 0.9
else:
sound.pan += 0.1
if event.key == pygame.K_ESCAPE:
exit()
clock.tick(10)

if __name__ == '__main__':
main()

Thanks,
Ryan

Re: [pygame] Capturing Multiple Keyboard Inputs

[Ian Mallett]

On Sun, Jan 15, 2012 at 7:46 PM, Ryan Strunk ryan.str...@gmail.com wrote:

 Hello everyone,
 I am testing my understanding of the pygame.key module by creating a
 program
 that pans the sound of a car engine and raises/lowers its frequency. While
 the individual keys do exactly what they're supposed to, I run into a big
 problem when I try to do two things at once. For example, if I hold the up
 arrow, the frequency of the sound rises with no problem. If I then hold
 down
 the left arrow while still holding up, however, the frequency stops rising
 and the pan begins to adjust itself. How can I make both keys carry out
 their assigned task at the same time?
 As a side note, aside from exporting the redundant code below into its own
 methods, are there any other ways to check for multiple keys without giving
 each its own if check?
 Ugly code is below:

 import pygame
 from sound_lib.stream import FileStream
 from sound_lib.output import Output

 def main():
clock = pygame.time.Clock()
o = Output()
sound = FileStream(file=sounds/car.wav)
screen = pygame.display.set_mode((640, 400))
sound.looping = True
sound.play()
pygame.key.set_repeat(50, 50)
while(True):
for event in pygame.event.get():
if event.type == pygame.KEYDOWN:
if event.key == pygame.K_UP:
sound.frequency += 200
if event.key == pygame.K_DOWN:
sound.frequency -= 200
if event.key == pygame.K_LEFT:
if sound.pan = -0.9:
sound.pan = -0.9
else:
sound.pan -= 0.1
if event.key == pygame.K_RIGHT:
if sound.pan = 0.9:
sound.pan = 0.9
else:
sound.pan += 0.1
if event.key == pygame.K_ESCAPE:
exit()
clock.tick(10)

 if __name__ == '__main__':
main()

 Thanks,
 Ryan

You should use pygame.key.get_pressed() to check whether the left/up keys
are pressed.  Something like:

while pygame.event.get(): pass
key = pygame.key.get_pressed()
if key[K_LEFT]: #whatever
if key[K_UP]: #whatever

Ian