[issue971965] urllib2 raises exception with non-200 success codes.
Changes by Georg Brandl: -- resolution: - duplicate status: open - closed superseder: - urllib* 20x responses not OK? Tracker [EMAIL PROTECTED] http://bugs.python.org/issue971965 ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1135] xview/yview of Tix.Grid is broken
Georg Brandl added the comment: IMO the patch is not complete, the xview method should rather be implemented like these in Tkinter.py. Assigning to Martin. -- assignee: - loewis nosy: +georg.brandl, loewis __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1135 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1169] Option -OO doesn't remove docstrings from functions
Georg Brandl added the comment: Fixed in rev. 58204, 58205 (2.5). -- resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1169 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1177] urllib* 20x responses not OK?
Sean Reifschneider added the comment: Ported code change to urllib, passes tests, committed as revision 58206 -- resolution: - accepted status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1177 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1177] urllib* 20x responses not OK?
Georg Brandl added the comment: This might need at least a NEWS entry, if not a documentation clarification. -- nosy: +georg.brandl __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1177 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1541463] Optimizations for cgi.FieldStorage methods
Sean Reifschneider added the comment: Georg: This has been assigned to you, do you have any thoughts on this? If you don't, please assign back to me. -- keywords: +py3k nosy: +jafo _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1541463 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1177] urllib* 20x responses not OK?
Sean Reifschneider added the comment: Facundo, can you do a NEWS update on this? -- assignee: - facundobatista keywords: +patch status: closed - open __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1177 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1541463] Optimizations for cgi.FieldStorage methods
Georg Brandl added the comment: Thanks for notifying me. The tracker currently doesn't send notifications if you only set the assignee, but don't include a message. I hope this will be fixed soon. The __nonzero__() is unproblematic. The keys() produced in this way will have an unpredictable order, while the original way preserves the order of names in self.list. I don't know whether that would cause problems. -- keywords: +patch -py3k _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1541463 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1541463] Optimizations for cgi.FieldStorage methods
Sean Reifschneider added the comment: Thanks for correcting my mis-click on the patch item, gbot. As far as the order goes, is this something that needs to be discussed on c.l.p, or should we assign it to someone else who might have an opinion on it? _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1541463 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1135] xview/yview of Tix.Grid is broken
Hirokazu Yamamoto
added the comment:
OK, how about this patch? I extracted [xy]view{,_moveto,_scroll}
as mixin class [XY]View, and included them. It seems working.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1135
__Index: Lib/lib-tk/Tix.py
===
--- Lib/lib-tk/Tix.py (revision 58194)
+++ Lib/lib-tk/Tix.py (working copy)
@@ -850,7 +850,7 @@
# FIXME: return python object
pass
-class HList(TixWidget):
+class HList(TixWidget, XView, YView):
HList - Hierarchy display widget can be used to display any data
that have a hierarchical structure, for example, file system directory
trees. The list entries are indented and connected by branch lines
@@ -1037,12 +1037,6 @@
def show_entry(self, entry):
return self.tk.call(self._w, 'show', 'entry', entry)
-def xview(self, *args):
-self.tk.call(self._w, 'xview', *args)
-
-def yview(self, *args):
-self.tk.call(self._w, 'yview', *args)
-
class InputOnly(TixWidget):
InputOnly - Invisible widget. Unix only.
@@ -1419,7 +1413,7 @@
if self.subwidget_list.has_key(name):
self.tk.call(self._w, 'invoke', name)
-class TList(TixWidget):
+class TList(TixWidget, XView, YView):
TList - Hierarchy display widget which can be
used to display data in a tabular format. The list entries of a TList
widget are similar to the entries in the Tk listbox widget. The main
@@ -1502,12 +1496,6 @@
def selection_set(self, first, last=None):
self.tk.call(self._w, 'selection', 'set', first, last)
-def xview(self, *args):
-self.tk.call(self._w, 'xview', *args)
-
-def yview(self, *args):
-self.tk.call(self._w, 'yview', *args)
-
class Tree(TixWidget):
Tree - The tixTree widget can be used to display hierachical
data in a tree form. The user can adjust
@@ -1777,7 +1765,7 @@
pass
-class Grid(TixWidget):
+class Grid(TixWidget, XView, YView):
'''The Tix Grid command creates a new window and makes it into a
tixGrid widget. Additional options, may be specified on the command
line or in the option database to configure aspects such as its cursor
@@ -1865,22 +1853,6 @@
# def size dim index ?option value ...?
# def unset x y
-def xview(self):
-return self._getdoubles(self.tk.call(self, 'xview'))
-def xview_moveto(self, fraction):
-self.tk.call(self,'xview', 'moveto', fraction)
-def xview_scroll(self, count, what=units):
-Scroll right (count0) or left count of units|pages
-self.tk.call(self, 'xview', 'scroll', count, what)
-
-def yview(self):
-return self._getdoubles(self.tk.call(self, 'yview'))
-def yview_moveto(self, fraction):
-self.tk.call(self,'ysview', 'moveto', fraction)
-def yview_scroll(self, count, what=units):
-Scroll down (count0) or up count of units|pages
-self.tk.call(self, 'yview', 'scroll', count, what)
-
class ScrolledGrid(Grid):
'''Scrolled Grid widgets'''
Index: Lib/lib-tk/Tkinter.py
===
--- Lib/lib-tk/Tkinter.py (revision 58194)
+++ Lib/lib-tk/Tkinter.py (working copy)
@@ -1948,6 +1948,36 @@
Pack, Place or Grid.
pass
+class XView:
+Internal class. Add methods xview, xview_moveto, xview_scroll.
+def xview(self, *args):
+Query and change horizontal position of the view.
+if not args:
+return self._getdoubles(self.tk.call(self._w, 'xview'))
+self.tk.call((self._w, 'xview') + args)
+def xview_moveto(self, fraction):
+Adjusts the view in the window so that FRACTION of the
+total width of the canvas is off-screen to the left.
+self.tk.call(self._w, 'xview', 'moveto', fraction)
+def xview_scroll(self, number, what):
+Shift the x-view according to NUMBER which is measured in units or pages (WHAT).
+self.tk.call(self._w, 'xview', 'scroll', number, what)
+
+class YView:
+Internal class. Add methods yview, yview_moveto, yview_scroll.
+def yview(self, *args):
+Query and change vertical position of the view.
+if not args:
+return self._getdoubles(self.tk.call(self._w, 'yview'))
+self.tk.call((self._w, 'yview') + args)
+def yview_moveto(self, fraction):
+Adjusts the view in the window so that FRACTION of the
+total height of the canvas is off-screen to the top.
+self.tk.call(self._w, 'yview', 'moveto', fraction)
+def yview_scroll(self, number, what):
+Shift the y-view according to NUMBER which is measured in units or pages (WHAT).
+self.tk.call(self._w, 'yview', 'scroll', number, what)
+
class Toplevel(BaseWidget, Wm):
Toplevel widget,
[issue1177] urllib* 20x responses not OK?
Facundo Batista added the comment: Done, rev 58207. -- resolution: accepted - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1177 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1541463] Optimizations for cgi.FieldStorage methods
Bob Kline added the comment: Please note that the documentation of the keys() method of the FieldStorage class (both in the method's docstring as well as in the separate library manual) describes the method as a dictionary style keys() method. Section 3.8 of the documentation has this to say about the keys() method of a dictionary: Keys and values are listed in an arbitrary order which is non-random, varies across Python implementations, and depends on the dictionary's history of insertions and deletions. I believe the proposed implementation conforms with this specified behavior. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1541463 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1541463] Optimizations for cgi.FieldStorage methods
Georg Brandl added the comment: While this is true, there may be code relying on the current behavior, and to break that for a tiny performance gain is gratuitous breakage and should be avoided. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1541463 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1541463] Optimizations for cgi.FieldStorage methods
Bob Kline added the comment: I'm not sure I would characterize a speedup of several orders of magnitude a tiny performance gain. We had scripts with very large numbers of fields which were actually timing out. While I understand and agree with the principle of breaking as little existing code as possible, when programmers have actually been told that the method behaves the way the dictionary keys() method behaves it seems unreasonable to assume that the method will preserve the original order of fields (whatever that might mean for multiply-occurring field names). _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1541463 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
Guido van Rossum added the comment: Cartman, please refrain from using vulgarities in your sample code. It's hard to take a bug report seriously with such variable names. -- nosy: +gvanrossum __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1175] .readline() has bug WRT nonblocking files
Guido van Rossum added the comment: readline() goes through C stdio which makes it impossible to get non-blocking I/O right. You should be using raw os.read() calls (until python 3000 which will remove Python's reliance on C stdio). -- nosy: +gvanrossum resolution: - wont fix status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1175 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1772851] Decimal and long hash, compatibly and efficiently
Facundo Batista added the comment: Applied the patchs long_hash.patch (rev 58208) and decimal_hash_v2.patch (rev 58211) -- resolution: - fixed status: open - closed _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1772851 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1180] Option to ignore ~/.pydistutils.cfg
Changes by Michael Hoffman: -- components: Distutils severity: normal status: open title: Option to ignore ~/.pydistutils.cfg type: rfe versions: Python 2.6 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1180 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1180] Option to ignore or substitute ~/.pydistutils.cfg
Changes by Michael Hoffman: -- title: Option to ignore ~/.pydistutils.cfg - Option to ignore or substitute ~/.pydistutils.cfg __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1180 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1180] Option to ignore or substitute ~/.pydistutils.cfg
Changes by Sean Reifschneider: -- priority: - normal __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1180 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
Sean Reifschneider added the comment: Guido: That code came from the full-disclosure list posting, I think cartman was just passing it on. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1643369] function breakpoints in pdb
Michael Hoffman added the comment: Agree with isandler. This is not a bug. -- nosy: +hoffman _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1643369 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1180] Option to ignore ~/.pydistutils.cfg
New submission from Michael Hoffman: It would be useful if setup.py instances had an option to ignore ~/.pydistutils.cfg or substitute it with another file. For example, this would be highly useful to people who maintain a system site-packages directory along with one in their own home directory. -- nosy: +hoffman __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1180 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
James Antill added the comment: So I think this is all the places integer overflow checking is needed in imageop.c and rbgimgmodule.c. There might be checks here which can't be exploited anyway, and I haven't checked any other files yet. Feel free to comment. Ps. This is against the 2.5 in Fedora-7, but it should apply to upstream. -- nosy: +nevyn __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
Changes by James Antill: __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1181] Redefine clear() for os.environ to use unsetenv() if possible
New submission from Martin Horcicka: This patch makes os.environ.clear() to have the same effect as: for name in os.environ.keys(): del os.environ[name] I believe that most people expect the effects to be the same anyway. The practical benefit is a simpler redefinition of the whole environment if desired (e.g. in scripts run via sudo on unix systems). -- components: Library (Lib) files: os.py.patch messages: 56048 nosy: horcicka severity: normal status: open title: Redefine clear() for os.environ to use unsetenv() if possible type: behavior __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1181 __Index: Lib/os.py === --- Lib/os.py (revision 58212) +++ Lib/os.py (working copy) @@ -446,6 +446,11 @@ def __delitem__(self, key): unsetenv(key) del self.data[key.upper()] + +def clear(self): +for key in self.data.keys(): +unsetenv(key) +del self.data[key] def has_key(self, key): return key.upper() in self.data def __contains__(self, key): @@ -503,6 +508,11 @@ def __delitem__(self, key): unsetenv(key) del self.data[key] + +def clear(self): +for key in self.data.keys(): +unsetenv(key) +del self.data[key] def copy(self): return dict(self) ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
Ismail Donmez added the comment: Guido, The poc is taken as is, sorry. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1181] Redefine clear() for os.environ to use unsetenv() if possible
Changes by Sean Reifschneider: -- keywords: +patch priority: - normal __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1181 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
Ismail Donmez added the comment: nevyn: Your patch cleanly applies to python 2.4.4 and fixes the interpreter crash with poc.py Thanks. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
Guido van Rossum added the comment: Hm. First of all, it seems the imageop module has completely missed the Py_ssize_t changes. Second, I don't think that if ( x != len / y ) is a valid replacement for if ( x*y != len ) -- consider x==5, y==2, len==11. -- priority: high - __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1179] [CVE-2007-4965] Integer overflow in imageop module
James Antill added the comment: Guido: It's true that that len can be slightly bigger than x*y, the big thing is that it can't be smaller so we can malloc(len) and use upto x*y (which was my main focus). I first looked at any of this code today, but I didn't see any reason that having len be slightly larger would be a problem ... and in pretty much all cases it'll be len == x*y. However we could have both cases covered by doing: if ( (len != x*y) || (x != (len / y)) ) ...but esp. at that point it seems like we'd want some interface so that we could just do something like: if ( check_mutliplies2(len, x, y) ) __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1179 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1053365] nntplib: add support for NNTP over SSL
Changes by Reinhard Speyerer : _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1053365 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1023290] proposed struct module format code addition
Changes by Brett Cannon: -- keywords: +patch _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1023290 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
