[issue3645] readline module Crashs on OpenBSD/amd64

[Gregory P. Smith]

Changes by Gregory P. Smith <[EMAIL PROTECTED]>:


--
keywords:  -needs review

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3645] readline module Crashs on OpenBSD/amd64

[Gregory P. Smith]

Gregory P. Smith <[EMAIL PROTECTED]> added the comment:

committed to trunk (2.6) in r66179.  This should be back ported to 
release25-maint and automagically merged into py3k.

can someone with OpenBSD confirm that this has indeed fixed the problem?  
if so i'll do the 25 backport and mark it as closed instead of pending.

--
assignee:  -> gregory.p.smith
keywords: +easy
nosy: +gregory.p.smith
resolution:  -> accepted
status: open -> pending
versions:  -Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2975] VS8 include dirs grow without bound

[Jim Kleckner]

Jim Kleckner <[EMAIL PROTECTED]> added the comment:

Yes, much better.  I should have read into the interior of the
discussion rather than just the edges...

Thanks!

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3756] re.escape() does not work with bytes()

[Andrew McNamara]

Changes by Andrew McNamara <[EMAIL PROTECTED]>:


Added file: http://bugs.python.org/file11352/re_escape-patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2975] VS8 include dirs grow without bound

[Scott Dial]

Scott Dial <[EMAIL PROTECTED]> added the comment:

This patch shouldn't have been applied as it is. The definition of
"removeDuplicates" is both poorly-named, not exactly correct, and
redundant (as there is already a "normalize_and_reduce_paths") for
performing this fix on PATH. 

Jim, you acknowledged already that:

"""The normalize_and_reduce_paths() function needs to be performed on
INCLUDE and LIBPATH in addition to the exec path.  i.e.
os.environ['lib'] and os.environ['include']."""

So, I don't understand how that got missed. I've attached a patch that
removes the extra code.

Added file: http://bugs.python.org/file11351/msvc9compiler_path.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3637] 2to3 refactoring

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Gregory P. Smith reviewed the change on Rietveld, and the patch was
applied in r66173.

--
resolution:  -> accepted
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3756] re.escape() does not work with bytes()

[Andrew McNamara]

Andrew McNamara <[EMAIL PROTECTED]> added the comment:

Will do, although I'm slightly concerned that my "bytes" version of the 
function is about 50% slower than the "str" version. I can see why, I 
just can't think of a way to do it any faster. There's an inherent 
asymetry in bytes type that didn't exist before: b''.join(list(b'abc')) 
does not work. Of course, this does work: bytes(list(b'abc')), but the 
bytes constructor only accepts ints, not bytes. I'd like to see either 
the join method accept ints as well as bytes, or the bytes ctor accept 
bytes as well as ints. Or something.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

[Antoine Pitrou]

Changes by Antoine Pitrou <[EMAIL PROTECTED]>:


--
nosy: +loewis

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2975] VS8 include dirs grow without bound

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Applied both patches (a bit differently for the equal sign) as r66171.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1638033] Add httponly to Cookie module

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Well, I'm sorry but this a feature request and must be delayed for
2.7/3.1, since 2.6/3.0 are now in the release candidate phase. :-(

(as for the patch, it would be nice if it added an unit test for the new
feature)

--
nosy: +pitrou
type:  -> feature request
versions: +Python 2.7, Python 3.1 -Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1638033] Add httponly to Cookie module

[Matt Chisholm]

Matt Chisholm <[EMAIL PROTECTED]> added the comment:

Any progress on this? This patch is extremely straightforward (only
three lines of code), and should not break existing code. 

The HttpOnly extension to cookies is now supported by IE, Firefox 3.0,
and Opera. 

This article explains why HttpOnly is a good way to make cross-site
scripting attacks significantly more difficult:

http://www.codinghorror.com/blog/archives/001167.htmllop

I'd really like to see this patch applied to Cookie.py.

--
nosy: +glyphobet

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3444] add warnings for intra-package imports

[Barry A. Warsaw]

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment:

Well, this would be nice, but it doesn't seem serious enough to block
the release.

--
priority: release blocker -> critical

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3637] 2to3 refactoring

[Benjamin Peterson]

Changes by Benjamin Peterson <[EMAIL PROTECTED]>:


Added file: http://bugs.python.org/file11350/after_gps_review.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3760] PEP 3121 --- PyType_Copy is missing

[Benjamin Peterson]

Changes by Benjamin Peterson <[EMAIL PROTECTED]>:


--
assignee:  -> loewis
nosy: +loewis
priority:  -> high

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3761] urllib.request and urllib.response cannot handle HTTP1.1 chunked encoding

[Chris Leow]

New submission from Chris Leow <[EMAIL PROTECTED]>:

Hi, fairly new to Python, so not sure if this is something you want as a
behaviour or not:

urllib.response object when fetching an HTTP1.1 page does not
transparently handle "Transfer-Encoding": "chunked", and I think it should.

You can view source code for addinfourl, AbstractHTTPHandler and
HTTPHandler to verify this (sorry, I don't have line-numbers, I'm typing
this at home).

I would suggest extending addinfourl to "addinfourlchunked", for
example, to allow substitutes for fp.read(), readlines() and readline()
to be specified during the construction of addinfourl.

This threw me initially, and seems like quite a glareing omission for
newbies.

Cheers,

Chris

--
components: Library (Lib)
messages: 72366
nosy: chrisleow
severity: normal
status: open
title: urllib.request and urllib.response cannot handle HTTP1.1 chunked encoding
type: behavior
versions: Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3759] test_asyncore.py leaks handle

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

Thanks, fixed in r66162(trunk), r66163(py3k)

--
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3759] test_asyncore.py leaks handle

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Tested on Linux: each call to test.test_asyncore.test_main() opens two
file descriptors (shown in /proc//fd). The patch corrects this.

--
keywords:  -needs review
nosy: +amaury.forgeotdarc
resolution:  -> accepted

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3759] test_asyncore.py leaks handle

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto <[EMAIL PROTECTED]>:


--
keywords: +easy, needs review

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1251] ssl module doesn't support non-blocking handshakes

[Senthil]

Senthil <[EMAIL PROTECTED]> added the comment:

Yes Janssen, I checked again and found it implemented in both trunk
(py26) and py3k. All the tests pass as well.

However, in one of my testcases for issue1424152, where I expected the 
timeout to happen for do_handshake(), it did not take effect. I shall
look for the reasons.

The following is the tail from the traceback.  

  File "/usr/local/lib/python2.6/httplib.py", line 1095, in connect
self.sock = ssl.wrap_socket(sock, self.key_file, self.cert_file)
  File "/usr/local/lib/python2.6/ssl.py", line 316, in wrap_socket
suppress_ragged_eofs=suppress_ragged_eofs)
  File "/usr/local/lib/python2.6/ssl.py", line 116, in __init__
self.do_handshake()
  File "/usr/local/lib/python2.6/ssl.py", line 260, in do_handshake
self._sslobj.do_handshake()
KeyboardInterrupt

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3760] PEP 3121 --- PyType_Copy is missing

[Paul Pogonyshev]

New submission from Paul Pogonyshev <[EMAIL PROTECTED]>:

PEP 3121 at python.org mentions PyType_Copy().  However, it doesn't seem
to be present in SVN version and there is no apparent replacement. 
Please clarify how types should be created for different module
instances --- if just sharing is fine, or should some copying (which
function?) be used.

--
components: Interpreter Core
messages: 72362
nosy: _doublep
severity: normal
status: open
title: PEP 3121 --- PyType_Copy is missing
type: behavior
versions: Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3419] multiprocessing module is racy

[Jesse Noller]

Jesse Noller <[EMAIL PROTECTED]> added the comment:

r66161 on py3k merges forward the fix for this

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3729] SystemError on calling len() if __len__() doesn't return an int

[Hagen Fürstenau]

Changes by Hagen Fürstenau <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11308/len_check2.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3729] SystemError on calling len() if __len__() doesn't return an int

[Hagen Fürstenau]

Changes by Hagen Fürstenau <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11307/len_check.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3729] SystemError on calling len() if __len__() doesn't return an int

[Hagen Fürstenau]

Hagen Fürstenau <[EMAIL PROTECTED]> added the comment:

There seems to be a pronouncement now
(http://mail.python.org/pipermail/python-3000/2008-September/014692.html),
so I'm attaching a patch which clips to sys.maxsize and includes
Amaury's suggestions.

Added file: http://bugs.python.org/file11349/len_check3.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3758] "make check" suggest a testing target under GNU coding standards

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

On Tue, Sep 2, 2008 at 7:17 AM, Benjamin Peterson
<[EMAIL PROTECTED]> wrote:
>
> Benjamin Peterson <[EMAIL PROTECTED]> added the comment:
>
> Brett, how about "patchcheck"?
>

Maybe. I will see if any inspiration comes to me in the near future.
Obviously there is no rush to get this into any specific RC.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3419] multiprocessing module is racy

[Jesse Noller]

Jesse Noller <[EMAIL PROTECTED]> added the comment:

Looks like Mark's patch was submitted as part of r66115 by Ben 
accidentally (as part of reverting r66114). I can confirm this patch 
resolves the incref issue as-is. I've run test_multiprocessing in a loop 
for about an hour now with no failures. 

Marking closed/fixed

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1441530] socket read() can cause MemoryError in Windows

[Iain MacKay]

Iain MacKay <[EMAIL PROTECTED]> added the comment:

Knowing that the large read provokes the problem enables one to write
this simple workaround by subclassing IMAP4 without patching the library:

maxRead = 100
class MySSL (imaplib.IMAP4_SSL):
  def read (self, n):
#print "..Attempting to read %d bytes" % n
  if n <= maxRead:
return imaplib.IMAP4_SSL.read (self, n)
  else:
soFar = 0
result = ""
while soFar < n:
  thisFragmentSize = min(maxRead, n-soFar)
  #print "..Reading fragment size %s" % thisFragmentSize
  fragment =\
imaplib.IMAP4_SSL.read (self, thisFragmentSize)
  result += fragment
  soFar += thisFragmentSize # only a few, so not a tragic o/head
  return result 

and this works just fine.

--
nosy: +anglocelt
versions: +Python 2.5 -Python 2.4

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3660] reference leaks in 3.0

[Antoine Pitrou]

Changes by Antoine Pitrou <[EMAIL PROTECTED]>:


--
keywords: +needs review

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

Given the problems with it, I'm dropping this to normal priority and
punting to 3.1.

(the release blocker status was just temporary to ensure we got a
decision on it before rc1 - it previously didn't have a priority set)

--
keywords:  -needs review
priority: release blocker -> normal
versions: +Python 3.1 -Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Guido van Rossum]

Guido van Rossum <[EMAIL PROTECTED]> added the comment:

I wonder if we shouldn't hold off on this. It's a substantial amount of
new code. I'd be fine with it going into 3.0.1 since it's pure
optimization (IIUC!). But right now we want burn-in, not new features.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

By the way, why is this release blocker? do we have performance numbers?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3081] Py_(X)SETREF macros

[Jesús Cea Avión]

Changes by Jesús Cea Avión <[EMAIL PROTECTED]>:


--
nosy: +jcea

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

v2 of my updated patch attached to fix the issue Antoine noted.

Also gets rid of some tab-instead-of-spaces indenting issues in the
file, and avoids hardcoding PyRange_Type when creating new instances.

However, the patch still has issues, as can be seen with the new tests I
added to test_range to actually exercise some of the functionality
beyond the sys.maxsize limit.

Added file: 
http://bugs.python.org/file11348/issue2690-range-sequence-ncoghlan-v2.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3720] segfault in for loop with evil iterator

[Amaury Forgeot d'Arc]

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11317/next-nevernull.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3720] segfault in for loop with evil iterator

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Oops, sorry. I have too many files opened at the same time.
Here is an updated patch.

I removed all the "assert(PyIter_Check(it))", our evil iterator used to
make them fail anyway in debug mode; and in the case of a null function
pointer, the C stack gives the same information.

Added file: http://bugs.python.org/file11347/next-nevernull-2.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2486] Decimal slowdown in 3.0 due to str/unicode changes

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Can not get into this now, but I'll be able to deal with this in some
weeks...

--
assignee:  -> facundobatista

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3720] segfault in for loop with evil iterator

[Armin Rigo]

Armin Rigo <[EMAIL PROTECTED]> added the comment:

Maybe the file 'next-nevernull.patch' is not complete?  I don't see any
change in the definition of PyIter_Check().

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

Good catch Antoine (I missed that in Alexander's patch) - working on
that now.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[jfdp]

jfdp <[EMAIL PROTECTED]> added the comment:

To respond to a couple questions:

Adding the double quotes fixed the issue I had -- but I did very
limited testing.

The "-b" option is not support by 'file' on Solaris.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

My initial patch had a few problems - I removed it and uploaded a
corrected version.

Added file: 
http://bugs.python.org/file11346/issue2690-range-sequence-ncoghlan.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Nick Coghlan]

Changes by Nick Coghlan <[EMAIL PROTECTED]>:


Removed file: 
http://bugs.python.org/file11345/issue2690-range-sequence-ncoghlan.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

It looks like your range_subscript() forgets to compute the length field...

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2690] Precompute range length

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

This issue was missing a priority setting.

Alexander's range-sequence patch still applies cleanly to the Py3k
branch, and "make test" still runs correctly after applying it.

As Alexander notes above, range_contains does still need slightly better
handling of non-integer numbers - I suggest doing a numeric conversion
via PyNumber_Index(el) at the beginning of range_contains, and if that
conversion fails, do a conversion via PyNumber_Long(el) and immediately
return False if the result is not equal to el itself (i.e. only integer
values of non-integer types will be found in the range.

Since that explanation got kind of complicated, I've added a modified
patch that includes the above change, and adds a couple of additional
tests to ensure a non-integer floating point value won't be found in the
sequence.

--
keywords: +needs review
priority:  -> release blocker
Added file: 
http://bugs.python.org/file11345/issue2690-range-sequence-ncoghlan.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3759] test_asyncore.py leaks handle

[Hirokazu Yamamoto]

New submission from Hirokazu Yamamoto <[EMAIL PROTECTED]>:

asyncore.file_wrapper() dups passed handle, so original handle must be
closed.

--
components: Tests
files: test_asyncore.patch
keywords: patch
messages: 72343
nosy: ocean-city
severity: normal
status: open
title: test_asyncore.py leaks handle
versions: Python 2.6, Python 3.0
Added file: http://bugs.python.org/file11344/test_asyncore.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2486] Decimal slowdown in 3.0 due to str/unicode changes

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

Looks like we'll be living with the slowdown for 3.0, so marking this as
a high priority item for 3.1.

(Given that the API doesn't change, I wonder if this could be included
in a 3.0.1 release?)

--
priority:  -> high
versions: +Python 3.1 -Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2975] VS8 include dirs grow without bound

[Jim Kleckner]

Jim Kleckner <[EMAIL PROTECTED]> added the comment:

Any hope for these two patches being applied?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2975] VS8 include dirs grow without bound

[Jim Kleckner]

Jim Kleckner <[EMAIL PROTECTED]> added the comment:

Here is the equals sign fix as a separate patch file.

Added file: http://bugs.python.org/file11343/equalsInEnv.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3758] "make check" suggest a testing target under GNU coding standards

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Brett, how about "patchcheck"?

--
assignee:  -> brett.cannon
nosy: +benjamin.peterson, brett.cannon

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3589] Misleading names for multiprocessing "convenience" functions

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

Not so much "too complicated" as "potentially touches a lot of code and
not something I want to fiddle with this close to release".

As I noted on python-dev, it's actually a change that can easily be
handled through the normal API deprecation process, so it can be
reconsidered at a later date.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3758] "make check" suggest a testing target under GNU coding standards

[Ralph Corderoy]

New submission from Ralph Corderoy <[EMAIL PROTECTED]>:

A new target, "check", has been added to Makefile for 2.6.  It runs some
tests on the source code that are intended to check there's nothing
wrong before preparing a patch. 
http://svn.python.org/view/python/trunk/Makefile.pre.in?rev=61528&view=markup

Unfortunately, GNU coding standards have cemented in many people's minds
that "check" is the target for self-tests, e.g. "make clean all check
install".  http://www.gnu.org/prep/standards/standards.html#Standard-Targets

I realise Python doesn't fall under those coding standards, but none the
less it is confusing to people to re-use a standard target name for a
different use.  In the past, Python had no "check" target so people
spotted their mistake, investigated, and found the "test" target.

Please consider renaming this new "check" target, e.g. to "prepatch", to
avoid this confusion when 2.6 is released.  Perhaps a "check" target can
be added as a synonym for "test" at the same time?

--
components: Build
messages: 72337
nosy: ralph.corderoy
severity: normal
status: open
title: "make check" suggest a testing target under GNU coding standards
type: behavior
versions: Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1868] threading.local doesn't free attrs when assigning thread exits

[Christian Heimes]

Christian Heimes <[EMAIL PROTECTED]> added the comment:

Amaury Forgeot d'Arc wrote:
> Maybe __dict__ should be special-cased in local_getattro()?

With the patch it's also no longer possible to get a list of attribute
names. +1 for special casing __dict__ in getattro and setattro.
setattr(local, "__dict__", egg) should raise an AttributeError.

Christian

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1868] threading.local doesn't free attrs when assigning thread exits

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

With the patch, subclasses of threading.local seem to have an empty
__dict__:

import threading
class MyLocal(threading.local):
pass

l = MyLocal()
l.x = 2
l.__dict__   # returns {}

Maybe __dict__ should be special-cased in local_getattro()?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3617] Add MS EULA to the list of third-party licenses in the Windows installer

[Marc-Andre Lemburg]

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment:

Raising priority since this needs to be resolved prior to the final
release of Python 2.6/3.0.

Regarding finding the eula.txt in the VS2008 installation, there doesn't
appear to be a generic way. The eula.txt is stored in a folder named
after the installed version of VS2008. Finding the installation folder
is easy (use VS90COMNTOOLS env setting), but determining the product
name doesn't look as easy.

Perhaps there's some registry trick we could pull off ?!

--
priority: critical -> release blocker

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1868] threading.local doesn't free attrs when assigning thread exits

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

The patch is basically fine with me. While reviewing it I've found out
that threading.local doesn't have cyclic garbage collecting enabled.
I've opened a new issue for it in #3757.

--
nosy: +pitrou

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3757] threading.local doesn't support cyclic garbage collecting

[Antoine Pitrou]

New submission from Antoine Pitrou <[EMAIL PROTECTED]>:

tp_traverse and tp_clear on threading.local are defined, but the
Py_TPFLAGS_HAVE_GC flag is not set. As a result, cycles are not collected:

>>> import threading, weakref
>>> o = threading.local()
>>> class X(object): pass
... 
>>> x = X()
>>> x.o = o
>>> o.x = x
>>> wr = weakref.ref(x)
>>> del x, o
>>> import gc
>>> gc.collect()
0
>>> wr()
<__main__.X object at 0x9bb0dc4>

--
components: Extension Modules, Library (Lib)
messages: 72332
nosy: pitrou
severity: normal
status: open
title: threading.local doesn't support cyclic garbage collecting
type: behavior
versions: Python 2.6, Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3733] Adding bin and Scripts folder into PATH

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

See the long discussion in issue3561.

--
nosy: +amaury.forgeotdarc
resolution:  -> duplicate
status: open -> closed
superseder:  -> Windows installer should add Python and Scripts directories to 
the PATH environment variable

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

OK, I understand. And I must apologizes about previous
my patch.

  fileout = _architecture_split(output)[1:]

should not be deleted. It was should be changed to

  fileout = _architecture_split(output)

Thank you.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Marc-Andre Lemburg]

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment:

Checked in as r66145 and r66146.

--
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Marc-Andre Lemburg]

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment:

On 2008-09-02 12:55, Hirokazu Yamamoto wrote:
> Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:
> 
> Well, if python was installed into directory named
> "foo ELF boo", python will say wrong architecture.
> 
 import platform
 platform.architecture()
> ('32bit', 'ELF')
> 
> Is it not good to use "file -b" option?

Well, I'd say that install path is rather unlikely to occur in real
life ;-)

I'm not sure how wide-spread support for the -b option is, so we'd
have to check during the next release cycle.

--
title: platform.py: _syscmd_file() can't handle target path with space or 
special shell character -> platform.py: _syscmd_file() can't handle target path 
with  space or special shell character

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

Well, if python was installed into directory named
"foo ELF boo", python will say wrong architecture.

>>> import platform
>>> platform.architecture()
('32bit', 'ELF')

Is it not good to use "file -b" option?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3747] Fix caching in ABCMeta.__subclasscheck__

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

2.6 fixed in r66144, merged to 3.0 in r66147

--
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Marc-Andre Lemburg]

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment:

Updated the Python versions.

--
versions: +Python 2.5, Python 2.6, Python 3.0 -Python 2.4

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Marc-Andre Lemburg]

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment:

Using subprocess is only possible conditionally, ie. if available.
Please note that the module is intended to be usable with multiple
Python versions and must at least support Python 2.1.

We could consider an updated patch for 2.7 and 3.1, but not for 2.6/3.0,
since it needs more testing.

I think for 2.6/3.0, adding the extra quotes is enough to get things
working.

Please open a new patch ticket for your patch and update it to work with
popen if subprocess is not available. The patch should also not remove
the lines:

-if sys.platform in ('dos','win32','win16','os2'):
-# XXX Others too ?
-return default

from _syscmd_file().

I'll checkin the extra quotes.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3748] platform.architecture() prints bogus message on windows

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

Well, should I backport this to release25-maint branch?
(If accepted, issue3719 as well)

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

[off topic]
I used cygwin to create this patch, but platform.architecture()[1]
becomes empty string because sys.executable in cygwin points to
directory. (at least before installing)

Python 2.6b3+ (trunk:66142M, Sep  2 2008, 17:09:46)
[GCC 3.4.4 (cygming special, gdc 0.12, using dmd 0.125)] on cygwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.executable
'/home/WhiteRabbit/python-dev/trunk/python'

I workarounded this by inserting "target = './python.exe'" in
_syscmd_file, but sorry if this patch won't work.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3719] platform.py: _syscmd_file() can't handle target path with space or special shell character

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

Can you try this patch?

1. used "file -b" option to eliminate file path. Otherwide, re.split
won't work because file path will contain space like this. (I hope -b
option can be used anywhere "file" command exists)

a b/python.exe: MS-DOS executable PE  for MS Windows (console) Intel
80386 32-bit

2. used subprocess module instead of popen. subprocess is useful when
argument contains space or quote like this issue.

--
keywords: +patch
nosy: +ocean-city
Added file: http://bugs.python.org/file11342/platform.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3352] Deficiencies in multiprocessing/threading API

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

Thanks!

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1160] Medium size regexp crashes python

[Adi]

Adi <[EMAIL PROTECTED]> added the comment:

Is there any progress on this bug? I am currently considering
maintaining a branch of 2.5.2 which includes the patch suggested by effbot.

--
nosy: +adi

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3548] subprocess.pipe function

[Legoll Vincent]

Legoll Vincent <[EMAIL PROTECTED]> added the comment:

On Mon, Sep 1, 2008 at 5:13 PM, Amaury Forgeot d'Arc
<[EMAIL PROTECTED]> wrote:
> Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:
>
> Vincent,
> GPL licenced code is incompatible with the inclusion into python.
> And if I am correct, you should sign a contributor agreement. Then the
> licence text is not necessary.

This is not a patch against python, this is a standalone script, just
implementing the same functionality as the original bug report in a
slightly different way...

But thanks for the input anyways.

If this functionality is really interesting people and agreed to be integrated
into upstream subprocess module, I can rework it the right way, or work
from the original patch from the bug report.

--
nosy: +vlegoll

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com