[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: You can open script made in python 2.x and it stops immediately working after saving, if it is coding-aware. You can have bigger project and use idle for editing config and text files from this project too. It is unfair to change without notification the encodings. Or do you consider IDLE just for beginners for learning? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: I forgot about Perhaps IDLE should offer to convert it on opening. That would be nice, too. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Martin v. Löwis mar...@v.loewis.de added the comment: Here is a patch to provide an explicit message that the file will be converted when the file is opened (also querying what encoding should be converted from), answering the complaint that the conversion is without notice. If you want to edit Python 2.x scripts with IDLE 3, you need to add encoding declarations to the files. For bigger projects, it is reasonable to expect that they do add these declarations. Again, please only report one issue at the time. You chose to make Python source files the topic of this issue, so please don't divert into config or text files. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: Sorry, where is the patch? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Changes by Martin v. Löwis mar...@v.loewis.de: -- keywords: +patch Added file: http://bugs.python.org/file12561/conv.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Changes by Martin v. Löwis mar...@v.loewis.de: -- keywords: +needs review priority: - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4796] Decimal to receive from_float method
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: -- assignee: rhettinger - marketdickinson keywords: +needs review -patch Added file: http://bugs.python.org/file12562/decimal2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4796 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4796] Decimal to receive from_float method
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: Removed file: http://bugs.python.org/file12558/decimal.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4796 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: OK, I got it. In my opinion it would nice if user can either convert file to utf8 or to do nothing and add new encodings declaration or cancel. Current Cancel gives an Decoding error. If you give an encodings that doesn't exist, it shouldn't destroy IDLE. Hoping its not my mistake, cause I do not have all files from 3.1a - just those from idlelib. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4796] Decimal to receive from_float method
Mark Dickinson dicki...@gmail.com added the comment:
Instead of the repeated divisions and Inexact tests, how about a direct
approach: n/2**k = (n*5**k)/10**k, so something like:
sign = 0 if copysign(1.0, self) == 1.0 else 1
n, d = abs(self).as_integer_ratio()
k = d.bit_length() - 1
return _dec_from_triple(sign, str(n*5**k), -k)
should work, and would likely be faster too.
I also think the sign of 0 should be preserved: i.e.,
Decimal.from_float(-0.0)
Decimal('-0')
Am still reviewing---more comments to come.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4796
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4816] Patch of itertools.{combinations, permutations} for empty combinations
New submission from Thomas Finley tfin...@gmail.com:
This is a patch for the Python 3.1 build checked out from
http://svn.python.org/projects/python/branches/py3k
The current behavior of itertools.combinations(iterable,r) and
itertools.permutations(iterable,r) is to throw a ValueError if iterable
yields fewer than r items. This changes these functions so the
generator instead yields 0 items.
As for my argument for acceptance, while the original behavior is not a
bug insofar as its implementation was deliberate, I'd argue this is
undesirable on grounds of mathematical consistency and functionality.
In mathematics the choose function is defined as (n choose r)=0 for
rn, so itertools.combinations' behavior is inconsistent with its
obvious combinatorial analogy. (Similar for permutations and the
combinatorial P function.)
For functionality I'll cite my own case as anecdote. In writing
regression tests I wanted to ensure that a group of items obeyed a
certain mutually consistent property between all triples. (Something
akin to the triangle inequality.) So:
all(triangle_respected(*triple) for triple in
itertools.combinations(group, 3))
If len(group)=2, that's fine, since with no triangles there is no
inconsistency, and all(())==True. However, the code failed with a
ValueError when groups were that small. Working around this was fairly
awkward, since I wanted to continue to fail noisily if my
triangle_respected function threw a ValueError, and I wasn't sure at all
that it wouldn't if my items were
The patch modifies Modules/itertoolsmodule.c slightly, changing
combinationsobject_new and permutationsobject_new. (Deleting the error
throwing code, and have one line changes in both structures to handle
the nr case. One could handle this special case more efficiently than
I do by not bothering to allocate certain structures in this case, but I
didn't want to tempt fate.) The patch also changes the appropriate
tests in Lib/test/test_itertools.py .
Obviously, this would break code that depends upon Python throwing
ValueError in the event of the combination or permutation sequence being
empty. However, I hope given that combinations and permutations are a
relative novelty that their behavior in this corner case is not yet
etched in stone.
Sorry if this belongs in a PEP -- it seems quite minor, but I don't
quite have a feel what the threshold is.
--
components: Library (Lib), Tests
files: itertools-empty-combinations.diff
keywords: patch
messages: 78943
nosy: TFinley
severity: normal
status: open
title: Patch of itertools.{combinations,permutations} for empty combinations
type: behavior
versions: Python 3.1
Added file: http://bugs.python.org/file12563/itertools-empty-combinations.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4816
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4608] urllib.request.urlopen does not return an iterable object
Jakub Wilk uba...@users.sf.net added the comment: Oops, __next__ is OK. Sorry for the confusion. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4608 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4817] PyOS_GetLastModificationTime is unused
New submission from Ulrich Eckhardt eckha...@satorlaser.com: This is just to record that the above function is wrongly documented, inconsistently implemented, but fortunately unused, so it can be removed. In addition to the patch attached, there are two files that can be removed: Python/getmtime.c RISCOS/Python/getmtime_riscos.c -- components: Interpreter Core files: python-2.7-eradicate-getmtime.0.patch keywords: patch messages: 78945 nosy: eckhardt severity: normal status: open title: PyOS_GetLastModificationTime is unused type: resource usage versions: Python 2.7 Added file: http://bugs.python.org/file12564/python-2.7-eradicate-getmtime.0.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4817 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4751] Patch for better thread support in hashlib
Changes by ebfe knabberknusperh...@yahoo.de: Removed file: http://bugs.python.org/file12557/md5module_small_locks.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4796] Decimal to receive from_float method
Mark Dickinson dicki...@gmail.com added the comment: A couple more things: 1. There's a typo 'equilvalent' in the decimal.py part of the patch. 2. Can I suggest using return d._fix(self) instead of return self.plus(d) in create_decimal_from_float. The plus method does two things: rounds to the current context *and* converts -0.0 to 0.0; we only want the first of these. (It's always been a source of mild irritation to me that there's no public method for simply rounding a Decimal to a given context---i.e., a public equivalent of _fix.) -- assignee: marketdickinson - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4796 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4818] Patch for thread-support in md5module.c
New submission from ebfe knabberknusperh...@yahoo.de: Here is another patch, this time for the fallback-md5-module. I know that situations are rare where openssl is not present but threading is. However they might occur out there and the md5module needed some love anyway: - The MD5 class from the fallback module can now also use threads with 'small locks' - The behaviour regarding unicode data input is now consistent as to what the openssl-driven classes do. - Some code cleanup. I might act on the sha modules as way the next days. sha256.c still accepts 's#'... Also see issue #4751 -- files: md5module_small_locks.diff keywords: patch messages: 78947 nosy: ebfe severity: normal status: open title: Patch for thread-support in md5module.c Added file: http://bugs.python.org/file12565/md5module_small_locks.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4818 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Martin v. Löwis mar...@v.loewis.de added the comment: In my opinion it would nice if user can either convert file to utf8 or to do nothing and add new encodings declaration or cancel. Ypu can still add an encoding declaration after the file got converted. Cancelling is also possible. If you give an encodings that doesn't exist, it shouldn't destroy IDLE. Right. Here is a patch that fixes that. Added file: http://bugs.python.org/file12566/conv.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Changes by Martin v. Löwis mar...@v.loewis.de: Removed file: http://bugs.python.org/file12561/conv.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4818] Patch for thread-support in md5module.c
Martin v. Löwis mar...@v.loewis.de added the comment: ebfe, please identify yourself with a real name; please also sign a contributor form. -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4818 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4812] Junk in the decimals namespace
Mark Dickinson dicki...@gmail.com added the comment: Done (r68191 through r68194). -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4812 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4816] Patch of itertools.{combinations, permutations} for empty combinations
Mark Dickinson dicki...@gmail.com added the comment: I agree that the proposed behaviour seems more correct: the collection of all subsets of size 4 of range(3) is perfectly valid and well-defined; it just happens to be empty. I've also encountered this in practice (in code that was enumerating partitions of a list into a fixed number of pieces), but in my case it was easier to work around. I guess the counterargument is that the current ValueError might catch bugs early; I don't know how often this is true in practice. In any case, this is Raymond's call. -- assignee: - rhettinger nosy: +marketdickinson, rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4816 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4751] Patch for better thread support in hashlib
ebfe knabberknusperh...@yahoo.de added the comment:
Haypo, we can probably reduce overhead by defining ENTER_HASHLIB like this:
#define ENTER_HASHLIB(obj) \
if ((obj)-lock) { \
if (!PyThread_acquire_lock((obj)-lock, 0)) { \
Py_BEGIN_ALLOW_THREADS \
PyThread_acquire_lock((obj)-lock, 1); \
Py_END_ALLOW_THREADS \
} \
}
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4751
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1717] Get rid of more refercenes to __cmp__
Mark Dickinson dicki...@gmail.com added the comment: [Georg Brandl, on spark.py] This is used by asdl_c.py which generates Python-ast.c -- it should be updated. The only issue here is a single comment, which reads: # GenericASTMatcher. AST nodes must have __getitem__ and __cmp__ Still, I'm reluctant to remove or alter the comment without understanding why it was there in the first place. If someone more familiar with AST stuff can confirm that __cmp__ is definitely no longer needed, I'll remove the mention of it from the comment. Misc/cheatsheet This needs a general overhaul. I'll open a separate issue for this, if that's okay with everyone. Presumably 3.0.1 doesn't need to wait for Misc/cheatsheet to be updated. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1717 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1717] Get rid of more references to __cmp__
Changes by Martin v. Löwis mar...@v.loewis.de: -- title: Get rid of more refercenes to __cmp__ - Get rid of more references to __cmp__ ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1717 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4580] slicing of memoryviews when itemsize != 1 is wrong
Changes by Martin v. Löwis mar...@v.loewis.de: -- keywords: -needs review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4580 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4580] slicing of memoryviews when itemsize != 1 is wrong
Changes by Martin v. Löwis mar...@v.loewis.de: -- assignee: - pitrou resolution: - accepted ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4580 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4818] Patch for thread-support in md5module.c
Lukas Lueg knabberknusperh...@yahoo.de added the comment: Sent the form by fax ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4818 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4819] Misc/cheatsheet needs updating
New submission from Mark Dickinson dicki...@gmail.com: Misc/cheatsheet could do with an upgrade, both for the 2.x and 3.x branches. For 3.x, I guess the changes needed are quite extensive. I'm not sure how much needs to be changed or added for 2.x; at a quick glance, the 'with' statement, the 'x if b else y' construction, and the unified try-except-finally are missing. -- assignee: georg.brandl components: Documentation messages: 78955 nosy: georg.brandl, marketdickinson severity: normal status: open title: Misc/cheatsheet needs updating versions: Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4819 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4753] Faster opcode dispatch on gcc
Antoine Pitrou pit...@free.fr added the comment: I'm not an expert in this kind of optimizations. Could we gain more speed by making the dispatcher table more dense? Python has less than 128 opcodes (len(opcode.opmap) == 113) so they can be squeezed in a smaller table. I naively assume a smaller table increases the amount of cache hits. I don't think so. The end of the current table, which doesn't correspond to any valid opcodes, will not be cached anyway. The upper limit to be considered is the maximum value for a valid opcode, which is 147. Reducing that to 113 may reduce cache pressure, but only by a tiny bit. Of course, only experimentation could tell us for sure :) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4753 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4806] Function calls taking a generator as star argument can mask TypeErrors in the generator
Hagen Fürstenau hfuerste...@gmx.net added the comment: I'm getting confused about whether it's actually desired behaviour that generators can be star arguments. The error message seems to say it's not: argument after * must be a sequence. The docs seem to agree: If the syntax *expression appears in the function call, expression must evaluate to a sequence. However test_extcall specifically tests function calls with (non-sequence) iterables as star arguments. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4806 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Changes by STINNER Victor victor.stin...@haypocalc.com: Removed file: http://bugs.python.org/file11200/tkinter_remove_mainloop.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
STINNER Victor victor.stin...@haypocalc.com added the comment: Tkapp_Mainloop is supposed to work both as a module function and a method, and it tests for self to find out which case it is. Now, this test is apparently broken in 3.x, ... Ok. In Python 2.x, selfptr is NULL whereas selfptr is a pointer to the module in Python 3.x. New attached patch uses PyModule_Check() to check if selfptr is the module or an object. if that function is removed, the code to support it should also be removed. Which code? I don't see which code uses _tkinter.mainloop. I saw code that calls the method mainloop() of a Tkapp object, like tkinter.mainloop() does. Or am I wrong? Added file: http://bugs.python.org/file12567/_tkinter_mainloop.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Martin v. Löwis mar...@v.loewis.de added the comment: Ok. In Python 2.x, selfptr is NULL whereas selfptr is a pointer to the module in Python 3.x. New attached patch uses PyModule_Check() to check if selfptr is the module or an object. The patch looks right in principle. Please make sure not to include printf calls in it. Please also consider all similar cases, such as Tkapp_CreateFileHandler. if that function is removed, the code to support it should also be removed. Which code? The code inside the function: all tests whether self is NULL. If mainloop would stop being a module function, this code also should go. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4811] invalid reST markup in several documents
Akira Kitada akit...@gmail.com added the comment: Could you also fix the indentation of Queues example code at http://docs.python.org/library/multiprocessing.html#exchanging-objects-between-processes ? -- nosy: +akitada ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4811 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Guilherme Polo ggp...@gmail.com added the comment: Victor, you seem to be confusing code that supports it with functions that use it. There are some conditional code inside Tkapp_MainLoop that depends on self being available, that is what Martin meant by code that supports it, and since it would no longer be a module function that code would no longer be needed. Now, I'm much more in favour to remove it from moduleMethods than from adjusting it to work in py3k. My reasons for the moment are: 1) To me, it makes much more sense to call a mainloop function from a Tcl interpreter object than from a module; 2) There is a member named dispatching in TkappObject, so I believe when this tcl/tk bridge was created -- or at least when this member was added -- it had the intention to allow multiple mainloops at some time (or is it really only intended to be used when trying to grab the thread that created the tcl interpreter ?); 3) It reduces code :) Although the reason #2 won't just work after removing mainloop from the module functions, it also doesn't help keeping it there. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4818] Patch for thread-support in md5module.c
Lukas Lueg knabberknusperh...@yahoo.de added the comment: fixed naming, lock get's tried before releasing the gil to wait for it Added file: http://bugs.python.org/file12568/md5module_small_locks-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4818 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4818] Patch for thread-support in md5module.c
Changes by Lukas Lueg knabberknusperh...@yahoo.de: Removed file: http://bugs.python.org/file12565/md5module_small_locks.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4818 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4820] ctypes.util.find_library incorrectly documented
New submission from David M. Beazley beaz...@users.sourceforge.net: In the ctypes reference / Finding shared libraries section of the ctypes documentation, the find_library() function is described as being located in ctypes.util. However, it's formal description right below that lists it as ctypes.find_library(). -- assignee: georg.brandl components: Documentation messages: 78964 nosy: beazley, georg.brandl severity: normal status: open title: ctypes.util.find_library incorrectly documented versions: Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4820 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Martin v. Löwis mar...@v.loewis.de added the comment: Now, I'm much more in favour to remove it from moduleMethods than from adjusting it to work in py3k. Would you apply the same reasoning to the other Tkapp methods available on _tkinter? IIRC, these functions were there first; the Tkapp object was added later. The module functions are kept for compatibility (which we were free to break in 3.0). I'm not opposed to removing these module functions now (not even for 3.0.1), but... 1) To me, it makes much more sense to call a mainloop function from a Tcl interpreter object than from a module; To me, it makes perfect sense. Windowing events are a global, and not specific to a Tcl interpreter - before receiving it, you cannot know (in general) what interpreter it is for. Indeed, Tcl's Tcl_DoOneEvent doesn't take a Tcl_Interp* parameter. 2) There is a member named dispatching in TkappObject, so I believe when this tcl/tk bridge was created -- or at least when this member was added -- it had the intention to allow multiple mainloops at some time (or is it really only intended to be used when trying to grab the thread that created the tcl interpreter ?); This entire machinery got added when Tcl started supporting threads in a way fundamentally different from Python's support for threads. Tcl is inherently single-threaded, no GIL. To support threads, you create a new interpreter for each new thread, and the different interpreters are completely independent from each other. So when a Tkinter application passes a Tcl command from one thread to another, this would crash or otherwise not work. In the old days, Python's threading could be used with Tcl just fine; any thread could make Tk calls (on Unix, at least). When Tcl threading was added, I tried to preserve this mode, by making one thread the Tcl thread. Any other Python thread can't make direct Tcl calls (since those would get to a different interpreter), but instead an RPC system based on Tcl's thread synchronization was added. As this RPC depends on the Tcl mainloop, the dispatching member tells the caller if the Tcl thread is up. So, no: the dispatching member is there for continued support of a single mainloop, not for multiple mainloops. 3) It reduces code :) That is a good reason. We would still need a complete patch. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: seems to be working. Seems to me now I get it. The file encoding is ruled by the encoding declaration. When I stated # -*- coding: cp1250 -*- then the file would be saved in cp1250. Now hoping that I would keep this issue, cause it comes with this patches: when I open file *with* say # -*- coding: cp1250 -*-, I am asked to change to utf8. This behaviour was not before and is probably unwanted. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Martin v. Löwis mar...@v.loewis.de added the comment: Now hoping that I would keep this issue, cause it comes with this patches: when I open file *with* say # -*- coding: cp1250 -*-, I am asked to change to utf8. This behaviour was not before and is probably unwanted. Actually, the behavior was there before - it's just that conversion was silent. If you put an empty line after the coding declaration, it should work well. issue 4008 contains a patch for that problem. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
STINNER Victor victor.stin...@haypocalc.com added the comment: Victor, you seem to be confusing code that supports it with functions that use it Oh ok, I didn't understood what code that supports it mean. There are some conditional code inside Tkapp_MainLoop that depends on self being available, that is what Martin meant by code that supports it, and since it would no longer be a module function that code would no longer be needed. Yes, right. I also prefer smaller code base with same functions ;-) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Guilherme Polo ggp...@gmail.com added the comment: Martin v. Löwis mar...@v.loewis.de added the comment: Now, I'm much more in favour to remove it from moduleMethods than from adjusting it to work in py3k. Would you apply the same reasoning to the other Tkapp methods available on _tkinter? As I see all those functions that are calling into Tcl should be moved from the module functions. Some parts of the code inside these functions are conflicting with each other, while one will try to allow multiple threads, the other part will just disallow it. And since to follow the Tcl appartment model we need to access some of the members in TkappObject it just makes me want to remove those functions even more. IIRC, these functions were there first; the Tkapp object was added later. The module functions are kept for compatibility (which we were free to break in 3.0). I'm not opposed to removing these module functions now (not even for 3.0.1), but... 1) To me, it makes much more sense to call a mainloop function from a Tcl interpreter object than from a module; To me, it makes perfect sense. Windowing events are a global, and not specific to a Tcl interpreter - before receiving it, you cannot know (in general) what interpreter it is for. Indeed, Tcl's Tcl_DoOneEvent doesn't take a Tcl_Interp* parameter. That is way to see it. But what I was taking into account was something like the proper update of the dispatching member for different interpreters, this would mean dispatching could be used to stop a running mainloop by setting it to 0. 2) There is a member named dispatching in TkappObject, so I believe when this tcl/tk bridge was created -- or at least when this member was added -- it had the intention to allow multiple mainloops at some time (or is it really only intended to be used when trying to grab the thread that created the tcl interpreter ?); This entire machinery got added when Tcl started supporting threads in a way fundamentally different from Python's support for threads. Tcl is inherently single-threaded, no GIL. To support threads, you create a new interpreter for each new thread, and the different interpreters are completely independent from each other. So when a Tkinter application passes a Tcl command from one thread to another, this would crash or otherwise not work. That is exactly one of the reasons to move mainloop and others from the moduleMethods. It is hard for me to accept the two distinct behaviours present in _tkinter, which are based from where you call the function. In the old days, Python's threading could be used with Tcl just fine; any thread could make Tk calls (on Unix, at least). When Tcl threading was added, I tried to preserve this mode, by making one thread the Tcl thread. Any other Python thread can't make direct Tcl calls (since those would get to a different interpreter), but instead an RPC system based on Tcl's thread synchronization was added. As this RPC depends on the Tcl mainloop, the dispatching member tells the caller if the Tcl thread is up. But I don't see a RPC being used there, I just see some polling. So, no: the dispatching member is there for continued support of a single mainloop, not for multiple mainloops. 3) It reduces code :) That is a good reason. We would still need a complete patch. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: Well, thanks a lot. (aware this is really off this issue): Now I even get the system of patches - issue 4008 solved the inconvenience in print Unicode signs inside IDLE. Still not sure how works patches for Python versions. I vote for including this a that patch about IDLE even in some 3.0.1, not only in branch 3.1. In non-English speaking countries troubles with encodings are more common, more beginners-frustrating than you can believe. HNY 2009 Pavel Kosina ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Martin v. Löwis mar...@v.loewis.de added the comment: But I don't see a RPC being used there, I just see some polling. Consider Tkapp_Call (e.g.). If this is invoked in the Tk interpreter thread, then there is a direct call to Tcl_EvalObjv/Tkapp_CallResult. If the call is made from a different thread, then a Tkapp_CallEvent is allocated, filled with the parameters, and Tkapp_ThreadSend is invoked. This puts the event into the thread queue of the receiving thread, and waits for a condition. In the interpreter thread, Tkapp_CallProc is invoked, which extracts the arguments from the event, invokes Tcl_EvalObj/Tkapp_CallResult, and notifies the condition. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Martin v. Löwis mar...@v.loewis.de added the comment: I vote for including this a that patch about IDLE even in some 3.0.1, not only in branch 3.1. This is my plan, yes - hence I marked them all release-critical. They still need review. I agree that IDLE in 3.0 is fairly broken wrt. non-ASCII characters. I knew that before the release, but there is so much work and only so little time. FWIW, my own language (German) also uses (some) non-ASCII characters. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Guilherme Polo ggp...@gmail.com added the comment: Martin v. Löwis mar...@v.loewis.de added the comment: But I don't see a RPC being used there, I just see some polling. Consider Tkapp_Call (e.g.). If this is invoked in the Tk interpreter thread, then there is a direct call to Tcl_EvalObjv/Tkapp_CallResult. If the call is made from a different thread, then a Tkapp_CallEvent is allocated, filled with the parameters, and Tkapp_ThreadSend is invoked. This puts the event into the thread queue of the receiving thread, and waits for a condition. In the interpreter thread, Tkapp_CallProc is invoked, which extracts the arguments from the event, invokes Tcl_EvalObj/Tkapp_CallResult, and notifies the condition. This is all true but the dispatching isn't used there actually. dispatching is being used in a polling manner to try to catch the thread running the tcl interpreter which someone tried to call into, the code then proceeds to do what you described. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Martin v. Löwis mar...@v.loewis.de added the comment: This is all true but the dispatching isn't used there actually. dispatching is being used in a polling manner to try to catch the thread running the tcl interpreter which someone tried to call into, the code then proceeds to do what you described. Right. If the main thread doesn't actually invoke mainloop(), the Tcl events don't get dispatched, and the RPC system breaks down, effectively leading to a deadlock. To prevent application breakage during startup, a grace period is added in case applications create threads before starting the mainloop. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4821] Patches for thread-support in built-in SHA modules
New submission from Lukas Lueg knabberknusperh...@yahoo.de: Here is the follow-up to issue #4818. The patches attached allow the built-in SHA modules to release the GIL. Also the build-in SHA modules will now no longer accept s# as input. Input is parsed just as in the openssl-driven classes where unicode-objects are explicitly rejected. The built-in hash modules have been not quite beautiful before even more code is now copy pasted between them. Is there any interest in refactoring all those modules? AFAIK _sha1 and such are only used by hashlib.py ... -- messages: 78975 nosy: ebfe severity: normal status: open title: Patches for thread-support in built-in SHA modules ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4821 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4751] Patch for better thread support in hashlib
Antoine Pitrou pit...@free.fr added the comment: I'm not sure about the approach of dynamically allocating self-lock. Imagine you allocate this lock while another thread is between ENTER_HASHLIB and LEAVE_HASHLIB. What happens on LEAVE_HASHLIB? The thread tries to release a lock it hadn't acquired (because the lock was NULL at the time). Is it simply ignored? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4821] Patches for thread-support in built-in SHA modules
Changes by Lukas Lueg knabberknusperh...@yahoo.de: -- keywords: +patch Added file: http://bugs.python.org/file12569/sha1module_small_locks.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4821 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4821] Patches for thread-support in built-in SHA modules
Changes by Lukas Lueg knabberknusperh...@yahoo.de: Added file: http://bugs.python.org/file12570/sha256module_small_locks.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4821 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4821] Patches for thread-support in built-in SHA modules
Changes by Lukas Lueg knabberknusperh...@yahoo.de: Added file: http://bugs.python.org/file12571/sha512module_small_locks.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4821 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4580] slicing of memoryviews when itemsize != 1 is wrong
Antoine Pitrou pit...@free.fr added the comment: The patch is committed in r68200, r68202. Thanks! ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4580 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4822] Fix indentation in memoryobject.c
New submission from Antoine Pitrou pit...@free.fr: The rules state new files should be indented with 4-spaces, but indentation has no consistent indentation: parts of it are indented with tabs, others with spaces. We could probably reindent it all with 4-spaces, especially since it hasn't been backported to trunk yet (and the versions in py3k and 3.0 should be identical). -- messages: 78978 nosy: pitrou priority: low severity: normal status: open title: Fix indentation in memoryobject.c type: behavior versions: Python 3.0, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4822 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4580] slicing of memoryviews when itemsize != 1 is wrong
Changes by Antoine Pitrou pit...@free.fr: -- resolution: accepted - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4580 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4751] Patch for better thread support in hashlib
Lukas Lueg knabberknusperh...@yahoo.de added the comment: The lock is created while having the GIL in EVP_update. No other function releases the GIL (besides the creator-function which does not need the local lock). Thereby no other thread can be in between ENTER and LEAVE while the lock is allocated. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4817] PyOS_GetLastModificationTime is unused
Martin v. Löwis mar...@v.loewis.de added the comment: Thanks for the patch. Committed as r68203 and r68204. -- nosy: +loewis resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4817 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4753] Faster opcode dispatch on gcc
Changes by djc dirk...@ochtman.nl: -- nosy: +djc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4753 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4822] Fix indentation in memoryobject.c
Georg Brandl ge...@python.org added the comment: I think this is the kind of reindention that Guido approved of on python-dev, along with unicodeobject.c. -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4822 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4822] Fix indentation in memoryobject.c
Benjamin Peterson benja...@python.org added the comment: +1 -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4822 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4823] idle height and place
New submission from Pavel Kosina g...@post.cz: Nearly always (after opening) is IDLE window outside visible area. Mainly the status bar is hidden under bottom windows menu bar. Same situation happens when choosing Window-Zoom Height from IDLE menu. xpsp3, 1024x768, py2.x-3.x -- components: IDLE messages: 78983 nosy: geon severity: normal status: open title: idle height and place type: behavior versions: Python 2.5, Python 2.6, Python 2.7, Python 3.0, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4823 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3959] Add Google's ipaddr.py to the stdlib
Duncan McGreggor duncan.mcgreg...@gmail.com added the comment: I am a contributor to netaddr, having deprecated my own old and crufty IP address library in its favor. JP's comments on the library in this ticket are included in the set of reasons that I initially chose it to replace my own. When I first looked at the ipaddr code a month ago, the features I was delighted to see in the ipaddr project include address exclusion and address collapsing (we'd been discussing these features in netaddr since my old project had similar functionality). Perhaps the following might be a prudent course: * determine how small or big a standard library ip address module or subpackage should be; * have a mutual discussion on the netaddr and ipaddr mail lists to determine what would need to be changed in each project in order to support inclusion in the standard lib; * choose the option that requires the least code changes (simple naming convention changes should probably be given less weight than any changes to logic). As for shutting down any project that is chosen, does such an action not leave older Python versions out in the cold? Shouldn't the project remain open to support Python versions 2.7, with a highly visible note that the code is included in 2.7/3.1+? (I am completely ignorant of related Python development policy.) -- nosy: +oubiwann ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3959 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3959] Add Google's ipaddr.py to the stdlib
Martin v. Löwis mar...@v.loewis.de added the comment: Perhaps the following might be a prudent course: This sounds all good. It is better if the experts in a domain make a recommendation, than if some random committer makes a choice. As for shutting down any project that is chosen, does such an action not leave older Python versions out in the cold? Shouldn't the project remain open to support Python versions 2.7, with a highly visible note that the code is included in 2.7/3.1+? Of course - hence I said eventually. The project could continue to maintain the external version as long as they please, provided it doesn't diverge from the in-core version (unless it is the in-core version itself that diverges). What I don't want to see happen is that the community recommends at some point to ignore the outdated crappy version in the core, and replace it with the more-powerful bug-fixed version available separately. This has happened in the past, so I'm extremely cautious here. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3959 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4822] Fix indentation in memoryobject.c
Antoine Pitrou pit...@free.fr added the comment: Here's a patch. -- keywords: +patch Added file: http://bugs.python.org/file12572/reindent-memview.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4822 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3959] Add Google's ipaddr.py to the stdlib
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3959 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4822] Fix indentation in memoryobject.c
Georg Brandl ge...@python.org added the comment: Do you expect a review? ;) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4822 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3959] Add Google's ipaddr.py to the stdlib
Duncan McGreggor duncan.mcgreg...@gmail.com added the comment: As for shutting down any project that is chosen, does such an action not leave older Python versions out in the cold? Shouldn't the project remain open to support Python versions 2.7, with a highly visible note that the code is included in 2.7/3.1+? Of course - hence I said eventually. The project could continue to maintain the external version as long as they please, provided it doesn't diverge from the in-core version (unless it is the in-core version itself that diverges). What I don't want to see happen is that the community recommends at some point to ignore the outdated crappy version in the core, and replace it with the more-powerful bug-fixed version available separately. This has happened in the past, so I'm extremely cautious here. Fantastic! Thanks for the clarification. David, in the event of netaddr's complete or partial inclusion, are you +1 with this and the maintenance of an ip/net library in Python? Guido, what is your preference regarding feature set/size for an ip/net library in Python? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3959 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3959] Add Google's ipaddr.py to the stdlib
Antoine Pitrou pit...@free.fr added the comment: If there's going to be lots of discussion, perhaps it should be taken to python-dev? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3959 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Antoine Pitrou pit...@free.fr added the comment: It is committed now in py3k and the 3.0 maintenance branch. Thanks all for your participation! -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4823] idle height and place
Pavel Kosina g...@post.cz added the comment: sorry it is duplicate to issue 3286 pls close ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4823 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3286] IDLE opens window too low on Windows
Pavel Kosina g...@post.cz added the comment: +1 -- nosy: +geon versions: +Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3286 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4796] Decimal to receive from_float method
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: The direct method is *much* faster! Applied Mark's suggestions. Committed as r68208 and r68211 . -- resolution: - fixed status: open - closed versions: +Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4796 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4822] Fix indentation in memoryobject.c
Antoine Pitrou pit...@free.fr added the comment: Ok, committed. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4822 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4823] idle height and place
Changes by Guilherme Polo ggp...@gmail.com: -- resolution: - duplicate status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4823 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3329] API for setting the memory allocator used by Python
Neil Richardson richyn...@gmail.com added the comment: I'll be in agreement here. I integrated Python into a game engine not too long ago, and had to a do a fair chunk of work to isolate Python into it's own heap - given that fragmentation on low memory systems can be a bit of a killer. Would also make future upgrades a heck of a lot easier too, as there'd be no need to do a search for all references and carefully replace them all. -- nosy: +neilo versions: +Python 2.5, Python 2.6, Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3329 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Antoine Pitrou pit...@free.fr added the comment: Reopening, the patch actually produces failures when run with python -bb, that is there are comparisons between str and bytes. See the errors at the end of http://www.python.org/dev/buildbot/3.x.stable/ppc%20Debian%20unstable%203.0/builds/26/step-test/0 -- resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Antoine Pitrou pit...@free.fr added the comment: People, does this patch look ok to you? Added file: http://bugs.python.org/file12573/wsgiref-bb.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Guilherme Polo ggp...@gmail.com added the comment: Here is a patch, two actually. The next one deprecates the functions in trunk Added file: http://bugs.python.org/file12574/issue3638.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Changes by Guilherme Polo ggp...@gmail.com: Added file: http://bugs.python.org/file12575/deprecated_funcs.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Dmitry Vasiliev d...@hlabs.spb.ru added the comment: Antoine Pitrou wrote: People, does this patch look ok to you? Oh, didn't know about -bb. The patch looks OK for me. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Antoine Pitrou pit...@free.fr added the comment: Le samedi 03 janvier 2009 à 20:24 +, Dmitry Vasiliev a écrit : Dmitry Vasiliev d...@hlabs.spb.ru added the comment: Antoine Pitrou wrote: People, does this patch look ok to you? Oh, didn't know about -bb. Well, it's meant to catch potential bugs. str and bytes always compare unequal in py3k (i.e. a != ba), so it's good to use -bb when porting some stuff from 2.x. There's another problem in that buildbot failure with the environment variable NO_PROXY. We'll see if it's still there after the patch. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Martin v. Löwis mar...@v.loewis.de added the comment: These look fine. I think further changes are necessary: tkinter/__init__.py tries to load createfilehandler/deletefilehandler; this becomes redundant. Also, why did you leave DoOneEvent and Quit as-is - don't they fall into the same category? One minor nit: I personally dislike function pointer casts, because they can easily go wrong. I rather prefer if the C compiler tells me when I mess up with function pointer types. Hence _tkinter uses selfptr/self all the time. -- assignee: - gpolo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Dmitry Vasiliev d...@hlabs.spb.ru added the comment: Antoine Pitrou wrote: There's another problem in that buildbot failure with the environment variable NO_PROXY. We'll see if it's still there after the patch. Strange error and it seems there is only part of the traceback. I've already seen such partially displayed Python 3 traceback and error actually can be in very different place. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Antoine Pitrou pit...@free.fr added the comment: Strange error and it seems there is only part of the traceback. I've already seen such partially displayed Python 3 traceback and error actually can be in very different place. If you can reproduce such a problem, please open a bug. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: I might have another problem with this patch and maybe also that one in issue 4008. Having a file with print (ěščřžýáíé) # saved in cp1250 Open - confirm converting to utf8 - F5 - error: see attached file idleunicode1.jpg Added file: http://bugs.python.org/file12576/idleunicode1.jpg ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Dmitry Vasiliev d...@hlabs.spb.ru added the comment: Antoine Pitrou wrote: Strange error and it seems there is only part of the traceback. I've already seen such partially displayed Python 3 traceback and error actually can be in very different place. If you can reproduce such a problem, please open a bug. OK, I'll try to reproduce. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Martin v. Löwis mar...@v.loewis.de added the comment: print (ěščřžýáíé) # saved in cp1250 I can't reproduce the problem. Can you please attach the exact file that failed to work? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Guilherme Polo ggp...@gmail.com added the comment: These look fine. I think further changes are necessary: tkinter/__init__.py tries to load createfilehandler/deletefilehandler; this becomes redundant. Indeed, I forgot to look into the Python code. I also see as redundant the checks for _tkinter._flatten and _tkinter._cnfmerge, the former because if we are still on Tkinter.py (or __init__.py in py3k) then _tkinter exists and _flatten is there too, the latter because there is no _cnfmerge in _tkinter. Also, why did you leave DoOneEvent and Quit as-is - don't they fall into the same category? Ah, it is nice you ask this. I was indeed going to move then, but I noticed strange things with DoOneEvent which made me only remove those functions that were already checking the thread id of the caller and the interp creator. But rethinking about this, it seems to make more sense to do the move now and fix the strange things in other patch. The problems I noticed may be a bit off-topic for this specific issue, but I would hate to just say I had problems with a function and don't say which errors I got, and how I got, so I have to write. So, the problem started when I noticed DoOneEvent doesn't check for python errors after Tcl_DoOneEvent returns, making me try to get one of those SystemErrors NULL result without error -- I failed to get it, but I got other unexpected results: I get an empty string with the text below, but I was expecting some nameerror message: import _tkinter def mybgerror(errmsg): print errmsg called = [] def bad(): called.append(True) raise InvalidThing x = _tkinter.create() x.createcommand(bad, bad) x.createcommand(bgerror, mybgerror) x.call(after, 1, bad) while not called: _tkinter.dooneevent() _tkinter.dooneevent() I ended up finding another problem (or problems, I forgot to annotate them), like with call: import _tkinter def bad(): raise InvalidThing x = _tkinter.create() x.createcommand(bad, bad) x.call(bad) Results in: Traceback (most recent call last): File my_badtests/test1.py, line 7, in module x.call(bad) _tkinter.TclError Meaning call is overwriting a python error by a tcl error, but since there was no error in the tcl interpreter the error message was empty (too many errors in a message). But these all would deserve another(s) issues, so I will be moving quit and dooneevent from there too. One minor nit: I personally dislike function pointer casts, because they can easily go wrong. I rather prefer if the C compiler tells me when I mess up with function pointer types. Hence _tkinter uses selfptr/self all the time. Fine. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Guilherme Polo ggp...@gmail.com added the comment: I get an empty string with the text below, but I was expecting some s/text/test ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: Martin v. Löwis napsal(a), dne 3.1.2009 22:24: I can't reproduce the problem. Can you please attach the exact file that failed to work? You can use that one that is already here: cp1250.py. It is the same error with me. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] tkinter.mainloop() is meaningless and crash: remove it
Martin v. Löwis mar...@v.loewis.de added the comment: But these all would deserve another(s) issues, so I will be moving quit and dooneevent from there too. I haven't tried reproducing these problems, but this all sounds plausible. So go ahead and check in all the changes for this issue. Don't forget Misc/NEWS entries, and don't forget to svnmerge block the 2.7 change from being merged into 3.k. You should then also merge the 3k change into the 3.0 branch. I don't think we have to merge the warnings into 2.6 (but could if we wanted to). Leave the various revision numbers in this report when done. If you rather prefer me to check it in, please let me know. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Martin v. Löwis mar...@v.loewis.de added the comment: You can use that one that is already here: cp1250.py. It is the same error with me. Ok, then what are the exact steps to reproduce? What code base, what patches applied, what user interaction in what order? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: Microsoft Windows XP [Verze 5.1.2600] (C) Copyright 1985-2001 Microsoft Corp. C:\prg\Python30\Lib\idlelibsvn update# from http://svn.python.org/projects/python/branches/py3k/Lib/idlelib Restored 'AutoCompleteWindow.py' Restored 'ToolTip.py' Restored 'UndoDelegator.py' Restored 'Bindings.py' Restored '__init__.py' Restored 'AutoComplete.py' Restored 'configHandler.py' Restored 'HyperParser.py' Restored 'ColorDelegator.py' Restored 'Delegator.py' Restored 'ObjectBrowser.py' Restored 'testcode.py' Restored 'configSectionNameDialog.py' Restored 'ZoomHeight.py' Restored 'PyShell.py' Restored 'ParenMatch.py' Restored 'config-keys.def' Restored 'Debugger.py' Restored 'CREDITS.txt' Restored 'configDialog.py' Restored 'StackViewer.py' Restored 'HISTORY.txt' Restored 'SearchEngine.py' Restored 'ReplaceDialog.py' Restored 'ScriptBinding.py' Restored 'ChangeLog' Restored 'tabbedpages.py' Restored 'keybindingDialog.py' Restored 'configHelpSourceEdit.py' Restored 'WidgetRedirector.py' Restored 'GrepDialog.py' Restored 'FormatParagraph.py' Restored 'EditorWindow.py' Restored 'help.txt' Restored 'config-highlight.def' Restored 'PyParse.py' Restored 'README.txt' Restored 'rpc.py' Restored 'OutputWindow.py' Restored 'aboutDialog.py' Restored 'idle.bat' Restored 'TODO.txt' Restored 'config-main.def' Restored 'IdleHistory.py' Restored 'PathBrowser.py' Restored 'IOBinding.py' Restored 'WindowList.py' Restored 'ScrolledList.py' Restored 'ClassBrowser.py' Restored 'FileList.py' Restored 'CallTips.py' Restored 'idle.py' Restored 'CodeContext.py' Restored 'textView.py' Restored 'SearchDialogBase.py' Restored 'CallTipWindow.py' Restored 'SearchDialog.py' Restored 'RemoteObjectBrowser.py' Restored 'idlever.py' Restored 'RemoteDebugger.py' Restored 'TreeWidget.py' Restored 'NEWS.txt' Restored 'idle.pyw' Restored 'run.py' Restored 'config-extensions.def' Restored 'AutoExpand.py' Restored 'Percolator.py' Restored 'dynOptionMenuWidget.py' Restored 'extend.txt' Restored 'MultiStatusBar.py' Restored 'MultiCall.py' Restored 'macosxSupport.py' At revision 68230. C:\prg\Python30\Lib\idlelibpatch conv.diff patching file IOBinding.py C:\prg\Python30\Lib\idlelibpatch idle_encoding_4.patch patching file ScriptBinding.py patching file IOBinding.py - Run IDLE - Open cp1250.py - confirm converting to utf8 - F5 (immediately, no change in code!) - error: see attached file idleunicode1.jpg All the other python code base is clean 3.0. xpsp3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4718] wsgiref package totally broken
Dmitry Vasiliev d...@hlabs.spb.ru added the comment: Attached patch for test_urllib, possible source of the NO_PROXY problem. Added file: http://bugs.python.org/file12577/no_proxy.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4718 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Martin v. Löwis mar...@v.loewis.de added the comment: I see. Here is a revised patch. This sets the modified flag on the buffer after conversion, so that you get asked to save it before running it. Added file: http://bugs.python.org/file12578/conv.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] Remove module level functions in _tkinter that depend on TkappObject
Guilherme Polo ggp...@gmail.com added the comment: Thanks Martin, trunk: r68231 (blocked on py3k) py3k: r68237 release30-maint: r68239 -- resolution: - fixed status: open - closed title: tkinter.mainloop() is meaningless and crash: remove it - Remove module level functions in _tkinter that depend on TkappObject versions: +Python 2.7, Python 3.1 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4753] Faster opcode dispatch on gcc
Changes by Yann Ramin at...@stackworks.net: -- nosy: +theatrus ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4753 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4815] idle 3.1a1 utf8
Pavel Kosina g...@post.cz added the comment: Yes. God job. ;-) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4815 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3638] Remove module level functions in _tkinter that depend on TkappObject
Guilherme Polo ggp...@gmail.com added the comment: Uh, I forgot about the code removal in __init__ in the first commits. r68242, r68244 now ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3638 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
