[issue8108] test_ftplib fails with OpenSSL 0.9.8m

[Darryl Miles]

Darryl Miles  added the comment:

In order to build Python with a specific version of OpenSSL followed the CYGWIN 
instructions and edited Modules/Setup to make it read (note - I added 
"-L$(SSL)" into the linker options too, since by default on CentOS 5.4 i386 
OpenSSL build in static library mode ala ../openssl-1.0.0/libssl.a) :

SSL=../openssl-1.0.0
_ssl _ssl.c \
-DUSE_SSL -I$(SSL)/include -I$(SSL)/include/openssl \
-L$(SSL)/lib -L$(SSL) -lssl -lcrypto


It is not clear to me what Python's goals are:
 * To be backward compatible, in which case I don't know your historical use of 
SSL_shutdown().
 * To be a thin-layer (1:1) over OpenSSL, so that "power users" can harness the 
full potential of OpenSSL if they are willing to understand the finer points.
 * To provide a full-featured Python API.
 * To provide a Python API that is easy to use within the Python paradigm.

These goals may not be convergent.

--
nosy: +dlmiles
Added file: http://bugs.python.org/file16838/python_ssl.c.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8354] siginterrupt with flag=False is reset when signal received

[Andrew Bennetts]

New submission from Andrew Bennetts :

The effect of signal.siginterrupt(somesig, False) is reset the first time a 
that signal is received.  This is not the documented behaviour, and I do not 
think this is a desireable behaviour.  It renders siginterrupt effectively 
useless at providing the robustness against EINTR it is intended to provide.

Attached is a fairly simple program to show this using SIGWINCH: run it in a 
resizeable terminal, and resize it twice.  Notice that on the second terminal 
resize (i.e. the second SIGWINCH signal) the program crashes with an EINTR from 
the os.read.

A partial workaround for the problem is to call signal.siginterrupt(somesig, 
False) again inside your signal handler, but it's very fragile.  It depends on 
Python getting a chance to run the Python function registered by the 
signal.signal call, but this is not guaranteed.  If there's frequent IO, that 
workaround might suffice.  For the sig-test.py example attached to this bug, it 
doesn't (try it).

The cause seems to be that signal_handler in signalmodule.c unconditionally 
does PyOS_setsig(sig_num, signal_handler) [except for SIGCHLD], which 
unconditionally invokes siginterrupt(sig, 1).  A possible fix would be to add a 
'int siginterrupt_flag;' to the Handlers array, and arrange for that value to 
be passed instead of the hard-coded 1.  Another might be to not call 
PyOS_setsig from signal_handler at all -- I'm not sure why it is trying to 
reinstall itself, but perhaps there's some issue there I'm not aware of.

--
components: Library (Lib)
files: sig-test.py
messages: 102688
nosy: spiv
severity: normal
status: open
title: siginterrupt with flag=False is reset when signal received
type: behavior
versions: Python 2.6
Added file: http://bugs.python.org/file16837/sig-test.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8352] imp.find_module of a .py ending dir causes glibc double free crash

[Shashwat Anand]

Shashwat Anand  added the comment:

mkdir bla.py; python -c 'import imp; imp.find_module("bla", ["."])'

This causes bpython to crash after the first input char if such a
directory exist.

I am sure you do not mean 'bpython intepretor' here.

--
nosy: +l0nwlf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4007] make clean fails to delete .a and .so.X.Y files

[Shashwat Anand]

Shashwat Anand  added the comment:

skip.montanaro forgot to attached the patch obviously, however the issue is 
trivial but there i.e. the presence of libpython.a file.

--
nosy: +l0nwlf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7443] test.support.unlink issue on Windows platform

[Tim Golden]

Tim Golden  added the comment:

This is basically a rerun of this discussion a couple of years ago:

  http://mail.python.org/pipermail/python-dev/2008-April/078333.html

The problem certainly still happens against trunk -- I have a semi-aggressive 
test-harness which can cause it to reproduce pretty much on-demand. I proposed 
an approach here:

  http://mail.python.org/pipermail/python-dev/2008-April/078339.html

but when I started digging into test_support it all got a bit hairy because -- 
naturally -- test.support.unlink is used in a *lot* of places. In short, 
there's still a problem to be fixed. I believe that a rename-unlink dance would 
solve it, but only at the cost of affecting a lot of tests.

--
nosy: +tim.golden

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8353] Negative exponentiation behaving oddly in python shell

[Chris Ward]

Chris Ward  added the comment:

Thanks for clearing that up and pointing me in the right direction. I should 
have tested print first. The assumption was based on the evaluation of (-4) ** 
2 within an expression, which does return correctly. I hadn't made the 
distinction that the parentheses made it evaluate differently by containing the 
unary.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8350] os.mkdir doc comment is incorrect

[Shashwat Anand]

Shashwat Anand  added the comment:

Tested on trunk. 

11:46:02 l0nwlf-MBP:python-svn $ ./python.exe 
Python 2.7a4+ (trunk:79888M, Apr  9 2010, 11:41:22) 
[GCC 4.2.1 (Apple Inc. build 5646) (dot 1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import posix
>>> posix.mkdir('1')
>>> posix.mkdir('2', 000)
>>> posix.mkdir('3', mode=000)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: mkdir() takes no keyword arguments
>>> import os
>>> os.mkdir('4', 777)
>>> os.mkdir('5', mode=777)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: mkdir() takes no keyword arguments
>>> 

The two options to fix this are:
1. Patch python-svn/Modules/posixmodule.c to take the keyword arguments.
2. Modify the PyDoc in posixmodule.c as Todd suggested.

I had attached a patch which solves the issue using solution '2'. 

Also I observed that os.makedirs() have no such issue even though it uses 
os.mkdir() because it uses 'mkdir(name, mode)' to call mkdir.

--
keywords: +patch
nosy: +l0nwlf
versions: +Python 2.7
Added file: http://bugs.python.org/file16836/posixmodule.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8353] Negative exponentiation behaving oddly in python shell

[Martin v . Löwis]

Martin v. Löwis  added the comment:

This is expected behavior. The power operator binds with higher precedence than 
the unary minus:

http://docs.python.org/reference/expressions.html#unary-arithmetic-and-bitwise-operations

Therefore, your term is interpreted as

-(4 ** 2)

As for "it only affects the prompt": I can't reproduce that. If I put

print(-4**2)

in a script and run that, it still prints -16 for me.

--
nosy: +loewis
resolution:  -> invalid
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8353] Negative exponentiation behaving oddly in python shell

[Chris Ward]

New submission from Chris Ward :

When using exponentiation interactively in the python shell, it returns all 
negative results when a negative number is the input. For example:

-4 ** 2 will return -16
-4 ** 2 should evaluate as -4 * -4, which correctly returns 16

This does not occur when using the 'Run Module' feature of IDLE and the 
exponentiation is processed from the module, it only seems to occur when 
directly typed into the interactive prompt. I couldn't find anything to suggest 
this is expected behavior. Using pow() from the prompt returns the correct 
result, so it only happens in this one situation. Obviously this is low 
priority since it only affects the prompt and there's a working alternative, 
but I figured I'd report it anyways. :)

--
components: IDLE
messages: 102681
nosy: CWardUSC
severity: normal
status: open
title: Negative exponentiation behaving oddly in python shell
type: behavior
versions: Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7978] SocketServer doesn't handle syscall interruption

[Vetoshkin Nikita]

Vetoshkin Nikita  added the comment:

I vote for making a global wrapper. As neologix pointed - many other modules 
can be (or are) affected. Futher found bugs could be fixed using that global 
wrapper.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4007] make clean fails to delete .a and .so.X.Y files

[Martin v . Löwis]

Martin v. Löwis  added the comment:

If it did eat the patch, we would have lost it by now: there is nothing in the 
history that shows that a file was attached at some point. More likely, Skip 
forgot to attach it when submitting this report.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8351] Suppress large diffs in unitttest.TestCase.assertSequenceEqual()

[Ezio Melotti]

Changes by Ezio Melotti :


--
versions: +Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8026] strftime bug when timedelta is negative

[Daniel Diniz]

Daniel Diniz  added the comment:

Confirmed on trunk, needs a simpler repro :)

--
components: +Library (Lib) -None
nosy: +ajaksu2
priority:  -> normal
stage:  -> test needed
versions: +Python 2.6, Python 2.7 -Python 2.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4007] make clean fails to delete .a and .so.X.Y files

[Daniel Diniz]

Daniel Diniz  added the comment:

Skip, was there a patch here? I can't find it in the bug lists, so I think we 
both missed it?

Pinging Martin in case the tracker ate the patch :)

--
nosy: +ajaksu2, loewis
stage:  -> needs patch
versions: +Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8351] Suppress large diffs in unitttest.TestCase.assertSequenceEqual()

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
priority:  -> normal
stage:  -> patch review
versions: +Python 3.2 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3985] removed string module from distutils [patch]

[Ezio Melotti]

Ezio Melotti  added the comment:

Patch looks good.
There's only a missing space before the for in:
+self.metadata.platforms = [kw.strip() 
+  for kw in platformlist.split(',')]

--
nosy: +ezio.melotti
resolution:  -> accepted
stage:  -> patch review
versions: +Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8352] imp.find_module of a .py ending dir causes glibc double free crash

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +brett.cannon, ncoghlan
priority:  -> high
stage:  -> test needed
type:  -> crash
versions:  -Python 2.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7378] unexpected truncation of traceback

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
versions: +Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5207] extend strftime/strptime format for RFC3339 and RFC2822

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7132] Regexp: capturing groups in repetitions

[Ezio Melotti]

Changes by Ezio Melotti :


--
status: open -> languishing

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7927] SSL socket is not closed properly

[Daniel Diniz]

Daniel Diniz  added the comment:

Confirmed on trunk.

--
nosy: +ajaksu2
priority:  -> normal
stage:  -> test needed
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7943] Memory leak due to circular references in ssl.SSLSocket

[Daniel Diniz]

Changes by Daniel Diniz :


--
priority:  -> normal
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7842] py_compile.compile SyntaxError output

[Daniel Diniz]

Daniel Diniz  added the comment:

Change went into py3k without tests, do we want them? If so, please update 
Stage to "test needed".

--
nosy: +ajaksu2
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7865] io close() swallowing exceptions

[Daniel Diniz]

Daniel Diniz  added the comment:

Wouldn't this break code that currently works?

--
nosy: +ajaksu2
priority:  -> low
stage:  -> needs patch
type:  -> behavior
versions:  -Python 2.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5207] extend strftime/strptime format for RFC3339 and RFC2822

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7584] datetime.rfcformat() for Date and Time on the Internet

[Éric Araujo]

Éric Araujo  added the comment:

Should have checked before speaking. RFC 3339 is a subset of W3CDTF, as said on 
Daniel’s first link.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7584] datetime.rfcformat() for Date and Time on the Internet

[Éric Araujo]

Éric Araujo  added the comment:

Note that the Atom format requires a subset of RFC 3339 (which is in turn a 
subset of ISO 8601 if I remember correctly, and is the same as the W3C Datetime 
Format): https://www.tools.ietf.org/html/rfc4287#section-3.3

Summary: Atom requires using an uppercase T between date and time (the RFC 
permits lower and upper case), and using an uppercase Z for UTC timezone, not 
“-00:00”.

Regards

--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7584] datetime.rfcformat() for Date and Time on the Internet

[Daniel Diniz]

Daniel Diniz  added the comment:

It looks like feed generators need this feature[1]. See also issue 5207 and a 
current implementation[2].

[1] http://validator.w3.org/feed/docs/error/InvalidRFC3339Date.html
[2] http://code.google.com/p/formattime/

--
keywords: +easy
nosy: +ajaksu2
priority:  -> normal
stage:  -> needs patch
type:  -> feature request

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8156] pybsddb 4.8.4 integration

[Jesús Cea Avión]

Changes by Jesús Cea Avión :


--
resolution:  -> accepted
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7378] unexpected truncation of traceback

[Daniel Diniz]

Daniel Diniz  added the comment:

Patch still applies to py3k, not applying cleanly to trunk anymore. Tests pass 
with patch on py3k.

--
nosy: +ajaksu2
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7425] [PATCH] Improve the robustness of "pydoc -k" in the face of broken modules

[Daniel Diniz]

Daniel Diniz  added the comment:

Nice improvement. This would also solve the "help(), modules" brokenness, right?

--
nosy: +ajaksu2
priority:  -> normal
stage:  -> test needed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7897] Support parametrized tests in unittest

[Yaroslav Halchenko]

Yaroslav Halchenko  added the comment:

In PyMVPA we have our little decorator as an alternative to Fernando's 
generators,  and which is closer, I think, to what Michael was wishing for:
@sweepargs

http://github.com/yarikoptic/PyMVPA/blob/master/mvpa/testing/sweepargs.py

NB it has some minor PyMVPA specificity which could be easily wiped out, and 
since it was at most 4 eyes looking at it and it bears "evolutionary" changes, 
it is far from being the cleanest/best piece of code, BUT:

* it is very easy to use, just decorate a test method/function and give an 
argument which to vary within the function call, e.g smth like

@sweepargs(arg=range(5))
def test_sweepargs_demo(arg):
ok_(arg < 5)
ok_(arg < 3)
ok_(arg < 2)

For nose/unittest it would still look like a single test

* if failures occur, sweepargs groups failures by the type/location of the 
failures and spits out a backtrace for one of failures + summary (instead of 
detailed backtraces for each failure) specifying which arguments lead to what 
error... here is the output for example above:

$> nosetests -s test_sweepargs_demo.py
F
==
FAIL: mvpa.tests.test_sweepargs_demo.test_sweepargs_demo
--
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.5/nose/case.py", line 183, in runTest
self.test(*self.arg)
  File "/usr/lib/pymodules/python2.5/nose/util.py", line 630, in newfunc
return func(*arg, **kw)
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa/tests/test_sweepargs_demo.py", line 
11, in test_sweepargs_demo
ok_(arg < 2)
  File "/usr/lib/pymodules/python2.5/nose/tools.py", line 25, in ok_
assert expr, msg
AssertionError: 
 Different scenarios lead to failures of unittest test_sweepargs_demo (specific 
tracebacks are below):
  File "/home/yoh/proj/pymvpa/pymvpa/mvpa/tests/test_sweepargs_demo.py", line 
10, in test_sweepargs_demo
ok_(arg < 3)
File "/usr/lib/pymodules/python2.5/nose/tools.py", line 25, in ok_
assert expr, msg
  on
arg=3 
arg=4 

  File "/home/yoh/proj/pymvpa/pymvpa/mvpa/tests/test_sweepargs_demo.py", line 
11, in test_sweepargs_demo
ok_(arg < 2)
File "/usr/lib/pymodules/python2.5/nose/tools.py", line 25, in ok_
assert expr, msg
  on
arg=2 

--
Ran 1 test in 0.003s

FAILED (failures=1)

* obviousely multiple decorators could be attached to the same test, to test on 
all combinations of more than 1 argument but output atm is a bit cryptic ;-)

--
nosy: +Yaroslav.Halchenko

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7370] patch: BaseHTTPServer reinventing rfc822 date formatting

[R. David Murray]

Changes by R. David Murray :


--
title: patch: BaseHTTPServer reinventing rfc822 -> patch: BaseHTTPServer 
reinventing rfc822 date formatting

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7370] patch: BaseHTTPServer reinventing rfc822

[R. David Murray]

Changes by R. David Murray :


--
versions: +Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7370] patch: BaseHTTPServer reinventing rfc822

[R. David Murray]

R. David Murray  added the comment:

The issue is not invalid. The code duplication should be removed, but using the 
email module as Éric suggests.  Reopening.

--
nosy: +r.david.murray
resolution: invalid -> 
stage: committed/rejected -> test needed
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue870479] Scripts need platform-dependent handling

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue976869] Stripping script extensions with distutils

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4151] Separate build dir broken

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3985] removed string module from distutils [patch]

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5411] add xz compression support to distutils

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1649329] gettext.py incompatible with eggs

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7370] patch: BaseHTTPServer reinventing rfc822

[Éric Araujo]

Éric Araujo  added the comment:

Following the last link on #2859, I’ve found that “rfc822.formatdate(time)” can 
be changed to “email.utils.formatdate(time, usegmt=True)”.

I’ll make a real diff in a few days if noone beats me to it.

Regards

--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7370] patch: BaseHTTPServer reinventing rfc822

[Daniel Diniz]

Daniel Diniz  added the comment:

Thanks for the patch. Per issue 2849, use of rfc822 should be gone from the 
stdlib. Please re-open if you disagree.

--
nosy: +ajaksu2
priority:  -> normal
resolution:  -> invalid
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7443] test.support.unlink issue on Windows platform

[Jason R. Coombs]

Changes by Jason R. Coombs :


--
nosy: +jaraco

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Jason R. Coombs  added the comment:

It seems issue7443 discusses the cause of the transient failures.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8352] imp.find_module of a .py ending dir causes glibc double free crash

[Matthias Klose]

New submission from Matthias Klose :

[forwarded from http://bugs.debian.org/577005]

seen with 2.5.5, 2.6.5 and 2.7alpha4:

The imp.find_module function causes a glibc double free or corruption if
it would be invoked with a directory with a ".py" ending. It can be
reproduced with:

mkdir bla.py; python -c 'import imp; imp.find_module("bla", ["."])'

This causes bpython to crash after the first input char if such a
directory exist.


stacktrace with 2.6.5:
(gdb) bt
#0  0x00355906 in *__GI_raise (sig=6) at 
../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00358e05 in *__GI_abort () at abort.c:88
#2  0x0038c78d in __libc_message (do_abort=2, fmt=0x453088 "*** glibc detected 
*** %s: %s: 0x%s ***\n")
at ../sysdeps/unix/sysv/linux/libc_fatal.c:173
#3  0x00396905 in malloc_printerr (action=2, str=0x453230 "double free or 
corruption (!prev)", ptr=
0x83004e0) at malloc.c:6239
#4  0x003981a3 in _int_free (av=0x46f3c0, p=0x83004d8) at malloc.c:4772
#5  0x0039b22d in *__GI___libc_free (mem=0x83004e0) at malloc.c:3738
#6  0x00386b55 in _IO_new_fclose (fp=0x83004e0) at iofclose.c:88
#7  0x08116efc in call_find_module (name=0xb7f52a54 "bla", path=['.']) at 
../Python/import.c:2844
#8  0x08117011 in imp_find_module (self=, args=('bla', 
['.']))
at ../Python/import.c:2865
#9  0x081b1755 in PyCFunction_Call (func=, arg=
('bla', ['.']), kw=) at ../Objects/methodobject.c:81
#10 0x080fbf03 in call_function (pp_stack=0xb3cc, oparg=2) at 
../Python/ceval.c:3750
#11 0x080f75ac in PyEval_EvalFrameEx (f=File , line 1, in  (), 
throwflag=0)
at ../Python/ceval.c:2412
#12 0x080f9c48 in PyEval_EvalCodeEx (co=0xb7fe6da8, globals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }, 
locals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }, 
args=0x0, argcount=0, kws=0x0, kwcount=0, defs=0x0, 
defcount=0, closure=) at ../Python/ceval.c:3000
#13 0x080efd6b in PyEval_EvalCode (co=0xb7fe6da8, globals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }, 
locals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }) at 
../Python/ceval.c:541
#14 0x0812376c in run_mod (mod=0x83565c0, filename=0x81ef6b1 "", 
globals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }, 
locals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }, 
flags=0xb6c0, arena=0x82f5700)
at ../Python/pythonrun.c:1339
#15 0x08123640 in PyRun_StringFlags (str=0x82e5008 "import imp; 
imp.find_module(\"bla\", [\".\"])\n", 
start=257, globals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }, 
locals=
{'__builtins__': , '__name__': '__main__', 
'__package__': None, '__doc__': None, 'imp': }, 
flags=0xb6c0) at ../Python/pythonrun.c:1302
#16 0x081223e9 in PyRun_SimpleStringFlags (command=
0x82e5008 "import imp; imp.find_module(\"bla\", [\".\"])\n", 
flags=0xb6c0)
at ../Python/pythonrun.c:961
#17 0x0805e3f6 in Py_Main (argc=3, argv=0xb7b4) at ../Modules/main.c:521
#18 0x0805d51f in main (argc=3, argv=0xb7b4) at ../Modules/python.c:23

--
components: Interpreter Core
messages: 102662
nosy: doko
severity: normal
status: open
title: imp.find_module of a .py ending dir causes glibc double free crash
versions: Python 2.5, Python 2.6, Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7163] IDLE suppresses sys.stdout.write() return value

[Daniel Diniz]

Daniel Diniz  added the comment:

sys.stdout is a idlelib.rpc.RPCProxy in IDLE. It calls 
Idlelib.PyShell.PseudoFile.write ->
.PyShell.write -> 
.OutputWindow.OutputWindow.write ->
.Percolator.Percolator.insert ->
...

I suppose we could mimic the return value patching PseudoFile.write (for 
educational purposes?).

--
nosy: +ajaksu2
priority:  -> normal
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7978] SocketServer doesn't handle syscall interruption

[Antoine Pitrou]

Changes by Antoine Pitrou :


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7978] SocketServer doesn't handle syscall interruption

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Ok, I think the wrapper approach is a good one. Now remains to decide whether 
it should stay private to socketserver or be exposed as a generic method (for 
example in the "os" module as proposed).

By the way, adding a test would be nice, too. I'm not sure it what form it 
should be done; perhaps register a signal handler and trigger the signal from a 
sub-thread while the main thread is iterating in a select loop?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7978] SocketServer doesn't handle syscall interruption

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Ok, I think the wrapper approach is a good one. Now remains to decide whether 
it should stay private to socketserver or be exposed as a generic method (for 
example in the "os" module as proposed).

By the way, adding a patch would be nice, too. I'm not sure it what form it 
should be done; perhaps register a signal handler and trigger the signal from a 
sub-thread while the main thread is iterating in a select loop?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Removed file: http://bugs.python.org/file16203/admin results.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Removed file: http://bugs.python.org/file16202/guest results.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Added file: http://bugs.python.org/file16835/guest results - patch 29.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Jason R. Coombs  added the comment:

With patch 29, I believe all patch-related test failures are corrected.

The remaining failures in some modules (namely test_tarfile, test_glob, 
test_mailbox, test_warnings) can be demonstrated to occur in unpatched builds. 
Since some failures are transient, I created repeat_test, which I used to 
demonstrate that test_glob, test_tarfile, and test_mailbox will fail on a clean 
build.

Additionally, I'm including test output for 32- and 64-bit builds on the 
unpatched build, the patched build running under administrator, and the patched 
build running under guest.

The test output was generated in an automated fashion to guarantee a clean 
build. The build process can be found by easy_installing jaraco.develop==1.1.1 
and running test-python-symlink-patch.py (VS9, GNU patch, and svn required).

--
Added file: http://bugs.python.org/file16832/repeat_test.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Added file: http://bugs.python.org/file16834/admin results - patch 29.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Added file: http://bugs.python.org/file16833/admin results - no patch.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5747] knowing the parent command

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3992] removed custom log from distutils

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6087] distutils.sysconfig.get_python_lib gives surprising result when used with a Python build

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6555] distutils config file should have the same name on both platforms and all scopes

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6142] Distutils doesn't remove .pyc files

[James]

James  added the comment:

i'm fine with that and willing to contribute patches, however i would feel 
better if whoever upstream was, was more supportive of the idea.
someone let me know.

a thought:
- it's true (as mentioned) that distclean isn't necessarily directly related to 
distributing python scripts, however (in my mind anyways) i see distutils as a 
replacement for common things we do in makefiles. so as a result if we did this 
we could get rid of makefiles and provide useful "action" targets such as 
distclean, test, etc... 100% pure python if needed...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue793069] Add --remove-source option

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6860] Inconsistent naming of custom command in setup.py help output

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4908] adding a get_metadata in distutils

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6142] Distutils doesn't remove .pyc files

[Éric Araujo]

Éric Araujo  added the comment:

Hello

So, is this bug “add a distclean command” now?

Regards

--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7677] distutils, better error message for setup.py upload -sign without identity.

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1109659] distutils argument parsing is bogus

[Éric Araujo]

Éric Araujo  added the comment:

“Global option” could be understood as “option that can be given to any 
command”, i.e. “egg spam -d” == “egg -d spam”. Is it feasible to support such 
and equivalence, too difficult or not desirable?

Regards

--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7007] Tiny inconsistency in the orthography of "url encoded" in the doc of urllib.parse

[Daniel Diniz]

Daniel Diniz  added the comment:

Hits from py3k:

Doc/library/urllib.rst:239:   Convert a mapping object or a sequence of 
two-element tuples  to a "url-encoded"

Doc/library/urllib.rst:263:   Convert the path component *path* from an encoded 
URL to the local syntax for a

Doc/library/urlparse.rst:112:   values in URL encoded queries should be treated 
as blank strings.   A true value

Doc/library/urlparse.rst:135:   values in URL encoded queries should be treated 
as blank strings.   A true value

Doc/library/logging.rst:2347:  Sends the record to the Web server as an 
URL-encoded dictionary.

Lib/logging/handlers.py:1021:Send the record to the Web server as an 
URL-encoded dictionary

Lib/cgi.py:135:URL encoded forms should be treated as blank strings.

Lib/cgi.py:414:URL encoded forms should be treated as blank strings.

Lib/urlparse.py:297:qs: URL-encoded query string to be parsed

Lib/urlparse.py:300:URL encoded queries should be treated as blank 
strings.

Lib/urlparse.py:323:qs: URL-encoded query string to be parsed

Lib/urlparse.py:326:URL encoded queries should be treated as blank 
strings.  A

--
assignee:  -> georg.brandl
components: +Documentation
keywords: +easy
nosy: +ajaksu2, georg.brandl
priority:  -> low
stage:  -> needs patch
type:  -> feature request

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1004696] translate Windows cr-lf when installing scripts on Linux

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5187] distutils upload should prompt for the user/password too

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8351] Suppress large diffs in unitttest.TestCase.assertSequenceEqual()

[Michael Foord]

Changes by Michael Foord :


--
assignee:  -> michael.foord
nosy: +michael.foord

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4843] make distutils use shutil

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3984] python interpreter import dependency with disutils/util

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +merwok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8351] Suppress large diffs in unitttest.TestCase.assertSequenceEqual()

[Floris Bruynooghe]

New submission from Floris Bruynooghe :

This patch adds the ability to suppress large diffs in the failure message of 
TestCase.assertSequenceEqual().  The maximum size of the diff is customisable 
as an new keyword parameter with hopefully a sensible default.

--
components: Library (Lib)
files: case_seq.diff
keywords: patch
messages: 102653
nosy: flub
severity: normal
status: open
title: Suppress large diffs in unitttest.TestCase.assertSequenceEqual()
type: feature request
versions: Python 3.3
Added file: http://bugs.python.org/file16831/case_seq.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6878] outdated docstring in tkinter.Canvas.coords

[Daniel Diniz]

Daniel Diniz  added the comment:

I think the obvious code fix of list(map()) is less likely to cause surprises 
than updating the docstring to the new map in 3.x.

--
keywords: +easy
nosy: +ajaksu2
priority:  -> low
stage:  -> needs patch
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6700] inspect.getsource() returns incorrect source lines

[Daniel Diniz]

Daniel Diniz  added the comment:

Confirmed in trunk and py3k. Also affects inspect.getsourcelines.

--
nosy: +ajaksu2
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6650] sre_parse contains a confusing generic error message

[Daniel Diniz]

Daniel Diniz  added the comment:

Thanks for the patch, LGTM assuming we don't need a test for this.

Do you think the vague message could be less cryptic for users that didn't want 
lookbehind (or don't know what it is)?

--
nosy: +ajaksu2
priority:  -> low
stage:  -> patch review
versions:  -Python 2.4, Python 2.5, Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7946] Convoy effect with I/O bound threads and New GIL

[Nir Aides]

Nir Aides  added the comment:

Uploaded an update.

--
Added file: http://bugs.python.org/file16830/bfs.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7946] Convoy effect with I/O bound threads and New GIL

[Nir Aides]

Changes by Nir Aides :


Removed file: http://bugs.python.org/file16710/bfs.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8350] os.mkdir doc comment is incorrect

[Todd Whiteman]

New submission from Todd Whiteman :

The doc command for os.mkdir is incorrect (at least for posix). It specifies 
that there is an optional mode keyword, but it's not a keyword argument, see 
below:

>>> import os
>>> help(os.mkdir)
mkdir(...)
mkdir(path [, mode=0777])

Create a directory.

>>> os.mkdir("/tmp/1", mode=777) 
Traceback (most recent call last):
  File "", line 1, in 
TypeError: mkdir() takes no keyword arguments


Suggest the following doc comment change:

mkdir(...)
mkdir(path [, mode])

Create a directory. Mode defaults to 0777 if not specified.

--
assignee: georg.brandl
components: Documentation
messages: 102648
nosy: georg.brandl, twhitema
severity: normal
status: open
title: os.mkdir doc comment is incorrect
versions: Python 2.6, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8349] os.environ.get returns incorrect data

[Martin v . Löwis]

Martin v. Löwis  added the comment:

This is the correct result. The value of the environment variables depends on 
whether a 32-bit or a 64-bit process is looking at them, see

http://msdn.microsoft.com/en-us/library/aa384274%28VS.85%29.aspx

--
nosy: +loewis
resolution:  -> invalid
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8349] os.environ.get returns incorrect data

[Dan Brandow]

New submission from Dan Brandow :

I have a Windows 7 64 bit machine, which means it has a few different 
environment variables concerning the program files location:
PROGRAMFILES=C:\Program Files (x86)
ProgramFiles(x86)=C:\Program Files (x86)

Note that both env variables have "(x86)" at the end.

When I do an os.environ.get I get the following results:

Python 2.6.5 (r265:79096, Mar 19 2010, 18:02:59) [MSC v.1500 64 bit (AMD64)] on 
win32
>>> import os
>>> print os.environ.get('ProgramFiles(x86)')
C:\Program Files (x86)
>>> print os.environ.get('PROGRAMFILES')
C:\Program Files
>>> print os.environ.get('ProgramFiles')
C:\Program Files
>>>

Note the missing "(x86)" on the last two test cases.

I tried it on the 64-bit version of 2.5.4 as well:

Python 2.5.4 (r254:67916, Dec 23 2008, 15:19:34) [MSC v.1400 64 bit (AMD64)] on 
win32
>>> import os
>>> print os.environ.get('ProgramFiles(x86)')
C:\Program Files (x86)
>>> print os.environ.get('PROGRAMFILES')
C:\Program Files
>>> print os.environ.get('ProgramFiles')
C:\Program Files
>>>

Same result.  So I tried the 32-bit version of 2.5.4:

Python 2.5.1 (r251:54863, Apr 18 2007, 08:51:08) [MSC v.1310 32 bit (Intel)] on 
win32
>>> import os
>>> print os.environ.get('ProgramFiles(x86)')
C:\Program Files (x86)
>>> print os.environ.get('PROGRAMFILES')
C:\Program Files (x86)
>>> print os.environ.get('ProgramFiles')
C:\Program Files (x86)
>>>

...which gave the correct strings...

--
components: Extension Modules
messages: 102646
nosy: dbrandow
severity: normal
status: open
title: os.environ.get returns incorrect data
versions: Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3081] Py_(X)SETREF macros

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
resolution:  -> rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3081] Py_(X)SETREF macros

[Mark Dickinson]

Mark Dickinson  added the comment:

I agree with Raymond about the Py_INCREF.  I could see more uses for this macro 
without the Py_INCREF, especially for things like in-place arithmetic 
operations.  The following pattern appears a lot in code like 
Objects/longobject.c:

Old code:

/* add one to x */
temp = PyNumber_Add(x, one);
Py_DECREF(x);
x = temp;
if (x == NULL)
return NULL;


With a non-INCREF version of Py_SETREF:

/* add one to x */
Py_SETREF(x, PyNumber_Add(x, one));
if (x == NULL)
return NULL;

--
nosy: +mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3081] Py_(X)SETREF macros

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Py_ASSIGN could be a better name, but given the enthusiasm generated by this 
proposal, I think we might just as well close the issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2643] mmap_object_dealloc does not call FlushViewOfFile on windows

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +akuchling, exarkun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7559] TestLoader.loadTestsFromName swallows import errors

[R. David Murray]

R. David Murray  added the comment:

Thank you very much for those tests.  I think you can simplify them a bit. For 
example, you can use assertRaises.  You also might be able to use the 
test_support.temp_cwd context manager in your context manager, even though you 
don't need the cwd part.

I've attached an alternate, simpler patch to fix this bug, based on a similar 
fix I did in pydoc.  The disadvantage of my patch is that it contains a 
hardcoding of the name of the function doing the import.  I think this is 
acceptable given the much greater simplicity of my patch.  I may be missing 
some subtlety, though, that the twisted folks know about.  Or perhaps people 
will just find the hardcoding itself objectionable.

--
Added file: http://bugs.python.org/file16829/alternate_import_fix.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2643] mmap_object_dealloc does not call FlushViewOfFile on windows

[Charles-Francois Natali]

Changes by Charles-Francois Natali :


Added file: http://bugs.python.org/file16828/test_mmap.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2643] mmap_object_dealloc does not call FlushViewOfFile on windows

[Charles-Francois Natali]

Charles-Francois Natali  added the comment:

Alright, the current behaviour is quite strange:
we don't call msync() when closing the object, we just unmap() it:
mmap_close_method(mmap_object *self, PyObject *unused)
{
[...]
#ifdef UNIX
if (0 <= self->fd)
(void) close(self->fd);
self->fd = -1;
if (self->data != NULL) {
munmap(self->data, self->size);
self->data = NULL;
}
#endif
[...]
}

But we set self->data to NULL to avoid calling munmap() a second time when 
deallocating the object:
static void
mmap_object_dealloc(mmap_object *m_obj)
{
[ ... ]
#ifdef UNIX
if (m_obj->fd >= 0)
(void) close(m_obj->fd);
if (m_obj->data!=NULL) {
msync(m_obj->data, m_obj->size, MS_SYNC);
munmap(m_obj->data, m_obj->size);
}
#endif /* UNIX */
[ ...]
}

So, if the object has been closed properly before being deallocated, msync() is 
_not_ called.
But, if we don't close the object, then msync() is called.

The attached test script shows the _huge_ performance impact of msync:
when only close() is called (no msync()):
$ ./python /home/cf/test_mmap.py
0.35829615593

when both flush() and close() are called (msync() called):
$ ./python /home/cf/test_mmap.py
4.95999493599

when neither is called, relying on the deallocation (msync() called):
$ ./python /home/cf/test_mmap.py
4.8811671257

And a strace leaves no doubt (called 10 times in a loop) :
mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 
0xb80b1000 <0.19>
write(1, "4.12167286873\n"..., 144.12167286873
)  = 14 <0.12>
close(3)= 0 <0.10>
munmap(0xb80b2000, 4096)= 0 <0.23>
rt_sigaction(SIGINT, {SIG_DFL}, {0x811d630, [], 0}, 8) = 0 <0.11>
close(5)= 0 <0.004889>
msync(0xb69f9000, 1000, MS_SYNC)= 0 <0.584054>
munmap(0xb69f9000, 1000)= 0 <0.000433>

See how expensive msync() is, and this is just for a 10MB file.

So the attached patch (mmap_msync.diff) removes the call to msync from 
mmap_object_dealloc(). Since UnmapViewOfFile() is only called inside flush() 
method, nothing to remove for MS Windows.

Here's the result of the same test script with the patch:
when only close() is called (no msync()):
$ ./python /home/cf/test_mmap.py
0.370584011078

when both flush() and close() are called (msync() called):
$ ./python /home/cf/test_mmap.py
4.97467517853

when neither is called, relying on the deallocation (msync() not called):
$ ./python /home/cf/test_mmap.py
0.390102148056

So we only get msync() latency when the user explicitely calls flush().

--
Added file: http://bugs.python.org/file16827/mmap_msync.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8108] test_ftplib fails with OpenSSL 0.9.8m

[Antoine Pitrou]

Antoine Pitrou  added the comment:

My analysis of SSL_shutdown() was missing something: timeout sockets are really 
non-blocking sockets in disguise. I guess it's never too late to notice.

OpenSSL doesn't know about the timeout, so we have to do it ourselves. 
Ironically, the infrastructure is already in place in _ssl.c, and used for 
read() and write() methods.

So here is a new patch, taking this into account.

--
Added file: http://bugs.python.org/file16826/newssl5.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Removed file: http://bugs.python.org/file16824/windows symlink draft 28.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Removed file: http://bugs.python.org/file16821/windows symlink draft 28.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Removed file: http://bugs.python.org/file16809/windows symlink draft 27.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Changes by Jason R. Coombs :


Added file: http://bugs.python.org/file16825/windows symlink draft 29.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1578269] Add os.symlink() and os.path.islink() support for Windows

[Jason R. Coombs]

Jason R. Coombs  added the comment:

In the last patch, I addressed test_platform running a test under a symlinked 
Python. I then found the same error resulting from essentially the same code in 
test_sysconfig. So I refactored those methods into a generator method in 
test.support. This is patch 29.

--
Added file: http://bugs.python.org/file16824/windows symlink draft 28.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8108] test_ftplib fails with OpenSSL 0.9.8m

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Ok, I raised the "errno 0" issue on the openssl mailing-list, and I had a nice 
response by Darryl Miles here:
http://www.mail-archive.com/openssl-us...@openssl.org/msg60710.html

The bottom line is that any "socket error" return from unwrap(), that is any 
"SSL_ERROR_SYSCALL" return from SSL_shutdown(), means that the socket is closed 
(abruptly or not). In this case, we can't do anything except ignore the error 
in test_ftplib.

We should also remove the special casing hack in _ssl.c, even though a socket 
error with "errno 0" isn't particularly informative.

Here is a new patch.

--
Added file: http://bugs.python.org/file16823/newssl4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7559] TestLoader.loadTestsFromName swallows import errors

[Chris Jerdonek]

Chris Jerdonek  added the comment:

The new unit tests pass with this patch (minor clean-up still needed).

--
Added file: http://bugs.python.org/file16822/_patch-7559-5.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8347] string capitalize erroneously lower-case any non-first letters

[Philip Jenvey]

Philip Jenvey  added the comment:

S.capitalize() -> string

Return a copy of the string S with only its first character
capitalized.

You've misunderstood the docs, only the first character is indeed capitalized. 
You want string.capwords instead

--
nosy: +pjenvey
resolution:  -> invalid
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3081] Py_(X)SETREF macros

[Jean-Paul Calderone]

Jean-Paul Calderone  added the comment:

The name suggests a different behavior to me - I assumed it would set the 
reference count to a specific value.  Maybe this is the kind of thing Raymond 
had in mind when he said "The mnemonic doesn't work for me".

--
nosy: +exarkun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8348] test_urllib2net fails because of bad URL

[Martin v . Löwis]

Martin v. Löwis  added the comment:

I changed the URL in r79908.

--
keywords: +buildbot
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com