[issue8745] zipimport is a bit slow

[Goplat]

New submission from Goplat :

Reading the list of files in a .zip takes a while because several seeks are 
done for each entry, which (on Windows at least) flushes stdio's buffer and 
forces a system call on the next read. For large .zips the effect on startup 
speed is noticeable, being perhaps 50ms per thousand files. Changing the 
read_directory function to read the central directory entirely sequentially 
would cut this time by more than half.

--
components: Interpreter Core
files: zipimport_speedup.patch
keywords: patch
messages: 105954
nosy: Goplat
priority: normal
severity: normal
status: open
title: zipimport is a bit slow
type: performance
versions: Python 2.6
Added file: http://bugs.python.org/file17387/zipimport_speedup.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8667] Link to PEP 3147 from importlib docs

[Ashley Sands]

Ashley Sands  added the comment:

Hi Brett,

I would like to contribute to the open source community and Python is my 
favourite language, so I figured I would begin here. But I have never done this 
before, so I am a open-source-contributor-newbie.

So to resolve this issue, I would need to:
Check out the source for Python 3.2.
Locate the importlib module.
Find the file containing the documentation (I presume it would be __init__.py).
Then insert some text and a URL to PEP 3147.
Then commit the change.

Is this the right approach?

--
nosy: +ashleyjsands

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3132] implement PEP 3118 struct changes

[Meador Inge]

Meador Inge  added the comment:

Attached is a patch that implements part of the additions.  More specifically, 
the 'T{}' syntax and the ability to place byte-order specifiers ('<', '>', '@', 
'^', '!", '=') anywhere in the struct string.  

The changes dictated by the PEP are so big that it is better to split things up 
into multiple patches.  These two features will lay some ground work and are 
probably less controversial than the others.

Surely some more tweaks will be needed, but I think what I have now is at least 
good enough for review.  I tested on OS X 10.6 and Ubuntu 10.4.  I also used 
valgrind and 'regrtest.py -R:' to check for memory and 
reference leaks, respectively.

--
Added file: http://bugs.python.org/file17386/struct-string.py3k.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8619] Doc bug for urllib.request._urlopener in Python 3.1+

[Senthil Kumaran]

Senthil Kumaran  added the comment:

Removed in r81283 and r81284.
With respect to the technical details of exposing this functionality for 
_urlretrieve and URLOpener.
- users can still do it.
- There is a better way, if the other global _opener be served for the same 
purpose, so that build_opener can be used. There is TODO mentioned in the code, 
let me see if it can be accomplished without any problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8619] Doc bug for urllib.request._urlopener in Python 3.1+

[Senthil Kumaran]

Senthil Kumaran  added the comment:

Actually, I see certain use-cases of _urlopener in py3k. Most visible one being 
urllib.request.urlretrieve and also URLOpener.open which is different from 
build_opener way of doing things.

- But still, public exposure of overriding globals to can be removed. There is 
no harm in the functionality. In py3k, users should resort to build_opener 
style of doing than use FancyURLOpener or URLOpener which are present for 
backward compatibility reasons only.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8619] Doc bug for urllib.request._urlopener in Python 3.1+

[Senthil Kumaran]

Senthil Kumaran  added the comment:

The functionality provided by urllib.request._urlopener can be accomplished in 
a more natural way using build_opener. Historically, _urlopener was there for 
urllib and build_opener style came in urllib2.

So, I think, this can be safely be removed from the docs considering David's 
suggestion that its better not to advertise _methods in the docs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8744] Maybe typo in doc

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8744] Maybe typo in doc

[Senthil Kumaran]

Senthil Kumaran  added the comment:

Fixed it in revision 81279 and other branches.

--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8591] update mkpkg to latest coding standards

[Dan Buch]

Dan Buch  added the comment:

The attached mkpkg-round-of-pylinting.patch is known to cleanly apply to 
tarek's branch @ 541f90ef0636

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8591] update mkpkg to latest coding standards

[Dan Buch]

Changes by Dan Buch :


--
keywords: +patch
Added file: http://bugs.python.org/file17385/mkpkg-round-of-pylinting.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8744] Maybe typo in doc

[INADA Naoki]

New submission from INADA Naoki :

http://docs.python.org/dev/library/test.html#test.test_support.captured_stdout

"This is a context manager than runs the with statement body using a 
StringIO.StringIO object as sys.stdout."

I think "than" is typo of "that".

--
assignee: d...@python
components: Documentation
messages: 105946
nosy: d...@python, naoki
priority: normal
severity: normal
status: open
title: Maybe typo in doc
versions: Python 2.6, Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5753] CVE-2008-5983 python: untrusted python modules search path

[Dave Malcolm]

Dave Malcolm  added the comment:

Attempting to summarize IRC discussion about this.

PySys_SetArgv is used to set up sys.argv   There is plenty of code which 
assumes that this is a list containing at least a zeroth string element; for 
example warnings.warn (see msg89688).

It seems reasonable for an program that embeds Python to have no arguments, and 
for this case, it makes sense for sys.argv to be [""]  (i.e. a list containing 
a single empty string).

However, in this case, it doesn't necessarily make sense to prepend the empty 
string to the front of sys.path

Looking through Python/sysmodule.c: if argc is 0 in the call to PySys_SetArgv, 
it looks like makeargvobject makes sys.argv be [""] (which is good), but it 
looks like it uses argc[0]  (as "argv") to prepend sys.path.

My reading of PySys_SetArgv is that if argv is NULL, then "char *argv0 = 
argv[0];" will read through NULL and thus will segfault on a typical platform.  

So one possible way to handle this might be to support PySys_SetArgv(0, NULL) 
as signifying that sys.argv should be set to [""] with no modification of 
sys.path

This Google code search for "pysys_setargv(0" shows 25 hits:
http://www.google.com/codesearch?hl=en&lr=&q=pysys_setargv\(0&sbtn=Search

Hoever, the function is complicated, and adding more special-cases seems 
error-prone.

I favor Antoine's approach in http://bugs.python.org/file13860/setargvex.patch 
of adding a new API entry point, whilst maximizing compatibilty for all of the 
code our there using the existing entry point.

I think that both the old and the new entry point need to have better 
documentation, in particular, spelling out the meaning of the args, what the 
effect of argc==0 is, and that argv must be non-NULL in the old entry point, 
but may be NULL for argc==0 in the new entry point (assuming that I'm reading 
that correctly).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8728] 2.7 regression in httplib.py: AttributeError: 'NoneType' object has no attribute 'makefile'

[Giampaolo Rodola']

Changes by Giampaolo Rodola' :


--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3051] heapq change breaking compatibility

[Giampaolo Rodola']

Changes by Giampaolo Rodola' :


--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8727] test_import failure

[Brett Cannon]

Brett Cannon  added the comment:

Sorry about that. I guess I should have been more explicit when I said that "I 
have flagged the test as an expected failure" that meant I made it pass in the 
test suite until I get a chance to fix this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8739] Update to smtpd.py to RFC 5321

[Giampaolo Rodola']

Giampaolo Rodola'  added the comment:

> It is not, but just seemed like good practice to advertise the limit in 
> EHLO and enforce it.  My patch doesn't do a good job of enforcing it 
> since it enforces it before doing process_message.  The problems with 
> 2518 and 1745035 are still there.

Then I doubt it would be a good idea, also because the following comment added 
in issue 1745035 should still stand:

> The patch does not work as Giampaolo intends.  If the patch were 
> applied as-is, no emails longer than 998 bytes could be sent.

Personally I think there's no other way to gracefully solve this other than 
using a tempfile to store the data, but since I'm not a user of the module I'm 
going to let someone else comment about this.

> RFC 5321 doesn't specify it must accept arguments, but I agree it is 
> a good idea.  I'll work on that and submit a new patch.

If there's no RFC which states that, then I would provide arguments for HELP 
*only* if that is a common practice amongst smtp servers.

--
nosy: +josiah.carlson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8446] buildbot: DeprecationWarning not raised for icglue (test_py3kwarn.TestStdlibRemovals)

[Florent Xicluna]

Florent Xicluna  added the comment:

Maybe this is due to webbrowser dependency on "ic" module.

Patch not tested.

--
assignee:  -> ronaldoussoren
components: +Macintosh
keywords: +patch
nosy: +flox, ronaldoussoren
stage:  -> patch review
type:  -> behavior
versions: +Python 2.7 -Python 3.2
Added file: http://bugs.python.org/file17384/issue8446_icglue_webbrowser.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8739] Update to smtpd.py to RFC 5321

[Alberto Trevino]

Alberto Trevino  added the comment:

> Giampaolo Rodola'  added the comment:
> 
> Some comments:
> 
> Is RFC 5321 completely implemented? Otherwise I would turn this in "as
> defined in RFC 821 and part of RFC 5321".

RFC 5321 obsoletes RFCs 821, 974, 1869 and 2821.  I don't think we should 
make reference to them anymore.  Perhaps say something like "implements RFC 
5321 which supersedes RFC 821."

As to how complete the implementation is, section 4.5.1 of RFC 5321 
specifies the following as the minimum set of commands that should be 
supported in a conforming specification: EHLO, HELO, MAIL, RCPT, DATA, RSET, 
NOOP, QUIT, VRFY.  The only gray area is VRFY which is supposed to see if a 
mailbox exists for a particular user.  Since that function cannot be easily 
performed in this proxy smtpd server, section 3.5.3 states a 252 reply code 
should be returned.  My patch returns code 252 if self.__getaddr returns 
true, or 502 if it returns false.

> > - Implement DATA size limit (32 MiB by default)
> I couldn't find any reference to this in RFC 5321. Is it recommended
> somewhere else maybe? Also, issue 2518 and issue 1745035 are somewhat
> related with this specific problem.

It is not, but just seemed like good practice to advertise the limit in EHLO 
and enforce it.  My patch doesn't do a good job of enforcing it since it 
enforces it before doing process_message.  The problems with 2518 and 
1745035 are still there.

> Since you implemented HELP command in the first place it would be good to
> do it completely.

RFC 5321 doesn't specify it must accept arguments, but I agree it is a good 
idea.  I'll work on that and submit a new patch.

> Too bad smtpd currently lacks a test suite.
> Before going any further with this issue I would recommend to write tests
> first. I have a patch for adding a basic test suite for smtpd module I
> hope I'll be able to submit within this week.

It would be great if you could implement a test suite.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5553] Py_LOCAL_INLINE(type) doesn't actually inline except using MSC

[Antoine Pitrou]

Antoine Pitrou  added the comment:

The patch looks ok to me.

--
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3362] locale.getpreferredencoding() gives bus error on Mac OS X 10.4.11 PPC

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +janssen, ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2226] Small _abcoll Bugs / Oddities

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +stutzbach
versions: +Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8729] The Mapping ABC's __eq__ method should return NotImplemented if the other type is not a Mapping

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8727] test_import failure

[Nick Coghlan]

Nick Coghlan  added the comment:

Brett marked it as an expected failure in r81219.

Probably should have mentioned that here at the time though...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8739] Update to smtpd.py to RFC 5321

[Giampaolo Rodola']

Giampaolo Rodola'  added the comment:

Some comments:

-# This file implements the minimal SMTP protocol as defined in RFC 821.  It
+# This file implements the minimal SMTP protocol as defined in RFC 5321.  It

Is RFC 5321 completely implemented? Otherwise I would turn this in "as defined 
in RFC 821 and part of RFC 5321".

> - Implement DATA size limit (32 MiB by default)

I couldn't find any reference to this in RFC 5321. Is it recommended somewhere 
else maybe?
Also, issue 2518 and issue 1745035 are somewhat related with this specific 
problem.

> +## TODO: implement command help

Since you implemented HELP command in the first place it would be good to do it 
completely (I guess this means HELP should be able to accept arguments, as in 
FTP protocol).


Too bad smtpd currently lacks a test suite.
Before going any further with this issue I would recommend to write tests first.
I have a patch for adding a basic test suite for smtpd module I hope I'll be 
able to submit within this week.

--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8732] Should urrllib2.urlopen send an Accept-Encoding header?

[Senthil Kumaran]

Senthil Kumaran  added the comment:

HTTP Ref says that Server can send any encoding, if client does not
specify Accept-Encoding header. But if 'identity' is one of the
encoding that server recognizes (?), then it should send it as
identity, which indicates untransformed content.

I also see in the httplib that Accept-Encoding = 'identity' is added in the
request level to the headers. I shall see what is missing here, if it
is not being sent for all requests.

BTW, I could not figure out the problem you are facing from the url
mentioned. I specifically do not see any interleaving gzip and no-gzip
request behaviours at different points.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8713] multiprocessing needs option to eschew fork() under Linux

[Ram Rachum]

Ram Rachum  added the comment:

+1 for this issue; I've also wished for this feature in the past.

--
nosy: +cool-RR

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6583] 2to3 fails to fix test.test_support

[Pascal Chambon]

Pascal Chambon  added the comment:

Sorry to reraise an old issue, but the documentation of "test" module is 
deceiving on that one : "The test.test_support module has been renamed to 
test.support in Python 3.0. The 2to3 tool will automatically adapt imports when 
converting your sources to 3.0.".

I lost quite some time on this one...

--
nosy: +pakal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2521] ABC caches should use weak refs

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> Antoine, do you have a suggestion for someone with with better 
> knowledge of ABCs to do the final review, so that I may very politely 
> pester them? ;-)

I guess Benjamin could.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7079] file_close() ignores return value of close_the_file

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Sorry, I had just forgotten. The patch has been committed in r81275 (trunk) and 
r81277 (2.6). Thank you:

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7079] file_close() ignores return value of close_the_file

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

Is there anything more I can do to help get this crash-fix committed before 2.7 
rc1?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2521] ABC caches should use weak refs

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

Antoine, do you have a suggestion for someone with with better knowledge of 
ABCs to do the final review, so that I may very politely pester them? ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8743] set() operators don't work with collections.Set instances

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

I should add:

I discovered the inconsistency while working on my sortedset class, which 
provides the same interface as set() but is also indexable like a list (e.g., 
S[0] always returns the minimum element, S[-1] returns the maximum element, 
etc.).

sortedset derives from collections.MutableSet, but it's challenging to 
precisely emulate set() when collections.MutableSet and set() don't work the 
same way. ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8743] set() operators don't work with collections.Set instances

[Daniel Stutzbach]

New submission from Daniel Stutzbach :

The set() operators (__or__, __and__, __sub__, __xor__, and their in-place 
counterparts) require that the parameter also be an instance of set().

They're documented that way:  "This precludes error-prone constructions like 
set('abc') &  'cbs' in favor of the more readable 
set('abc').intersection('cbs')."

However, an unintended consequence of this behavior is that they don't 
inter-operate with user-created types that derive from collections.Set.

That leads to oddities like this:

MySimpleSet() | set()  # This works
set() | MySimpleSet()  # Raises TypeError

(MySimpleSet is a minimal class derived from collections.Set for illustrative 
purposes -- set attached file)

collections.Set's operators accept any iterable.

I'm not 100% certain what the correct behavior should be.  Perhaps set's 
operators should be a bit more liberal and accept any collections.Set instance, 
while collections.Set's operators should be a bit more conservative.  Perhaps 
not.  It's a little subjective.

It seems to me that at minimum set() and collections.Set() should inter-operate 
and have the same behavior.

--
components: Interpreter Core
files: set-vs-set.py
messages: 105929
nosy: stutzbach
priority: normal
severity: normal
stage: unit test needed
status: open
title: set() operators don't work with collections.Set instances
type: behavior
versions: Python 2.7, Python 3.2
Added file: http://bugs.python.org/file17383/set-vs-set.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7981] False failure with doctest NORMALIZE_WHITESPACE in 3.1.1

[trambalda]

trambalda  added the comment:

but with print() it works:

print("This text\n contains weird spacing.")
# doctest: +NORMALIZE_WHITESPACE

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7981] False failure with doctest NORMALIZE_WHITESPACE in 3.1.1

[trambalda]

trambalda  added the comment:

Same problem in 2.6.4 r264:75708 and 3.1 r31:73574

--
nosy: +trambalda

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8741] 2.7 regression in tarfile: IOError: link could not be created

[Sridhar Ratnakumar]

Sridhar Ratnakumar  added the comment:

Aside: why is the original exception ignored, and instead a generic IOError is 
thrown? Why not use one of the exceptions inheriting `TarError`, so that 
application code can reliably catch these errors?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8741] 2.7 regression in tarfile: IOError: link could not be created

[Sridhar Ratnakumar]

Sridhar Ratnakumar  added the comment:

The actual exception caught (before it was ignored and a generic IOError was 
thrown) was this:

  File "C:\Python27\lib\tarfile.py", line 2168, in _extract_member
self.makelink(tarinfo, targetpath)
  File "C:\Python27\lib\tarfile.py", line 2258, in makelink
shutil.copy2(linkpath, targetpath)
  File "C:\Python27\lib\shutil.py", line 127, in copy2
copyfile(src, dst)
  File "C:\Python27\lib\shutil.py", line 81, in copyfile
with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: 
'eternity-0.13\\src\\eternity\\django\\templates\\eui\\concerns\\..\\registry\\delet
e.html'

The specified file actually does not exist. Perhaps, in the middle of the 
extraction process, it was not created *yet*.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8633] tarfile doesn't support undecodable filename in PAX format

[Lars Gustäbel]

Lars Gustäbel  added the comment:

I added support for the hdrcharset method and a workaround for the GNU tar bug, 
see r81273.

--
resolution:  -> accepted
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8742] broken asdl link in Parser/asdl.py

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8742] broken asdl link in Parser/asdl.py

[Patrick Sabin]

New submission from Patrick Sabin :

The link:
http://www.cs.princeton.edu/~danwang/Papers/dsl97/dsl97-abstract.html
in the file Parser/asdl.py seems to be broken. When I tried to open it I got a 
page with: "Sorry, the page you requested couldn't be found". It seems to me 
that this is a permanent issue and therefore the link should be removed as 
there is another link, that works.

--
assignee: d...@python
components: Documentation, Interpreter Core
messages: 105923
nosy: d...@python, pyfex
priority: normal
severity: normal
status: open
title: broken asdl link in Parser/asdl.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6054] tarfile normalizes arcname

[Sridhar Ratnakumar]

Sridhar Ratnakumar  added the comment:

Apparently this fix introduced a regression. See issue8741

--
nosy: +srid

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1285086] urllib.quote is too slow

[Florent Xicluna]

Florent Xicluna  added the comment:

Committed to 3.2 in r81271, after some additional tuning.

Btw, I kept list comprehension in 3.2, because it is faster for small strings 
(even if the gain is ~10%).

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8741] 2.7 regression in tarfile: IOError: link could not be created

[Sridhar Ratnakumar]

New submission from Sridhar Ratnakumar :

Repro steps:

Download http://appropriatesoftware.net/provide/docs/eternity-0.13.tar.gz (via 
'eternity' module in PyPI) and look at the following command line session:

C:\Temp\tfbug>python27 -c "import tarfile as T; 
T.open('eternity-0.13.tar.gz').extractall()"
Traceback (most recent call last):
  File "", line 1, in 
  File "C:\Python27\lib\tarfile.py", line 2046, in extractall
self.extract(tarinfo, path)
  File "C:\Python27\lib\tarfile.py", line 2083, in extract
self._extract_member(tarinfo, os.path.join(path, tarinfo.name))
  File "C:\Python27\lib\tarfile.py", line 2168, in _extract_member
self.makelink(tarinfo, targetpath)
  File "C:\Python27\lib\tarfile.py", line 2260, in makelink
raise IOError("link could not be created")
IOError: link could not be created

C:\Temp\tfbug>python26 -c "import tarfile as T; 
T.open('eternity-0.13.tar.gz').extractall()"

C:\Temp\tfbug>dir eternity-0.13
 Volume in drive C has no label.
 Volume Serial Number is 1877-E6BA

 Directory of C:\Temp\tfbug\eternity-0.13

10/14/2008  06:08 PM  .
10/14/2008  06:08 PM  ..
09/05/2008  01:31 PM   115 AUTHORS
10/14/2008  06:08 PM  bin
09/05/2008  01:31 PM 0 CHANGES
09/05/2008  01:31 PM17,998 COPYING
10/14/2008  06:08 PM  etc
09/05/2008  01:31 PM   447 INSTALL
09/11/2008  06:06 PM   231 MANIFEST.in
10/14/2008  06:08 PM   802 PKG-INFO
09/05/2008  01:31 PM   516 README
09/10/2008  04:10 PM 2,948 setup.py
10/14/2008  06:08 PM  src
   8 File(s) 23,057 bytes
   5 Dir(s)   3,493,781,504 bytes free

C:\Temp\tfbug>

--
components: Library (Lib), Windows
messages: 105920
nosy: lars.gustaebel, srid
priority: normal
severity: normal
status: open
title: 2.7 regression in tarfile: IOError: link could not be created
type: crash
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1285086] urllib.quote is too slow

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
assignee: orsenthil -> flox
resolution:  -> fixed
stage: patch review -> committed/rejected

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1285086] urllib.quote is too slow

[Senthil Kumaran]

Senthil Kumaran  added the comment:

On Mon, May 17, 2010 at 01:38:57PM +, Florent Xicluna wrote:
> Committed in r81265 for 2.7.

Thanks. That was interesting. Without resorting to any drastic changes like
use of regex, interesting speed-up seems to have been achieved by
using rsplit and map.

In py3k, I think its 'okay' to go for rsplit, defaultdict and map
which will be similar to py2k version. I saw that map vs list
comprehension did not have much differences.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

The second patch looks good to me.

--
resolution:  -> accepted
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

[Pascal Chambon]

Changes by Pascal Chambon :


Removed file: http://bugs.python.org/file17369/msvcrt_crash.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

[Pascal Chambon]

Pascal Chambon  added the comment:

My bad, here is a better patch...

--
Added file: http://bugs.python.org/file17382/msvcrt_crash2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1800] ctypes callback fails when called in Python with array argument

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
keywords: +needs review
stage: unit test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1800] ctypes callback fails when called in Python with array argument

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

Attached patch fixes the issue, but feels a little bit like a band-aid. I think 
making array arguments "decay" into pointers is the right solution, but I am 
not sure this should be done when prototype is created or when it is called.  
If python level solution is accepted, a better way to detect an array type 
should probably be found.

--
keywords: +patch
Added file: http://bugs.python.org/file17381/issue1800.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1285086] urllib.quote is too slow

[Florent Xicluna]

Changes by Florent Xicluna :


Removed file: http://bugs.python.org/file17366/issue1285086_using_rstrip_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8726] test_capi failure

[Jeffrey Yasskin]

Jeffrey Yasskin  added the comment:

Fixed in r81269. Sorry about that.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8730] Spurious test failure in distutils

[Ronald Oussoren]

Ronald Oussoren  added the comment:

I'd also skip the test, this is not a bug in Python but a broken compress 
executable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8740] infinite recursion with setfilesystemencoding and pdb

[STINNER Victor]

STINNER Victor  added the comment:

Oh, flox closed the issue: it's a duplicate of #8226. The bug was fixed in 
Python 3.1.2 by myself (r79394).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8740] infinite recursion with setfilesystemencoding and pdb

[Christophe Combelles]

Christophe Combelles  added the comment:

Traceback (most recent call last):
  File "/usr/lib/python3.1/encodings/__init__.py", line 98, in search_function
level=0)
  File "/usr/lib/python3.1/encodings/__init__.py", line 98, in search_function
level=0)
(...)
  File "/usr/lib/python3.1/encodings/__init__.py", line 98, in search_function
level=0)
  File "/usr/lib/python3.1/encodings/__init__.py", line 98, in search_function
level=0)
  File "/usr/lib/python3.1/encodings/__init__.py", line 83, in search_function
norm_encoding = normalize_encoding(encoding)
  File "/usr/lib/python3.1/encodings/__init__.py", line 55, in 
normalize_encoding
if isinstance(encoding, bytes):
RuntimeError: maximum recursion depth exceeded while calling a Python object

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8740] infinite recursion with setfilesystemencoding and pdb

[STINNER Victor]

STINNER Victor  added the comment:

The file system encoding should not be modifiable. Call 
sys.setfilesystemencoding() breaks Python, eg. module filenames are not 
reencoded. See also #8611.

sys.setfilesystemencoding() is as danregeous as sys.setdefaultencoding() 
because it changes too much things in Python.

If you would like to decode a filename with an encoding different than 
sys.setfilesystemencoding(): use the bytes type. Eg. os.listdir(b'.') gives you 
bytes filenames.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8740] infinite recursion with setfilesystemencoding and pdb

[STINNER Victor]

STINNER Victor  added the comment:

What is the problem?

$ python3.1
Python 3.1.2 (r312:79147, Apr 21 2010, 23:52:07) 
[GCC 4.4.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys, pdb; sys.setfilesystemencoding('iso8859-7'); pdb.set_trace()
--Return--
> (1)()->None
(Pdb) 

Where is the infinite loop?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8685] set(range(100000)).difference(set()) is slow

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Will look at this when I get back to the U.S.

--
priority: normal -> low

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8734] msvcrt get_osfhandle crash on bad FD

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

I agree with the fix.
However the patch should test for "sys.platform == 'win32'" before importing 
msvcrt.
And there is an extra space on another line.

--
nosy: +amaury.forgeotdarc
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3051] heapq change breaking compatibility

[Jean-Paul Calderone]

Changes by Jean-Paul Calderone :


--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3051] heapq change breaking compatibility

[Maciek Fijalkowski]

Maciek Fijalkowski  added the comment:

Hello.

I would like to complain. It was decided at some point some time ago that both 
pure-python and C version should run against the same test suite and should not 
have any differencies. The reasoning behind it is that other python 
implementations might choose to use pure-python version and we should avoid 
surprises with random code crashing in obscure ways. Please don't divert 
deliberately those sources.

Cheers,
fijal

--
nosy: +fijal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8740] infinite recursion with setfilesystemencoding and pdb

[Florent Xicluna]

Florent Xicluna  added the comment:

Next release should fix it: 3.1.3
(Tested on 3.1 branch)

--
nosy: +flox, haypo
resolution:  -> duplicate
stage:  -> committed/rejected
status: open -> closed
superseder:  -> sys.setfilesystemencoding("xxx"); open("a") => stack overflow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1800] ctypes callback fails when called in Python with array argument

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
nosy: +belopolsky
stage:  -> unit test needed
versions: +Python 3.2, Python 3.3 -Python 2.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8727] test_import failure

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

I cannot reproduce this on Ubuntu 10.04 with current py3k (r81268), even using 
the boiled down example given by Antoine.  What platform are you on?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2456] Make sysmodule.c compatible with Bazaar

[Barry A. Warsaw]

Changes by Barry A. Warsaw :


--
resolution:  -> wont fix
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8739] Update to smtpd.py to RFC 5321

[Barry A. Warsaw]

Changes by Barry A. Warsaw :


--
versions:  -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8739] Update to smtpd.py to RFC 5321

[R. David Murray]

Changes by R. David Murray :


--
nosy: +r.david.murray
stage:  -> unit test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8740] infinite recursion with setfilesystemencoding and pdb

[Christophe Combelles]

New submission from Christophe Combelles :

This leads to a maximum recursion depth error:

$ python3.1
>>> import sys, pdb
>>> sys.setfilesystemencoding('iso8859-7')
>>> pdb.set_trace()

I'm on ubuntu 10.04 x86_64, with LANG=fr_FR.utf8

--
components: None
messages: 105904
nosy: ccomb
priority: normal
severity: normal
status: open
title: infinite recursion with setfilesystemencoding and pdb
type: behavior
versions: Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1285086] urllib.quote is too slow

[Florent Xicluna]

Florent Xicluna  added the comment:

Committed in r81265 for 2.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8739] Update to smtpd.py to RFC 5321

[Alberto Trevino]

New submission from Alberto Trevino :

This patch updates smtpd.py to be more RFC 5321 compliant.  It contains:

 - EHLO support
 - Implement DATA size limit (32 MiB by default)
 - 8-bit mime extension plumbing (doesn't do anything, but accepts and
   records command)
 - Basic VRFY support
 - Basic HELP support
 - A few improvements to messages (more in line with RFC 5321 examples)
 - Misc. documentation updates

The patch is specific to Python 3.1.  I have not tried to backport the changes 
to 2.x.  If possible, I would like the patch to be considered for inclusion to 
3.2.

--
components: Library (Lib)
files: smtpd.py-0.2-rfc5321-enhancements.diff
keywords: patch
messages: 105902
nosy: alfmel, barry
priority: normal
severity: normal
status: open
title: Update to smtpd.py to RFC 5321
type: feature request
versions: Python 3.1, Python 3.2
Added file: 
http://bugs.python.org/file17380/smtpd.py-0.2-rfc5321-enhancements.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8736] *= is undocumented for lists

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

Good point, since I see now that *= (and +=) also works on immutable sequence 
types (though does something subtly different).  I always forget that.

--
resolution:  -> invalid
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7946] Convoy effect with I/O bound threads and New GIL

[Victor Godoy Poluceno]

Changes by Victor Godoy Poluceno :


--
nosy: +victorpoluceno

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8730] Spurious test failure in distutils

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Just skip the test, IMO.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8730] Spurious test failure in distutils

[Tarek Ziadé]

Tarek Ziadé  added the comment:

So do you know if this is specific to all sharutils versions ? 

I could read the version and raise a specific error in that case.
*or* just not fix this bug and fix the test so it's permissive in this very 
particular case (by looking at the compression version)

What do you think ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8738] cPickle dumps(tuple) != dumps(loads(dumps(tuple)))

[Antoine Pitrou]

Antoine Pitrou  added the comment:

I don't think you can expect serialized results to always be equal. It can 
depend on specifics of the internal algorithm, such as optimizations or dict 
iteration order.

--
nosy: +alexandre.vassalotti, pitrou
priority: normal -> low
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8688] distutils sdist is too laze w.r.t. recalculating MANIFEST

[Tarek Ziadé]

Tarek Ziadé  added the comment:

done in r81255, r81256 (2.6), r81258 (py3), r81260 (3.1)

Thanks Ronald

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8738] cPickle dumps(tuple) != dumps(loads(dumps(tuple)))

[Alberto Planas Domínguez]

New submission from Alberto Planas Domínguez :

Sometimes, when I use cPickle to serialize tuples of strings, I get different 
dumps() result for the same tuple:

import cPickle
t = ('', 'JOHN')
s1 = cPickle.dumps(t)
s2 = cPickle.dumps(cPickle.loads(cPickle.dumps(t)))
assert s1 == s2 # AssertionError

With cPickle doesn't matter what protocol use por dumps(). The assertion is Ok 
if I use the pickle module instead of cPickle.

This means that I can't use a serialized object as a key in a map/dict object.

--
messages: 105896
nosy: Alberto.Planas.Domínguez
priority: normal
severity: normal
status: open
title: cPickle dumps(tuple) != dumps(loads(dumps(tuple)))
type: behavior
versions: Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8589] test_warnings.CEnvironmentVariableTests.test_nonascii fails under an ascii terminal

[STINNER Victor]

STINNER Victor  added the comment:

Does my fix this #8533 fixes this issue or not? I guess yes, but I would prefer 
a confirmation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8733] list type and UserList do not call super in __init__ and therefore, they cannot be parents in a multiple inheritence scheme

[Sagiv Malihi]

Changes by Sagiv Malihi :


--
nosy: +Sagiv.Malihi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8736] *= is undocumented for lists

[Ray.Allen]

New submission from Ray.Allen :

Does *= need document? I think the documentation of * for all sequence type can 
already cover the *= usage.

--
nosy: +ysj.ray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com