[issue7322] Socket timeout can cause file-like readline() method to lose data
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch which fixes the issue. Instead of allowing the readline method to lose data, it adds a check to SocketIO.readinto() to ensure that the socket does not have a timeout and throws an IOError if it does. Also does the same for SocketIO.write(). I think this is a better approach - just failing immediately when a readline on a nonblocking socket occurs instead of failing sometimes and losing data. -- keywords: +patch nosy: +rosslagerwall Added file: http://bugs.python.org/file20202/7322_v1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7322 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7322] Socket timeout can cause file-like readline() method to lose data
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- nosy: +loewis, pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7322 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags
Ross Lagerwall rosslagerw...@gmail.com added the comment: issue1515839 seems to be a duplicate of this one. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7995 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2636] Regexp 2.7 (modifications to current re 2.2.2)
Jacques Grove aquara...@gmail.com added the comment: Thanks for putting up the hg repo, makes it much easier to follow. Getting back to the performance regression I reported in msg124904: I've verified that if I take the hg commit 7abd9f9bb1 , and I back out the guards changes manually, while leaving the FAST_INIT changes in, the performance is back to normal on my full regression suite (i.e. the 30-40% penalty disappears). I've repeated my tests a few times to make sure I'm not mistaken; since the guard changes doesn't look like it should impact performance much, but it does. I've attached the diff that restored the speed for me (as usual, using Python 2.6.5 on Linux x86_64) BTW, now that we have the code on google code, can we log individual issues over there? Might make it easier for those interested to follow certain issues than trying to comb through every individual detail in this super-issue-thread...? -- Added file: http://bugs.python.org/file20203/remove_guards.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2636 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1515839] socket timeout inheritance on accept
Ned Deily n...@acm.org added the comment: The problem you have reported here was later independently reported in Issue7995 where a possible fix has been proposed. Suggest adding yourself to the nosy list of that issue to monitor current status. -- nosy: +ned.deily resolution: - duplicate status: open - closed superseder: - On Mac / BSD sockets returned by accept inherit the parent's FD flags ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1515839 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6210] Exception Chaining missing method for suppressing context
Antoine Pitrou pit...@free.fr added the comment: Le vendredi 31 décembre 2010 à 00:07 +, Patrick W. a écrit : Patrick W. p...@borntolaugh.de added the comment: Antoine Pitrou (pitrou) at 2010-12-30 18:32 (UTC) We are talking about context, not cause. Yes, but - as said before - obviously the cause takes a higher precedence than context (otherwise it wouldn't show a context message when you explicitely set that). So when *explicitely* setting the cause to `None`, it should use the cause `None` and ignore the context, and as such display nothing. It looks quite unintuitive to me, though. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6210 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7322] Socket timeout can cause file-like readline() method to lose data
Antoine Pitrou pit...@free.fr added the comment: While this patch looks conformant to the documentation, it is very likely to break code in the wild. Even in the stdlib, there are uses of makefile() + socket timeouts (e.g. in http.client and urllib). It would be better to find a way to make readline() functional even with socket timeouts. -- assignee: gregory.p.smith - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7322 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3766] socket.socket.recv broken (unbearably slow)
Konstantin Osipov kostja.osi...@gmail.com added the comment: I was able to observe the same issue: I'm using Python 2.6.5 on Ubuntu 10.0.4 LTS. My system is 64 bit Intel Core I7, Quad core, Linux kernel 2.6.32-generic x86_64, Ubuntu EGLIBC 2.11.1-0ubuntu7.5. A simple client TCP socket, which sends 35 bytes over to a server on localhost and receives 20 bytes in response, produces only 22 RPS. An identical application written in C gives me 7000 RPS. TCP_NODELAY is on on the server side. Turning on TCP_NODELAY on the client gives me ~500 RPS in Python (which I'm satisfied with, 'cause I think I then hit other bottlenecks). Still, such low performance on by default can be surprising and hard to debug. -- nosy: +kostja ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3766 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
New submission from M. Z. mzdkm...@gmail.com: Trying to unpack a ZIP file where some packet files contain danish letters results in: zipfile.BadZipFile: File name in directory 'filename_with_æoå.txt' and header b'filename_with_\x91o\x86.txt' differ. Using Py 3.2b2 on Win7. Unpack the attached ZIP file and run the Py script, which will show the problem using the enclosed two ZIP files. -- components: Library (Lib) files: bug_zipfile_extractall.zip messages: 124964 nosy: M..Z. priority: normal severity: normal status: open title: zipfile.ZipFile().extractall() header mismatch for non-ASCII characters type: behavior versions: Python 3.2 Added file: http://bugs.python.org/file20204/bug_zipfile_extractall.zip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +amaury.forgeotdarc, haypo, loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags
Antoine Pitrou pit...@free.fr added the comment: Thanks for the patch. Comments/questions: - please don't use C++-style comments (//) in C code; some compilers can choke on them - should the code path be also enabled for netbsd? (or other variants?) - why does the test silence socket.error on accept()? - what if fcntl() returns -1? (unlikely I know) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7995 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
Martin v. Löwis mar...@v.loewis.de added the comment: The attached patch fixes it for me. No time to write tests right now. -- keywords: +patch Added file: http://bugs.python.org/file20205/zipfile.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags
Ross Lagerwall rosslagerw...@gmail.com added the comment: From what I coud see, the same applied to NetBSD so I enabled it for NetBSD as well - if there are any other OSes that need it enabled, they can be added. The updated patch checks for fcntl() failing and simply leaves the socket as is if it fails. The test silenced socket.error() just because the other tests did like testSetBlocking, testInitNonBlocking, testAccept, etc. I updated it to remove this. -- Added file: http://bugs.python.org/file20206/7995_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7995 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6210] Exception Chaining missing method for suppressing context
Ethan Furman et...@stoneleaf.us added the comment: raise AttributeError from None makes sense to me, and in a nice, short example like that I prefer it. In real code, however, I think raise AttributeError.no_context(Field %s is not in table % attr) is going to be easier for the human to parse than raise AttributeError(Field %s is not in table % attr) from None -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6210 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9361] Tests for leapdays in calendar.py module
Sandro Tosi sandro.t...@gmail.com added the comment: I just tried John's patch, and: - it still applies without problem (except for a bit of offset) - I can confirm that it actually adds test coverage for leapdays() function (bringing calendar coverage from 71% to 72%). I think it would be good to apply it to py3k branch. Cheers, Sandro -- nosy: +sandro.tosi stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9361 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9370] Add reader redirect from test package docs to unittest module
Sandro Tosi sandro.t...@gmail.com added the comment: Hi Nick, the See also section already points to unittest module; are you asking to extend its description to mention that's the tool people should use for their unittest suites? Cheers, Sandro -- nosy: +sandro.tosi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9370 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2636] Regexp 2.7 (modifications to current re 2.2.2)
Matthew Barnett pyt...@mrabarnett.plus.com added the comment: Why not? :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2636 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1674555] sys.path in tests contains system directories
R. David Murray rdmur...@bitdance.com added the comment: Here is a proof of concept patch if anyone wants to play with it.Note that a higher value could be used for the j option; multiple threads help even on uniprocessor systems since a bunch of the tests spend time waiting around. The patch removes the '-l' option from the make test run. I'm not sure that matters, since we do our best to fix memory leaks before shipping a release, and we don't use make test to do our leak testing (as far as I know). I'm not sure this is an appropriate solution, so I won't apply this unless I get some favorable votes from committers and/or packagers. One interesting thing is that several additional tests show up as altering the execution environment when run this way. That bears investigation at some point, but is an orthogonal issue. As noted, test_trace does not pass, but only one test within it fails, so that ought to be easy enough to fix. Also note that this fix would only be applicable to 3.2 and 2.7. -- keywords: +patch nosy: +doko, loewis, pitrou Added file: http://bugs.python.org/file20207/make_test_S.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1674555 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9671] test_executable_without_cwd fails: AssertionError: 1 != 47
Sandro Tosi sandro.t...@gmail.com added the comment: Hello, I tried on a freshly build 2.7, and I can't replicate the reported error. Could it be it has been fixed by r78136? Sridhar, are you still seeing this error? Cheers, Sandro -- nosy: +sandro.tosi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9671 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9361] Tests for leapdays in calendar.py module
R. David Murray rdmur...@bitdance.com added the comment: Applied in r87590. I threw in an extra test for a multi-leapyear-range. Since there was no reason not to, I backported it to 3.1 in r87591 and 2.7 in r87592. In the latter two commits I also backported the issue 9342 patch. Thanks for the patch, John, and for the review, Sandro. -- nosy: +r.david.murray resolution: - accepted stage: patch review - committed/rejected status: open - closed versions: +Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9361 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9342] Tests for monthrange in calendar.py module
R. David Murray rdmur...@bitdance.com added the comment: Backported it to 3.1 in r87591 and 2.7 in r87592 along with the patch for issue 9361. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9342 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10270] Fix resource warnings in test_threading
Sandro Tosi sandro.t...@gmail.com added the comment: Already fixed in r86107 -- nosy: +sandro.tosi resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10270 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10694] zipfile.py end of central directory detection not robust
R. David Murray rdmur...@bitdance.com added the comment: I finally got around to researching this issue in the tracker. Issue 10298 is a close relative to this issue. The fix from that issue make the test that Xuanji added here pass. That issue contains no testsit would be ideal to have tests that test the behavior in the face of actual comments in the zipfile, but even if all we have is Xuanji's test IMO we should apply one of the two fixes. The 10298 patch takes the approach of ignoring the excess data but preserving the comment if any. The author implies that that is what other tools do, so in the absence of input from Alan or other zipfile experts that's probably what we should go with. Rep, could you look over this issue and indicate if you agree? Note also issue 9239, which fixes one way that zipfile could create a zipfile with garbage at the end. Then there is issue 1757072, where we hear some of Alan's thinking about this: a non-strict mode...but it is perhaps too late for a feature request, and there is the fact that ignoring the trailing data appears to be a de-facto standard. And then we have issue 1757072, which is identical to this one and was closed won't fix, but apparently only because the source of the corrupted zip files wasn't identified, which this issue does do. Interestingly, issue 669036 claims that zipfile.py supports garbage at the start, which makes tolerating garbage at the end seem sensibly symmetric. Finally, comment support was added by the patch in issue 611760. It would be interesting to know if garbage at the end was supported before that patch. My guess is that it was, by ignoring it, but I haven't tested it. Summary: if someone can review the actual patch, I think we should apply the issue 10298 patch along with Xuanji's test. Xuanji, if you have the time and desire to add some additional tests that test comments with trailing data, that would be a bonus. You could look at the tests in issue 9239 for ideas. -- nosy: +rep, rfk ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10694 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
R. David Murray rdmur...@bitdance.com added the comment: FWIW, having just looked at related code in zipfile recently, this patch looks correct to me. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10771] descriptor protocol documentation has two different definitions of owner class
Terry J. Reedy tjre...@udel.edu added the comment: For future reference, the 'trunk' branch was frozen with the release of 2.7 in June 2010. However, this particular text is unchanged since in 2.7.1 and still in 3.2b2 (except for removal of 'new style'.) -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10771 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10772] Several actions for argparse arguments missing from docs
Changes by Terry J. Reedy tjre...@udel.edu: -- nosy: +bethard versions: +Python 3.2 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10772 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10782] Not possible to cross-compile due to poor detection of %lld support in printf
Terry J. Reedy tjre...@udel.edu added the comment: Requests for information should go to python-list or other support forums. That said, does the response settle this issue, so that it can be closed, or is there still a claim that something should be changed in the Python repository? -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10782 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10786] unittest.TextTextRunner does not respect redirected stderr
Terry J. Reedy tjre...@udel.edu added the comment: Since the current behavior matches the current doc, class unittest.TextTestRunner(stream=sys.stderr, descriptions=True, verbosity=1, runnerclass=None, warnings=None) A basic test runner implementation which prints results on standard error. ... this is a feature change request, not a bug report. Hence, the change should not be backported, lest it surprise someone. One could even question whether the change should be introduced now, but is does seem rather minor. That aside, the doc needs to be changed and a version-changed note added. Something like class unittest.TextTestRunner(stream=None, descriptions=True, verbosity=1, runnerclass=None, warnings=None) A basic test runner implementation. If *stream* is the default None, results go to standard error. ... Version changed 3.2: default stream determined when class is instantiated rather than when imported. -- nosy: +terry.reedy type: behavior - feature request versions: -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10786 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10787] [random.gammavariate] Add the expression of the distribution in a comprehensive form for random.gammavariate
Terry J. Reedy tjre...@udel.edu added the comment: From reading the Wikipedia article, I might conclude that beta = 1/theta, but from reading random.py, beta=theta. I think this much should be clarified, but without giving the formula in a hard to read text form. Perhaps the random doc should give reference to the much more complete numpy.random (and Wikipedia and/or Mathworld) entries rather than merely 'any statistics text' (many of which will not describe all). -- nosy: +terry.reedy versions: +Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10787 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10789] Lock.acquire documentation is misleading
Terry J. Reedy tjre...@udel.edu added the comment: Since threading is written in Python, one might expect Lock to be written in Python and its methods to accept keywords. However, threading.py (3.2) has _acquire_lock = _thread.acquire_lock Lock = _aquire_lock so threading.Lock objects are C-coded _thread.lock objects and hence *might* not accept keyword args. In 3.1: lock.acquire([waitflag]) # same 2.7 Lock.acquire(blocking=True) # [blocking=1] in 2.7 Indeed the first is correct. from threading import Lock l=Lock() l.acquire(blocking=True) Traceback (most recent call last): File pyshell#2, line 1, in module l.acquire(blocking=True) TypeError: acquire() takes no keyword arguments l.acquire(True) True r87596, r87596 In 3.2: lock.acquire(waitflag=1, timeout=-1) Lock.acquire(blocking=True, timeout=-1) The edit in 3.2 is actually correct from threading import Lock l=Lock() l.acquire(blocking=True) True l.acquire(timeout=1) False _thread.lock.acquire now accepts keywords. -- assignee: d...@python - terry.reedy nosy: +terry.reedy resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10789 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10794] Infinite recursion while garbage collecting loops indefinitely
Terry J. Reedy tjre...@udel.edu added the comment: 2.6 is finished except for possible security patches. This should be verified in a current release, preferably 3.2 -- nosy: +terry.reedy stage: - needs patch versions: +Python 2.7 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10794 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9370] Add reader redirect from test package docs to unittest module
Nick Coghlan ncogh...@gmail.com added the comment: Yeah, I think I wrote this issue based on the diff that added the new note at the top, rather than looking at the existing intro text that already references unittest and doctest. No need to change anything after all. -- resolution: - invalid status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9370 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10794] Infinite recursion while garbage collecting loops indefinitely
Gregory P. Smith g...@krypto.org added the comment: it happens on 3.2 (py3k head). -- Added file: http://bugs.python.org/file20208/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10794 ___it happens on 3.2 (py3k head).br ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6285] Silent abort on XP help document display
Changes by Terry J. Reedy tjre...@udel.edu: Removed file: http://bugs.python.org/file20199/z6285.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6285 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6285] Silent abort on XP help document display
Terry J. Reedy tjre...@udel.edu added the comment: I verified the bug by creating a copy of idlelib/help.txt, making the new help entry, testing it, deleting the copy, and retesting -- IDLE silently disappears. (A copy is necessary because IDLE checks that the file exists and gives a similar message as in the patch before posting the new menu item.) I decided that since a file can get renamed, moved, or deleted for various reasons, failure to open it should be caught. I them tested my patch, found and fixed an typo-error (yes, testing is good even for simple patches!), found and fixed another bug in one of the two functions, and committed. r87598, r97599, r87600 -- resolution: - fixed status: open - closed Added file: http://bugs.python.org/file20209/z6285.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6285 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2636] Regexp 2.7 (modifications to current re 2.2.2)
Matthew Barnett pyt...@mrabarnett.plus.com added the comment: Just to check, does this still work with your changes of msg124959? regex.search(r'\d{4}(\s*\w)?\W*((?!\d)\w){2}', XX) For me it fails to match! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2636 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6285] Silent abort on XP help document display
Terry J. Reedy tjre...@udel.edu added the comment: Bug and fix also apply to missing Idlelib/help.txt. r87601 News entry for 3.2. Thanks Scott. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6285 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2636] Regexp 2.7 (modifications to current re 2.2.2)
Jacques Grove aquara...@gmail.com added the comment: You're correct, after the change: regex.search(r'\d{4}(\s*\w)?\W*((?!\d)\w){2}', XX) doesn't match (i.e. as before commit 7abd9f9bb1). I was, however, just trying to narrow down which part of the code change killed the performance on my regression tests :-) Happy new year to all out there. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2636 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
Eli Bendersky eli...@gmail.com added the comment: I'll try to produce a test in the next hour or two -- nosy: +eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
Eli Bendersky eli...@gmail.com added the comment: I'm attaching a patch with a test for Martin's fix. I had trouble programmatically generating a bad zip for this bug, since it has different encodings for the header and filename (probably created by WinZip?). So I created a directory in test/ and placed the problematic zipfile M.Z. submitted in there, and wrote an appropriate test in test_zipfile.py I verified the test fails on py3k trunk before Martin's fix, and succeeds after it, both by running the test file directly and through regrtest. Note: Tested only on Ubuntu -- Added file: http://bugs.python.org/file20210/issue10801_test.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
Changes by Eli Bendersky eli...@gmail.com: Removed file: http://bugs.python.org/file20210/issue10801_test.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters
Changes by Eli Bendersky eli...@gmail.com: Added file: http://bugs.python.org/file20211/issue10801_test.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10801 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com