[issue11549] Rewrite peephole to work on AST
Eugene Toder elto...@gmail.com added the comment: AFAICT my patch has everything that #1346238 has, except BoolOps, which can be easily added (there's a TODO). I don't want to add any new code, though, until the current patch will get reviewed -- adding code will only make reviewing harder. #10399 looks interesting, I will take a look. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11549 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11604] Have type(n,b,d) check for type(b[i]) is module
Ray.Allen ysj@gmail.com added the comment: I am only suggesting a check for module because the is the only mistake I remember anyone reporting. Passing a number as a base class gives a similar message, but no one does that. And as far as I know, there is no way in general to detect whether a callable works as a metaclass except by calling it with name, bases, and dict. Since 3.x all the module names became lower-case and can be easily differ from class names, so I don't think this problem will present much in 3.x, right? -- nosy: +ysj.ray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11604 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10812] Add some posix functions
Roundup Robot devnull@devnull added the comment: New changeset 96e09d039433 by Ross Lagerwall in branch 'default': Fix refleak introduced by #10812. http://hg.python.org/cpython/rev/96e09d039433 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10812 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11465] Set documentation: Link to wikipedia
Raymond Hettinger raymond.hettin...@gmail.com added the comment: I concur with the other respondants. Also, experience has shown a near zero learning curve for sets. For whatever reason, people seem to just get it and not require further explanation. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11465 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7198] Extraneous newlines with csv.writer on Windows
John Machin sjmac...@lexicon.net added the comment: Can somebody please review my doc patch submitted 2 months ago? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7198 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11463] IncompleteRead: IncompleteRead(168 bytes read)
Senthil Kumaran orsent...@gmail.com added the comment: Since the reporter did not get back with more details (testing against curl or a HEAD output to eliminate server issues), I am closing this issue. -- resolution: - invalid status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11463 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11549] Rewrite peephole to work on AST
Changes by Georg Brandl ge...@python.org: -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11549 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11563] test_urllibnet is triggering a ResourceWarning
Roundup Robot devnull@devnull added the comment: New changeset edc3d3b07435 by Senthil Kumaran in branch '3.2': Closes issue11563 - test_urllibnet ResourceWarning. Patch by Jeff McNeil. http://hg.python.org/cpython/rev/edc3d3b07435 New changeset dfceb98767c0 by Senthil Kumaran in branch 'default': Closes issue11563 test_urllibnet is triggering a ResourceWarning. Patch by Jeff McNeil. http://hg.python.org/cpython/rev/dfceb98767c0 -- nosy: +python-dev resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11563 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11412] Section numbers in the Library Reference have a trailing period
Georg Brandl ge...@python.org added the comment: WFM then. -- resolution: - works for me status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11412 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11563] test_urllibnet is triggering a ResourceWarning
STINNER Victor victor.stin...@haypocalc.com added the comment: @Senthil Kumaran: Because your patch touchs not only the test, can you document your change in Misc/NEWS? Sending a new HTTP header should be documented. Is there an issue to support persistent connections in AbstractHTTPHandler.do_open()? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11563 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11575] addresses.txt file leaks into search engines
Georg Brandl ge...@python.org added the comment: Sure, the repo can go private if deemed necessary. I still think this is not a big deal anyway. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11575 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11605] EMail generator.flatten() disintegrates over UTF-8 multipart/alternative
New submission from Steffen Daode Nurpmeso sdao...@googlemail.com:
Hi David, i'm having real problems here!
Got a multipart mail and i get this:
__
Traceback (most recent call last):
File /Users/steffen/usr/bin/s-postman.py, line 1239, in save_ticket
mb.add(ticket.message())
File /Users/steffen/usr/opt/py3k/lib/python3.3/mailbox.py, line 279, in add
self._dump_message(message, tmp_file)
File /Users/steffen/usr/opt/py3k/lib/python3.3/mailbox.py, line 215, in
_dump_message
gen.flatten(message)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line 91,
in flatten
self._write(msg)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
137, in _write
self._dispatch(msg)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
163, in _dispatch
meth(msg)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
224, in _handle_multipart
g.flatten(part, unixfrom=False, linesep=self._NL)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line 91,
in flatten
self._write(msg)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
137, in _write
self._dispatch(msg)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
163, in _dispatch
meth(msg)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
388, in _handle_text
super(BytesGenerator,self)._handle_text(msg)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
201, in _handle_text
self.write(payload)
File /Users/steffen/usr/opt/py3k/lib/python3.3/email/generator.py, line
349, in write
self._fp.write(s.encode('ascii', 'surrogateescape'))
Exception: UnicodeEncodeError: 'ascii' codec can't encode character '\xdf' in
position 21: ordinal not in range(128)
__
I'll attach that mail. I don't know wether your version of
my postman reproduces it (though it should, but hey, it's broken!),
i'm using tag 0.4.0a1 (revision 420fcd870797).
I would be thankful for a hint on what this is and how i can
avoid this.
--
components: Library (Lib)
files: generator_booom.mbox
messages: 131406
nosy: r.david.murray, sdaoden
priority: normal
severity: normal
status: open
title: EMail generator.flatten() disintegrates over UTF-8 multipart/alternative
type: behavior
versions: Python 3.3
Added file: http://bugs.python.org/file21288/generator_booom.mbox
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11605
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11606] maxlinelen exceeded by email module's body_encode() function
New submission from Michael Henry pyt...@drmikehenry.com: The email module's body_encode() function (found in quoprimime.py) can generate oversized encoded lines that exceed the maximum line length specified by the maxlinelen parameter. The attached test case 'test_encode_trailing_space_at_maxlinelen' demonstrates the problem. When encoding the body 'abcd \n1234' with maxlinelen=5, the erroneous output is 'abcd =\n\n1234', with 6 characters in the first output line. The attached patch provides unit tests and a fix for body_encode(). Note: This patch depends on application of the patch in Issue #11590. -- components: Library (Lib) files: quoprimime_patch_body_encode.patch keywords: patch messages: 131407 nosy: michael.henry, r.david.murray priority: normal severity: normal status: open title: maxlinelen exceeded by email module's body_encode() function Added file: http://bugs.python.org/file21289/quoprimime_patch_body_encode.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11606 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11605] EMail generator.flatten() disintegrates over UTF-8 multipart/alternative
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment: Just want to point out that to my knowledge the mail is absolutely correct, in respect to classification and content. BytesGenerator tries to warp a UTF-8 message (which effectively contains LATIN1 data in the text part) to ASCII data, failing on the first (correctly LATIN1-ified) character. Maybe the addressed behaviour would indeed belong to #11216? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11605 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11605] EMail generator.flatten() disintegrates over non-ascii multipart/alternative
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment: By the way, instead of using my postman you may also reuse the stuff from #11401. To crash that instead of generator_booom.mbox simply change whatever character in the text/plain part to a valid LATIN1 (charset=ISO-8859-1) character, i've personally changed the second character of 'You' to 00F6;LATIN SMALL LETTER O WITH DIAERESIS;Ll;0;L;006F 0308N;LATIN SMALL LETTER O DIAERESIS;;00D6;;00D6 -- title: EMail generator.flatten() disintegrates over UTF-8 multipart/alternative - EMail generator.flatten() disintegrates over non-ascii multipart/alternative versions: +Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11605 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11459] Python select.select does not correctly report read readyness
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch which uses -1 for the buffer size of popen(). This gets translated by the io.open() to the default io buffer size. -- Added file: http://bugs.python.org/file21290/11459_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11459 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10050] urllib.request still has old 2.x urllib primitives
Antoine Pitrou pit...@free.fr added the comment: I don't think the tests should be moved from one file to the other. It's making more difficult to tell whether you have changed them or not. I think moving the tests (as well as changing the synopsis, hello Eric) are cosmetic changes that are better done in separate changesets. Some other things: - please do the import tempfile at the top-level. Imports from functions are generally frown upon, unless otherwise necessary. - instead of try ... finally: tfp.close(), you can simply write with tfp: ... - I don't understand why `size` is read only when a reporthook is set, while it is always used for raising ContentTooShortError - I'm not sure why the reporthook is called with `bs` rather than `len(block)`. I think the user is more interested in the actual number of bytes. - you don't need to update Misc/NEWS yourself -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10050 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11466] getpass.getpass doesn't close tty file
Éric Araujo mer...@netwok.org added the comment: About security: i think that you, Éric, have referred to this when you've said your patch is not uncontroversial. No, I was only referring to the fact that one unrelated change was present in a patch while it was still being discussed in another issue (“This new patch (11466.2.patch) also includes the #11236 patch”). it would be easier if _raw_input() would take a terminal_setup=False argument and encapsulate echoing of a final newline It’s a private function, it that makes the patch smaller let’s change it. The current patch looks rather complicated just to close a file object. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11466 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11572] bring Lib/copy.py to 100% coverage
Éric Araujo mer...@netwok.org added the comment: Nice cleanup. -reductor = getattr(x, __reduce__, None) -if reductor: -rv = reductor() -else: -raise Error(un(shallow)copyable object of type %s % cls) +raise Error(un(shallow)copyable object of type %s % cls) Why change this? self.assertTrue(issubclass(copy.Error, Exception)) You could change that to assertIsInstance. -def _test(): I assume that all cases that were tested in that function are covered by unit tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11572 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z
Changes by Éric Araujo mer...@netwok.org: -- Removed message: http://bugs.python.org/msg130613 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11236 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z
Éric Araujo mer...@netwok.org added the comment: If this bugs needs to be solved before #11466 can be fixed, let’s mark it as a dependency. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11236 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11466] getpass.getpass doesn't close tty file
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment: On Sat, Mar 19, 2011 at 01:29:28PM +, Éric Araujo wrote: It’s a private function, it that makes the patch smaller let’s change it. You get a new patch from me tomorrow evening at the latest -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11466 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7198] Extraneous newlines with csv.writer on Windows
Skip Montanaro s...@pobox.com added the comment: John John Machin sjmac...@lexicon.net added the comment: John Can somebody please review my doc patch submitted 2 months ago? My apologies. I have it in my sandbox, but a combination of the switch to Mercurial and lack of round tuits has conspired to keep me from checking it in. Skip -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7198 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7198] Extraneous newlines with csv.writer on Windows
Skip Montanaro s...@pobox.com added the comment: Actually, I was thinking of another doc patch for the csv module. Your changes (or something very like them) made it into the 3.2 release, as you can see here: http://docs.python.org/py3k/library/csv.html S -- resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7198 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11605] EMail generator.flatten() disintegrates over non-ascii multipart/alternative
Changes by R. David Murray rdmur...@bitdance.com: -- assignee: - r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11605 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11606] maxlinelen exceeded by email module's body_encode() function
Changes by R. David Murray rdmur...@bitdance.com: -- assignee: - r.david.murray stage: - patch review type: - behavior versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11606 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10050] urllib.request still has old 2.x urllib primitives
Jeff McNeil j...@jmcneil.net added the comment: I'll make those changes, sure. I had the same thought re: block size, but I was trying to keep inline with what the current function did. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10050 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11605] EMail generator.flatten() disintegrates over non-ascii multipart/alternative
R. David Murray rdmur...@bitdance.com added the comment: I can reproduce this just using message_from_binary_file and BytesGenerator on your input file, so thanks for attaching the email. I have a test in the test suite that is *supposed* to test this, but clearly there is a case here that is not being tested. It looks like there is something about multipart that my code isn't handling. I'll look in to it. (I'm very annoyed with myself that I didn't put in a test case for this to start with.) -- stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11605 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11575] addresses.txt file leaks into search engines
Skip Montanaro s...@pobox.com added the comment: Tom Pinckney thinks it's a big deal. I suspect he might be interested to know why you think it's not. We are entitled to our own opinions about privacy, but the request at hand concerns another person's privacy. He's the one you need to convince. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11575 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11575] addresses.txt file leaks into search engines
Georg Brandl ge...@python.org added the comment: As I said, I'm not opposed to make the repo private. I don't need to convince anyone. You sound like you're trying to change my opinion here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11575 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11459] Python select.select does not correctly report read readyness
Antoine Pitrou pit...@free.fr added the comment: Here is the adapted patch for 3.1, with a test case. -- nosy: +pitrou Added file: http://bugs.python.org/file21291/11459_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11459 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11607] Apllication crashes when saving file
New submission from roobman26 rlsander...@gmail.com: when i try to save a file it saves, but then the application crashes. The same thing happens when I try to open a saved file. -- assignee: ronaldoussoren components: Macintosh messages: 131424 nosy: ronaldoussoren, roobman26 priority: normal severity: normal status: open title: Apllication crashes when saving file type: crash versions: Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11607 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11459] Python select.select does not correctly report read readyness
Roundup Robot devnull@devnull added the comment: New changeset 1dc52ecb8949 by Antoine Pitrou in branch '3.1': Issue #11459: A `bufsize` value of 0 in subprocess.Popen() really creates http://hg.python.org/cpython/rev/1dc52ecb8949 New changeset 7451da272111 by Antoine Pitrou in branch '3.2': Issue #11459: A `bufsize` value of 0 in subprocess.Popen() really creates http://hg.python.org/cpython/rev/7451da272111 New changeset cb148da52c47 by Antoine Pitrou in branch 'default': Issue #11459: A `bufsize` value of 0 in subprocess.Popen() really creates http://hg.python.org/cpython/rev/cb148da52c47 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11459 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11459] Python select.select does not correctly report read readyness
Antoine Pitrou pit...@free.fr added the comment: Fixed now, thank you! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11459 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11608] GzipFile cannot be used for streaming
New submission from Enrico Zini enr...@enricozini.org: Hello, this snippet does not work, because GzipFile wants a file-like object that can do tell() and seek(): #!/usr/bin/python import gzip from urllib import urlopen zfd = urlopen(http://ftp.debian.org/debian/dists/sid/Contents-udeb.gz;) fd = gzip.GzipFile(fileobj=zfd, mode=r) for line in fd: foobar(line) It must be possible to build a decompressing file-like object wrapper that can do without seeking, since it is obviously not a limitation of gzip decompression libraries. It would be extremely useful to have such a thing, as shown in the example snippet above. Some more details (including a very annoying misrepresentation of the issue found in Dive Into Python) can be found at http://www.enricozini.org/2011/cazzeggio/python-gzip/ (I apologise about the ranting tone of the post). -- components: Library (Lib) messages: 131427 nosy: enrico priority: normal severity: normal status: open title: GzipFile cannot be used for streaming type: behavior versions: Python 2.5, Python 2.6, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11608 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11607] Apllication crashes when saving file
Eric Smith e...@trueblade.com added the comment: You're going to need to supply more information. What application? Can you post the source code? What does crashes mean? Is it giving a Python traceback? If so, please supply it. Thanks. -- nosy: +eric.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11607 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11563] test_urllibnet is triggering a ResourceWarning
Nadeem Vawda nadeem.va...@gmail.com added the comment: urlopen_HttpTests.test_willclose() fails to call unfakehttp(), which breaks subsequent runs of test_urllib2_localnet, test_urllib2net and test_urllibnet. Fix attached. -- Added file: http://bugs.python.org/file21292/unfakehttp.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11563 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11609] urllib-related buildbot failures
New submission from Antoine Pitrou pit...@free.fr: Many urllib-related buildbot failures recently, this seems to be cause by one of the recent urllib commits. 3.2 and 3.3 are affected. http://www.python.org/dev/buildbot/all/builders/AMD64%20Gentoo%20Wide%203.x/builds/1255 -- assignee: orsenthil components: Library (Lib), Tests keywords: buildbot messages: 131430 nosy: georg.brandl, orsenthil, pitrou priority: release blocker severity: normal stage: needs patch status: open title: urllib-related buildbot failures type: behavior versions: Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11609 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11572] bring Lib/copy.py to 100% coverage
Nick Coghlan ncogh...@gmail.com added the comment: Regarding __reduce__, other readers will have the same question Éric did, so that point should definitely go in a comment after the __reduce_ex__ check. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11572 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11575] addresses.txt file leaks into search engines
Antoine Pitrou pit...@free.fr added the comment: Ok, the repo is now private. -- resolution: - fixed status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11575 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11456] Documentation csv RFC4180
Roundup Robot devnull@devnull added the comment: New changeset c63d7374b89a by Skip Montanaro in branch 'default': Mention RFC 4180. Based on input by Tony Wallace in issue 11456. http://hg.python.org/cpython/rev/c63d7374b89a -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11456 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11572] bring Lib/copy.py to 100% coverage
Brandon Craig Rhodes bran...@rhodesmill.org added the comment: Nick Coghlan rep...@bugs.python.org writes: Nick Coghlan ncogh...@gmail.com added the comment: Regarding __reduce__, other readers will have the same question Éric did, so that point should definitely go in a comment after the __reduce_ex__ check. I had initially wanted to make a comment, but feared the objection that a comment would eventually fall out of sync with the implementation of object.__reduce_ex__ over the years (just as copy.py currently has all sorts of cruft that is no longer applicable). But I think that you are right that a comment that's at least true today is better than no comment at all; so I will add one on Monday. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11572 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11583] os.path.isdir() is slow on windows
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11583 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11575] addresses.txt file leaks into search engines
Skip Montanaro s...@pobox.com added the comment: I interpreted not a big deal to mean that having addresses exposed was not a big deal. Too many pronouns perhaps. -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11575 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11610] Improving property to accept abstract methods
New submission from Darren Dale dsdal...@gmail.com:
I posted a suggestion at python-ideas that the declaration of abstract
properties could be improved in such a way that they could be declared with
either the long-form or decorator syntax using the built-in property and
abc.abstractmethod:
{{{
class MyProperty(property):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
for f in (self.fget, self.fset, self.fdel):
if getattr(f, '__isabstractmethod__', False):
self.__isabstractmethod__ = True
break
class C(metaclass=ABCMeta):
@MyProperty
@abstractmethod
def x(self):
pass
@x.setter
@abstractmethod
def x(self, val):
pass
# this syntax would also be supported:
#@abstractmethod
#def getx(self):
#pass
#@abstractmethod
#def setx(self, val):
#pass
#x = MyProperty(getx, setx)
class D(C):
'D does not define a concrete setter and cannot be instantiated'
@C.x.setter
def x(self):
return 1
class E(D):
'E has a concrete getter and setter, and can be instantiated'
@D.x.setter
def x(self, val):
pass
}}}
It is hopefully evident that a relatively minor extension can be made to the
built-in property such that @abstractproperty would no longer be needed. I have
prepared a patch, complete with documentation and unit tests, but unfortunately
I have not been able to test it because I have not been able to build Python
from a mercurial checkout on either Ubuntu 11.04 or OS X 10.6.6 (for reasons
unrelated to the patch.) BDFL thought the idea sounded good for inclusion in
Python-3.3, and requested I submit the patch here.
--
components: Library (Lib)
files: property_with_abstractmethod.patch
keywords: patch
messages: 131436
nosy: dsdale24
priority: normal
severity: normal
status: open
title: Improving property to accept abstract methods
type: feature request
versions: Python 3.3
Added file: http://bugs.python.org/file21293/property_with_abstractmethod.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11610
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11456] Documentation csv RFC4180
Changes by Skip Montanaro s...@pobox.com: -- resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11456 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11610] Improving property to accept abstract methods
Darren Dale dsdal...@gmail.com added the comment: The discussion on python-ideas: http://mail.python.org/pipermail/python-ideas/2011-March/009411.html -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11610 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11575] addresses.txt file leaks into search engines
Georg Brandl ge...@python.org added the comment: Your interpretation was correct indeed. It's an email address we're talking about here, which is necessarily a public bit of information, not a private one like a Social Security or credit card number. Anyway, the repo is now private, so nobody will be able to access any version of the addresses.txt anymore via python.org. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11575 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10515] csv sniffer does not recognize quotes at the end of line
Changes by Skip Montanaro s...@pobox.com: -- assignee: skip.montanaro - nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10515 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11549] Rewrite peephole to work on AST
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11549 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11579] python 2.5 does not build from hg - looks for subversion keywords
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11579 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11445] python.exe on OS X shared-llbrary build erroneously linked to MacPorts python library
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11445 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11419] Python-ast.[ch] out-of-date w.r.t. sources in fresh 2.5 checkout
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11419 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11007] stack tracebacks should give the relevant class name
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11007 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9348] Calling argparse's add_argument with the wrong number of metavars causes delayed error message
Denver Coneybeare denver.coneybe...@gmail.com added the comment: For kicks, I just took a look at this old, forgotten issue. I agree with the submitter that add_argument() should fail if nargs and metavar do not match, instead of having format_help() raise the exception later on. I've attached a patch (issue9348_patch_v01.txt) with a proposed fix and associated test cases. The drawback of my approach is that if a custom HelpFormatter is used which has different semantics for metavar it could cause add_argument() to incorrectly reject the metavar value. I'm not sure how common that is though. -- nosy: +denversc Added file: http://bugs.python.org/file21294/issue9348_patch_v01.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9348 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11421] Subversion keywords missing on 2.5 checkout
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11421 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11205] Evaluation order of dictionary display is different from reference manual.
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11205 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10954] No warning for csv.writer API change
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10954 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10444] A mechanism is needed to override waiting for Python threads to finish
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10444 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10401] Globals / builtins cache
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10401 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9650] format codes in time.strptime docstrings
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9650 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9788] atexit and execution order
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9788 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9755] Fix refcounting details in Py3k C API documentation
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9755 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8387] use universal newline mode in csv module examples
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8387 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11608] GzipFile cannot be used for streaming
Changes by Daniel Stutzbach stutzb...@google.com: -- nosy: +stutzbach ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11608 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5863] bz2.BZ2File should accept other file-like objects. (issue4274045)
Antoine Pitrou pit...@free.fr added the comment: Given the absence of response on python-dev, I'd say simply remove the obsolete copyright notice. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5863 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11610] Improving property to accept abstract methods
Changes by Daniel Urban urban.dani...@gmail.com: -- nosy: +durban ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11610 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11611] wxPython PropertyGrid Demo error and fix
New submission from Arif Zaman arifza...@gmail.com: In the wxPython Demo the PropertyGrid code has the lines # # Let's use some simple custom editor # # NOTE: Editor must be registered *before* adding a property that # uses it. pg.RegisterEditor(TrivialPropertyEditor) pg.RegisterEditor(SampleMultiButtonEditor) pg.RegisterEditor(LargeImageEditor) The first time you look at this demo, it runs. Then if you go to some other demo, and return back to this (in the same session), it tries to register the same editors. Since they are already registered this causes an AssertionError. I fixed it by # # Let's use some simple custom editor # # NOTE: Editor must be registered *before* adding a property that # uses it. try: pg.RegisterEditor(TrivialPropertyEditor) pg.RegisterEditor(SampleMultiButtonEditor) pg.RegisterEditor(LargeImageEditor) except AssertionError: pass although I am sure you can probably do better. PS: This is my first visit to this site, so if I have posted this with some incorrect area, please just let me know kindly. -- components: Demos and Tools messages: 131441 nosy: Arif.Zaman priority: normal severity: normal status: open title: wxPython PropertyGrid Demo error and fix type: compile error versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11611 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11610] Improving property to accept abstract methods
Daniel Urban urban.dani...@gmail.com added the comment: I looked at the patch (I didn't test it yet), my comments are on Rietveld. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11610 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11567] http.server error message format
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11567 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11205] Evaluation order of dictionary display is different from reference manual.
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- priority: normal - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11205 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7198] Extraneous newlines with csv.writer on Windows
John Machin sjmac...@lexicon.net added the comment: Skip, The changes that I suggested have NOT been made. Please re-read the doc page you pointed to. The writer paragraph does NOT mention that newline='' is required when writing. The writer examples do NOT include newline=''. The examples have NOT been enhanced by using a with statement and not using space as an example delimiter. PLEASE RE-OPEN THIS ISSUE. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7198 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11609] urllib-related buildbot failures
Roundup Robot devnull@devnull added the comment: New changeset 5c83a375a23e by Senthil Kumaran in branch '3.2': Call unfakehttp in order to close connection while opening the connection through a fakehttp object. http://hg.python.org/cpython/rev/5c83a375a23e -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11609 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11611] wxPython PropertyGrid Demo error and fix
Ned Deily n...@acm.org added the comment: What demo file are you referring to? If it is something to do with wxPython, you probably want to refer to the bug tracker for that project. wxPython is not part of the standard Python library. See http://www.wxpython.org/ and http://trac.wxwidgets.org/ -- nosy: +ned.deily status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11611 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11610] Improving property to accept abstract methods
Darren Dale dsdal...@gmail.com added the comment: Here is a new patch that addresses a couple problems found in review: * Unit tests contained a typo (Property instead of property) * DeprecationWarning would be issued when importing abc rather than when creating abstractproperty. (whether abstractproperty should be deprecated has been questioned). -- Added file: http://bugs.python.org/file21295/property_with_abstractmethod_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11610 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11607] Apllication crashes when saving file
Ronald Oussoren ronaldousso...@mac.com added the comment: Please also add the platform you are using python on, and which installer you used to install Python. Assuming that you have a problem with IDLE: If you used Mac OS X 64-bit/32-bit Installer (3.2) for Mac OS X 10.6: did you install a new copy of Tcl/Tk? The system version of Tk is known to be bad, the ActiveState installer fixes a number of those and that includes most crashers (see http://www.python.org/download/mac/tcltk/ for more information). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11607 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10954] No warning for csv.writer API change
John Machin sjmac...@lexicon.net added the comment: The doc patch proposed by Skip on 2001-01-24 for this bug has NOT been reviewed, let alone applied. Sibling bug #7198 has been closed in error. Somebody please help. -- nosy: +skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10954 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11609] urllib-related buildbot failures
Senthil Kumaran orsent...@gmail.com added the comment: Buildbots pass the tests again. -- priority: release blocker - resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11609 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11609] urllib-related buildbot failures
Roundup Robot devnull@devnull added the comment: New changeset 00459310b136 by Senthil Kumaran in branch 'default': closes issue11609. buildbot related failures in the test_urllibnet. http://hg.python.org/cpython/rev/00459310b136 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11609 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11485] Default SDK value on MacOSX needs changing
Ronald Oussoren ronaldousso...@mac.com added the comment: The 10.4 SDK needs to be changed in 2.7, 3.1 and 3.2 as well: the most recent version of Xcode no longer ships with the 10.4 SDK (and possibly without the 10.5 SDK as well, I'll writing this at the airport and haven't downloaded the latest release yet). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11485 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10954] No warning for csv.writer API change
Terry J. Reedy tjre...@udel.edu added the comment: Since this is not a doc issue, doc people would not especially see it. That aside... What is *your* review. Does it satisfy you? Answer on #7198 if you want. And please be a bit patient as people are learning the new hg system. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10954 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9740] Support for HTTP 1.1 persistent connections throughout the standard library
Changes by Senthil Kumaran orsent...@gmail.com: -- assignee: - orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9740 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.
Changes by Senthil Kumaran orsent...@gmail.com: -- assignee: - orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3566 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3080] Full unicode import system
Changes by STINNER Victor victor.stin...@haypocalc.com: Added file: http://bugs.python.org/file21296/issue3080.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3080 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11466] getpass.getpass doesn't close tty file
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
On Sat, Mar 19, 2011 at 01:29:28PM +, Ãric Araujo wrote:
Itâs a private function, if that makes the patch smaller letâs change it.
The promised 11466.5.patch. It:
- Fixes #11466 resource warning.
- Fixes bogus newline which would have been written before
in case the fallback implementation needs to be used.
+ _raw_input() has been renamed to _user_input() because that
is what it actually does (wether it's raw depends on caller).
It will now encapsulate the complete user prompting,
thus including the mentioned final newline.
- Allows patch-in of #11236 patch without any further
adjustments (i.e. no additional catch of another resource
warning necessary).
- It cleans up the control flow and the comments a bit which
i think was the reason that the first two items above could
actually become introduced in the code at all.
But - it's even larger than 11466.4.patch!
--
Added file: http://bugs.python.org/file21297/11466.5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11466
___diff --git a/Lib/getpass.py b/Lib/getpass.py
--- a/Lib/getpass.py
+++ b/Lib/getpass.py
@@ -38,27 +38,25 @@
Always restores terminal settings before returning.
-fd = None
-tty = None
-try:
-# Always try reading and writing directly on the tty first.
-fd = os.open('/dev/tty', os.O_RDWR|os.O_NOCTTY)
-tty = os.fdopen(fd, 'w+', 1)
-input = tty
-if not stream:
-stream = tty
-except EnvironmentError as e:
-# If that fails, see if stdin can be controlled.
+tty, exinst, passwd = None, None, None
+# Something to break off if an error happens
+while 1:
try:
-fd = sys.stdin.fileno()
-except (AttributeError, ValueError):
-passwd = fallback_getpass(prompt, stream)
-input = sys.stdin
-if not stream:
-stream = sys.stderr
+# Always try reading and writing directly on the tty first.
+fd = os.open('/dev/tty', os.O_RDWR|os.O_NOCTTY)
+input = tty = os.fdopen(fd, 'w+', 1)
+if not stream:
+stream = tty
+except EnvironmentError:
+# If that fails, see if stdin can be controlled;
+# use generic fallback implementation as last resort
+try:
+fd = sys.stdin.fileno()
+except:
+break
+if not stream:
+stream = sys.stderr
-if fd is not None:
-passwd = None
try:
old = termios.tcgetattr(fd) # a copy to save
new = old[:]
@@ -68,21 +66,29 @@
tcsetattr_flags |= termios.TCSASOFT
try:
termios.tcsetattr(fd, tcsetattr_flags, new)
-passwd = _raw_input(prompt, stream, input=input)
+passwd = _user_input(prompt, stream, input=input, echooff=True)
+except Exception as e:
+exinst = e
finally:
termios.tcsetattr(fd, tcsetattr_flags, old)
-stream.flush() # issue7208
-except termios.error as e:
+stream.flush() # issue7208 (7246)
+except Exception as e:
if passwd is not None:
-# _raw_input succeeded. The final tcsetattr failed. Reraise
-# instead of leaving the terminal in an unknown state.
-raise
-# We can't control the tty or stdin. Give up and use normal IO.
-# fallback_getpass() raises an appropriate warning.
-del input, tty # clean up unused file objects before blocking
-passwd = fallback_getpass(prompt, stream)
+# _user_input succeeded, but the final tcsetattr failed.
+# Reraise the termios.error instead of leaving the terminal
+# in an unknown state.
+exinst = e
+break
-stream.write('\n')
+if not exinst and passwd is None:
+# We can't control the tty or stdin. Give up and use normal IO.
+# fallback_getpass() raises an appropriate warning.
+passwd = fallback_getpass(prompt, stream)
+
+if tty:
+tty.close()
+if exinst:
+raise exinst
return passwd
@@ -115,10 +121,10 @@
if not stream:
stream = sys.stderr
print(Warning: Password input may be echoed., file=stream)
-return _raw_input(prompt, stream)
+return _user_input(prompt, stream, input=None, echooff=False)
-def _raw_input(prompt=, stream=None, input=None):
+def _user_input(prompt, stream, input=None, echooff=False):
# This doesn't save the string in the GNU readline history.
if not stream:
[issue3080] Full unicode import system
Changes by STINNER Victor victor.stin...@haypocalc.com: -- Removed message: http://bugs.python.org/msg123994 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3080 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment: The attached 11236.depend.patch updates Merlijn's patch so that it applies cleanly just in case the #11466.5.patch is used in the end. -- Added file: http://bugs.python.org/file21298/11236.depend.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11236 ___diff --git a/Lib/getpass.py b/Lib/getpass.py --- a/Lib/getpass.py +++ b/Lib/getpass.py @@ -60,7 +60,7 @@ try: old = termios.tcgetattr(fd) # a copy to save new = old[:] -new[3] = ~(termios.ECHO|termios.ISIG) # 3 == 'lflags' +new[3] = ~termios.ECHO # 3 == 'lflags' tcsetattr_flags = termios.TCSAFLUSH if hasattr(termios, 'TCSASOFT'): tcsetattr_flags |= termios.TCSASOFT ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10883] urllib: socket is not closed explicitly
Nadeem Vawda nadeem.va...@gmail.com added the comment: Would it be possible to commit this partial fix now? It gets rid of 4 of the 8 warnings that I am currently seeing in test_urllib2net. (As an aside, for anyone reading this who hasn't seen issue11563, test_urllibnet is now warning-free) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11563] test_urllibnet is triggering a ResourceWarning
Senthil Kumaran orsent...@gmail.com added the comment: Victor - Issue9740 and Issue3566 talks about the need to have persistent connection. 3.3 would be a good target to have this feature in. Shall add the NEWS entry. Nadeen Wadwa - Thanks for your patch. I committed the fix as part of another bug (Issue3566). I shall mention the credits in an update to the log. thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11563 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3080] Full unicode import system
STINNER Victor victor.stin...@haypocalc.com added the comment: Replace open_exclusive() by fopen(name, wb) on Windows: is it correct? I reverted this change in my Mercurial branch (unicode_import). rename xxxobj = xxx to keep original names and have a short patch done catch encoding errors in case_ok() done don't encode in case_ok() if case_ok() does nothing (eg. on Linux) done find a better name for find_module2() done: find_module_path_list() and find_module_path() -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3080 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11563] test_urllibnet is triggering a ResourceWarning
Changes by Senthil Kumaran orsent...@gmail.com: -- Removed message: http://bugs.python.org/msg131456 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11563 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11563] test_urllibnet is triggering a ResourceWarning
Senthil Kumaran orsent...@gmail.com added the comment: Victor - Issue9740 and Issue3566 talks about the need to have persistent connection. 3.3 would be a good target to have this feature in. Shall add the NEWS entry. Nadeem Vawda - Thanks for your patch. I committed the fix as part of another bug (Issue3566). I shall mention the credits in an update to the log. thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11563 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10954] No warning for csv.writer API change
John Machin sjmac...@lexicon.net added the comment: Terry, I have already made the point the docs bug is #7198. This is the meaningful-exception bug. My review is changing 'should' to 'must' is not very useful without a consistent interpretation of what those two words mean and without any enforcement of use of newline=''. I was patient enough to wait 2 months for a review of my doc patch on #7198. My issues are that the 3.2 docs have NOT been changed (have a look at the csv.writer paragraph: do you see the word newline anywhere??), #7198 has been closed without any action, and BOTH of these two issues (which have in effect been lurking about since Python 3.0.0alpha) appear to have been abandoned. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10954 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10444] A mechanism is needed to override waiting for Python threads to finish
Michael Hughes michaelahug...@gmail.com added the comment: Hey guys We don't always have control over all of the threads launched within our application. We might have inexperienced users writing basic scripts using threads, but they don't know enough about setting them to Daemon. Previous versions of the Python interpreter we were using in our app didn't block. I'd like an option to override the blocking, because for our application, for the most part, we do want it to always quit and not wait for threads to quit properly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10444 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10883] urllib: socket is not closed explicitly
Senthil Kumaran orsent...@gmail.com added the comment: I saw the partial fix suggested by the patch, but for some reason I did not see ResourceWarning being shutup. Let's look at this again. The warnings are all from the (old) ftp portion of the code.. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10444] A mechanism is needed to override waiting for Python threads to finish
Antoine Pitrou pit...@free.fr added the comment: This looks like an ugly hack to solve a slightly exotic problem. You could instead enumerate() all threads and set their daemon flag to False, before shutting down the interpreter. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10444 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11046] setup.py/configure [darwin]
Ronald Oussoren ronaldousso...@mac.com added the comment: I've filed Issue11485 for the SDK issue (the default SDK should be more sane for normal use). AFAIK that means it is not necessary to keep this issue open. -- resolution: - later status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11046 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3080] Full unicode import system
STINNER Victor victor.stin...@haypocalc.com added the comment: test_runpy fails on Windows on make_legacy_pyc() (of test.support), I don't know why. Gotcha: I replaced mkdir() by CreateDirectoryW(), but the directory already exists error was not ignored. Fixed by 2debe178697b. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3080 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11567] http.server error message format
Éric Araujo mer...@netwok.org added the comment: I agree with Ezio. I noticed the commit but didn’t comment: I wanted to bring up the subject of HTML-producing modules in the stdlib and advocate use of HTML 5 (for real, pragmatic reasons, not because of a mode effect—I’ll dig up a number of links that explain the problems with pseudo-XHTML). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11567 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
