[issue16838] fail to "import locale" when there's a dir named "locale" in current dir

[Christian Heimes]

Christian Heimes added the comment:

I'm not able to reproduce the issue. Please provide a step by step description 
of what you did. Does the locale directory contain any files?

--
nosy: +christian.heimes
type: compile error -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14621] Hash function is not randomized properly

[Nick Coghlan]

Nick Coghlan added the comment:

Bob, the hash invariant isn't a mere implementation detail, it is critical to 
making hash based data structures work properly - if two equal objects (say the 
integer zero and the float zero) ever end up in different hash bins, then the 
uniqueness property of dictionary keys and sets breaks down.

The three proposed mitigation strategies (using SipHash for string hashing, a 
tunable collision counting hash map and providing a non-hash based mapping 
container in the standard library) are all reasonable approaches to the problem 
and, most importantly, they're *orthogonal* approaches to the problem. There's 
nothing stopping us doing all three if someone is willing and able to provide 
the code.

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16838] fail to "import locale" when there's a dir named "locale" in current dir

[Eiro Neemous]

Changes by Eiro Neemous :


--
title: fail to import "locale" module when there's a dir named "locale" in pwd 
-> fail to "import locale" when there's a dir named "locale" in current dir

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16838] fail to import "locale" module when there's a dir named "locale" in pwd

[Eiro Neemous]

New submission from Eiro Neemous:

as title said, what's the problem?

--
title: fail to import "locale" module when there -> fail to import "locale" 
module when there's a dir named "locale" in pwd
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16838] fail to import "locale" module when there

[Eiro Neemous]

Changes by Eiro Neemous :


--
components: 2to3 (2.x to 3.x conversion tool)
nosy: Cravix
priority: normal
severity: normal
status: open
title: fail to import "locale" module when there
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14621] Hash function is not randomized properly

[Christian Heimes]

Christian Heimes added the comment:

Thanks for the information! I'm working on a PEP for the issue at hand.

--
assignee:  -> christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Re: [issue13810] refer people to Doc/Makefile when not using 'make' to build main documentation

[Senthil Kumaran]

I think, the the URLs on this page are correct ( or have been corrected
since the opening of this issue) -
http://hg.python.org/devguide/file/20333d160f4e/documenting.rst
If anything needs to be changed, then a patch would be helpful.


On Sat, Dec 29, 2012 at 8:48 AM, Tshepang Lekhonkhobe <
rep...@bugs.python.org> wrote:

>
> Tshepang Lekhonkhobe added the comment:
>
> > Additionally, the whole way we're fetching those tools will be revisited
> soon.
>
> What are/were your plans ?
>
> --
>
> ___
> Python tracker 
> 
> ___
> ___
> Python-bugs-list mailing list
> Unsubscribe:
> http://mail.python.org/mailman/options/python-bugs-list/senthil%40uthcode.com
>
>
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Senthil Kumaran]

Senthil Kumaran added the comment:

I reviewed the patch. Changes LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Zachary Ware]

Changes by Zachary Ware :


Removed file: http://bugs.python.org/file28392/iterable_glossary.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Zachary Ware]

Changes by Zachary Ware :


Removed file: http://bugs.python.org/file28520/iterable_glossary_no-reflow.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Zachary Ware]

Changes by Zachary Ware :


Added file: http://bugs.python.org/file28525/issue16747.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16694] Add pure Python operator module

[Zachary Ware]

Changes by Zachary Ware :


Added file: http://bugs.python.org/file28524/py_operator.v8.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16833] http.client delayed ack / Nagle algorithm optimisation performs badly for large messages

[Ramchandra Apte]

Changes by Ramchandra Apte :


--
title: httpc.lient delayed ack / Nagle algorithm optimisation performs badly 
for large messages -> http.client delayed ack / Nagle algorithm optimisation 
performs badly for large messages

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14393] Incorporate Guide to Magic Methods?

[Ezio Melotti]

Changes by Ezio Melotti :


--
type:  -> enhancement
versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16748] Ensure test discovery doesn't break for modules testing C and Python implementations

[Ezio Melotti]

Ezio Melotti added the comment:

Attached patch fixes Lib/test/test_heapq.py.
I also replaced the test_main() with unittest.main() and got rid of the code 
previously used to "test" reference leaks.  As it is the patch can be applied 
on 3.3/default.  If you think it should be backported to 2.7/3.2 too, the 
changes on test_main() should be reverted.

--
keywords: +patch
stage: test needed -> patch review
Added file: http://bugs.python.org/file28523/issue16748.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16818] Couple of mistakes in PEP 431

[Ezio Melotti]

Ezio Melotti added the comment:

Fixed in http://hg.python.org/peps/rev/90a9e083933b.
I also made a few more fixes in http://hg.python.org/peps/rev/eb668670ad0e.

--
assignee:  -> ezio.melotti
nosy: +barry, ezio.melotti
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16835] Update PEP 399 to allow for test discovery

[Ezio Melotti]

Changes by Ezio Melotti :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14590] ConfigParser doesn't strip inline comment when delimiter occurs earlier without preceding space.

[Roundup Robot]

Roundup Robot added the comment:

New changeset d5c45089df2d by Łukasz Langa in branch '3.3':
Misc/NEWS updated to tell about #14590 and #16820
http://hg.python.org/cpython/rev/d5c45089df2d

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16820] configparser.ConfigParser.clean and .update bugs

[Roundup Robot]

Roundup Robot added the comment:

New changeset d5c45089df2d by Łukasz Langa in branch '3.3':
Misc/NEWS updated to tell about #14590 and #16820
http://hg.python.org/cpython/rev/d5c45089df2d

New changeset 7938847b2641 by Łukasz Langa in branch '3.2':
Misc/NEWS updated to tell about #16820
http://hg.python.org/cpython/rev/7938847b2641

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Martin v . Löwis]

Changes by Martin v. Löwis :


--
Removed message: http://bugs.python.org/msg178789

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Martin v . Löwis]

Changes by Martin v. Löwis :


--
Removed message: http://bugs.python.org/msg178791

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Martin v . Löwis]

Martin v. Löwis added the comment:

(sorry, wrong issue)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13719] bdist_msi upload fails

[Martin v . Löwis]

Martin v. Löwis added the comment:

schmir: your information on msi support is probably outdated; pypi.python.org 
does support MSI files, see for example

http://pypi.python.org/pypi/Twisted/12.3.0

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Martin v . Löwis]

Martin v. Löwis added the comment:

schmir: your information on msi support is probably outdated; pypi.python.org 
does support MSI files, see for example

http://pypi.python.org/pypi/Twisted/12.3.0

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

[Daniel Shahaf]

Daniel Shahaf added the comment:

Also, the class inheritance in the tests should be amended to follow #16835.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16694] Add pure Python operator module

[Zachary Ware]

Zachary Ware added the comment:

Ok, I believe the attached v7 properly addresses Éric's concerns about test 
discovery, and has no other changes unrelated to that compared to v5.

Thank you very much to Ezio for directing me towards the json tests for an 
example to work from.

--
nosy: +ezio.melotti
Added file: http://bugs.python.org/file28522/py_operator.v7.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Chris Jerdonek]

Chris Jerdonek added the comment:

Changed lines should still be reflowed to respect the column limit.  I was just 
referring to the unchanged lines before and afterwards that shouldn't be 
reflowed.

Not reflowing makes it easier for people viewing diffs on python-checkins and 
hg.python.org, using hg annotate, etc. to see what has changed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16837] Number ABC can be instantiated

[Alexander Belopolsky]

New submission from Alexander Belopolsky:

According to the reference manual, "None of the types defined in [numbers] 
module can be instantiated."  However,

>>> from numbers import *
>>> Number()


This can probably be fixed by making Number.__hash__ an abstract method.

--
messages: 178785
nosy: belopolsky
priority: normal
severity: normal
status: open
title: Number ABC can be instantiated
type: behavior
versions: Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14621] Hash function is not randomized properly

[Domen Kožar]

Domen Kožar added the comment:

According to talk at 29c3: 
http://events.ccc.de/congress/2012/Fahrplan/events/5152.en.html

Quote: We also describe a vulnerability of Python's new randomized hash, 
allowing an attacker to easily recover the 128-bit secret seed. As a reliable 
fix to hash-flooding, we introduce SipHash, a family of cryptographically 
strong keyed hash function competitive in performance with the weak hashes, and 
already adopted in OpenDNS, Perl 5, Ruby, and in the Rust language.

--
nosy: +iElectric

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

[Daniel Shahaf]

Daniel Shahaf added the comment:

Eli Bendersky wrote on Tue, Jan 01, 2013 at 00:32:51 +:
> 1. Why did you choose to implement __reduce__ and not __getstate__?

Maybe I was simply imitating what some other extension module was doing ;)

By using __reduce__ with the type as first return value, the
__setstate__ code becomes simpler because it doesn't need to address
'tag' and 'attrib'.  This consideration is somewhat moot now that the
unpickle-Python-pickled-Element's code path has to think about all
instance attributes, including those settable by the constructor.

> 2. A lot of code appears to be shared between
> element_setstate_from_attributes and the init method implementation,
> can it be refactored?

It seems there might be room for code reuse --- both functions set
tag,text,tail,attrib (but the unpickler sets the children too).  I'll
look into that in the next iteration (once the class name and pickle
output format issues are settled).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16833] httpc.lient delayed ack / Nagle algorithm optimisation performs badly for large messages

[Benno Leslie]

Benno Leslie added the comment:

I've updated the patch based on Charles-François and Antoine's feedback.

Primarily this increase the estimated MSS value to 16KiB.
Additionally tests are added and comments improved.

Thanks for the feedback.

--
Added file: http://bugs.python.org/file28521/http_opt_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Ezio Melotti]

Ezio Melotti added the comment:

Yes, that would have been better.
I actually prefer reflowing text, but pointing out the changes makes reviewing 
the patch easier.

--
assignee: docs@python -> ezio.melotti
stage:  -> commit review
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13719] bdist_msi upload fails

[Ralf Schmitt]

Ralf Schmitt added the comment:

AFAIK pypi.python.org disallows uploads of .msi files. That means I've lost 
interest in this issue. 

Feel free to close it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16694] Add pure Python operator module

[Zachary Ware]

Changes by Zachary Ware :


Removed file: http://bugs.python.org/file28391/py_operator.v6.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16694] Add pure Python operator module

[Zachary Ware]

Zachary Ware added the comment:

Sorry, I misunderstood Éric's suggestions regarding the tests; v6 is useless.  
v7 forthcoming.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

[Daniel Shahaf]

Daniel Shahaf added the comment:

Eli Bendersky wrote on Tue, Jan 01, 2013 at 15:54:00 +:
> Why did you change the class name, by the way, I don't think it's
> a valid change at least for 3.3 in terms of backwards compatibility.
> 

With unmodified tip of 3.4:

>>> import pickle, xml.etree.ElementTree as ET
>>> pickle.dumps(ET.Element('foo'))
Traceback (most recent call last):
  File "", line 1, in 
_pickle.PicklingError: Can't pickle : attribute lookup 
builtins.Element failed

I added the "_elementtree" to the tp_name in order to bypass the above
error.  Module-qualified names were in use elsewhere (including by
_elementtree._element_iterator) so it seemed reasonable.  I'll defer to
you about compatibility implications of this change.

> Regarding that compatibility, and even easier idea would be for the
> C pickle to return the same __dict__ implicitly gathered from the
> Python version, and then only one version of the unpickle is required.

That makes sense.  But going forward it might be even better to define
an explicit __reduce__/__getstate__ for the Python version too, so if
the instance dict grows new members, they won't get serialised
unintentionally.  (This consideration is also why C code in the latest
patch makes some effort to notice unknown args in the dict.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Zachary Ware]

Zachary Ware added the comment:

Hi folks,

Sorry it's taken me so long to get back to this, it's been a busy month :)

Here's the non-reflowed diff.  In retrospect, I should have just specifically 
mentioned the grammatical changes I made in the first place; they were merely 
to change 'and' between 'dict' and 'file object' to a comma, and add a comma 
after 'file object'.

--
Added file: http://bugs.python.org/file28520/iterable_glossary_no-reflow.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16820] configparser.ConfigParser.clean and .update bugs

[Łukasz Langa]

Łukasz Langa added the comment:

Breaking section order when using `__setitem__` was a bug and as such was fixed 
in 3.2.4 and 3.3.1.

In the DEFAULTSECT case above someone could potentially use the broken 
behaviour as a feature so that change was only made for 3.3.1+. In the section 
order case there is no such controversy.

--
resolution: rejected -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Ralf Schmitt]

Ralf Schmitt added the comment:

The TypeError error happened when using gevent. I've already written in that 
other issue that this information was wrong and I get a "bad family" error. 
Sorry, about that.

But this also demonstrates my point here. The Type error was raised exactly 
because the gevent code didn't expect a string at that point!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16818] Couple of mistakes in PEP 431

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
nosy: +belopolsky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16820] configparser.ConfigParser.clean and .update bugs

[Roundup Robot]

Roundup Robot added the comment:

New changeset 6f0cee62f0c6 by Łukasz Langa in branch '3.2':
configparser: preserve section order when using `__setitem__` (issue #16820)
http://hg.python.org/cpython/rev/6f0cee62f0c6

New changeset 2f5320497017 by Łukasz Langa in branch '3.3':
Null-merged 3.2 section order preservation fix when using `__setitem__` (issue
http://hg.python.org/cpython/rev/2f5320497017

New changeset 27b698395d35 by Łukasz Langa in branch 'default':
Null-merged 3.2 section order preservation fix when using `__setitem__` (issue
http://hg.python.org/cpython/rev/27b698395d35

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Martin v . Löwis]

Martin v. Löwis added the comment:

It's not at all useless: it enables the application to bypass limitations in 
Python, i.e. process the sockaddr on its own (very much in the same way as you 
have to do for ioctl/fcntl).

Whether it's surprising or not depends on what you expected to happen. Python 
always tries to expose system interfaces unmodified, so one "should" expect 
something like this to happen when there is a real chance that the system 
returns data which Python cannot interpret.

What is puzzling is that you (reportedly) get a TypeError when you pass them to 
the socket creation (or connect); instead, it should tell you that the address 
family is not supported.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16047] Tools/freeze no longer works in Python 3

[Meador Inge]

Meador Inge added the comment:

As mentioned, the ABI issues are being handled in issue11824.  I believe the 
linking problems in this issue have to do with the changes that were made in 
3.3 to bootstrap importlib into Python.  I will look into it more.

--
assignee:  -> meador.inge
keywords: +3.3regression
stage:  -> needs patch
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

[Eli Bendersky]

Eli Bendersky added the comment:

Thank you for the input Stefan. I was actually glancing at _decimal as an 
example of implementing pickling and inter-compatibility between the C and Py 
versions of pickles.

You've chosen compatibility by having the same class name and __reduce__ 
returning the exact same tuple for both implementation. This is a pretty good 
idea.

Unfortunately, in the case of Element it's more difficult, because the existing 
Py implementation does not have __reduce__, so pickle does its thing by looking 
at __dict__. Changing the Py version to have a __reduce__ seems risky as it may 
break compatibility between the different Py versions of Element (say, from 
3.2) and this is bad.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Meador Inge]

Meador Inge added the comment:

I don't think the current patch is correct.  It breaks the usage of `freeze.py 
-p $path` since LIBDIR and LIBRARY are blindly used.

Maybe something like the attached that respects -p and -P can be used instead?

As for the testing, I think a reasonable solution to get started with is to add 
some buildbot runs that automate the hello.py freeze on various hosts.  That 
will give us some basic coverage and then more tests can be added over time if 
need be.  I would be happy to help set that up (with given guidance on how to 
access the buildbots).

Even with the attached patch I still can't fully build (on OS X 10.7.5) because 
of issue16047:

Undefined symbols for architecture x86_64:
  "_PyInit__imp", referenced from:
  __PyImport_Inittab in config.o
ld: symbol(s) not found for architecture x86_64

I will take a look at that issue next.

--
assignee:  -> meador.inge
Added file: http://bugs.python.org/file28519/issue11824-0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Ralf Schmitt]

Ralf Schmitt added the comment:

Given the fact that the bytes object is rather surprising and probaby useless 
for the caller I wouldn't call this a "correct result".

(sorry, I lost too much time on this issue, I had to put another comment here).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9644] PEP 383: os.statvfs() does not accept surrogateescape arguments

[STINNER Victor]

STINNER Victor added the comment:

@baikie: Thanks for the fix, I applied it to Python 3.2 and I added a test. I 
also added the patch to Python 3.3 and 3.3. You may migrate to Python 3.3, it 
has a better support for undecodable filenames ;-)

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9644] PEP 383: os.statvfs() does not accept surrogateescape arguments

[Roundup Robot]

Roundup Robot added the comment:

New changeset dbe607fdc271 by Victor Stinner in branch 'default':
(Merge 3.3) Issue #9644: Add a test on os.statvfs() for the PEP 383
http://hg.python.org/cpython/rev/dbe607fdc271

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9644] PEP 383: os.statvfs() does not accept surrogateescape arguments

[Roundup Robot]

Roundup Robot added the comment:

New changeset 479fca0adbf6 by Victor Stinner in branch '3.2':
Issue #9644: Fix the encoding used by os.statvfs(): use the filesystem encoding
http://hg.python.org/cpython/rev/479fca0adbf6

New changeset b0cc0b9e2472 by Victor Stinner in branch '3.3':
Issue #9644: Add a test on os.statvfs() for the PEP 383
http://hg.python.org/cpython/rev/b0cc0b9e2472

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Martin v . Löwis]

Martin v. Löwis added the comment:

The data returned is not bogus; this is the correct result. If the system's 
getaddrinfo returns an unsupported address family, Python returns a bytes 
object (the system's sockaddr buffer) to the application. This should be 
documented, though (either in the introduction to the socket module, or 
specifically for getaddrinfo).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16836] configure script disables support for IPv6 on a system where IPv6 is disabled

[Antoine Pitrou]

Antoine Pitrou added the comment:

Indeed, I think the runtime check is misguided. If the system provides the 
required APIs for AF_INET6, then IPv6 support should be enabled regardless of 
whether the current system config allows to create an IPv6 socket or not.

Would you want to provide a patch for this? It's probably simple.

--
keywords: +easy
nosy: +pitrou
stage:  -> needs patch
versions: +Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16836] configure script disables support for IPv6 on a system where IPv6 is disabled

[Ralf Schmitt]

New submission from Ralf Schmitt:

The configure script uses a runtime check to determine if IPv6 is working. If 
IPv6 is disabled system-wide via a kernel option on linux, the resulting python 
interpreter is compiled as if "--disable-ipv6" had been passed to the configure 
script.

This causes multiple issues:
- http://bugs.python.org/issue7735
- http://bugs.python.org/issue16208

Both of the above issues have been closed as wontfix, and I have been told to 
not use --disable-ipv6 and instead disable IPv6 system wide via a boot option. 
This is what I did, and now I have the same issue because the configure script 
has this runtime check...

--
messages: 178762
nosy: schmir
priority: normal
severity: normal
status: open
title: configure script disables support for IPv6 on a system where IPv6 is 
disabled
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[STINNER Victor]

STINNER Victor added the comment:

> socket.getaddrinfo("python.org", 80)

This is a different issue: it's #7735.

> Do you really think that this is not a bug?

#7735 is a bug but it was decided that it will not be fixed. You may reopen 
#7735 if you disagree.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[Ralf Schmitt]

Ralf Schmitt added the comment:

socket getaddrinfo returns garbage:

>>> socket.getaddrinfo("python.org", 80)
[(2, 1, 6, '', ('82.94.164.162', 80)), (2, 2, 17, '', ('82.94.164.162', 80)), 
(2, 3, 0, '', ('82.94.164.162', 80)), (10, 1, 6, '', (10, 
'\x00P\x00\x00\x00\x00 \x01\x08\x88 \x00\x00\r')), (10, 2, 17, '', (10, 
'\x00P\x00\x00\x00\x00 \x01\x08\x88 \x00\x00\r')), (10, 3, 0, '', (10, 
'\x00P\x00\x00\x00\x00 \x01\x08\x88 \x00\x00\r'))]

yes, I would expect that python didn't give me garbage when calling 
getaddrinfo. Note that the caller didn't specify AF_INET6 this time!

Do you really think that this is not a bug?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16820] configparser.ConfigParser.clean and .update bugs

[Roundup Robot]

Roundup Robot added the comment:

New changeset f580342b63d8 by Łukasz Langa in branch '3.3':
configparser: preserve section order when using `__setitem__` (issue #16820)
http://hg.python.org/cpython/rev/f580342b63d8

New changeset a758f561a280 by Łukasz Langa in branch 'default':
Merged section order preservation fix when using `__setitem__` (issue #16820)
http://hg.python.org/cpython/rev/a758f561a280

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16320] Establish order in bytes/string dependencies

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I'll wait for some time, perhaps a Christian wants to say something.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16809] Tk 8.6.0 introduces TypeError. (Tk 8.5.13 works)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The simplest fix probably is just wrap self.tk.call() with str() (I have not 
tested it yet). However the problem is more serious (tkinter doesn't support 
fully even 8.5 and subtle bugs are possible) and I'll spend some more time on 
its research.

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16208] getaddrinfo returns wrong results if IPv6 is disabled

[STINNER Victor]

STINNER Victor added the comment:

"""The switch --disable-ipv6 is supported and works as intended. It is not the 
intention of the switch to disable  lookups. Instead, it disables support 
for IPv6 sockets."""

I just think that this definition is not exact. Do you seriously expect IPv6 to 
work when you explicitly use --disable-ipv6 which *disables* support of IPv6?

If you would like to use IPv6, just forget this old configuration option.

If you would like to disable IPv6, disable it system-wide. See:
http://bugs.python.org/issue7735#msg178634

--
nosy: +loewis
resolution:  -> wont fix
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9586] "warning: comparison between pointer and integer" in multiprocessing build on Tiger

[Richard Oudkerk]

Changes by Richard Oudkerk :


--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16820] configparser.ConfigParser.clean and .update bugs

[Łukasz Langa]

Łukasz Langa added the comment:

This is a fair point. Stay tuned.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Senthil Kumaran]

Senthil Kumaran added the comment:

Oh Okay, Thanks! I was checking it against 2.7!

On Tue, Jan 1, 2013 at 11:48 AM, R. David Murray wrote:

>
> R. David Murray added the comment:
>
> senthil: the file type doesn't exist any more in python3.
>
> --
> nosy: +r.david.murray
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16814] use --directory option of make in describing how to build the docs

[Senthil Kumaran]

Senthil Kumaran added the comment:

I find, cd Doc easy to remember as well. If make tricks can be used then I
hope readers note it rather than be exposed via Documentation. Chris's
patch is helpful to me, but still I may not vote a +1 for it to be in
Documentation. thanks.

On Sun, Dec 30, 2012 at 7:14 AM, Ezio Melotti wrote:

>
> Ezio Melotti added the comment:
>
> FWIW even if I heard about the one-liner a few times already I can't
> really seem to remember it, and prefer to do "cd Doc" anyway.  Using "cd
> Doc" also makes all the subsequent commands shorter (e.g. opening files,
> running other make targets).
> The patch proposed by Chris looks OK to me though.
>
> --
>
> ___
> Python tracker 
> 
> ___
> ___
> Python-bugs-list mailing list
> Unsubscribe:
> http://mail.python.org/mailman/options/python-bugs-list/senthil%40uthcode.com
>
>

--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16819] IDLE b"" method completion incorrect

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16819] IDLE b"" method completion incorrect

[Roundup Robot]

Roundup Robot added the comment:

New changeset de82da4b04cd by Serhiy Storchaka in branch '2.7':
Issue #16819: IDLE method completion now correctly works for unicode literals.
http://hg.python.org/cpython/rev/de82da4b04cd

New changeset 99a06886b258 by Serhiy Storchaka in branch '3.2':
Issue #16819: IDLE method completion now correctly works for bytes literals.
http://hg.python.org/cpython/rev/99a06886b258

New changeset b8b5303ac96f by Serhiy Storchaka in branch '3.3':
Issue #16819: IDLE method completion now correctly works for bytes literals.
http://hg.python.org/cpython/rev/b8b5303ac96f

New changeset 00cbbcd8af31 by Serhiy Storchaka in branch 'default':
Issue #16819: IDLE method completion now correctly works for bytes literals.
http://hg.python.org/cpython/rev/00cbbcd8af31

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16835] Update PEP 399 to allow for test discovery

[Ezio Melotti]

Ezio Melotti added the comment:

Here's a patch:
1) the base class doesn't inherit from TestCase anymore -- the subclasses do;
2) added a skipUnless() decorator on the C subclass;
3) used the modern if __name__ == '__main__': unittest.main() idiom;
4) renamed the AcceleratedExampleTest to CExampleTest (I prefer the PyFoo/CFoo 
parallel, "Accelerated" doesn't necessarily imply that it's testing the C 
version);
5) added a paragraph to explain the idiom;
6) added Post-History;
7) did a couple of minor cleanup in the code;

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15564] cgi.FieldStorage should not call read_multi on files

[Christian Boos]

Christian Boos added the comment:

I think that reverting to a read_single() when the read_multi() fails could do 
the trick here. At least this approach seems to work for uploading .mht files. 
See also http://trac.edgewall.org/ticket/9880.

--
nosy: +cboos

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16835] Update PEP 399 to allow for test discovery

[Ezio Melotti]

Changes by Ezio Melotti :


--
assignee:  -> ezio.melotti
components: +Documentation
nosy: +ezio.melotti
stage:  -> needs patch
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16748] Ensure test discovery doesn't break for modules testing C and Python implementations

[Brett Cannon]

Brett Cannon added the comment:

I created http://bugs.python.org/issue16835 to remind me to update PEP 399.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16835] Update PEP 399 to allow for test discovery

[Brett Cannon]

New submission from Brett Cannon:

Don't have the base tests inherit from TestCase else they will be discovered by 
unittest and run even though they are not fully defined.

See http://bugs.python.org/issue16748 as the trigger for this issue.

--
messages: 178748
nosy: brett.cannon
priority: normal
severity: normal
status: open
title: Update PEP 399 to allow for test discovery

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[R. David Murray]

R. David Murray added the comment:

senthil: the file type doesn't exist any more in python3.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

[Senthil Kumaran]

Senthil Kumaran added the comment:

Hello Zachary, What'wrong with referencing :class:`file` for iterable? I find 
it as OK. Also if it needs to be corrected, the reference could be made for 
:ref:`bltin-file-objects`

Re grammatical fixes, you could point out which were made as with the reflow of 
the text, it is difficult to spot the fix.

--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

[Stefan Krah]

Stefan Krah added the comment:

Yes, currently the C version is also used for unpickling. Actually
this problem was one of the reasons why _decimal sets its name to
"decimal".
 


from test.support import import_fresh_module
import pickle, sys

C = import_fresh_module('xml.etree.ElementTree', fresh=['_elementtree'])
P = import_fresh_module('xml.etree.ElementTree', blocked=['_elementtree'])
e = C.Element('foo', bar=42)
e.text = "text goes here"
e.tail = "opposite of head"
C.SubElement(e, 'child').append(C.Element('grandchild'))
e.append(C.Element('child'))
e.findall('.//grandchild')[0].set('attr', 'other value')
sys.modules['xml.etree.ElementTree'] = C 
s = pickle.dumps(e)
s

b'\x80\x03c_elementtree\nElement\nq\x00X\x03\x00\x00\x00fooq\x01}q\x02X\x03\x00\x00\x00barq\x03K*s\x86q\x04Rq\x05X
\x0e\x00\x00\x00text goes hereq\x06X\x10\x00\x00\x00opposite of 
headq\x07h\x00X\x05\x00\x00\x00childq\x08\x85q\tRq
\nNNh\x00X\n\x00\x00\x00grandchildq\x0b}q\x0cX\x04\x00\x00\x00attrq\rX\x0b\x00\x00\x00other
 valueq\x0es\x86q\x0fRq
\x10NNN\x87q\x11b\x85q\x12\x87q\x13bh\x00h\x08\x85q\x14Rq\x15NNN\x87q\x16b\x86q\x17\x87q\x18b.'

sys.modules['xml.etree.ElementTree'] = P
x = pickle.loads(s)
type(x)


--
nosy: +skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16819] IDLE b"" method completion incorrect

[Senthil Kumaran]

Senthil Kumaran added the comment:

The patch seems good to me. Please commit it.

--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16830] Add skip_host and skip_accept_encoding to httplib/http.client

[Antoine Pitrou]

Antoine Pitrou added the comment:

> On Tue, Jan 1, 2013 at 5:41 AM, Antoine Pitrou wrote:
> > Another possibility would be to allow passing None in values of the
> `headers` dict, in which case the given header wouldn't be send at
> all.
> 
> I agree that your solution is more scaling-friendly than the patch I
> originally submitted. But from another perspective, consider how alien
> it is to have to explicitly add keys set to None in the headers to get
> desired behavior.

Well, that is not a common need, is it?
That said, we could indeed have a separate argument "omit_headers"
listing the headers that we don't want to send.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11939] Implement stat.st_dev and os.path.samefile on windows

[Brian Curtin]

Brian Curtin added the comment:

Backed out the changeset. If you have a solution, feel free to fix it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16830] Add skip_host and skip_accept_encoding to httplib/http.client

[Bryan Bishop]

Bryan Bishop added the comment:

On Tue, Jan 1, 2013 at 5:41 AM, Antoine Pitrou wrote:
> Another possibility would be to allow passing None in values of the `headers` 
> dict, in which case the given header wouldn't be send at all.

I agree that your solution is more scaling-friendly than the patch I originally 
submitted. But from another perspective, consider how alien it is to have to 
explicitly add keys set to None in the headers to get desired behavior.

Maybe there could be a single flag "strict" (or possibly a better name) that 
would indicate that the dict is in fact what I want to send and that it should 
not be modified? Or perhaps there should be "base_headers" list (not a 
dictionary) of header keys of which defaults to not inject?

Also, would making {"Accept-Encoding": None} send no "Accept-Encoding" header 
be backwards incompatible with the current behavior?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11939] Implement stat.st_dev and os.path.samefile on windows

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Now the code is wrong on non-Windows without PY_LONG_LONG and with signed 
st_dev.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11939] Implement stat.st_dev and os.path.samefile on windows

[Roundup Robot]

Roundup Robot added the comment:

New changeset 61bada808b34 by Brian Curtin in branch 'default':
Set st_dev on Windows as unsigned long to match its DWORD type, related to the 
change to fix #11939.
http://hg.python.org/cpython/rev/61bada808b34

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9586] "warning: comparison between pointer and integer" in multiprocessing build on Tiger

[Roundup Robot]

Roundup Robot added the comment:

New changeset a5b49db3383d by Richard Oudkerk in branch '3.2':
Issue #9586: Redefine SEM_FAILED on MacOSX to keep compiler happy.
http://hg.python.org/cpython/rev/a5b49db3383d

New changeset a70db584e897 by Richard Oudkerk in branch '3.3':
Issue #9586: Merge
http://hg.python.org/cpython/rev/a70db584e897

New changeset 92990dd91b07 by Richard Oudkerk in branch 'default':
Issue #9586: Merge.
http://hg.python.org/cpython/rev/92990dd91b07

New changeset 395976a1f26f by Richard Oudkerk in branch '2.7':
Issue #9586: Redefine SEM_FAILED on MacOSX to keep compiler happy.
http://hg.python.org/cpython/rev/395976a1f26f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16748] Ensure test discovery doesn't break for modules testing C and Python implementations

[Ezio Melotti]

Ezio Melotti added the comment:

I just came across the problem described here while reviewing #16694.

The idiom I used for the JSON tests[0] (and possibly a couple of other tests) 
when I rewrote them was to have something like:

class FooTest:
# all the test methods here

class CFooTest(FooTest, unittest.TestCase):
module = c_foo

class PyFooTest(FooTest, unittest.TestCase):
module = py_foo

The reason to only have the subclasses inheriting from unittest.TestCase was 
exactly to avoid having FooTest as a discoverable TestCase.

I think PEP 399 should be updated and the tests should be fixed.
I don't think it's necessary to provide a base class as suggested in the first 
message (it's actually not even necessary to set the module to None, because 
eventually it will be set to either some cmodule or pymodule.  In case 
something goes wrong it's even better if the AttributeError says "self has no 
attribute 'module'" rather than "NoneType has no attribute 'somemeth'".)

@Brett, should I open a separate issue for the PEP 399 changes?

[0] see e.g.: Lib/test/json_tests/test_float.py and 
Lib/test/json_tests/__init__.py (note that here the idiom is a bit more 
complicated, because in addition to set the self.module, I also had to set 
additional attributes and work with different test files in the same package.  
I also added additional tests in __init__ to make sure that import_fresh_module 
worked after adapting it to work with packages.)

--
assignee:  -> ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16733] Solaris ctypes_test failures

[Meador Inge]

Changes by Meador Inge :


--
nosy: +meador.inge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16076] xml.etree.ElementTree.Element and xml.etree.ElementTree.TreeBuilder are no longer pickleable

[Eli Bendersky]

Eli Bendersky added the comment:

Other thoughts.

I'm not sure why you're surprised the C->Python pickle/unpickle works. You've 
changed the type name from Element to _elementtree.Element, so I would guess 
Python always uses the C version to unpickle as well. Can you debug to verify 
what actually goes on under the hood? Why did you change the class name, by the 
way, I don't think it's a valid change at least for 3.3 in terms of backwards 
compatibility.

Regarding that compatibility, and even easier idea would be for the C pickle to 
return the same __dict__ implicitly gathered from the Python version, and then 
only one version of the unpickle is required.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16787] asyncore.dispatcher_with_send - increase the send buffer size

[Charles-François Natali]

Charles-François Natali added the comment:

Closing!

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16787] asyncore.dispatcher_with_send - increase the send buffer size

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2eddf7c2efe6 by Charles-François Natali in branch 'default':
Issue #16787: Increase asyncore and asynchat default output buffers size, to
http://hg.python.org/cpython/rev/2eddf7c2efe6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16833] httpc.lient delayed ack / Nagle algorithm optimisation performs badly for large messages

[Charles-François Natali]

Charles-François Natali added the comment:

> Thanks for the patch. Perhaps our MSS value should be an upper bound of 
> common values? Apparently for a localhost connection TCP_MAXSEG gives 16384 
> here (but I don't know if the http.client optimization is important for 
> localhost connections).

According to http://en.wikipedia.org/wiki/Maximum_transmission_unit,
the MTU (from which the MSS is derived) for a wireless NIC is around
8000, and you can have jumbo frames on Ethernet up to 9000, so a value
of 2K might be too small (since the goal is to avoid sending a payload
less than MSS with its own send() syscall).
So I think a value like 16K should be OK (the downside to using a
large value is the extra copying, but OTOH it will incur less copying
than now).
Note that the ideal fix for this would be scatter-gather I/O with
sendmsg(): both the header and the payload could be sent in the same
segment, without any extra copying. But I'm not sure it's worth it
here.

A note on the comment:
"""
722 # TCP Maximum Segment Size (MSS) is a TCP stack parameter. There
723 # is no simple and efficient platform independent mechanism for
724 # determining the MSS, so instead a reasonable estimate is chosen.
"""

The MSS is not really a TCP stack parameter (i.e. it's not fixed by
the host like socket buffers, etc): it's usually negociated between
the hosts (and with path MTU discovery or IPv6 it depends on the path
MTU). That's why it's hard to guess ahead of time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16834] ioctl mutate_flag behavior in regard to the buffer size limit

[Yuval Weinbaum]

New submission from Yuval Weinbaum:

In fcntl module, the documentation states the following regarding the 
mutate_flag in ioctl method:

***
If it is false, the buffer’s mutability is ignored and behaviour is as for a 
read-only buffer, except that the 1024 byte limit mentioned above is avoided – 
so long as the buffer you pass is as least as long as what the operating system 
wants to put there, things should work.
***

However, looking at the code (fcntlmodule.c) it seems that the 1024 bytes 
limitation is avoided when the mutate_flag is set to True (the opposite of what 
is stated in the doc).

--
assignee: docs@python
components: Documentation
messages: 178732
nosy: Yuval.Weinbaum, docs@python
priority: normal
severity: normal
status: open
title: ioctl mutate_flag behavior in regard to the buffer size limit
versions: Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16828] bz2 error on compression of empty string

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
priority: normal -> high

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16833] httpc.lient delayed ack / Nagle algorithm optimisation performs badly for large messages

[Antoine Pitrou]

Antoine Pitrou added the comment:

Thanks for the patch. Perhaps our MSS value should be an upper bound of common 
values? Apparently for a localhost connection TCP_MAXSEG gives 16384 here (but 
I don't know if the http.client optimization is important for localhost 
connections).

Also, it would be nice to add an unit test in Lib/test/test_httplib.py.

--
nosy: +neologix, pitrou
stage:  -> patch review
versions: +Python 3.4 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16830] Add skip_host and skip_accept_encoding to httplib/http.client

[Antoine Pitrou]

Antoine Pitrou added the comment:

I'm not sure this is a desirable feature in the stdlib, but regardless, your 
solution isn't very scalable: a new argument will have to be added each time 
someone wants to avoid sending a given header.

Another possibility would be to allow passing None in values of the `headers` 
dict, in which case the given header wouldn't be send at all.

--
nosy: +orsenthil, pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16809] Tk 8.6.0 introduces TypeError. (Tk 8.5.13 works)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I don't install Tcl/Tk 8.6 yet, but looks as "pack info" call returns a new 
type of Tcl data (perhaps DictType) which doesn't detected in FromObj().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16833] httpc.lient delayed ack / Nagle algorithm optimisation performs badly for large messages

[Benno Leslie]

New submission from Benno Leslie:

he http.client HTTPConnection._send_output method has an optimization for 
avoiding bad interactions between delayed-ack and the Nagle algorithm:

http://hg.python.org/cpython/file/f32f67d26035/Lib/http/client.py#l884

Unfortunately this interacts rather poorly if the case where the message_body 
is a bytes instance and is rather large.

If the message_body is bytes it is appended to the headers, which causes a copy 
of the data. When message_body is large this duplication of data can cause a 
significant spike in memory usage.

(In my particular case I was uploading a 200MB file to 30 hosts at the same 
leading to memory spikes over 6GB.

[There is a short thread discussing this issue on python-dev; Subject: 
"http.client Nagle/delayed-ack optimization"; Date: Dec 15, 2012]

--
components: Library (Lib)
files: http_opt.diff
keywords: patch
messages: 178728
nosy: bennoleslie
priority: normal
severity: normal
status: open
title: httpc.lient delayed ack / Nagle algorithm optimisation performs badly 
for large messages
type: performance
versions: Python 3.3
Added file: http://bugs.python.org/file28518/http_opt.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11939] Implement stat.st_dev and os.path.samefile on windows

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> New changeset 3738d270c54a by Brian Curtin in branch 'default':
> st_dev/st_rdev should be unsigned long as dwVolumeSerialNumber, which it is
> set to, is a DWORD. This was fixed in #11939 and the overflow was
> mentioned in #10657 and seen by me on some machines.
> http://hg.python.org/cpython/rev/3738d270c54a

But than st_dev used as long in _pystat_fromstructstat(). Perhaps you should 
check if st_dev is negative and then select 
PyLong_FromLong/PyLong_FromLongLong or 
PyLong_FromUnsignedLong/PyLong_FromUnsignedLongLong.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16832] Expose cache validity checking support in ABCMeta

[Daniel Urban]

Changes by Daniel Urban :


--
nosy: +daniel.urban

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com