[issue18181] super vs. someclass.__getattribute__

2013-07-04 Thread Ronald Oussoren

Ronald Oussoren added the comment:

Updated version of the patch, with some semantic changes and tests for the 
Python level API.

Known issues:

* Patches uses tabs for indentation

* No tests for the C level API

* I don't like implementation of slot_tp_getattro_super

--
Added file: http://bugs.python.org/file30766/issue-18181-poc-v4.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18181] super vs. someclass.__getattribute__

2013-07-04 Thread Ronald Oussoren

Changes by Ronald Oussoren ronaldousso...@mac.com:


Removed file: http://bugs.python.org/file30546/issue-18181-poc.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18181] super vs. someclass.__getattribute__

2013-07-04 Thread Ronald Oussoren

Changes by Ronald Oussoren ronaldousso...@mac.com:


Removed file: http://bugs.python.org/file30555/issue-18181-poc-v3.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18181] super vs. someclass.__getattribute__

2013-07-04 Thread Ronald Oussoren

Changes by Ronald Oussoren ronaldousso...@mac.com:


Removed file: http://bugs.python.org/file30528/supers.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18181] super vs. someclass.__getattribute__

2013-07-04 Thread Ronald Oussoren

Changes by Ronald Oussoren ronaldousso...@mac.com:


Removed file: http://bugs.python.org/file30556/super-hook-proposal.rst

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18181] super vs. someclass.__getattribute__

2013-07-04 Thread Ronald Oussoren

Ronald Oussoren added the comment:

Also updated the draft PEP text

--
Added file: http://bugs.python.org/file30767/super-hook-proposal.rst

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18309] Make python slightly more relocatable

2013-07-04 Thread Mathias Fröhlich

Mathias Fröhlich added the comment:

Hi Ronald, Eric, Nick,

Looking up the symbol name of the current function should work also.
And I am free to rename these functions to whatever you like.

Attached is version 2 of the patch with the suggested changes.
The windows implementation is still untested.

It would be interesting to know if this kind of lookup scheme can be included 
into PEP 432.
Provided the spirit of this PEP, I can imagine to provide several functions to 
build up the pythonpath starting from something.
So say, have a 'get python path from argv[0]', a 'get python path from shared 
python library' and a 'get python path from prefix' function (I may miss a 
variant). Also a 'build python path from python home root entry point' function 
would be useful and could be used by the above functions.
An application embedding python can then call those functions that are sensible 
for its own use and installation scheme to set the module path in the PyConfig 
struct. The Py_ReadConfig function will internally use the above suggested 
functions to build up the default configuration if not already provided.

Greetings

Mathias

--
Added file: http://bugs.python.org/file30768/python-relative-path-lookup-v2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18309
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18356] help(numpy) causes segfault on exit

2013-07-04 Thread Michelle Arzul

New submission from Michelle Arzul:

As far as we could tell this bug is only consistently reproducible on Ubuntu 
13.04.

A line in pydoc.py causes a segfault when help(numpy) (no other libraries that 
I know of) exits. The offending method is pipepager().

For a full trackdown and workaround of the problem see 
http://stackoverflow.com/questions/17344974/python-helpnumpy-causes-segfault-on-exit

--
assignee: docs@python
components: Documentation
messages: 192276
nosy: Leeward, docs@python
priority: normal
severity: normal
status: open
title: help(numpy) causes segfault on exit
type: crash
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18356
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18356] help(numpy) causes segfault on exit

2013-07-04 Thread Christian Heimes

Christian Heimes added the comment:

Please provide more information about your setup. Not everybody has access to a 
Ubuntu 13.04 box

* exact Python version
* NumPy version
* platform (X86, X86_64, ARM)
* Kernel, libc and compiler version are useful, too
* terminal application
* environment variables (output of ``export``, you may want to strip sensible 
values like DBus address). Especially TERM, PAGER and all LESS* variables are 
of interest.

--
components: +Library (Lib) -Documentation
nosy: +christian.heimes
versions: +3rd party

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18356
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18356] help(numpy) causes segfault on exit

2013-07-04 Thread Michelle Arzul

Michelle Arzul added the comment:

I'm no expert, I just found the bug... but I'll try my best.

* exact Python version: 2.7.4 (GCC 4.7.3)
* NumPy version: 1.7.1
* platform (X86, X86_64, ARM): i686
* Kernel: Linux 3.8.0-25-generic #37-Ubuntu SMP Thu Jun 6 20:47:30 UTC 2013 
i686 i686 i686 GNU/Linux
* libc: ldd (Ubuntu EGLIBC 2.17-0ubuntu5) 2.17
* compiler: gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1)
* terminal application: not sure what you mean
* environment variables:
TERM=xterm
(PAGER is not present)
LESSCLOSE=/usr/bin/lesspipe %s %s
LESSOPEN=| /usr/bin/lesspipe %s

If you need anything else please let me know.

--
components: +Documentation -Library (Lib)
versions:  -3rd party

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18356
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18291] codecs.open interprets space as line ends

2013-07-04 Thread Paul

Paul added the comment:

Right, #7643 indeed seems to be exactly about the issue I described here (for 
as much as I know unicode which isn't all that much). So maybe they should be 
merged. The issue was closed March 2010, is that after 2.7.3 was released?

By the way, where I wrote \x12, \x13, \x14, and \x15, I should have written 
\x1c, \x1d, \x1e, \x1f (the hex representation of characters 28 to 31). Lost in 
translation, I guess.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18291
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18305] [patch] Fast sum() for non-numbers

2013-07-04 Thread Sergey

Sergey added the comment:

This patch implements another solution to the same bug. But instead of changing 
default code it adds a special case optimization for lists, tuples and strings, 
similar to those two special cases for numbers, that are already there.

=== Lists ===
No patch:
  $ ./python -mtimeit --setup=x=[[1,2,3]]*1 sum(x,[])
  10 loops, best of 3: 885 msec per loop
fastsum.patch:
  $ ./python -mtimeit --setup=x=[[1,2,3]]*1 sum(x,[])
  1000 loops, best of 3: 524 usec per loop
fastsum-special.patch:
  $ ./python -mtimeit --setup=x=[[1,2,3]]*1 sum(x,[])
  1000 loops, best of 3: 298 usec per loop
Result: 3000 times faster.

=== Tuples ===
No patch:
  $ ./python -mtimeit --setup=x=[(1,2,3)]*1 sum(x,())
  10 loops, best of 3: 585 msec per loop
fastsum.patch:
  $ ./python -mtimeit --setup=x=[(1,2,3)]*1 sum(x,())
  10 loops, best of 3: 585 msec per loop
fastsum-special.patch:
  $ ./python -mtimeit --setup=x=[(1,2,3)]*1 sum(x,())
  1000 loops, best of 3: 536 usec per loop
Result: 1000 times faster.

=== Strings ===
No patch (just string check removed):
  $ ./python -mtimeit --setup=x=['abc']*10 sum(x,'')
  10 loops, best of 3: 1.52 sec per loop
fastsum.patch (+ string check removed):
  $ ./python -mtimeit --setup=x=['abc']*10 sum(x,'')
  10 loops, best of 3: 1.52 sec per loop
fastsum-special.patch
  $ ./python -mtimeit --setup=x=['abc']*10 sum(x,'')
  10 loops, best of 3: 27.8 msec per loop
join:
  $ ./python -mtimeit --setup=x=['abc']*10 ''.join(x)
  1000 loops, best of 3: 1.66 msec per loop
Result: 50 times faster, but still constantly slower than join.

NB:
The string part of this patch is a Proof-of-Concept, just for tests, to 
demonstrate, that sum can really be O(n) for strings. It was written for python 
2.7.5, won't work for python3, and is not expected to be applied to python2, as 
it changes the behavior of sum, allowing it to sum strings.

But! If string part is stripped from the patch it works for both python2 and 
python3, and does not change existing behavior, except making sum faster.

--
Added file: http://bugs.python.org/file30769/fastsum-special.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18305
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Christian Heimes

Changes by Christian Heimes li...@cheimes.de:


--
nosy: +christian.heimes

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18353] PyUnicode_WRITE_CHAR macro definition missing

2013-07-04 Thread Martin v . Löwis

Martin v. Löwis added the comment:

I'll declare that the documentation is in error. I was pondering adding this 
macro, and the API changed forth and back several times (also after other 
people started contributing to the new Unicode API). The API is now what is 
implemented, and the documentation should follow.

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18353
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Christian Heimes

Christian Heimes added the comment:

I first suspected that file based IO involves too many syscalls and context 
switches. However ``strace -c`` showed only minor differences in the amount of 
syscalls. The difference between read() and recvfrom() should not make any 
difference.

perf revealed that the makefile() test uses much more CPU cycles. A quick check 
with python3.3 -m profile points to Python method call overhead. Five methods 
are called more than 122,000 times each and a couple of attributes are checked, 
too. Perhaps we can optimize away _checkReadable() and _checkClosed()?

I think I know what's going on here. For socket IO readline() uses a readahead 
buffer size of 1. For each char a cascade of Python functions is called. 
os.fdopen() uses a default buffering of 4096 (or more) so it's not affected.

--
Added file: http://bugs.python.org/file30770/perf.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Christian Heimes

Christian Heimes added the comment:

Summary:

makefile: 611990 primitive calls
fdopen: 1629 primitive calls

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11185] test_wait4 error on AIX

2013-07-04 Thread Charles-François Natali

Changes by Charles-François Natali cf.nat...@gmail.com:


--
assignee:  - neologix

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11185
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18357] add tests for dictview set difference operations

2013-07-04 Thread Fraser Tweedale

New submission from Fraser Tweedale:

The Python documentation states that set-like dictionary view objects support 
set difference (-), however, this behaviour is untested.

Add some tests for this behaviour.

(This issue was discovered because PyPy doesn't support (-) for dictviews, yet 
they claimed to pass the test suite.  Well, they did pass it ^_^

--
components: Tests
files: dictview-set-sub-test.patch
keywords: patch
messages: 192285
nosy: frasertweedale
priority: normal
severity: normal
status: open
title: add tests for dictview set difference operations
type: enhancement
versions: Python 2.7
Added file: http://bugs.python.org/file30771/dictview-set-sub-test.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18357
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18358] update links to Apple Style Guide

2013-07-04 Thread Russkel

New submission from Russkel:

Apple has relocated and renamed their style guide. This patch reflects those 
changes and provides links to both PDF and online version.

--
components: Devguide
files: style-guide-fixes.patch
keywords: patch
messages: 192286
nosy: Russkel, ezio.melotti
priority: normal
severity: normal
status: open
title: update links to Apple Style Guide
Added file: http://bugs.python.org/file30772/style-guide-fixes.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18358
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18358] update links to Apple Style Guide

2013-07-04 Thread Ronald Oussoren

Ronald Oussoren added the comment:

This is a duplicate of #18021

--
nosy: +ronaldoussoren
resolution:  - duplicate
stage:  - committed/rejected
status: open - closed
superseder:  - Update broken link to Apple Publication Style Guide
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18358
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18358] update links to Apple Style Guide

2013-07-04 Thread Russ Webber

Russ Webber added the comment:

So it is. Sorry, should have searched first.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18358
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18357] add tests for dictview set difference operations

2013-07-04 Thread Fraser Tweedale

Fraser Tweedale added the comment:

and here's a patch for python3 (the earlier patch is for the 2.7 branch).

--
Added file: http://bugs.python.org/file30773/dictview-set-sub-test-python3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18357
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18359] pickle fail to handle some class with __new__

2013-07-04 Thread yoch

New submission from yoch:

Hi,

If some class objects have extra arguments in the __new__ constructor , pickle 
fail to serialize it.

Here the output of provided test-case :

Traceback (most recent call last):
  File /home/yoch/bug.py, line 19, in module
y = pickle.load(fp)
TypeError: __new__() missing 1 required positional argument: 'arg'

Best regards

--
components: Library (Lib)
files: bug.py
messages: 192290
nosy: yoch.melka
priority: normal
severity: normal
status: open
title: pickle fail to handle some class with __new__
versions: Python 3.3
Added file: http://bugs.python.org/file30774/bug.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18359
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18359] pickle fail to handle some class with __new__

2013-07-04 Thread Amaury Forgeot d'Arc

Amaury Forgeot d'Arc added the comment:

This is expected, your class must say how this __new__ constructor can be 
called.
http://docs.python.org/2/library/pickle.html#object.__getnewargs__

--
nosy: +amaury.forgeotdarc
resolution:  - works for me
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18359
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18356] help(numpy) causes segfault on exit

2013-07-04 Thread R. David Murray

R. David Murray added the comment:

pydoc doesn't do anything special other than import the module.  Well, there's 
some special code in linecache for getting docstrings from C modules, I think, 
so that could be something to check. 

Does Ubuntu have local patches to numpy?

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18356
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18356] help(numpy) causes segfault on exit

2013-07-04 Thread Michelle Arzul

Michelle Arzul added the comment:

Apparently it only occurs with the Ubuntu packaged versions of Python and 
numpy. Somebody who was able to reproduce my problem had it with 
python-2.7.4-0ubuntu1-amd64 and python-numpy-1:1.7.1-1ubuntu1-amd64 which 
exhibited the same behaviour. Apparently python-dbg and python-numpy-dbg do not 
reproduce the error.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18356
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18360] Won't install. Keeps telling me DLL is missing.

2013-07-04 Thread Dale Smith

New submission from Dale Smith:

When I click install - run, it tells me a DLL is missing and to contact my 
vendor (Windows 7 Home Premium).

This is the only installation that does this. I cannot find an answer anywhere 
and all other installations work fine.  What could be causing this?  Which DLL 
is specific only to this installation that Microsoft does not have an answer 
to?  Thank you.

--
components: Installation
messages: 192294
nosy: daleastar
priority: normal
severity: normal
status: open
title: Won't install.  Keeps telling me DLL is missing.
type: crash
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18360
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16977] argparse: mismatch between choices parsing and usage/error message

2013-07-04 Thread paul j3

paul j3 added the comment:

Changing _check_value from:

def _check_value(self, action, value):
# converted value must be one of the choices (if specified)
if action.choices is not None and value not in action.choices:
...

to

def _check_value(self, action, value):
# converted value must be one of the choices (if specified)
if action.choices is not None:
choices = action.choices
if isinstance(choices, str):
choices = list(choices)
if value not in action.choices:
...

would correct the string search without affecting other types of choices.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16977
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Richard Oudkerk

Richard Oudkerk added the comment:

 I think I know what's going on here. For socket IO readline() uses a 
 readahead buffer size of 1.

Why is that?  I think that makefile(mode='rb') and fdopen() both create 
BufferedReader objects with the same buffer size.

It looks to me like there are the same number of reads for both cases (about 
120,000 ~ data_size/buffer_size).  But with SocketIO, there are 5 function 
calls for each read into the buffer.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Richard Oudkerk

Richard Oudkerk added the comment:

Using

while True:
if not fileobj.read(8192):
break

instead of

for line in fileobj:
pass

results in higher throughput, but a similar slowdown with makefile().  So this 
is not a problem specific to readline().

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Christian Heimes

Christian Heimes added the comment:

Err, you are right. It's buffered. I misread one function call and thought it's 
not buffered at all.

 COUNT = 100
 LINELEN = 1000
 int(LINELEN * COUNT / 8192)
122070

The number looks familiar, doesn't it? :)

I still stand by my analysis that the slow down is caused by Python's method 
call overhead and the extra function call to _checkReadable(),  readable and 
_checkClosed(). A C implementation of the raw SocketIO class would reduce the 
overhead.

The implementation of SocketIO assumes that performance is dominated by IO 
(e.g. slow internet connection). A local socket pair is faster than 10GBit/sec 
ethernet or 8 GBit/sec fibre channel.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18021] Update broken link to Apple Publication Style Guide

2013-07-04 Thread Madison May

Madison May added the comment:

If the general consensus is that the APSG link should be removed, here's one 
more patch for you.

--
Added file: http://bugs.python.org/file30775/apsg_removed.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18021
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18351] Incorrect variable name in importlib._bootstrap._get_sourcefile

2013-07-04 Thread Madison May

Madison May added the comment:

Here's a 5 character patch for the sake of completeness.

--
keywords: +patch
nosy: +madison.may
Added file: http://bugs.python.org/file30776/Issue18351.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Richard Oudkerk

Richard Oudkerk added the comment:

The only real reason for implementing SocketIO in pure Python is because read() 
and write() do not work on Windows with sockets.  (I think there are also a few 
complications involving SSL sockets and the close() method.)

On Windows I have implemented a file object type in C which works with pipe 
handles.  I hope to use it in multiprocessing at some point.  It would not be 
too difficult to support sockets as well and use that instead of SocketIO.  For 
Unix, FileIO can be used instead of SocketIO.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Christian Heimes

Christian Heimes added the comment:

There is little bit more to it. A comment in the class' body describes the 
reason for SockteIO:

# One might wonder why not let FileIO do the job instead.  There are two
# main reasons why FileIO is not adapted:
# - it wouldn't work under Windows (where you can't used read() and
#   write() on a socket handle)
# - it wouldn't work with socket timeouts (FileIO would ignore the
#   timeout and consider the socket non-blocking)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Richard Oudkerk

Richard Oudkerk added the comment:

Ah.  I had not thought of socket timeouts.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18351] Incorrect variable name in importlib._bootstrap._get_sourcefile

2013-07-04 Thread Brett Cannon

Brett Cannon added the comment:

Any chance you want to write some tests for the function? =)

--
keywords: +easy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11185] test_wait4 error on AIX

2013-07-04 Thread Roundup Robot

Roundup Robot added the comment:

New changeset b3ea1b5a1617 by Antoine Pitrou in branch '3.3':
Issue #11185: Fix test_wait4 under AIX.  Patch by Sébastien Sablé.
http://hg.python.org/cpython/rev/b3ea1b5a1617

New changeset 8055521e372f by Antoine Pitrou in branch 'default':
Issue #11185: Fix test_wait4 under AIX.  Patch by Sébastien Sablé.
http://hg.python.org/cpython/rev/8055521e372f

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11185
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11185] test_wait4 error on AIX

2013-07-04 Thread Roundup Robot

Roundup Robot added the comment:

New changeset e3fd5fc5dc47 by Antoine Pitrou in branch '2.7':
Issue #11185: Fix test_wait4 under AIX.  Patch by Sébastien Sablé.
http://hg.python.org/cpython/rev/e3fd5fc5dc47

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11185
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18200] Update stdlib to use ModuleNotFoundError

2013-07-04 Thread Brett Cannon

Brett Cannon added the comment:

As ModuleNotFoundError is going to be reverted so should the changesets for 
this issue.

--
resolution: fixed - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18200
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11185] test_wait4 error on AIX

2013-07-04 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Thank you. This should be fixed now. Please reopen if not.

--
nosy: +pitrou
resolution:  - fixed
stage:  - committed/rejected
status: open - closed
versions: +Python 2.7, Python 3.3, Python 3.4 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11185
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18302] test_multiprocessing: test.support.import_module() does not ignore the ImportError on SemLock

2013-07-04 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
dependencies: +add ModuleNotFoundError

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18302
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18200] Update stdlib to use ModuleNotFoundError

2013-07-04 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
dependencies:  -add ModuleNotFoundError

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18200
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15767] add ModuleNotFoundError

2013-07-04 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
dependencies: +Update stdlib to use ModuleNotFoundError

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15767
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread STINNER Victor

STINNER Victor added the comment:

On Python 2, socket.makefile(rb) duplicates the file descriptor and creates a 
new file object: fileobj.read() calls the C function read().

On Python 3, socket.makefile(rb) creates a SocketIO wrapped in 
BufferedReader: fileobj.read() calls the C function recv() (recvfrom() syscall).

For a UNIX socket, read() is maybe more efficient than recv().

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18361] Move dev-in-a-box to os.cpu_count()

2013-07-04 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
assignee: brett.cannon
keywords: easy
nosy: brett.cannon
priority: low
severity: normal
stage: needs patch
status: open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18361
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18362] Make build_cpython.py from dev-in-a-box work outside of a box

2013-07-04 Thread Brett Cannon

New submission from Brett Cannon:

No reason why it can't be generalized to accept a directory argument so that it 
can be used by anyone to build a checkout of CPython whether it is in a box or 
not.

Would also help maintain the code as me (and one else who cared to) could then 
just always use the script to build CPython.

--
messages: 192310
nosy: brett.cannon
priority: normal
severity: normal
stage: needs patch
status: open
title: Make build_cpython.py from dev-in-a-box work outside of a box

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18362
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18363] Change use of acronym tag in devinabox index.html to abbr

2013-07-04 Thread Brett Cannon

New submission from Brett Cannon:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/abbr

--
assignee: brett.cannon
keywords: easy
messages: 192311
nosy: brett.cannon
priority: low
severity: normal
status: open
title: Change use of acronym tag in devinabox index.html to abbr

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18363
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17845] Clarify successful build message

2013-07-04 Thread Brett Cannon

Brett Cannon added the comment:

First, thanks to Yogesh for writing a patch!

Second, I still think the second line should be The necessary bits to build 
these optional modules were not found:. I purposefully like the vagueness of 
it so we don't start going on about external vs. system, whether header files 
needs to be mentioned, etc. That is a perk for people who aren't C programmers 
and don't want to know what a header file is.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17845
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread STINNER Victor

STINNER Victor added the comment:

My results of the benchmark on Linux 3.9, first with a loop calling 
fileobj.read(8192) (read), then with the for line in fileobj: pass 
(readline).

$ python2.7 bench_socket_read.py
TCP  mode, makefile method. 1775085.8 lines per second (1692.9 MB/s). Delay is 
0.56 seconds
TCP  mode,   fdopen method. 2767162.2 lines per second (2639.0 MB/s). Delay is 
0.36 seconds
UNIX mode, makefile method. 5238015.2 lines per second (4995.4 MB/s). Delay is 
0.19 seconds
UNIX mode,   fdopen method. 6218906.2 lines per second (5930.8 MB/s). Delay is 
0.16 seconds

$ python3.4 bench_socket_read.py
TCP  mode, makefile method. 1403075.1 lines per second (1338.1 MB/s). Delay is 
0.71 seconds
TCP  mode,   fdopen method. 2324254.2 lines per second (2216.6 MB/s). Delay is 
0.43 seconds
UNIX mode, makefile method. 1770625.0 lines per second (1688.6 MB/s). Delay is 
0.56 seconds
UNIX mode,   fdopen method. 4953624.6 lines per second (4724.1 MB/s). Delay is 
0.20 seconds

$ python2.7 bench_socket_readline.py
TCP  mode, makefile method. 246268.2 lines per second (234.9 MB/s). Delay is 
4.06 seconds
TCP  mode,   fdopen method. 1980998.2 lines per second (1889.2 MB/s). Delay is 
0.50 seconds
UNIX mode, makefile method. 3378778.4 lines per second (3222.3 MB/s). Delay is 
0.30 seconds
UNIX mode,   fdopen method. 3271267.0 lines per second (3119.7 MB/s). Delay is 
0.31 seconds

$ python3.4 bench_socket_readline.py
TCP  mode, makefile method. 826646.7 lines per second (788.4 MB/s). Delay is 
1.21 seconds
TCP  mode,   fdopen method. 1664917.8 lines per second (1587.8 MB/s). Delay is 
0.60 seconds
UNIX mode, makefile method. 942409.0 lines per second (898.8 MB/s). Delay is 
1.06 seconds
UNIX mode,   fdopen method. 2619285.2 lines per second (2497.9 MB/s). Delay is 
0.38 seconds

The results of the read benchmark for UNIX mode, makefile method case are 
very different on Python 2.7 (call read()) and Python 3.4 (call recv()): 4995.4 
MB/s vs 1688.6 MB/s (2.95x slower).

Readline on TCP is much faster on Python 3.4 than 2.7: 788.4 MB/s vs 234.9 MB/s 
(3.4x faster). I don't know why, but I don't want to investigate (it is not a 
regression) :-)

The slowdown on other readline tests are less interesting: Python 3.4 is 16% 
slower for TCP  mode, fdopen method and 20% slower for UNIX mode, fdopen 
method.

It would be interesting to have the same benchmark implemented in C to compare 
raw performances, so it would be possible to measure the overhead of Python.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18279] IDLE Unit test for RstripExtension.py

2013-07-04 Thread Phil Webster

Phil Webster added the comment:

Added to Terry's Text Widget code (in #18226) and created mock_idle.py for the 
mock EditorWindow. Todd's FormatParagraph test in the aforementioned issue also 
passes with the mock EditorWindow.

--
Added file: http://bugs.python.org/file30777/test_rstrip2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18279
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18360] Won't install. Keeps telling me DLL is missing.

2013-07-04 Thread R. David Murray

R. David Murray added the comment:

Exactly which installer are you trying to run and where did you download it 
from?

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18360
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18329] for line in socket.makefile() speed degradation

2013-07-04 Thread Richard Oudkerk

Richard Oudkerk added the comment:

I find that by adding the lines

fileobj.raw.readinto = ss.recv_into
fileobj.raw.read = ss.recv

the speed with makefile() is about 30% slower than with fdopen().

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18360] Won't install. Keeps telling me DLL is missing.

2013-07-04 Thread Dale Smith

Dale Smith added the comment:

http://www.python.org/ftp/python/2.7.5/python-2.7.5.msi

That is the URL I downloaded from and the installer.

Thank you,

Dale

On 7/4/2013 4:17 PM, R. David Murray wrote:
 R. David Murray added the comment:

 Exactly which installer are you trying to run and where did you download it 
 from?

 --
 nosy: +r.david.murray

 ___
 Python tracker rep...@bugs.python.org
 http://bugs.python.org/issue18360
 ___

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18360
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18200] Update stdlib to use ModuleNotFoundError

2013-07-04 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 7769c4d72806 by Brett Cannon in branch 'default':
Issue #18200: Back out usage of ModuleNotFoundError (8d28d44f3a9a)
http://hg.python.org/cpython/rev/7769c4d72806

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18200
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15767] add ModuleNotFoundError

2013-07-04 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 0e4e062751fa by Brett Cannon in branch 'default':
Issue #15767: Back out 8d28d44f3a9a related to ModuleNotFoundError.
http://hg.python.org/cpython/rev/0e4e062751fa

New changeset e3ec8b176a80 by Brett Cannon in branch 'default':
Issue #15767: Revert 3a50025f1900 for ModuleNotFoundError
http://hg.python.org/cpython/rev/e3ec8b176a80

New changeset ee9662d77ebb by Brett Cannon in branch 'default':
Issue #15767: back out 8a0ed9f63c6e, finishing the removal of
http://hg.python.org/cpython/rev/ee9662d77ebb

New changeset de947db308ba by Brett Cannon in branch 'default':
Issue #15767: Excise the remaining instances of ModuleNotFoundError
http://hg.python.org/cpython/rev/de947db308ba

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15767
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18302] test_multiprocessing: test.support.import_module() does not ignore the ImportError on SemLock

2013-07-04 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
resolution:  - out of date
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18302
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18200] Update stdlib to use ModuleNotFoundError

2013-07-04 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
resolution:  - rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18200
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15767] add ModuleNotFoundError

2013-07-04 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
resolution:  - rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15767
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18302] test_multiprocessing: test.support.import_module() does not ignore the ImportError on SemLock

2013-07-04 Thread STINNER Victor

STINNER Victor added the comment:

Brett: Why did you close this issue? It still occurs on the buildbot:

http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.x/builds/3794/steps/test/logs/stdio

--
resolution: out of date - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18302
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18302] test_multiprocessing: test.support.import_module() does not ignore the ImportError on SemLock

2013-07-04 Thread Brett Cannon

Brett Cannon added the comment:

Because I removed ModuleNotFoundError; check the buildbot again and you will 
notice it is 8 changesets behind, most of which are related to the removal of 
ModuleNotFoundError.

--
resolution:  - out of date
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18302
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18364] Remove _not_found hack from importlib

2013-07-04 Thread Brett Cannon

New submission from Brett Cannon:

Having a private attribute has already caused one bug report. I want to try and 
come up with something that doesn't leak outside of importlib.

--
assignee: brett.cannon
components: Library (Lib)
messages: 192322
nosy: brett.cannon
priority: normal
severity: normal
stage: needs patch
status: open
title: Remove _not_found hack from importlib
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18364
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18347] ElementTree corrupts cAse of closing tags when html method is specified

2013-07-04 Thread Roundup Robot

Roundup Robot added the comment:

New changeset df79735b21c1 by Christian Heimes in branch '3.3':
Issue #18347: ElementTree's html serializer now preserves the case of closing 
tags.
http://hg.python.org/cpython/rev/df79735b21c1

New changeset d5536c06a082 by Christian Heimes in branch 'default':
Issue #18347: ElementTree's html serializer now preserves the case of closing 
tags.
http://hg.python.org/cpython/rev/d5536c06a082

New changeset 328781ae35d2 by Christian Heimes in branch '2.7':
Issue #18347: ElementTree's html serializer now preserves the case of closing 
tags.
http://hg.python.org/cpython/rev/328781ae35d2

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18347
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18347] ElementTree corrupts cAse of closing tags when html method is specified

2013-07-04 Thread Christian Heimes

Changes by Christian Heimes li...@cheimes.de:


--
resolution:  - fixed
stage: needs patch - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18347
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16396] Importing ctypes.wintypes on Linux gives a traceback

2013-07-04 Thread Christian Heimes

Christian Heimes added the comment:

RM, please decide. :)

--
assignee:  - benjamin.peterson
stage: needs patch - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16396
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5639] Support TLS SNI extension in ssl module

2013-07-04 Thread Mark Kubacki

Changes by Mark Kubacki wm...@hurrikane.de:


Removed file: http://bugs.python.org/file30757/python-2.7.5-tlssni.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5639
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5639] Support TLS SNI extension in ssl module

2013-07-04 Thread Mark Kubacki

Changes by Mark Kubacki wm...@hurrikane.de:


Added file: http://bugs.python.org/file30778/python-2.7.5-tlssni.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5639
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5639] Support TLS SNI extension in ssl module

2013-07-04 Thread Mark Kubacki

Changes by Mark Kubacki wm...@hurrikane.de:


Removed file: http://bugs.python.org/file30778/python-2.7.5-tlssni.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5639
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5639] Support TLS SNI extension in ssl module

2013-07-04 Thread Mark Kubacki

Changes by Mark Kubacki wm...@hurrikane.de:


Added file: http://bugs.python.org/file30779/python-2.7.5-tlssni.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5639
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18364] Remove _not_found hack from importlib

2013-07-04 Thread Eric Snow

Changes by Eric Snow ericsnowcurren...@gmail.com:


--
nosy: +eric.snow

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18364
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18279] IDLE Unit test for RstripExtension.py

2013-07-04 Thread Terry J. Reedy

Terry J. Reedy added the comment:

I want to make two separate commits. First add mock Text into mock_tk.py, and 
add a new test_text.py. I suggested looking at the tkinter Text test. I turns 
out that it only tests a few special search cases. I am guessing that they have 
something to do with the tkinter interface. If neither you nor Todd feel like 
writing the Text test, I will. Let me know either way.

Second, add the new mock_idle and test_rstrip files. For the latter, at least 
one line should have no whitespace, and one should have an indent. With an 
indent, the test would fail if rstrip in the tested file were changed to strip.

In the tearDown method, the apparent purpose of
self.rstripextension = None
is to actually do
del self.rstripextension
and that happens automatically when self disappears.
With a mock editor window, there is no need for root.destroy and hence for 
the close call, and hence for the tearDown method.

With only one test method, the setUp lines can be part of the test. For the 
attribute names, I strongly prefer 'rstrip' to 'rstripExtension' and 'editor' 
to 'mockEditorWindow'.

I am curious about this comment:
# Note: Tkinter always adds a newline at the end of the text widget,
# hence the newline in the expected_text string

In live Idle, I tried 'strip trailing whitespace' with text that did not end 
with \n and there was none visible after.

An annoyance is that after stripping  the filename is prefixed with * to 
indicate that it has been changed and needs to be changed, even when it has not 
(or should not have been). Closing brings up the unnecessary 'Changed, save?' 
box. Is this related to the comment?

--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18279
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18200] Update stdlib to use ModuleNotFoundError

2013-07-04 Thread Jesús Cea Avión

Jesús Cea Avión added the comment:

 As ModuleNotFoundError is going to be reverted so should the changesets for 
 this issue.

Could you possibly clarify this?. Pointers?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18200
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com