[issue16809] Tk 8.6.0 introduces TypeError. (Tk 8.5.13 works)

2013-07-23 Thread alejandro autalan

alejandro autalan added the comment:

Hello.
I tried 'tkinter_split.patch' patch against 3.3.2, but a fix for grid_info 
function is also needed.

#test.py
import tkinter as tk

root = tk.Tk()
b = tk.Button(root, text='Button')
b.grid()
print(b.grid_info())
root.mainloop()


Here's is the script's output:

alejandro@vostro1:~/tmp$ cpython3.3 test.py 
Traceback (most recent call last):
  File test.py, line 10, in module
print(b.grid_info())
  File /home/alejandro/apps/cpython3.3.2/lib/python3.3/tkinter/__init__.py, 
line 2024, in grid_info
if value[:1] == '.':
TypeError: '_tkinter.Tcl_Obj' object is not subscriptable

--
nosy: +alejandroautalan

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15805] Add stdout redirection tool to contextlib

2013-07-23 Thread Nick Coghlan

Nick Coghlan added the comment:

Can we go paint bikesheds somewhere else now, please? Raymond has persuaded me 
as contextlib maintainer that this small addition is worth making as a way of 
factoring out repeated calls to print with a file redirection in simple user 
scripts where thread safety isn't a concern.

I think more sophisticated tools are also potentially worthwhile, but *not 
here*.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15805
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18526] Add resource management/guarding to unittest

2013-07-23 Thread Robert Collins

Changes by Robert Collins robe...@robertcollins.net:


--
nosy: +rbcollins

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18526
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18526] Add resource management/guarding to unittest

2013-07-23 Thread Robert Collins

Robert Collins added the comment:

I'll do a full review shortly, but at the conceptual level, I don't see any 
benefit in making a new SkipTest base class, other than instantly breaking 
other runners when an unknown exception is raised. SkipTest is part of the API. 
Making a new exception part of the API requires a strong reason - not just 'we 
want to show it differently' but 'we want the runner to behave differently.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18526
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18526] Add resource management/guarding to unittest

2013-07-23 Thread Michael Foord

Michael Foord added the comment:

My question is, is this generally useful enough for test suites beyond the 
Python standard library. Essentially it provides a command line interface to 
specialized test skipping. 

I *still* feel that a generalized mechanism for adding command line options to 
the standard test runner would allow for this and a myriad of other slightly 
specialized use cases. It's hard to see how to do that cleanly without full 
blown extension machinery (which I'm in favour of and have prototyped but it is 
a *much* bigger change set).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18526
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8716] test_tk/test_tkk_guionly fails on OS X if run from buildbot slave daemon -- crashes Python

2013-07-23 Thread Ronald Oussoren

Ronald Oussoren added the comment:

I just noticed that the Tk tests still get skipped on my machine, and 
rediscovered this issue. The reason that MacOS.WMAvailable() returns False on 
the buildbot is because it runs ./python.exe, which is not part of an 
application bundle and therefore has no GUI access.

To easily reproduce with a framework install:

* Note that MacOS.WMAvailable() returns True when you run
  the python/pythonw when you are logged in to the machine

* Now copy 
/Library/Framework/Python.frameworks/Versions/Current/Resources/Python.app/Contents/MacOS/Python
 to python.exe

* Run ./python.exe and note that MacOS.WMAvailable() now returns
  False (and that sys.prefix still refers to the framework)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8716
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-23 Thread Larry Hastings

Larry Hastings added the comment:

Looks like it's too late for Christian, he's already generated the report with 
Coverity:

https://docs.google.com/file/d/0B5wQCOK_TiRiMWVqQ0xPaDEzbkU/edit

But I'm still interested in putting this to bed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17899
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17496] OS X test for Tk availability in runtktests.py doesn't work

2013-07-23 Thread Ronald Oussoren

Ronald Oussoren added the comment:

To respond to my own message: running a small Tcl script is not good enough, 
the process environment of python itself is also important.

In particular, GUI frameworks only work from inside an application bundle (or 
by using some undocumented private APIs) and that's why the Tk tests cannot 
work on OSX without installing. 

BTW. I just verified that MacOS.WMAvailable() works just fine in 64-bit 
processes (python 2.7 on OSX 10.8), and according to the header files the API 
functions used in its implementation (and the corresponding python code in 3.x) 
are not deprecated.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17496
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18526] Add resource management/guarding to unittest

2013-07-23 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Does registerResource() mutate some kind of global per-process state? This 
doesn't sound like a good idea.
(and even less so the default resources, IMO: these are stdlib test 
suite-specific)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18526
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-23 Thread Christian Heimes

Christian Heimes added the comment:

That's a preliminary report I made a couple of days ago. I posted it on G+ for 
some friends, it got re-posted by the official Python account and gone viral on 
Twitter.

The interview is tonight. Coverity is probably going to create their own report 
after the interview.

The save_errno approach is a common technique and not a hack. On modern 
systems with threading support the errno variable is a carefully crafted macro 
that wraps an internal function + thread local storage. Several Python files 
like signalmodule, faulthandler and more are using save_errno.

Yes, we are pedantic. Sometimes it's not easy to cope with but we are creating 
a hell of a shiny piece of software. :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17899
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18535] termios.tcgetattr should return namedtuple

2013-07-23 Thread anatoly techtonik

New submission from anatoly techtonik:

Names of field for tuple returned by tcgetattr are already in documentation at 
http://docs.python.org/2/library/termios.html

It would be nice to get them into code.

--
components: Library (Lib)
messages: 193595
nosy: techtonik
priority: normal
severity: normal
status: open
title: termios.tcgetattr should return namedtuple
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18535
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18535] termios.tcgetattr should return namedtuple

2013-07-23 Thread anatoly techtonik

anatoly techtonik added the comment:

Actually namedtuple doesn't suit the use case well. The use case is to read 
termios config, (re)set flags set it back. The attributes should be mutable.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18535
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue791968] Arguments tooltip wrong if def contains tuple

2013-07-23 Thread ariel brunner

ariel brunner added the comment:

It seems like the solution has caused a different issue: now, when defining a 
function with factional default arguments, the tuple text replaces the 
correct values in the tooltip.

Here's an example -

 def f(a=0.5):
pass
 f(

tooltip shows - (a=0tuple), i.e. replaces the .5 with tuple.

--
nosy: +ariel_bruner

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue791968
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18535] termios.tcgetattr should return namedtuple

2013-07-23 Thread Amaury Forgeot d'Arc

Amaury Forgeot d'Arc added the comment:

namedtuple has a _replace method, but I agree that it would be an incompatible 
change. namedlist someone?

class tcattributes(object):
__slots__ = ['iflag', 'oflag', 'cflag', 'lflag', 'ispeed', 'ospeed', 'cc']

def __new__(cls, values):
self = object.__new__(cls)
for attr, value in zip(cls.__slots__, values):
setattr(self, attr, value)
return self

def __getitem__(self, index):
return getattr(self, self.__slots__[index])

--
nosy: +amaury.forgeotdarc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18535
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15805] Add stdout redirection tool to contextlib

2013-07-23 Thread Barry A. Warsaw

Barry A. Warsaw added the comment:

On Jul 23, 2013, at 04:24 AM, Alexander Belopolsky wrote:

@contextlib.contextmanager
def redirect_stdout(stream):
old_stdout = sys.stdout
sys.stdout = stream
yield
sys.stdout = old_stdout

Make that:

@contextlib.contextmanager
def redirect_stdout(stream):
old_stdout = sys.stdout
sys.stdout = stream
try:
yield
finally:
sys.stdout = old_stdout

and I'll be able to remove those 8 lines of code from all my other code bases
:)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15805
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18536] 李浩在 Google+ 上分享了一条信息

2013-07-23 Thread 浩 李

New submission from 浩 李:

Forwarded conversation
Subject: 李浩在 Google+ 上分享了一条信息


From: *李浩 (Google+)* noreply-6e55d...@plus.google.com
Date: 2013/7/23
To: hk45...@gmail.com

李浩分享了一条信息https://plus.google.com/_/notifications/emlink?emr=03756893426188686779emid=CNi3kdLaxbgCFcTD3godEgYAAApath=%2F100970428986760683840%2Fposts%2FD6dgVePoxpudt=1374585664867ub=49
。
https://plus.google.com/_/notifications/emlink?emr=03756893426188686779emid=CNi3kdLaxbgCFcTD3godEgYAAApath=%2F100970428986760683840dt=1374585664867ub=49
https://plus.google.com/_/notifications/emlink?emr=03756893426188686779emid=CNi3kdLaxbgCFcTD3godEgYAAApath=%2F100970428986760683840%2Fposts%2FD6dgVePoxpudt=1374585664867ub=49

你收到此通知是因为李浩曾在你所订阅的某个圈子中。
Google Inc., 1600 Amphitheatre Pkwy, Mountain View, CA 94043 USA

--
From: *李浩 (Google+)* noreply-6e55d...@plus.google.com
Date: 2013/7/23
To: hk45...@gmail.com

李浩分享了一条信息https://plus.google.com/_/notifications/emlink?emr=16080280340979752301emid=COjbmdTaxbgCFQQk3QodzBsAAApath=%2F100970428986760683840%2Fposts%2FD6dgVePoxpudt=1374585669204ub=49
。
https://plus.google.com/_/notifications/emlink?emr=16080280340979752301emid=COjbmdTaxbgCFQQk3QodzBsAAApath=%2F100970428986760683840dt=1374585669204ub=49
https://plus.google.com/_/notifications/emlink?emr=16080280340979752301emid=COjbmdTaxbgCFQQk3QodzBsAAApath=%2F100970428986760683840%2Fposts%2FD6dgVePoxpudt=1374585669204ub=49

你收到此通知是因为李浩在你的“关注对象”圈子中。你可以更改https://plus.google.com/_/notifications/emlink?emr=16080280340979752301emid=COjbmdTaxbgCFQQk3QodzBsAAApath=%2Fstream%2Fcircles%2Fp4921781a0fa899dd%2Fop%2Fufedt=1374585669204ub=49
此圈子的通知设置。
Google Inc., 1600 Amphitheatre Pkwy, Mountain View, CA 94043 USA

--
messages: 193600
nosy: 浩.李
priority: normal
severity: normal
status: open
title: 李浩在 Google+ 上分享了一条信息

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18536
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18535] termios.tcgetattr should return namedtuple

2013-07-23 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Returning a list was probably silly to begin with (a dict would have been more 
natural).
However, I don't think I want to see such a thing as a namedlist in the stdlib. 
:-(

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18535
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18536] 李浩在 Google+ 上分享了一条信息

2013-07-23 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
resolution:  - invalid
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18536
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18534] File name attribute should always be a text string

2013-07-23 Thread Antoine Pitrou

Antoine Pitrou added the comment:

You can never assume that name will be a string:

 f = open(0, r)
 f.name
0

This may be a bit of a bad idea API-wise, but changing it now will start 
breaking code, so I think we should leave it as-is.

--
nosy: +aronacher, pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18534
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18293] ssl.wrap_socket (cert_reqs=...), getpeercert, and unvalidated certificates

2013-07-23 Thread Antoine Pitrou

Antoine Pitrou added the comment:

getpeercert() has a crappy API to begin with, but we can't change its behaviour 
for fear of breaking existing code (and, even, breaking it security-wise). 
Adding a parameter would make the API even more awful.

Which is why I support Christian's idea of exposing a new API, either:
- to expose the full cert chain (even if not validated)
- or to set the cert verify callback

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18293
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18458] libedit history offset workaround

2013-07-23 Thread Jesús Cea Avión

Changes by Jesús Cea Avión j...@jcea.es:


--
nosy: +jcea

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18458
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18520] Fixes bugs found by pyfailmalloc during Python initialization

2013-07-23 Thread Jesús Cea Avión

Changes by Jesús Cea Avión j...@jcea.es:


--
nosy: +jcea

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18520
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18512] sys.stdout.write does not allow bytes in Python 3.x

2013-07-23 Thread Martin v . Löwis

Martin v. Löwis added the comment:

Rephrasing R.David's question: 

ntrrgc: Did you consult any documentation (browsing or searching), and if so, 
where did you look?

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18512
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18521] [cppcheck] Full report

2013-07-23 Thread Ronald Oussoren

Ronald Oussoren added the comment:

What is cppcheck?

The report contains some very dodgy false positives, like:

[Modules/_cursesmodule.c:1095]: (style) Variable 'rtn' is assigned a value that 
is never used.
[Modules/_cursesmodule.c:1097]: (style) Unused variable: break

1) The rtn is used further on the function
2) break is not a variable at all, but a C keyword

There are also valid messages, but there appear to be a lot of false positives 
(based on the limited amount of checking that I've done)

--
nosy: +ronaldoussoren

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18460] .chm documentation files advertised in download.html but not there.

2013-07-23 Thread Martin v . Löwis

Martin v. Löwis added the comment:

The CHM files for 2.7.x and 3.3.x are now there.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18460
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18460] .chm documentation files advertised in download.html but not there.

2013-07-23 Thread Martin v . Löwis

Changes by Martin v. Löwis mar...@v.loewis.de:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18460
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18211] -Werror=statement-after-declaration problem

2013-07-23 Thread Ronald Oussoren

Ronald Oussoren added the comment:

I also don't understand why the optimization level shouldn't be used when 
building 3th-party extensions.  

Removing the -O flag for build_ext would be a regression compared to the 
current behavior because 3th-party extensions would suddenly be compiled with 
less optimization than before and extension authors would have to arrange for 
those flags themselves. That's fine on platforms using a compiler with a 
command-line interface that's simular to GCC, but the are compilers that don't 
(such as a number of vendor compilers for the various commercial unix systems).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18211
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18537] bool.toggle()

2013-07-23 Thread James Lu

New submission from James Lu:

the bool type should have a toggle() function

--
messages: 193608
nosy: James.Lu
priority: normal
severity: normal
status: open
title: bool.toggle()
type: enhancement
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18537
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18537] bool.toggle()

2013-07-23 Thread Eric V. Smith

Eric V. Smith added the comment:

bool instances are immutable, so all value.toggle() could do is the same as 
not value. That is, return a new bool with the toggled value.

--
nosy: +eric.smith
resolution:  - invalid
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18537
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18537] bool.toggle()

2013-07-23 Thread James Lu

James Lu added the comment:

I mean, return a value, some people like this style.

james

On Tue, Jul 23, 2013 at 12:10 PM, Eric V. Smith rep...@bugs.python.orgwrote:


 Eric V. Smith added the comment:

 bool instances are immutable, so all value.toggle() could do is the same
 as not value. That is, return a new bool with the toggled value.

 --
 nosy: +eric.smith
 resolution:  - invalid
 status: open - closed

 ___
 Python tracker rep...@bugs.python.org
 http://bugs.python.org/issue18537
 ___


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18537
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18537] bool.toggle()

2013-07-23 Thread Eric V. Smith

Eric V. Smith added the comment:

Since it would be the same as not value, I can't imagine this would be added 
to the language.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18537
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18537] bool.toggle()

2013-07-23 Thread James Lu

James Lu added the comment:

well, filter() could take the function not lambda x:not x

james

On Tue, Jul 23, 2013 at 12:23 PM, Eric V. Smith rep...@bugs.python.orgwrote:


 Eric V. Smith added the comment:

 Since it would be the same as not value, I can't imagine this would be
 added to the language.

 --

 ___
 Python tracker rep...@bugs.python.org
 http://bugs.python.org/issue18537
 ___


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18537
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18521] [cppcheck] Full report

2013-07-23 Thread Julien Nabet

Julien Nabet added the comment:

quotation from
http://en.wikipedia.org/wiki/Cppcheck :

Cppcheck is a static code analysis tool for the C and C++ programming languages

or from http://cppcheck.sourceforge.net/

Cppcheck is a static analysis tool for C/C++ code. Unlike C/C++ compilers and 
many other analysis tools it does not detect syntax errors in the code. 
Cppcheck primarily detects the types of bugs that the compilers normally do not 
detect. The goal is to detect only real errors in the code (i.e. have zero 
false positives).


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18537] bool.toggle()

2013-07-23 Thread Eric V. Smith

Eric V. Smith added the comment:

If that's your concern, you can use operator.not_.

 import operator
 filter(operator.not_, [False, True, False, False, True])
[False, False, False]

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18537
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-23 Thread Larry Hastings

Larry Hastings added the comment:

I swear I've seen a compiler where you couldn't assign to errno.  But now I'm 
pretty sure it was MSVC, and possibly a version back in the 90s.  So I'm happy 
to live in a world where errno is an lvalue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17899
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18534] File name attribute should always be a text string

2013-07-23 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Seconded Antoine.

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18534
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue791968] Arguments tooltip wrong if def contains tuple

2013-07-23 Thread Ned Deily

Ned Deily added the comment:

Ariel, if you think there is a problem, please open a new issue with all the 
pertinent information.  This issue was closed long ago.

--
nosy: +ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue791968
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18521] [cppcheck] Full report

2013-07-23 Thread Ronald Oussoren

Ronald Oussoren added the comment:

It doesn't really live up to its description.

From the start of the 'filtered' list:

* Messages about PyThread_acquire_lock appear to be false positives,
  that name is a function that's called by the macros expanded on those
  lines.

* Syntax error in _ctypes.h: the code is ugly, but is valid C; the
  message is about:

else if PySlice_Check(item) {

  This is valid because PySlice_Check is a macro that expands into
  an expression with parentheses:

   #define PySlice_Check(op) (Py_TYPE(op) == PySlice_Type)

  That said, I would have used explicit parentheses here.

* unused variable in _ctypes_test.c: false positives, the variable is
  used in a function call two lines lower.

* callproc.c:1620: False positive because the tool doesn't know that
  PyMem_Malloc is a malloc function and returns unitialized memory
  (the first one that isn't a problem with the tool)

* messages about alloca: correct, I haven't looked seriously if the
  use of alloca is defensible here.

* callproc.c:751: False positive, the variable is used by some
  macros that are used in the function.

* the unused 'rtn' variable and 'break' in cursesmodule I've mentioned
  in a previous message.

I haven't checked the rest of the list, but so far I'm not impressed by this 
tool. That's too bad, static analysis tools can be helpful in improving code 
quality.

The high rate of false positives might be due to the preprocessor feature 
described in chapter 3 of the manual, the tool seems to be confused a lot by 
code that uses macros.  Getting it to run properly on the CPython tools might 
therefore require significant tuning.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14853] test_file.py depends on sys.stdin being unseekable

2013-07-23 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Elena, your patch looks ok to me, thank you.
Could you sign a contributor's agreement? http://www.python.org/psf/contrib/
(or have you already done so?)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14853
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18533] Avoid error from repr() of recursive dictview

2013-07-23 Thread Ben North

Ben North added the comment:

New patch including tests attached, against 3.3.  Terry Reedy's example
above now gives

 d = {}
 d[1] = d.keys()
 d[2] = d.values()
 d
{1: dict_keys([1, 2]), 2: dict_values([dict_keys([1, 2]), ...])}

which I think is preferable.

Summary of patch:

dictobject.c:

dictview_repr() now uses a Py_ReprEnter() / Py_ReprLeave() pair to
check for recursion, and produces ... if so.  I think I've got the
behaviour correct in the case that PySequence_List() fails, but
couldn't find a way to trigger this in testing.

test_dictviews.py:

test_recursive_repr() checks for the correct string (containing
...) rather than a RuntimeError.

test_deeply_nested_repr() is a new function, aiming to replace the
original test_recursive_repr().  It checks that a RuntimeError is
raised in the case of a non-recursive but deeply nested structure.

Under --with-pydebug,

./python -m test.regrtest -R20:30 test_dictviews

passes.

--
Added file: 
http://bugs.python.org/file31022/non-error-recursive-dictview-3.3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18533
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18538] `python -m dis `

2013-07-23 Thread Michele Orrù

Changes by Michele Orrù maker...@gmail.com:


--
components: Library (Lib)
nosy: maker
priority: normal
severity: normal
status: open
title: `python -m dis `
type: enhancement
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18538
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18538] `python -m dis ` relying on argparse

2013-07-23 Thread Michele Orrù

New submission from Michele Orrù:

I feel a little bit embarassed for this patch;
while reading the stdlib's Lib/dis.py file, I saw that the _test() function 
parses by itself sys.argv. 

I tried to clean it up using argparse; diff and manual tests attached.

--
title: `python -m dis ` - `python -m dis ` relying on argparse
Added file: http://bugs.python.org/file31023/issue18538.log

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18538
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18519] test_sqlite crashes on OS X tiger 3.x buildbot

2013-07-23 Thread R. David Murray

R. David Murray added the comment:

OK, this makes much more sense to me now :)

I take it the overflow error is the only one the C code could ever raise?  If 
so, the patch looks good to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18519
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18538] `python -m dis ` relying on argparse

2013-07-23 Thread STINNER Victor

STINNER Victor added the comment:

Please attach your patch separatly.

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18538
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18533] Avoid error from repr() of recursive dictview

2013-07-23 Thread STINNER Victor

STINNER Victor added the comment:

non-error-recursive-dictview-3.3.patch: small nit, initialize result to NULL, 
instead of setting it to NULL only in case of error. It makes the code more 
readable and it is the common coding style to handle errors.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18533
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18538] `python -m dis ` relying on argparse

2013-07-23 Thread Michele Orrù

Changes by Michele Orrù maker...@gmail.com:


--
keywords: +patch
Added file: http://bugs.python.org/file31024/issue18538.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18538
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18534] File name attribute should always be a text string

2013-07-23 Thread Nick Coghlan

Nick Coghlan added the comment:

Ouch, that complicates matters :(

It also occurs to me that given the existence of the opener callback,
name could be just about any type :P

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18534
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com