[issue20292] clinic.py str_converter with encoding throws exception
Roundup Robot added the comment: New changeset 949acdd43b45 by Larry Hastings in branch 'default': Issue #20292: Small bug fix for Argument Clinic supporting format units http://hg.python.org/cpython/rev/949acdd43b45 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20292 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20292] clinic.py str_converter with encoding throws exception
Larry Hastings added the comment: Thanks for the report! It's fixed now. Sorry about that! -- assignee: - larry components: +Demos and Tools -Build resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20292 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Larry Hastings added the comment: That macro, STRFTIME_FORMAT_CODES, is only used in two functions. If it were me I'd just copy and paste the text into both functions. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20282] Argument Clinic: int with boolean default
Larry Hastings added the comment: I think these shouldn't be int, they should be bool. bool will allow you to use a default of False. It maps to the p format unit, which was new in 3.3. Back before 3.3, when someone wanted a boolean they just used i, and relied on the fact that True turned into 1 and False turned into 0. (Even more so before 2.2, when we didn't even have True and False.) In theory it's a semantic change, because i only accepts ints (and True/False), whereas p will accept floats, lists, tuples, dicts, sets... anything with a __bool__. But the intent of code like this is clear, it's only interested in true/false. And Python has well-established rules for what is considered a true and false. So I feel like this change is an improvement. -- resolution: - wont fix stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20282 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20227] Argument Clinic: rename arguments in generated C?
Larry Hastings added the comment: I have a couple big patches incoming, over the next couple of days. Here's a sneak-peek of my todo list: * buffer support just went in (#20287) * all builtins support landing maybe tomorrow (#20260) * suppress the self parameter on impl for METH_STATIC * allow variables to be renamed between parsing and impl functions *** * allow passing in args and kwargs into impl (#20291) The one I triple-starred is going to change the code you hacked up a *lot*. I'm not going to look at this patch before then, because that change will break the patch completely. But I'll make you a deal. If you try again *after* all of the above lands, I'll look at it, and if it's fine it can probably go in. I don't know if I said, but the obvious syntax is foo as bar. as should bind more tightly than the colon for the converter. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20227 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20293] pydoc fails with the unspecified default value
New submission from Serhiy Storchaka: With patch for the zlib module (issue20193) which uses the unspecified default value: $ ./python -m pydoc zlib Traceback (most recent call last): File /home/serhiy/py/cpython/Lib/inspect.py, line 1997, in wrap_value value = eval(s, module_dict) File string, line 1, in module NameError: name 'unspecified' is not defined During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/serhiy/py/cpython/Lib/inspect.py, line 2000, in wrap_value value = eval(s, sys_module_dict) File string, line 1, in module NameError: name 'unspecified' is not defined During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/serhiy/py/cpython/Lib/runpy.py, line 189, in _run_module_as_main __main__, mod_spec) File /home/serhiy/py/cpython/Lib/runpy.py, line 87, in _run_code exec(code, run_globals) File /home/serhiy/py/cpython/Lib/pydoc.py, line 2593, in module cli() File /home/serhiy/py/cpython/Lib/pydoc.py, line 2558, in cli help.help(arg) File /home/serhiy/py/cpython/Lib/pydoc.py, line 1840, in help elif request: doc(request, 'Help on %s:', output=self._output) File /home/serhiy/py/cpython/Lib/pydoc.py, line 1578, in doc pager(render_doc(thing, title, forceload)) File /home/serhiy/py/cpython/Lib/pydoc.py, line 1571, in render_doc return title % desc + '\n\n' + renderer.document(object, name) File /home/serhiy/py/cpython/Lib/pydoc.py, line 356, in document if inspect.ismodule(object): return self.docmodule(*args) File /home/serhiy/py/cpython/Lib/pydoc.py, line 1142, in docmodule contents.append(self.document(value, key, name)) File /home/serhiy/py/cpython/Lib/pydoc.py, line 358, in document if inspect.isroutine(object): return self.docroutine(*args) File /home/serhiy/py/cpython/Lib/pydoc.py, line 1323, in docroutine signature = inspect.signature(object) File /home/serhiy/py/cpython/Lib/inspect.py, line 1468, in signature return Signature.from_builtin(obj) File /home/serhiy/py/cpython/Lib/inspect.py, line 2052, in from_builtin p(name, default) File /home/serhiy/py/cpython/Lib/inspect.py, line 2038, in p default_node = RewriteSymbolics().visit(default_node) File /home/serhiy/py/cpython/Lib/ast.py, line 245, in visit return visitor(node) File /home/serhiy/py/cpython/Lib/inspect.py, line 2030, in visit_Name return wrap_value(node.id) File /home/serhiy/py/cpython/Lib/inspect.py, line 2002, in wrap_value raise RuntimeError() RuntimeError -- messages: 208394 nosy: larry, serhiy.storchaka priority: normal severity: normal status: open title: pydoc fails with the unspecified default value type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20293 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
New submission from Serhiy Storchaka: Currently Argument Clinic doesn't support the __init__ methods, mainly because the C implementation of this method should return int, not PyObject *. In some cases it is possible to wrap a function generated by Argument Clinic (as in Modules/_pickle.c). But not always, because the __init__ method is called with the self, args, and kwargs arguments, while Argument Clinic can generate function without kwargs. -- components: Demos and Tools messages: 208395 nosy: larry, serhiy.storchaka priority: normal severity: normal status: open title: Argument Clinic: add support for __init__ type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20294 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Argument Clinic: add support for __init__, pydoc fails with the unspecified default value ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20193 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33369/lzma_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20193 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33368/bz2_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20193 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33370/zlib_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20193 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files - Derby: Convert the ElementTree module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file8/etree_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20159 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files - Derby: Convert the ElementTree module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33355/etree_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20159 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files - Derby: Convert the ElementTree module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file33526/etree_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20159 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20148] Derby: Convert the _sre module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33329/sre_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20148 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20148] Derby: Convert the _sre module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33353/sre_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20148 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20148] Derby: Convert the _sre module to use Argument Clinic
Serhiy Storchaka added the comment: Now all methods except Match.group() (which needs *args) use Argument Clinic. Most important change is that first parameters of some Pattern methods are renamed from pattern or source to string. This was obvious bug (issue20283). string conforms to the documentation and to the name of the Match.string attribute. -- Added file: http://bugs.python.org/file33527/sre_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20148 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20148] Derby: Convert the _sre module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20148 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: Here is a patch. -- keywords: +patch nosy: +gpolo stage: - patch review Added file: http://bugs.python.org/file33528/tkinter_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20151] Derby: Convert the binascii module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file2/binascii_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20151 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20151] Derby: Convert the binascii module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33354/binascii_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20151 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20151] Derby: Convert the binascii module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file33529/binascii_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20151 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20133] Derby: Convert the audioop module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33320/audioop_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20133 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20133] Derby: Convert the audioop module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33352/audioop_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20133 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20133] Derby: Convert the audioop module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33461/audioop_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20133 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20133] Derby: Convert the audioop module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file33530/audioop_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20133 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20245] Check empty mode in TarFile.*open()
Roundup Robot added the comment: New changeset 8edb892f4d69 by Serhiy Storchaka in branch '2.7': Issue #20245: The open functions in the tarfile module now correctly handle empty mode. http://hg.python.org/cpython/rev/8edb892f4d69 New changeset 8ef1fd952410 by Serhiy Storchaka in branch '3.3': Issue #20245: The open functions in the tarfile module now correctly handle empty mode. http://hg.python.org/cpython/rev/8ef1fd952410 New changeset 7a2db897a1b6 by Serhiy Storchaka in branch 'default': Issue #20245: The open functions in the tarfile module now correctly handle empty mode. http://hg.python.org/cpython/rev/7a2db897a1b6 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20245 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20238] Incomplete gzip output with tarfile.open(fileobj=..., mode=w:gz)
Roundup Robot added the comment: New changeset 5c69332dc3b0 by Serhiy Storchaka in branch '3.3': Issue #20238: TarFile opened with external fileobj and w:gz mode didn't http://hg.python.org/cpython/rev/5c69332dc3b0 New changeset e154b93f3857 by Serhiy Storchaka in branch 'default': Issue #20238: TarFile opened with external fileobj and w:gz mode didn't http://hg.python.org/cpython/rev/e154b93f3857 New changeset f7381f1bf1ec by Serhiy Storchaka in branch '2.7': Backported test for issue #20238. http://hg.python.org/cpython/rev/f7381f1bf1ec -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20238 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20243] ReadError when open a tarfile for writing
Roundup Robot added the comment: New changeset 61b6accbca9f by Serhiy Storchaka in branch '2.7': Issue #20243: TarFile no longer raise ReadError when opened in write mode. http://hg.python.org/cpython/rev/61b6accbca9f New changeset 2f3b47b63f91 by Serhiy Storchaka in branch '3.3': Issue #20243: TarFile no longer raise ReadError when opened in write mode. http://hg.python.org/cpython/rev/2f3b47b63f91 New changeset 40a5c7547c3d by Serhiy Storchaka in branch 'default': Issue #20243: TarFile no longer raise ReadError when opened in write mode. http://hg.python.org/cpython/rev/40a5c7547c3d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20243 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20244] Possible resources leak in tarfile.open()
Roundup Robot added the comment: New changeset 05d186a1a367 by Serhiy Storchaka in branch '3.3': Issue #20244: Fixed possible file leaks when unexpected error raised in http://hg.python.org/cpython/rev/05d186a1a367 New changeset 0386cde12657 by Serhiy Storchaka in branch 'default': Issue #20244: Fixed possible file leaks when unexpected error raised in http://hg.python.org/cpython/rev/0386cde12657 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20244 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17481] inspect.getfullargspec could use __signature__
Changes by Yury Selivanov yseliva...@gmail.com: -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17481 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20245] Check empty mode in TarFile.*open()
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20245 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20238] Incomplete gzip output with tarfile.open(fileobj=..., mode=w:gz)
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20238 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20243] ReadError when open a tarfile for writing
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20243 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20244] Possible resources leak in tarfile.open()
Serhiy Storchaka added the comment: As for 2.7, I suppose it have file leaks even when expected exception is raised. 2.7 needs more tests and perhaps changes for GzipFile. This was not fixed in issue11513 and is not fixed here. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20244 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20270] urllib.parse doesn't work with empty port
Roundup Robot added the comment: New changeset a4a51a0d4575 by Serhiy Storchaka in branch '2.7': Issue #20270: urllib and urlparse now support empty ports. http://hg.python.org/cpython/rev/a4a51a0d4575 New changeset 52edc7087c81 by Serhiy Storchaka in branch '3.3': Issue #20270: urllib.urlparse now supports empty ports. http://hg.python.org/cpython/rev/52edc7087c81 New changeset 1469c4fde8cd by Serhiy Storchaka in branch 'default': Issue #20270: urllib.urlparse now supports empty ports. http://hg.python.org/cpython/rev/1469c4fde8cd -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20270 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20270] urllib.parse doesn't work with empty port
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20270 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20293] pydoc fails with the unspecified default value
Larry Hastings added the comment: Just checking--that happens with current trunk? Revision 32f9e0ae23f7 or newer? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20293 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
Larry Hastings added the comment: Oh! I thought it worked fine, because I've seen people convert both an __init__ and a __new__. But I guess they wrapped them. It's an easy change, I can try to do that today. -- assignee: - larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20294 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20293] pydoc fails with the unspecified default value
Serhiy Storchaka added the comment: That happens with current trunk (revision 1469c4fde8cd) and a patch for zlib from issue20193 [1]. [1] http://bugs.python.org/file33523/zlib_clinic.patch -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20293 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c
Serhiy Storchaka added the comment: I take it. -- assignee: - serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20171 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20295] imghdr add openexr support
New submission from Martin Vignali: Add support for detect openexr file (http://www.openexr.com/) Based on information provided by : http://www.openexr.com/ReadingAndWritingImageFiles.pdf I make some tests, on different kind of exr file, to check, the new function. -- components: Library (Lib) files: img_hdr_exr.patch keywords: patch messages: 208409 nosy: mvignali priority: normal severity: normal status: open title: imghdr add openexr support type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file33531/img_hdr_exr.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20295 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20296] PyArg_ParseTuple 2.X docs mention int for t#, but Py_ssize_t for w#, etc.
New submission from Rob Browning: Here (http://docs.python.org/2/c-api/arg.html), the documentation for t# says: t# (read-only character buffer) [char *, int]... while the documentation for w# says: w# (read-write character buffer) [char *, Py_ssize_t]... However, from getargs.c, it looks like they're handled the same with respect to the size type. At a minimum, it seems like it might make sense to change these docs to match, and if w# and t# are actually handled similarly to s#, it would be even better to just change their docs to match (or refer to) s#'s which are more detailed, i.e. they mention the PY_SSIZE_T_CLEAN issues, etc. Thanks -- assignee: docs@python components: Documentation messages: 208410 nosy: docs@python, rlb priority: normal severity: normal status: open title: PyArg_ParseTuple 2.X docs mention int for t#, but Py_ssize_t for w#, etc. versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20296 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20293] pydoc fails with the unspecified default value
Larry Hastings added the comment: I just built from a new clone of trunk, and it works fine for me. I didn't see the exception you report--I get the documentation for zlib. Do you still get the error if you build from a new clone of the current trunk? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20293 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
Larry Hastings added the comment:
* As is probably expected, __init__ and __call__ procs
can't be converted.
I should have a fix in for __init__ and __call__ later today. (Issue #20294.)
For the record, you could convert them, you just had to wrap the parsing
function
to deal with the return type difference, and *args / **kwargs might be tricky
too.
* sqlite3.Connection.{execute, executemany, executescript} don't use
PyArg_Parse*.
In the next few days I'm going to add support for *args and **kwargs, and
then you'll be able to convert these functions. (Issue #20291.) Again, even
if Argument Clinic doesn't do any parsing, it's still helpful to have it
generate signatures.
* The clinic version of 'sqlite3.adapt' has an argument string of O|OO.
The first optional parameter defaults to 'pysqlite_PrepareProtocolType'
in C and 'sqlite3.ProtocolType' in Python. However, I don't know how to
represent the Python value because Python default values are 'eval'd by
clinic *and* the 'sqlite3' module is not imported for the eval.
You'll be able to do this soon:
parameter: object(c_default='pysqlite_PrepareProtocolType') = ProtocolType
This feature isn't checked in yet, I'm waiting for a review. It's part of
#20226, which I guess you already noticed.
* The clinic version of 'sqlite3.Cursor.fetchmany' has an arguments string
of |i. The first parameter defaults to
'((pysqlite_Cursor *)self)-arraysize' in C and 'self.arraysize' in
Python. I don't know how to express the Python initialization.
You can't. How about you use a default of -1 and then:
if (maxrows == -1)
maxrows = self-arraysize
* I didn't convert 'sqlite3.Cursor.setinputsizes' and
'sqlite3.Cursor.setoutputsize' because they share a docstring and
simple no-op method def.
I'd prefer it if you converted them anyway. Converting them means they'll
have signature information which is an unconditional good.
* I didn't convert 'sqlite.connect' because it would have required
packaing the arguments back up to pass to 'PyObject_Call'.
Once I add the ability to pass in *args and **kwargs, you'll be able to
convert sqlite.connect.
I think I responded to all your other comments when I reviewed the patch.
Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20294
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
Larry Hastings added the comment: Oops, sorry, that last comment was intended for a different issue. Please ignore, and sorry for the spam! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20294 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files
Larry Hastings added the comment:
Larry Hastings added the comment:
* As is probably expected, __init__ and __call__ procs
can't be converted.
I should have a fix in for __init__ and __call__ later today. (Issue #20294.)
For the record, you could convert them, you just had to wrap the parsing
function
to deal with the return type difference, and *args / **kwargs might be tricky
too.
* sqlite3.Connection.{execute, executemany, executescript} don't use
PyArg_Parse*.
In the next few days I'm going to add support for *args and **kwargs, and
then you'll be able to convert these functions. (Issue #20291.) Again, even
if Argument Clinic doesn't do any parsing, it's still helpful to have it
generate signatures.
* The clinic version of 'sqlite3.adapt' has an argument string of O|OO.
The first optional parameter defaults to 'pysqlite_PrepareProtocolType'
in C and 'sqlite3.ProtocolType' in Python. However, I don't know how to
represent the Python value because Python default values are 'eval'd by
clinic *and* the 'sqlite3' module is not imported for the eval.
You'll be able to do this soon:
parameter: object(c_default='pysqlite_PrepareProtocolType') = ProtocolType
This feature isn't checked in yet, I'm waiting for a review. It's part of
#20226, which I guess you already noticed.
* The clinic version of 'sqlite3.Cursor.fetchmany' has an arguments string
of |i. The first parameter defaults to
'((pysqlite_Cursor *)self)-arraysize' in C and 'self.arraysize' in
Python. I don't know how to express the Python initialization.
You can't. How about you use a default of -1 and then:
if (maxrows == -1)
maxrows = self-arraysize
* I didn't convert 'sqlite3.Cursor.setinputsizes' and
'sqlite3.Cursor.setoutputsize' because they share a docstring and
simple no-op method def.
I'd prefer it if you converted them anyway. Converting them means they'll
have signature information which is an unconditional good.
* I didn't convert 'sqlite.connect' because it would have required
packaing the arguments back up to pass to 'PyObject_Call'.
Once I add the ability to pass in *args and **kwargs, you'll be able to
convert sqlite.connect.
I think I responded to all your other comments when I reviewed the patch.
Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20178
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19855] uuid._find_mac fails if an executable not in /sbin or /usr/sbin
Roundup Robot added the comment: New changeset 9fe32328a573 by R David Murray in branch '2.7': #19855: restore use of LC_ALL, not LC_MESSAGES http://hg.python.org/cpython/rev/9fe32328a573 New changeset 706354c4d8f5 by R David Murray in branch '3.3': #19855: restore use of LC_ALL, not LC_MESSAGES http://hg.python.org/cpython/rev/706354c4d8f5 New changeset 418212180bf1 by R David Murray in branch 'default': Merge #19855: restore use of LC_ALL, not LC_MESSAGES http://hg.python.org/cpython/rev/418212180bf1 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19855 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17481] inspect.getfullargspec could use __signature__
Terry J. Reedy added the comment: While I plan to change Idle code to use signature directly, instead of getfullargspec, I agree that changing inspect also, and in 3.4, is a good idea. It may, however, affect tests other than Idle's, if there are any other stdlib consumers. I will try to look at the patch after changing Idle. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17481 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20227] Argument Clinic: rename arguments in generated C?
Ryan Smith-Roberts added the comment: I believe the feature you starred resolves this enhancement issue, in which case my patches are obsolete. And yes, the 'as' syntax makes a lot more sense. Here's how I hope it works (the arg parsing wrapper remains unchanged): foo: int ... _impl(..., int foo) can become foo: int as bar ... _impl(..., int bar) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20227 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20297] concurrent.futures.as_completed() installs waiters for already completed Futures
New submission from Glenn Langford: as_completed() calls _create_and_install_waiters() over all given Futures, even if some (or all) of the Futures have already completed. The following fragment of the as_completed code (from 3.3.3): with _AcquireFutures(fs): finished = set( f for f in fs if f._state in [CANCELLED_AND_NOTIFIED, FINISHED]) pending = set(fs) - finished waiter = _create_and_install_waiters(fs, _AS_COMPLETED) installs waiters into Futures contained in fs, rather than pending. A more efficient approach might be to only install waiters on the pending subset if necessary. This would be faster and would also result in less dwell time with all of the Future conditions locked via the _AcquireFutures context manager. Also: waiters are appended with the Future condition lock acquired, but are removed (at the conclusion of as_completed) without the _AcquireFutures condition lock. Is this correct? -- components: Library (Lib) messages: 208418 nosy: glangford priority: normal severity: normal status: open title: concurrent.futures.as_completed() installs waiters for already completed Futures type: performance versions: Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20297 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20227] Argument Clinic: rename arguments in generated C?
Larry Hastings added the comment: On 01/18/2014 01:12 PM, Ryan Smith-Roberts wrote: Ryan Smith-Roberts added the comment: I believe the feature you starred resolves this enhancement issue, in which case my patches are obsolete. And yes, the 'as' syntax makes a lot more sense. Here's how I hope it works (the arg parsing wrapper remains unchanged): foo: int ... _impl(..., int foo) can become foo: int as bar ... _impl(..., int bar) Nope, not what I wanted. I said as binds more tightly than :: foo as bar: int But if you're dropping the patch I guess it's irrelevant. //arry/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20227 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18574] BaseHTTPRequestHandler.handle_expect_100() sends invalid response
Nikolaus Rath added the comment: Thanks for looking at this! Attached is an updated patch with testcase (sorry, I thought I had included testcases everywhere). -- Added file: http://bugs.python.org/file33532/issue18574_rev2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18574 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20227] Argument Clinic: rename arguments in generated C?
Ryan Smith-Roberts added the comment: Yes, that makes more sense. The specific syntax is nearly irrelevant compared to the feature existing at all. You still haven't indicated whether your starred feature matches the *result* that I outlined. Does it? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20227 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20246] buffer overflow in socket.recvfrom_into
Stefan Krah added the comment: One test fails on FreeBSD 9.0 and 6.4: == ERROR: testRecvFromIntoSmallBuffer (test.test_socket.BufferIOTest) -- Traceback (most recent call last): File /usr/home/db3l/buildarea/3.x.bolen-freebsd/build/Lib/test/test_socket.py, line 259, in _tearDown raise exc File /usr/home/db3l/buildarea/3.x.bolen-freebsd/build/Lib/test/test_socket.py, line 271, in clientRun test_func() File /usr/home/db3l/buildarea/3.x.bolen-freebsd/build/Lib/test/test_socket.py, line 4690, in _testRecvFromIntoSmallBuffer self.serv_conn.send(MSG*2048) BrokenPipeError: [Errno 32] Broken pipe -- nosy: +skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20246 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17811] Improve os.readv() and os.writev() documentation and docstring
Nikolaus Rath added the comment: Indeed, this makes most sense. I didn't know that glossary entry existed. I have attached an updated patch. Thanks for reviewing! -- Added file: http://bugs.python.org/file33533/issue17811_rev2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17811 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17811] Improve os.readv() and os.writev() documentation and docstring
Changes by Nikolaus Rath nikol...@rath.org: -- versions: -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17811 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Nikolaus Rath added the comment: Will do. Another question: what should I do with return annotations, e.g. the - dict part in get_clock_info(name: str) - dict\n Should I drop that part? In the clinic howto, I couldn't find anything about return annotations (only that parameter annotations are unsupported). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20227] Argument Clinic: rename arguments in generated C?
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: -serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20227 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Nikolaus Rath added the comment: One more question: what's a good way to find sites that need changes? Searching for PyArg_ finds both converted and unconverted functions... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Larry Hastings added the comment: Yes, you should drop things that look like return annotations in the original docstring. I don't have a magic formula for finding unchanged functions, sorry. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20252] Argument Clinic howto: small typo in y# translation
Ryan Smith-Roberts added the comment: I saw the fix for this in the commit stream. Closing. -- resolution: - fixed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20252 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20252] Argument Clinic howto: small typo in y# translation
Changes by Ryan Smith-Roberts r...@lab.net: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20252 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20246] buffer overflow in socket.recvfrom_into
Ryan Smith-Roberts added the comment: Perhaps the test is sending an infeasibly large message. If you remove the '*2048' does it pass? (I set up a FreeBSD 9.2 amd64 VM but all tests are passing here). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20246 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Nikolaus Rath added the comment: Here is a patch for timemodule.c. I have converted everything except: * ctime() uses the gettmarg() function. Converting gettmarg() itself doesn't seem possible to me (because it's not Python callable), and duplicating the functionality in a single complicated clinic section just for ctime() did not seem reasonable either. * gmtime(), localtime(), ctime() use a the parse_time_t_args() utility function. I have not yet figured out how to replace this with argument clinic (sent a mail to python-dev about that). -- Added file: http://bugs.python.org/file33534/timemodule.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Changes by Nikolaus Rath nikol...@rath.org: Removed file: http://bugs.python.org/file33521/issue20177.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20298] json library needs a non-strict option to decode single-quoted strings
New submission from David Barnett:
Many sloppy JSON APIs return data with poorly-encoded strings, either with
single-quotes as delimiters:
{'foo': 'bar'}
or with no delimiters at all on keys:
{foo: 'bar'}
The json library is useless for making sense of this data, because all it will
tell you is No JSON object could be decoded.
It would be incredibly helpful if the json library had some special non-strict
decoding mode that could interpret these common misspellings of JSON strings.
Or, more generally, it could accept another decoder hook to reformat the
remaining string, something like:
def malformed_hook(remaining, parent):
if remaining.startswith('):
# We know this is a string, regex it to find the end.
m = re.match(pyparsing.quotedString.reString, remaining)
if m is not None:
# Use json.dumps to add quotes around string literal.
return json.dumps(eval(m.group(0))) + remaining[m.end():]
# If we're inside an object, this could be a naked object key.
if isinstance(parent, dict):
m = re.match(r'([a-zA-Z_]\w*):', remaining)
if m is not None:
return json.dumps(m.group(1)) + remaining[len(m.group(1)):]
print(json.loads(['foo', null, {a: 'b'}], malformed_hook=malformed_hook))
['foo', None, {'a': 'b'}]
This would at least save you having to write a parser/tokenizer from scratch.
--
components: Library (Lib)
messages: 208430
nosy: mu_mind
priority: normal
severity: normal
status: open
title: json library needs a non-strict option to decode single-quoted strings
type: enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20298
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files
Tal Einat added the comment: I'm attaching my conversion of deque.rotate and _count_elements in Modules/_collectionsmodule.c. There remain 3 other functions in that module to be converted. One is deque_init which returns int; Larry said (on IRC) to hold off with that for now. The other two are dequeiter_new and dequereviter_new, which use the O! format, which I am unsure how to handle. -- keywords: +patch nosy: +taleinat Added file: http://bugs.python.org/file33535/_collectionsmodule.c.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18574] BaseHTTPRequestHandler.handle_expect_100() sends invalid response
Roundup Robot added the comment: New changeset 093ab6c02ff4 by Benjamin Peterson in branch '3.3': fix handling of 100-continue status code (closes #18574) http://hg.python.org/cpython/rev/093ab6c02ff4 New changeset 20a2597d6653 by Benjamin Peterson in branch 'default': merge 3.3 (#18574) http://hg.python.org/cpython/rev/20a2597d6653 -- nosy: +python-dev resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18574 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20122] Move CallTips tests to idle_tests
Terry J. Reedy added the comment: Attached patch moves all tests, changed (and simplified) to call get_argspec directly. I will apply after I get tk 8.6 to test with 3.4. -- Added file: http://bugs.python.org/file33536/test_calltips-33.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20122 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18574] BaseHTTPRequestHandler.handle_expect_100() sends invalid response
Nikolaus Rath added the comment: I just realized that the Misc/NEWS entry is just utterly wrong (it is talking abou the client, even though the bug is in the server), my apologies. Here's a fixed one: - Issue #18574: Added missing newline in 100-Continue reply from http.server.BaseHTTPRequestHandler. Patch by Nikolaus Rath. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18574 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20223] inspect.signature does not support new functools.partialmethod
Nick Coghlan added the comment: Aye, I agree with Terry that this is a behavioural bug introduced with the new partialmethod feature - we missed adding a new test case to check that inspect.signature handled it properly. Reviewing the patch now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20223 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18574] BaseHTTPRequestHandler.handle_expect_100() sends invalid response
Roundup Robot added the comment: New changeset d00ed6e7a823 by Benjamin Peterson in branch '3.3': correct news entry for #18574 http://hg.python.org/cpython/rev/d00ed6e7a823 New changeset cf0678c3b735 by Benjamin Peterson in branch 'default': merge 3.3 (#18574) http://hg.python.org/cpython/rev/cf0678c3b735 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18574 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17481] inspect.getfullargspec should use __signature__
Nick Coghlan added the comment: I upgraded the description to a should. Argument Clinic and other changes in Python 3.4 greatly improve introspection support for various aspects of the runtime and standard library (for example, issue 20223 will handle the new functools.partialmethod support). By also making those enhancements available via getfullargpsec, we should significantly increase the amount of existing code which benefits automatically for those enhancements, as it will no longer require explicit migration to the new PEP 362 APIs at the application/library level. Reviewing the patch now. -- title: inspect.getfullargspec could use __signature__ - inspect.getfullargspec should use __signature__ ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17481 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17811] Improve os.readv() and os.writev() documentation and docstring
Roundup Robot added the comment: New changeset 8b413f813a13 by Benjamin Peterson in branch '3.3': improve description of buffers argument for readv/writev (closes #17811) http://hg.python.org/cpython/rev/8b413f813a13 New changeset 4d56006133f1 by Benjamin Peterson in branch 'default': merge 3.3 (#17811) http://hg.python.org/cpython/rev/4d56006133f1 -- nosy: +python-dev resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17811 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Nikolaus Rath added the comment: Hmm. After reading some of the threads on python-dev, I'm now confused if I did the conversion of optional arguments correctly. Should something like strftime(format[, tuple]) be converted using optional groups, or should tuple become a parameter with a default value? (so far, I have done the latter). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17481] inspect.getfullargspec should use __signature__
Larry Hastings added the comment: If we modify inspect.getfullargspec, shouldn't we modify inspect.getargspec too? deprecated doesn't mean unsupported, it means not recommended for new code, please stop using it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17481 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files
Larry Hastings added the comment: Optional groups really are only for cases when that's the behavior of the original code. If the original function used a switch statement examining the size of the tuple, then had different parsing functions based on that size, use optional groups. But if the function can be expressed with normal positional parameters and default values, that's best. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20177 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17481] inspect.getfullargspec should use __signature__
Yury Selivanov added the comment: Larry, getargspec uses getfullargspec, so it's covered. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17481 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17481] inspect.getfullargspec should use __signature__
Nick Coghlan added the comment: getargspec() is just a thin wrapper around getfullargspec(), so we get that for free. Similarly, getcallargs() is also implicitly updated to full PEP 362 support by changing the implementation of getfullargspec(). The other two standard library consumers appear to be IDLE (as Terry noted above) and xmlrpc.server.ServerHTMLDoc.docroutine (the self-documenting XML-RPC server API, which sadly appears to be lacking test cases). Reviewing those cases (especially the XML-RPC one) have convinced me we need a backwards compatibility fallback in the updated getfullargspec implementation. Specifically, if the new API throws ValueError (because it can't find a way to build a coherent signature object), we should fall back to the old approach. Otherwise we run the risk of introducing unexpected exceptions into introspection code. That is, the new call to signature in getfullargspec should look something like: try: sig = signature(func) except ValueError: if not hasattr(func, __code__): raise # The legacy fallback doesn't support this input type # The callable signature appears to be incoherent, so we fall # back to the legacy implementation to preserve compatibility args, varargs, kwonlyargs, varkw = _getfullargs(func.__code__) return FullArgSpec(args, varargs, varkw, func.__defaults__, kwonlyargs, func.__kwdefaults__, func.__annotations__) I suspect this may actually be a better solution for IDLE rather than updating it to call inspect.signature directly (since IDLE probably *wants* the more graceful fallback to the old behaviour). The way I would document all this in What's New is to update the current argument clinic section to also explain that we've taken advantage of PEP 362 to improve introspection in multiple areas, including for code that is using the introspection APIs that predate PEP 362. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17481 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
Larry Hastings added the comment: Here's a patch. Wasn't as easy as I thought, it kind of took all day. Changes include: * __init__ and __new__ always take kwargs. * if the function signature doesn't accept keyword arguments, it calls _PyArg_NoKeywords(). * __init__ returns int, not PyObject *. * __init__ and __new__ should support all argument parsing scenarios (unpack tuple, positional only, etc). Pre-exiting behavior: * The C function basename chosen for __new__ is just the name of the class, it doesn't end in __new__. * The methoddef #define is suppressed. -- Added file: http://bugs.python.org/file33537/larry.argument.clinic.init.and.new.patch.1.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20294 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9521] xml.etree.ElementTree strips XML declaration and procesing instructions
Nikolaus Rath added the comment: I can confirm this. The actual problem is that neither XML nor SGML PIs in the input make it into the etree, and no events are generated for them during incremental parsing. XML PIs that are added into the tree using Python functions are correctly written out. SGML PIs currently cannot be represented at all (there's no ElementTree.SGMLProcessingInstruction analogous to ElementTree.ProcessingInstruction) There is special cased support for the DOCTYPE element in the TreeBuilder class to allow retrieving the doctype when not parsing incrementally, but it needs to be retrieved manually and written out manually. I have attached a testcase for XML PIs. For proper SGML PI handling, ElementTree first needs to learn about them. Recommended stage for this issue: needs patch -- keywords: +patch nosy: +Nikratio versions: +Python 3.3, Python 3.4 -Python 3.1 Added file: http://bugs.python.org/file33538/testcase.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9521 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9521] xml.etree.ElementTree skips processing instructions when parsing
Changes by Nikolaus Rath nikol...@rath.org: -- title: xml.etree.ElementTree strips XML declaration and procesing instructions - xml.etree.ElementTree skips processing instructions when parsing ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9521 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20189] inspect.Signature doesn't recognize all builtin types
Zachary Ware added the comment:
Problems 1 (ValueError from help(os)) and 2 ('module' as first param) were
simple fixes:
The attached patch fixes problem 1 (and is probably worth doing anyway, since
inspect.signature has the ability to raise ValueError, and (IMO) help(module)
should never raise an exception.
Problem 2 is just a matter of adding self.show_in_signature = False to the
first param of module-level functions. I've left a review comment at the right
line.
Problem 3 would also be fixed by re-adding 'module' to c_keywords, but since
you want it to work without that, that's out, and I'm not sure what the proper
fix would be otherwise.
The current patch no longer applies cleanly after #20287; I would just post an
updated version of the entire patch with my changes as well, but the merge is
not trivial and I don't want to screw it up :)
--
keywords: +patch
Added file: http://bugs.python.org/file33539/issue20189.pydoc.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20189
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20299] Argument Clinic CConverter.__init__() overrides c_default and py_default
New submission from Ryan Smith-Roberts: The docs indicate that you can do: class foo_converter(CConverter): ... c_default = 'bar()' py_default = 'Bar' except that CConverter.__init__() unconditionally overwrites these values. Patch attached. -- components: Build files: ac_overwritten_defaults.patch keywords: patch messages: 208447 nosy: larry, rmsr priority: normal severity: normal status: open title: Argument Clinic CConverter.__init__() overrides c_default and py_default type: behavior versions: Python 3.4 Added file: http://bugs.python.org/file33540/ac_overwritten_defaults.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20299 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20300] Argument Clinic raises exception for custom converter with default
New submission from Ryan Smith-Roberts: If a custom converter declares both default and converter class attributes, you get this exception (test file attached): Exception raised during parsing: Traceback (most recent call last): File Tools/clinic/clinic.py, line 1445, in parse parser.parse(block) File Tools/clinic/clinic.py, line 2738, in parse self.state(None) File Tools/clinic/clinic.py, line 3468, in state_terminal self.function.docstring = self.format_docstring() File Tools/clinic/clinic.py, line 3344, in format_docstring s += .join(a) TypeError: sequence item 2: expected str instance, NoneType found -- files: ac_converter_test.c messages: 208448 nosy: Nikratio, larry, rmsr priority: normal severity: normal status: open title: Argument Clinic raises exception for custom converter with default Added file: http://bugs.python.org/file33541/ac_converter_test.c ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20300 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20300] Argument Clinic raises exception for custom converter with default
Changes by Ryan Smith-Roberts r...@lab.net: -- components: +Build type: - crash versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20300 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20299] Argument Clinic CConverter.__init__() overrides c_default and py_default
Changes by Ryan Smith-Roberts r...@lab.net: -- nosy: +Nikratio ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20299 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20299] Argument Clinic CConverter.__init__() overrides c_default and py_default
Roundup Robot added the comment: New changeset 8f11493cf727 by Larry Hastings in branch 'default': Issue #20299: Argument Clinic custom converters may now change the default http://hg.python.org/cpython/rev/8f11493cf727 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20299 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20299] Argument Clinic CConverter.__init__() overrides c_default and py_default
Changes by Larry Hastings la...@hastings.org: -- assignee: - larry resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20299 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20299] Argument Clinic CConverter.__init__() overrides c_default and py_default
Larry Hastings added the comment: Checked in. Thanks for the report, and the patch! I worked so quickly, I just realized, I didn't credit you in the NEWS file for the fix. Do you want me to fix that? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20299 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
Zachary Ware added the comment: Rietveld doesn't like the patch and I'm having a hard time finding a changeset on which I can get it to apply cleanly. May I suggest avoiding `--git` on `hg diff` unless copying/moving/renaming a file? -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20294 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20299] Argument Clinic CConverter.__init__() overrides c_default and py_default
Ryan Smith-Roberts added the comment: No, I'm happy. It isn't really news anyway, since the patch just brings reality inline with the docs :). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20299 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
Larry Hastings added the comment: Whoops, that doesn't apply cleanly. Here's an updated patch. -- Added file: http://bugs.python.org/file33542/larry.argument.clinic.init.and.new.patch.2.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20294 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20295] imghdr add openexr support
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag stage: - patch review versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20295 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20122] Move CallTips tests to idle_tests
Terry J. Reedy added the comment: Attached is patch for 2.7 with all tests passing. 3.x get_argspec cannot replace 2.x get_arg_text because it uses inspect.getfullargspec, which does not exist in 2.7. (Its use made the code simpler.) Besides minor changes in test_calltips.py, I made 3 changes to get_arg_text() to get tests to pass. 1. Stop deleting first parameter for unbound methods (bugfix). 2. Replace class instances with __call__ methods (bugfix). 3. Change tip for def f(*some_name, **other_name) from '(..., ***)' to '(*args, **kwds)'. 2.7 either does not keep the dummy names, which anyway cannot be used when calling , or the current code makes no effort to retrieve them. My reasons for 3. are that the replacement is a) the current convention everywhere else, b) more like the corresponding 3.x tip (which has the exact names), and c) more indicative of what one actually writes in a call. -- Added file: http://bugs.python.org/file33543/test_calltips-27.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20122 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20189] inspect.Signature doesn't recognize all builtin types
Larry Hastings added the comment: Your fixes for #1 and #2 were fine, I've incorporated them into the patch. I'll update the diff after I've added the tests Nick suggested. The assertion failure in #3 will also be gone, replaced with a failure: You can't have two parameters named module! The problem is that we silently inserted a self converter for the first argument, and because this is a module-level function, that self parameter is naturally named module. I have a fix in mind for this: basically to teach Argument Clinic that the parser function and impl function have different namespaces, and to map names in the first to the second. So, you could have a parameter named args, and Clinic would notice, and rename the variable in the parser function args_value or something, and then pass it in in the right spot. Once I've done that, it'd be easy to make it also rename the secret self converter name to _module or something. Anyway, long story short, let's not try to fix #3 in this patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20189 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20189] inspect.Signature doesn't recognize all builtin types
Zachary Ware added the comment: Larry Hastings added the comment: Once I've done that, it'd be easy to make it also rename the secret self converter name to _module or something. Anyway, long story short, let's not try to fix #3 in this patch. That sounds fine. _winapi is the only place I've seen that has a 'module' parameter and it's not finished yet anyway, so it can wait a bit more (less than a week, though ;-). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20189 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20293] pydoc fails with the unspecified default value
Berker Peksag added the comment: I just built from a new clone of trunk, and it works fine for me. It works fine for me, too (revision 8f11493cf727). -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20293 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20294] Argument Clinic: add support for __init__
Zachary Ware added the comment: Output looks good and I didn't see anything that scared me in the patch, though I can't pretend to fully understand 100% of it. Builds on Windows, pickle tests pass, and nothing else is affected (that's checked in so far). Looks good to me, as far as I can see. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20294 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
